New issue
Advanced search Search tips

Issue 713412 link

Starred by 1 user
Status: Assigned
Owner:
efoo@chromium.org
Cc:
tandrii@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Contact info for masters

Project Member Reported by efoo@chromium.org, Apr 19 2017 
Problem: Currently, there is no one source of truth to find out who owns each master. go/cit-masters was manually generated a few quarters ago but it's a manual process and no one official owns updating it. 

We need to single source of truth for the owners (teams), contact alias, parent component of each master that's maintained by the teams individually. 

- Avoid manually generated list like go/cit-masters since this will be stale
- No one team should own the full list. List should be automatically generated from individual team definitions. 

Ideas: 
- An OWNERS file for each master

Usages: 
- Possible failure/blame routing
- Information for alerts and Troopers

Comment 1 by efoo@chromium.org, Apr 19 2017 

From email discussion: 
efoo@ - A masters OWNERS file that could include team, contact alias, parent component, relevant depot path, etc... That would be cool. We could supplementing the OWNERS file similar to what's proposed for the repo dirs. That adds teams and components lines like the following: 

# TEAM: foo-team@chromium.org
# COMPONENT: foo>barcomponent

All masters could be made to require a OWNERS file. Maybe we can generate initial files using a mix of the data in cit-masters and relevant Findit blame data?

Comment 2 Deleted

Comment 3 Deleted

Comment 4 Deleted

Comment 5 by iannucci@chromium.org, Apr 19 2017 

Not sure how Findit is related, git-blame would be sufficient, right?

I would VERY STRONGLY urge you not to put data in comments. Comments are read-only metadata for humans. If you intend for this metadata to be machine readable, it should be a real change to the OWNERS file format, complete with actual parsing semantics.

Something like:

  '$' <VARNAME=[^:space:]*> <sp> '=' <sp> <value=.*>

(e.g. `$TEAM = foo-team@chromium.org`)

Would be sufficient and should not exist in any existing OWNERS file.
Project Member

Comment 6 by sheriffbot@chromium.org, Apr 20 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 7 by tandrii@chromium.org, May 4 2018

Owner: efoo@chromium.org
Status: Assigned (was: Untriaged)
Do we really need this? Maybe merge into bug to send PSA this quarter that master owners should migrate to LUCI by <date>?

Comment 8 by efoo@chromium.org, May 4 2018

Cc: tandrii@chromium.org
Agreed, since masters are going away, this is not needed in the long run. 

We should create a new builder/owner and bucket/owner mapping though. Does one already exist?

+tandrii@chromium.org

Comment 9 by tandrii@chromium.org, May 4 2018 

builder owners is only relevant in chromium, so i'd defer to John on existence/usefulness of this.

bucket owners doesn't exist. But each bucket is guaranteed to be in a project. So, i'd argue it should be owner per-project.

swarming pool owners: already exists: https://chrome-internal.googlesource.com/infradata/config/+/master/configs/chrome-swarming/pools.cfg#20

project owners: probably should exist here https://chrome-internal.googlesource.com/infradata/config/+/master/configs/luci-config/projects.cfg
►

Sign in to add a comment