New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 713403 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Task



Sign in to add a comment

Don't paint effectively-invisible layers with tiny opacity in SPv2.

Project Member Reported by wkorman@chromium.org, Apr 19 2017

Issue description

Noted while working on http://crrev.com/2523103003. Believe we should consider kMinimumVisibleOpacity in PaintLayerPainter::PaintedOutputInvisible for SPv2 as we do for SPv1.

Likely need to make sure we do still paint them if there's an animation.
 
Labels: PaintTeamTriaged-20170420 BugSource-Team
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/caaa5c77ce09501d9dd409bde61ae226e1768b7f

commit caaa5c77ce09501d9dd409bde61ae226e1768b7f
Author: wkorman <wkorman@chromium.org>
Date: Fri Apr 28 20:49:34 2017

Skip paint chunks with effectively invisible opacity.

For SPv2 we always paint effectively invisible content,
but during layerization we scrutinize effect node and
skip chunks that would be effectively invisible. This
simplifies code in SPv2 while still avoiding the
resource and processing overhead of creating, managing
and rastering a layer for that chunk.

BUG= 713403 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2833883003
Cr-Commit-Position: refs/heads/master@{#468120}

[modify] https://crrev.com/caaa5c77ce09501d9dd409bde61ae226e1768b7f/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp
[modify] https://crrev.com/caaa5c77ce09501d9dd409bde61ae226e1768b7f/third_party/WebKit/Source/core/paint/PaintLayerPainterTest.cpp
[modify] https://crrev.com/caaa5c77ce09501d9dd409bde61ae226e1768b7f/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp
[modify] https://crrev.com/caaa5c77ce09501d9dd409bde61ae226e1768b7f/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp

Status: Fixed (was: Assigned)

Sign in to add a comment