Issue 713398 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	alph@chromium.org
Closed:	May 2017
Components:	Platform>DevTools Platform>DevTools>Performance
EstimatedDays:	----
NextAction:	----
OS:	All
Pri:	2
Type:	Bug

DevTools: Timeline treeview totals should exclude idle time

Project Member Reported by paulir...@chromium.org, Apr 19 2017

Issue description

In any view, all percents should total up to 100%

This appeared to regress at some point, as I can't repro this on stable.

	Screen Shot 2017-04-19 at 3.02.54 PM.png 87.9 KB View Download

	Screen Shot 2017-04-19 at 3.03.00 PM.png 100 KB View Download

Project Member

Comment 1 by bugdroid1@chromium.org, Apr 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d132efa7a0e1579c81f3eb89eeb3366b6f2e0d9

commit 0d132efa7a0e1579c81f3eb89eeb3366b6f2e0d9
Author: alph <alph@chromium.org>
Date: Wed Apr 26 02:04:49 2017

DevTools: Base aggregated tree view percentage on the busy time.

Previously these included idle time.

BUG= 713398 

Review-Url: https://codereview.chromium.org/2829923002
Cr-Commit-Position: refs/heads/master@{#467203}

[modify] https://crrev.com/0d132efa7a0e1579c81f3eb89eeb3366b6f2e0d9/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js
[modify] https://crrev.com/0d132efa7a0e1579c81f3eb89eeb3366b6f2e0d9/third_party/WebKit/Source/devtools/front_end/timeline/timelinePanel.css
[modify] https://crrev.com/0d132efa7a0e1579c81f3eb89eeb3366b6f2e0d9/third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineProfileTree.js

Comment 2 by alph@chromium.org, May 3 2017

Status: Fixed (was: Assigned)

►

Issue 713398 link

Issue metadata

DevTools: Timeline treeview totals should exclude idle time

Issue description

Comment 1 by bugdroid1@chromium.org, Apr 26 2017

Comment 1 Deleted

Comment 2 by alph@chromium.org, May 3 2017

Comment 2 Deleted

Sign in to add a comment