Media benchmarks report success when media play failed |
||||||||||
Issue descriptionThe media benchmarks on Android (media.android.tough_video_cases and media.android.tough_video_cases_tbmv2) has a media file tulip2.ogv. It uses a codec (theora) not supported on Android, and thus the media playback fails. However, the benchmark didn't detect the failure, and reports meaningless results for this media (see http://crbug.com/713113 ).
,
Apr 19 2017
,
Apr 25 2017
,
Apr 28 2017
It does give an error message when playback fails: (ERROR) 2017-04-27 17:07:24,091 media_action.HasEventCompletedOrError:45 Detected media error while waiting for playing: Media error: error, code:4
,
Apr 28 2017
There is an error message for anyone who looks at the output, however automated runs of the benchmark think it's successful.
,
Apr 28 2017
Correct. Sorry, I didn't mean to imply that this wasn't a good bug. I was just noting the output line to help with my future investigation.
,
May 4 2017
,
May 5 2017
,
May 5 2017
This is blocked on https://github.com/catapult-project/catapult/issues/3540
,
May 5 2017
,
Nov 10 2017
I heard back from the catapult bug. example command to run unit tests: ./bin/run_tests --browser=system PlayActionTest.testPlayWithNoSelector --also-run-disabled-tests I will start working on this again.
,
Dec 19 2017
,
Dec 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b2a146b94632b92acd0eddbd19da0014c6720b4c commit b2a146b94632b92acd0eddbd19da0014c6720b4c Author: Caleb Rouleau <crouleau@chromium.org> Date: Tue Dec 19 18:14:51 2017 Remove broken test case. Discovered that this was broken while fixing crbug.com/713394 . Bug: 713394 Change-Id: I4fc12ebc4864872ba09674f614f35d0ad8064490 Reviewed-on: https://chromium-review.googlesource.com/833403 Reviewed-by: John Chen <johnchen@chromium.org> Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#525082} [modify] https://crrev.com/b2a146b94632b92acd0eddbd19da0014c6720b4c/tools/perf/page_sets/media_cases.py
,
Dec 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/788d0fd19737ac55103321922dce69153a46999a commit 788d0fd19737ac55103321922dce69153a46999a Author: Caleb Rouleau <crouleau@chromium.org> Date: Tue Dec 19 18:22:29 2017 [Telemetry] Error when media playback fails. This change uncovered failing tests such as detailed in https://chromium-review.googlesource.com/c/chromium/src/+/833403 Bug: chromium:713394 Change-Id: I85102ddab2f866327866ce2dda1dd56ad96ead5a Reviewed-on: https://chromium-review.googlesource.com/832921 Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> [modify] https://crrev.com/788d0fd19737ac55103321922dce69153a46999a/telemetry/telemetry/internal/actions/media_action.py
,
Dec 19 2017
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by crouleau@chromium.org
, Apr 19 2017