New issue
Advanced search Search tips

Issue 713379 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Add ash::SessionController::GetActiveUserType() and replace IsUserChild()

Project Member Reported by jamescook@chromium.org, Apr 19 2017

Issue description

SessionController::IsUserSupervised() and IsUserChild() overlap a little bit (a child is supervised, but a "supervised user" may not be a child).

Also, there is lots of code in ash that checks ash::LoginStatus to check the user type, but LoginStatus only partially overlaps session type and user type.

Add a GetActiveUserType() method that returns user_manager::UserType. Replace IsUserChild() calls with it. The method will have to return something when there is no active user, which would mean adding UserType::UNKNOWN = -1 (since there are histograms on UserType) and updating the mojo serializers.

This would be a good intro to the session management code in ash.

 

Comment 1 by xiy...@chromium.org, Apr 28 2017

Cc: -xiy...@chromium.org
Owner: xiy...@chromium.org
Status: Assigned (was: Untriaged)

Sign in to add a comment