We should remove unused code from code base. For example: handlers/monitor_alerts.py handlers/triage_analysis.py
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/5f48a21aff6c4c279aa6c6f64f6b162247d904e3 commit 5f48a21aff6c4c279aa6c6f64f6b162247d904e3 Author: Chan <chanli@chromium.org> Date: Wed Apr 19 22:00:32 2017 [Findit] Remove handlers/monitor_alerts.py This handler is not used any more, reomve the code. Bug:713375 Change-Id: I0258a6669e0a289f04ae1ab3ce73825ce15803d6 Reviewed-on: https://chromium-review.googlesource.com/482519 Reviewed-by: Shuotao Gao <stgao@chromium.org> Commit-Queue: Shuotao Gao <stgao@chromium.org> [delete] https://crrev.com/17198ddd77bfbb9c2ff52663c2ec4495781eaadc/appengine/findit/handlers/monitor_alerts.py [modify] https://crrev.com/5f48a21aff6c4c279aa6c6f64f6b162247d904e3/appengine/findit/main.py [delete] https://crrev.com/17198ddd77bfbb9c2ff52663c2ec4495781eaadc/appengine/findit/handlers/test/monitor_alerts_test.py
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/028bf49a806f3add512d9d5d2600248839e13bb4 commit 028bf49a806f3add512d9d5d2600248839e13bb4 Author: Chan <chanli@chromium.org> Date: Wed Apr 19 22:07:44 2017 [Findit] Remove handlers/triage_analysis.py Currently we triage at CL level so handlers/triage_analysis.py is obsolete and we should remove it. Bug: 713375 Change-Id: I475e77738380e3f0284c217b2eae076db72ca02d Reviewed-on: https://chromium-review.googlesource.com/482420 Reviewed-by: Shuotao Gao <stgao@chromium.org> Commit-Queue: Shuotao Gao <stgao@chromium.org> [delete] https://crrev.com/152ba675bcc212e7fbb0eabcb7913892ae2465f3/appengine/findit/handlers/test/triage_analysis_test.py [modify] https://crrev.com/028bf49a806f3add512d9d5d2600248839e13bb4/appengine/findit/main.py [modify] https://crrev.com/028bf49a806f3add512d9d5d2600248839e13bb4/appengine/findit/templates/build_failure.html [delete] https://crrev.com/152ba675bcc212e7fbb0eabcb7913892ae2465f3/appengine/findit/handlers/triage_analysis.py
Comment 1 by chanli@chromium.org
, Apr 19 2017