New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 713353 link

Starred by 1 user
Status: Archived
Owner:
█ michaeln@chromium.org
Last visit > 30 days ago
Closed: Apr 2017
Cc:
xiy...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocked on:
issue 619927


Sign in to add a comment

HostContentSettingsMap used from other thread before initialization finishes

Project Member Reported by xiy...@chromium.org, Apr 19 2017 
DCHEC_NE in HostContentSettingsMap::RegisterProvider [1] is quite easy to happen now after https://codereview.chromium.org/2777183010. The CL added a special_storage_policy_->IsStorageSessionOnly() call which uses HostContentSettingsMap::GetWebsiteSetting on IO thread before ExtensionService::RegisterContentSettings is called from ProfileManager::DoFinalInitForServices on the main thread.

To repro, build a chromeos chrome on linux and run with "--login-manager" and signs in as a user. Think it happens on device too but go un-noticed because this is only a DCHECK.

michaeln@, could you take a look? It breaks the work flow on dev box.

[1] https://cs.chromium.org/chromium/src/components/content_settings/core/browser/host_content_settings_map.cc?rcl=4cd4d67ff4b29899a150e92a129179ca4bbcdd49&l=241

Comment 1 by xiy...@chromium.org, Apr 19 2017

Labels: -Pri-2 Pri-3
It seems to be related to whether you have a hosted app installed in the user profile. The race is because of the LogHostedAppUnlimitedStorageUsage call [1] that happens when extension service loads an hosted app during user profile init.

My testing user has "Entanglement Web App" (aciahcmjmecflokailenpkdchphgkefd) and this happens.

Dropping to P3 since it only happens with certain users.

[1] https://cs.chromium.org/chromium/src/chrome/browser/extensions/extension_special_storage_policy.cc?rcl=a2c82f66d03db799714d03fb8cdd666a8596b97d&l=73

Comment 2 by michaeln@chromium.org, Apr 20 2017

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/79743d6711cd3e10938f7a7fb057dd065dca3822

commit 79743d6711cd3e10938f7a7fb057dd065dca3822
Author: michaeln <michaeln@chromium.org>
Date: Thu Apr 20 19:56:26 2017

Only test SpecialStoragePolicy->IsOriginSessionOnly for temporary storage

The attribute doesn't apply to other types and this also avoid calling
into the ExtensionSpecialStoragePolicy prior to the extension system
being fully initialized.

BUG= 713353 

Review-Url: https://codereview.chromium.org/2834563002
Cr-Commit-Position: refs/heads/master@{#466097}

[modify] https://crrev.com/79743d6711cd3e10938f7a7fb057dd065dca3822/storage/browser/quota/quota_manager.cc

Comment 4 by michaeln@chromium.org, Apr 20 2017

Status: Fixed (was: Started)

Comment 5 by gab@chromium.org, May 25 2017 

 Issue 718605  has been merged into this issue.

Comment 6 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 7 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 8 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
►

Sign in to add a comment