CanvasRenderingContext2DTestWithTestingPlatform.ElementRequestsCompositingUpdateOnHibernateAndWakeUp crashes after finishing |
|||||
Issue descriptionRunning the test on its own won't see the crash, because the process exits before it can crash. But when running all tests it will crash, I narrowed it down to this test by disabling tests and when this one is disabled the crash goes away. Received signal 11 <unknown> 000000000000 #0 0x7ff5ba43745b base::debug::StackTrace::StackTrace() #1 0x7ff5ba43615c base::debug::StackTrace::StackTrace() #2 0x7ff5ba436f6f base::debug::(anonymous namespace)::StackDumpSignalHandler() #3 0x7ff5bad5a330 <unknown> #4 0x7ff5b47e2cc6 blink::scheduler::WebThreadBase::TaskObserverAdapter::WillProcessTask() #5 0x7ff5b47ada69 blink::scheduler::TaskQueueManager::ProcessTaskFromWorkQueue() #6 0x7ff5b47aaced blink::scheduler::TaskQueueManager::DoWork() #7 0x7ff5b47b6094 _ZN4base8internal13FunctorTraitsIMN5blink9scheduler16TaskQueueManagerEFvbEvE6InvokeIRKNS_7WeakPtrIS4_EEJRKbEEEvS6_OT_DpOT0_ #8 0x7ff5b47b5f9f _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIRKMN5blink9scheduler16TaskQueueManagerEFvbERKNS_7WeakPtrIS6_EEJRKbEEEvOT_OT0_DpOT1_ #9 0x7ff5b47b5f13 _ZN4base8internal7InvokerINS0_9BindStateIMN5blink9scheduler16TaskQueueManagerEFvbEJNS_7WeakPtrIS5_EEbEEEFvvEE7RunImplIRKS7_RKSt5tupleIJS9_bEEJLm0ELm1EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEE #10 0x7ff5b47b5e2c _ZN4base8internal7InvokerINS0_9BindStateIMN5blink9scheduler16TaskQueueManagerEFvbEJNS_7WeakPtrIS5_EEbEEEFvvEE3RunEPNS0_13BindStateBaseE #11 0x7ff5ba43d96e _ZNO4base8CallbackIFvvELNS_8internal8CopyModeE0ELNS2_10RepeatModeE0EE3RunEv #12 0x7ff5ba43d0ae base::debug::TaskAnnotator::RunTask() #13 0x7ff5ba4cf4cd base::MessageLoop::RunTask() #14 0x7ff5ba4cf754 base::MessageLoop::DeferOrRunPendingTask() #15 0x7ff5ba4cfa44 base::MessageLoop::DoWork() #16 0x7ff5ba4e7afc base::MessagePumpGlib::HandleDispatch() #17 0x7ff5ba4e82a1 base::(anonymous namespace)::WorkSourceDispatch() #18 0x7ff5a8328e04 g_main_context_dispatch #19 0x7ff5a8329048 <unknown> #20 0x7ff5a83290ec g_main_context_iteration #21 0x7ff5ba4e7bff base::MessagePumpGlib::Run() #22 0x7ff5ba4cf067 base::MessageLoop::RunHandler() #23 0x7ff5ba576f0a base::RunLoop::Run() #24 0x7ff5ba577189 base::RunLoop::RunUntilIdle() #25 0x00000076abc4 (anonymous namespace)::runHelper() #26 0x0000006efc2a _ZN4base8internal13FunctorTraitsIPFvPN5blink16FrameTestHelpers18TestWebFrameClientEEvE6InvokeIJS5_EEEvS7_DpOT_ #27 0x00000076b318 _ZN4base8internal12InvokeHelperILb0EiE8MakeItSoIRKPFiPNS_9TestSuiteEEJS5_EEEiOT_DpOT0_ #28 0x00000076b2d7 _ZN4base8internal7InvokerINS0_9BindStateIPFiPNS_9TestSuiteEEJNS0_17UnretainedWrapperIS3_EEEEEFivEE7RunImplIRKS6_RKSt5tupleIJS8_EEJLm0EEEEiOT_OT0_NS_13IndexSequenceIJXspT1_EEEE #29 0x00000076b21c _ZN4base8internal7InvokerINS0_9BindStateIPFiPNS_9TestSuiteEEJNS0_17UnretainedWrapperIS3_EEEEEFivEE3RunEPNS0_13BindStateBaseE #30 0x000000bf01fd _ZNKR4base8CallbackIFvvELNS_8internal8CopyModeE1ELNS2_10RepeatModeE1EE3RunEv #31 0x000001b83226 base::(anonymous namespace)::LaunchUnitTestsInternal() #32 0x000001b83094 base::LaunchUnitTests() #33 0x00000076aaa4 main #34 0x7ff5a860af45 __libc_start_main #35 0x000000653be4 <unknown> r8: 0000000000000000 r9: 00007fff68d9eff0 r10: fffffffffffffe20 r11: 00007ff5a8772cf0 r12: 00000c3a2e1bdb60 r13: 0000000000000000 r14: 00007ff5ba4e8280 r15: 00000c3a2e87dd40 di: 0000079303bc2908 si: 2c2c2c2c2c2c2c2c bp: 00007fff68d9f930 bx: 0000000000000000 dx: 830fe1f653ccf500 ax: 00000c3a2ead5890 cx: 00007ff5b47e2ca0 sp: 00007fff68d9f910 ip: 00007ff5b47e2cc6 efl: 0000000000010202 cgf: 0000000000000033 erf: 0000000000000000 trp: 000000000000000d msk: 0000000000000000 cr2: 0000000000000000 [end of stack trace]
,
Apr 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d5521d9d44f51d4372ac4246747761c437739e9d commit d5521d9d44f51d4372ac4246747761c437739e9d Author: eseckler <eseckler@chromium.org> Date: Mon Apr 24 09:10:53 2017 [blink] Fix crashes in CanvasRenderingContext2DTests. ElementRequestsCompositingUpdateOnHibernateAndWakeUp caused crashes after finishing. It seems this is caused by resetting the testing platform after TearDown() runs. This patch makes sure that it is reset before. BUG= 713352 Review-Url: https://codereview.chromium.org/2826403002 Cr-Commit-Position: refs/heads/master@{#466604} [modify] https://crrev.com/d5521d9d44f51d4372ac4246747761c437739e9d/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp
,
Apr 24 2017
,
Apr 24 2017
Please tag with applicable OSs. Thanks.
,
Apr 24 2017
Sure. This affects only reliability of test execution on the release branch (e.g. on builders / try bots) - not sure if a merge is necessary or desired. Please advise :)
,
Apr 25 2017
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f67183d3d0bc00c432556d98ae989759dca2d7dc commit f67183d3d0bc00c432556d98ae989759dca2d7dc Author: Eric Seckler <eseckler@chromium.org> Date: Tue Apr 25 10:58:49 2017 [blink] Fix crashes in CanvasRenderingContext2DTests. ElementRequestsCompositingUpdateOnHibernateAndWakeUp caused crashes after finishing. It seems this is caused by resetting the testing platform after TearDown() runs. This patch makes sure that it is reset before. BUG= 713352 Review-Url: https://codereview.chromium.org/2826403002 Cr-Commit-Position: refs/heads/master@{#466604} (cherry picked from commit d5521d9d44f51d4372ac4246747761c437739e9d) Review-Url: https://codereview.chromium.org/2836283002 . Cr-Commit-Position: refs/branch-heads/3071@{#199} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/f67183d3d0bc00c432556d98ae989759dca2d7dc/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by xlai@chromium.org
, Apr 19 2017Owner: eseckler@chromium.org