fieldset loses box-shadow after adding legend and rounded corners
Reported by
marc...@gmail.com,
Apr 19 2017
|
||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/57.0.2987.133 Safari/537.36 Example URL: https://marcoen.tk/chromium-fieldset-no-box-shadow.html Steps to reproduce the problem: 1. open page in chromium 2. look at middle fieldset 3. What is the expected behavior? The middle fieldset should have a box shadow rendered What went wrong? The middle fieldset does not have a box shadow rendered Does it occur on multiple sites: N/A Is it a problem with a plugin? N/A Did this work before? N/A Does this work in other browsers? Yes Chrome version: 57.0.2987.133 Channel: n/a OS Version: Flash Version: I think it used to work in chromium, might be a regression.
,
Apr 20 2017
,
Apr 20 2017
Using the per-revision bisect providing the bisect results, Good build: 56.0.2908.0 (Revision : 429486). Bad build:56.0.2910.0 (Revision : 430103). You are probably looking for a change made after 429737 (known good), but no later than 429738 (first known bad). CHANGELOG URL: The script might not always return single CL as suspectas some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/57c0a6fdc6a530bcb43f6657a8cf708752adca66..eac477641ec5fdf9e3b9ec52d46fc3a908e8503e From the CL above, assigning the issue to the concern owner @wangxianzhu- Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Review-Url: https://codereview.chromium.org/2464053003 Note : Issue is a regression issue broken in M56 and seen in latest stable , beta ,dev and canary channels and across Mac , linux and windows OS Thanks!
,
Apr 20 2017
,
Apr 20 2017
,
Apr 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7d8aac7b2e42174063748f68741f2a681df2e7b9 commit 7d8aac7b2e42174063748f68741f2a681df2e7b9 Author: wangxianzhu <wangxianzhu@chromium.org> Date: Fri Apr 21 20:56:21 2017 Fix box-shadow painting for fieldset with legend, background, and border-radius This regressed since https://codereview.chromium.org/2464053003 which separated box-shadow painting from background painting, but missed modification to FieldsetPainter about box-shadow/background painting. BUG= 713331 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2836673002 Cr-Commit-Position: refs/heads/master@{#466441} [add] https://crrev.com/7d8aac7b2e42174063748f68741f2a681df2e7b9/third_party/WebKit/LayoutTests/paint/background/fieldset-legend-background-shadow-border-radius-expected.png [add] https://crrev.com/7d8aac7b2e42174063748f68741f2a681df2e7b9/third_party/WebKit/LayoutTests/paint/background/fieldset-legend-background-shadow-border-radius-expected.txt [add] https://crrev.com/7d8aac7b2e42174063748f68741f2a681df2e7b9/third_party/WebKit/LayoutTests/paint/background/fieldset-legend-background-shadow-border-radius.html [modify] https://crrev.com/7d8aac7b2e42174063748f68741f2a681df2e7b9/third_party/WebKit/Source/core/paint/FieldsetPainter.cpp
,
Apr 21 2017
It will be good if M59 has the fix.
,
Apr 21 2017
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 21 2017
Please merge your change to M59 branch #3071 latest before 4:00 PM PT, Monday (04/24) so we can take it for next week last M59 dev release. Thank you.
,
Apr 21 2017
,
Apr 21 2017
Merged: https://codereview.chromium.org/2834583005/. bugdroid email delayed.
,
Apr 25 2017
Verified this issue on Windows-10, Mac 10.12.4 and Ubuntu 14.04 using chrome latest Dev #59.0.3071.25 by following steps mentioned in the original comment Shadow is seen now for middle field set box. Please find the screen cast
,
Apr 25 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 25 2017
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by marc...@gmail.com
, Apr 19 2017903 bytes
903 bytes View Download
18.9 KB
18.9 KB View Download
14.5 KB
14.5 KB View Download