New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 713327 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Last visit > 30 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on: View detail
issue 713338
issue 714231
issue 713334
issue 713335
issue 713346

Blocking:
issue 575762



Sign in to add a comment

Harden Telemetry benchmark harnesses' API through benchmarks merging

Project Member Reported by nedngu...@google.com, Apr 19 2017

Issue description

This is the meta bug for the effort of hardening Telemetry benchmark harnesses APIs through merging benchmarks. 
For example, instead of having many loading benchmarks such as page_cycler_v2.typical_25, page_cycler_v2.intl_ar_fa_he, page_cycler_v2.intl_es_fr_pt-BR.., we would just have a single loading.desktop benchmarks for all the desktop cases & loading.mobile for all the mobile cases.

There are few cases where people don't care about splitting desktop/mobile test cases, which it would be fine to have a single "benchmark_foo" harness.

Besides the fact that this make it simpler to reason about how to add new test cases, there are many benefits of such merging which are explained in this doc: https://bit.ly/why-merge-benchmarks

 
Labels: -Pri-3 Pri-2
Description: Show this description
Blockedon: 713334
Blockedon: 713335
Blockedon: 713338
Blockedon: 713346
Blockedon: 714231
Project Member

Comment 8 by sheriffbot@chromium.org, Jul 19 2017

Labels: Hotlist-Google
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d28ef91a002972a7743c9a90105b86c851bdc3a

commit 4d28ef91a002972a7743c9a90105b86c851bdc3a
Author: Ned Nguyen <nednguyen@google.com>
Date: Thu Aug 03 19:43:58 2017

Remove chrome_signin_startup benchmark

This benchmark has been disabled for a long time without anyone reviving it.
It also has some design problem make it hard to maintain, so we better remove it
& design it from scratch when the time come for this benchmark to be a priority.

This CL also removes chrome_signin_archive_000.wpr.sha1 (legacy WPR archives format)

Bug: 551938, 713327,  730036 
Change-Id: I64abd43757a8111e2c7a25a3104b0b1a121b42f0
Reviewed-on: https://chromium-review.googlesource.com/600767
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491818}
[modify] https://crrev.com/4d28ef91a002972a7743c9a90105b86c851bdc3a/tools/perf/benchmark.csv
[delete] https://crrev.com/2c3ec3ced96f6050c1bbcc0c4a8b9ebc12917a7f/tools/perf/benchmarks/chrome_signin_startup.py
[delete] https://crrev.com/2c3ec3ced96f6050c1bbcc0c4a8b9ebc12917a7f/tools/perf/page_sets/chrome_signin.py
[delete] https://crrev.com/2c3ec3ced96f6050c1bbcc0c4a8b9ebc12917a7f/tools/perf/page_sets/data/chrome_signin_archive.json
[delete] https://crrev.com/2c3ec3ced96f6050c1bbcc0c4a8b9ebc12917a7f/tools/perf/page_sets/data/chrome_signin_archive_000.wpr.sha1
[modify] https://crrev.com/4d28ef91a002972a7743c9a90105b86c851bdc3a/tools/perf/unowned_benchmarks.txt

Owner: nednguyen@chromium.org
Blocking: 575762

Sign in to add a comment