Issue metadata
Sign in to add a comment
|
Supervised user message doesn't fit in MD system tray |
||||||||||||||||||||||
Issue descriptionChrome ToT r465655 The supervised user tray item text is too large, so it gets clipped on the top and bottom. This is probably due to font changes from MD. See screenshot. Code is in ash/system/supervised/tray_supervised_user.cc. I noticed this while refactoring some stuff for mustash -- please CC me on any CL that changes that file. To tdanderson@ for triage.
,
Apr 19 2017
,
Apr 19 2017
tbuckley@, what is the desired behavior here, is it ok to elide this text or are there security reasons that we should always show the entire message?
,
Apr 20 2017
Don't work on this until my mustash refactor in issue 712799 is resolved -- I'm having to make lots of changes to TraySupervisedUser.
,
Apr 20 2017
@bruthig eliding would certainly be better than cutting the text off, though I think the ideal is that we show the whole message. If it's elided, will hovering over it show the whole string in a tooltip?
,
Apr 27 2017
James, I just tried this on ToT @467672 with the same string as in #0 (see attached) and there doesn't seem to be any layout issues. Mind double-checking this on your end?
,
Apr 27 2017
Seems fixed for me too. Someone must have fixed line wrapping in tray label items.
,
Apr 27 2017
In looking at issue 715615 I found a case where this bug can still reproduce. Re-opening and assigning back to myself.
,
May 9 2017
Handing this over to mohsen@. As discussed: * See https://codereview.chromium.org/2638163002/ for how a similar issue was addressed previously (this also explains the root cause). Note this will not reproduce with all strings (depends on the length and how line wrapping takes place), but you can repro locally if you force the supervised user string to be exactly the same one as seen in #0. * Bug should repro for anything that uses LabelTrayView (supervised user, session length limit, enterprise user). * Once this bug is fixed, consider having TrayTracing also make use of LabelTrayView. (TrayTracing uses multiline text so it is possible this same bug could also repro in that view, depending on locale).
,
May 18 2017
,
May 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/abf6d850267cf2669a6ed99c8cd690f58dfb2eb2 commit abf6d850267cf2669a6ed99c8cd690f58dfb2eb2 Author: Mohsen Izadi <mohsen@chromium.org> Date: Thu May 18 20:03:12 2017 Remove extra padding from system menu labels There is an extra 8dp padding added to the right hand side of almost all labels in the system menu. Other than causing issues with multiline labels, it doesn't seem necessary everywhere. For cases that it is needed, the padding can be added to the container of the label. BUG= 713317 TEST=none Change-Id: I3ef923473b28a2a133c2907522682b57138de399 Reviewed-on: https://chromium-review.googlesource.com/508391 Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#472910} [modify] https://crrev.com/abf6d850267cf2669a6ed99c8cd690f58dfb2eb2/ash/system/date/date_view.cc [modify] https://crrev.com/abf6d850267cf2669a6ed99c8cd690f58dfb2eb2/ash/system/network/network_list.cc [modify] https://crrev.com/abf6d850267cf2669a6ed99c8cd690f58dfb2eb2/ash/system/screen_security/screen_tray_item.cc [modify] https://crrev.com/abf6d850267cf2669a6ed99c8cd690f58dfb2eb2/ash/system/tray/hover_highlight_view.cc [modify] https://crrev.com/abf6d850267cf2669a6ed99c8cd690f58dfb2eb2/ash/system/tray/tray_popup_utils.cc [modify] https://crrev.com/abf6d850267cf2669a6ed99c8cd690f58dfb2eb2/ash/system/tray_caps_lock.cc
,
May 24 2017
,
Jul 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dbfab9c2f00000115eb304de54a7b2ed0a4663ac commit dbfab9c2f00000115eb304de54a7b2ed0a4663ac Author: bratell <bratell@opera.com> Date: Mon Jul 10 10:10:04 2017 Some documentation for the jumbo feature. R=dpranke@chromium.org BUG= 713317 Review-Url: https://codereview.chromium.org/2968963002 Cr-Commit-Position: refs/heads/master@{#485222} [add] https://crrev.com/dbfab9c2f00000115eb304de54a7b2ed0a4663ac/docs/jumbo.md [modify] https://crrev.com/dbfab9c2f00000115eb304de54a7b2ed0a4663ac/docs/windows_build_instructions.md
,
Aug 1 2017
Verified on Chrome OS 9592.71.0, 60.0.3112.80 (stable build). |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by tdander...@chromium.org
, Apr 19 2017