New issue
Advanced search Search tips

Issue 713303 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature
STS
Team-Accessibility

Blocking:
issue 801410



Sign in to add a comment

[Select-to-Speak] Ability to speak only selected text

Project Member Reported by lpalmaro@chromium.org, Apr 19 2017

Issue description

OS: Chrome

Not launch blocking, but would be great to add a checkbox in settings to read only the text that is selected by pressing a specific keyboard shortcut. This shortcut should be Search plus another key, perhaps Ctrl + Search, as this doesn't appear to be used right now. 

Basically, we should have an overall section for "Select-to-Speak" in settings, then have two checkbox options that could either be enabled individually or together. One for speaking the selected text, and the other for holding down search and drawing a square/rectangle around a given item of the screen to hear the content within it. 
 
Labels: -Restrict-View-Google
Owner: ----
Status: Available (was: Assigned)
Labels: STS

Comment 3 by katie@chromium.org, Dec 19 2017

Owner: katie@chromium.org

Comment 4 by katie@chromium.org, Dec 20 2017

Status: Started (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/15df088c255c7c5b7fdd6d650b0082a0319ba227

commit 15df088c255c7c5b7fdd6d650b0082a0319ba227
Author: Katie Dektar <katydek@google.com>
Date: Thu Dec 21 21:56:57 2017

Use ChromeVox utils in Select-to-Speak to support future changes.

Includes a closure_shim.js that allows Select-to-Speak to use these
files without closure.

This is temporary, eventually ChromeVox and Select-to-Speak should
both pull these utility files from one shared location.

Bug:  713303 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I0bb93e5989e2ea83d89a500b6d92134031e78f07
Reviewed-on: https://chromium-review.googlesource.com/834206
Commit-Queue: Katie Dektar <katie@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525820}
[modify] https://crrev.com/15df088c255c7c5b7fdd6d650b0082a0319ba227/chrome/browser/resources/chromeos/chromevox/chromevox/background/background.js
[modify] https://crrev.com/15df088c255c7c5b7fdd6d650b0082a0319ba227/chrome/browser/resources/chromeos/chromevox/common/chromevox.js
[modify] https://crrev.com/15df088c255c7c5b7fdd6d650b0082a0319ba227/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js
[modify] https://crrev.com/15df088c255c7c5b7fdd6d650b0082a0319ba227/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util.js
[modify] https://crrev.com/15df088c255c7c5b7fdd6d650b0082a0319ba227/chrome/browser/resources/chromeos/chromevox/cvox2/background/constants.js
[modify] https://crrev.com/15df088c255c7c5b7fdd6d650b0082a0319ba227/chrome/browser/resources/chromeos/select_to_speak/BUILD.gn
[add] https://crrev.com/15df088c255c7c5b7fdd6d650b0082a0319ba227/chrome/browser/resources/chromeos/select_to_speak/closure_shim.js
[modify] https://crrev.com/15df088c255c7c5b7fdd6d650b0082a0319ba227/chrome/browser/resources/chromeos/select_to_speak/compiled_resources2.gyp
[modify] https://crrev.com/15df088c255c7c5b7fdd6d650b0082a0319ba227/chrome/browser/resources/chromeos/select_to_speak/manifest.json.jinja2

Project Member

Comment 6 by bugdroid1@chromium.org, Dec 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2af7b4b8f28c2a95d6e545ac5a04d75f226034bf

commit 2af7b4b8f28c2a95d6e545ac5a04d75f226034bf
Author: Katie Dektar <katie@chromium.org>
Date: Fri Dec 22 19:12:08 2017

Revert "Use ChromeVox utils in Select-to-Speak to support future changes."

This reverts commit 15df088c255c7c5b7fdd6d650b0082a0319ba227.

Reason for revert: Breaks PFQ trybots
Bug:797339

Original change's description:
> Use ChromeVox utils in Select-to-Speak to support future changes.
> 
> Includes a closure_shim.js that allows Select-to-Speak to use these
> files without closure.
> 
> This is temporary, eventually ChromeVox and Select-to-Speak should
> both pull these utility files from one shared location.
> 
> Bug:  713303 
> Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
> Change-Id: I0bb93e5989e2ea83d89a500b6d92134031e78f07
> Reviewed-on: https://chromium-review.googlesource.com/834206
> Commit-Queue: Katie Dektar <katie@chromium.org>
> Reviewed-by: David Tseng <dtseng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#525820}

TBR=dmazzoni@chromium.org,dtseng@chromium.org,katie@chromium.org

Change-Id: I108428209aec17d0c88e0feee21837da7eb4d769
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  797339 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/843206
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526038}
[modify] https://crrev.com/2af7b4b8f28c2a95d6e545ac5a04d75f226034bf/chrome/browser/resources/chromeos/chromevox/chromevox/background/background.js
[modify] https://crrev.com/2af7b4b8f28c2a95d6e545ac5a04d75f226034bf/chrome/browser/resources/chromeos/chromevox/common/chromevox.js
[modify] https://crrev.com/2af7b4b8f28c2a95d6e545ac5a04d75f226034bf/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js
[modify] https://crrev.com/2af7b4b8f28c2a95d6e545ac5a04d75f226034bf/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util.js
[modify] https://crrev.com/2af7b4b8f28c2a95d6e545ac5a04d75f226034bf/chrome/browser/resources/chromeos/chromevox/cvox2/background/constants.js
[modify] https://crrev.com/2af7b4b8f28c2a95d6e545ac5a04d75f226034bf/chrome/browser/resources/chromeos/select_to_speak/BUILD.gn
[delete] https://crrev.com/3cf32744d21a6f64e491c167cb995e72fe0d67bc/chrome/browser/resources/chromeos/select_to_speak/closure_shim.js
[modify] https://crrev.com/2af7b4b8f28c2a95d6e545ac5a04d75f226034bf/chrome/browser/resources/chromeos/select_to_speak/compiled_resources2.gyp
[modify] https://crrev.com/2af7b4b8f28c2a95d6e545ac5a04d75f226034bf/chrome/browser/resources/chromeos/select_to_speak/manifest.json.jinja2

Project Member

Comment 7 by bugdroid1@chromium.org, Dec 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c143cd64c891a5bd4b12142d80fa7d140f106bd7

commit c143cd64c891a5bd4b12142d80fa7d140f106bd7
Author: Katie Dektar <katydek@google.com>
Date: Sat Dec 23 02:10:28 2017

Reland 'Use ChromeVox utils in Select-to-Speak to support future changes.'

This reverts https://chromium-review.googlesource.com/834206, which
was a revert to the original because chromevox files were not properly
copied into the select-to-speak directory.

Original commit message:
Use ChromeVox utils in Select-to-Speak to support future changes.

Includes a closure_shim.js that allows Select-to-Speak to use these
files without closure.

This is temporary, eventually ChromeVox and Select-to-Speak should
both pull these utility files from one shared location.

Bug:  713303 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Iafad9edd686df7cf3f65b34a9860127f1d7c325d
Reviewed-on: https://chromium-review.googlesource.com/843479
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526129}
[modify] https://crrev.com/c143cd64c891a5bd4b12142d80fa7d140f106bd7/chrome/browser/resources/chromeos/chromevox/chromevox/background/background.js
[modify] https://crrev.com/c143cd64c891a5bd4b12142d80fa7d140f106bd7/chrome/browser/resources/chromeos/chromevox/common/chromevox.js
[modify] https://crrev.com/c143cd64c891a5bd4b12142d80fa7d140f106bd7/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js
[modify] https://crrev.com/c143cd64c891a5bd4b12142d80fa7d140f106bd7/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util.js
[modify] https://crrev.com/c143cd64c891a5bd4b12142d80fa7d140f106bd7/chrome/browser/resources/chromeos/chromevox/cvox2/background/constants.js
[modify] https://crrev.com/c143cd64c891a5bd4b12142d80fa7d140f106bd7/chrome/browser/resources/chromeos/select_to_speak/BUILD.gn
[add] https://crrev.com/c143cd64c891a5bd4b12142d80fa7d140f106bd7/chrome/browser/resources/chromeos/select_to_speak/closure_shim.js
[modify] https://crrev.com/c143cd64c891a5bd4b12142d80fa7d140f106bd7/chrome/browser/resources/chromeos/select_to_speak/compiled_resources2.gyp
[modify] https://crrev.com/c143cd64c891a5bd4b12142d80fa7d140f106bd7/chrome/browser/resources/chromeos/select_to_speak/manifest.json.jinja2

Project Member

Comment 8 by bugdroid1@chromium.org, Jan 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/23e5753d4c6df3873e0eec6134228133ad39e78f

commit 23e5753d4c6df3873e0eec6134228133ad39e78f
Author: Katie Dektar <katydek@google.com>
Date: Mon Jan 08 20:23:19 2018

Adds ability to read only selected text.

See go/chromeos-sts-selection-keystroke
This is not complete: If the user has focus inside
an editable text field, search+s will not be recognized.

Bug:  713303 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I8e54c89de090f6ba981206a0e94cee7596904752
Reviewed-on: https://chromium-review.googlesource.com/838365
Commit-Queue: Katie Dektar <katie@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527736}
[modify] https://crrev.com/23e5753d4c6df3873e0eec6134228133ad39e78f/chrome/browser/chromeos/accessibility/select_to_speak_event_rewriter.cc
[modify] https://crrev.com/23e5753d4c6df3873e0eec6134228133ad39e78f/chrome/browser/chromeos/accessibility/select_to_speak_event_rewriter.h
[modify] https://crrev.com/23e5753d4c6df3873e0eec6134228133ad39e78f/chrome/browser/chromeos/accessibility/select_to_speak_event_rewriter_unittest.cc
[modify] https://crrev.com/23e5753d4c6df3873e0eec6134228133ad39e78f/chrome/browser/resources/chromeos/select_to_speak/select_to_speak.js
[modify] https://crrev.com/23e5753d4c6df3873e0eec6134228133ad39e78f/chrome/browser/resources/chromeos/select_to_speak/select_to_speak_unittest.gtestjs

Comment 9 by katie@chromium.org, Jan 10 2018

Labels: a11y-testing
Project Member

Comment 10 by bugdroid1@chromium.org, Jan 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/95084c1883cf8b420099177dbc37b40e375a7101

commit 95084c1883cf8b420099177dbc37b40e375a7101
Author: Katie Dektar <katydek@google.com>
Date: Wed Jan 10 23:54:36 2018

Integration tests for select-to-speak.

Adds tests to read text at keystroke using the select-to-speak
extension.

More tests coming up now that this framework will be in place.

Bug:  713303 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I6d07693e5e63975e1821d7fd325df8764357e6ae
Reviewed-on: https://chromium-review.googlesource.com/852819
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528492}
[modify] https://crrev.com/95084c1883cf8b420099177dbc37b40e375a7101/chrome/browser/resources/chromeos/select_to_speak/BUILD.gn
[add] https://crrev.com/95084c1883cf8b420099177dbc37b40e375a7101/chrome/browser/resources/chromeos/select_to_speak/mock_tts.js
[modify] https://crrev.com/95084c1883cf8b420099177dbc37b40e375a7101/chrome/browser/resources/chromeos/select_to_speak/select_to_speak.js
[add] https://crrev.com/95084c1883cf8b420099177dbc37b40e375a7101/chrome/browser/resources/chromeos/select_to_speak/select_to_speak_e2e_test_base.js
[add] https://crrev.com/95084c1883cf8b420099177dbc37b40e375a7101/chrome/browser/resources/chromeos/select_to_speak/select_to_speak_keystroke_selection_test.extjs
[modify] https://crrev.com/95084c1883cf8b420099177dbc37b40e375a7101/chrome/browser/resources/chromeos/select_to_speak/select_to_speak_main.js
[modify] https://crrev.com/95084c1883cf8b420099177dbc37b40e375a7101/testing/buildbot/chromium.chromiumos.json
[modify] https://crrev.com/95084c1883cf8b420099177dbc37b40e375a7101/testing/buildbot/gn_isolate_map.pyl
[modify] https://crrev.com/95084c1883cf8b420099177dbc37b40e375a7101/testing/buildbot/test_suites.pyl

Project Member

Comment 11 by bugdroid1@chromium.org, Jan 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e52721497af7891444d62a2a7fca043990b1728

commit 2e52721497af7891444d62a2a7fca043990b1728
Author: Katie Dektar <katydek@google.com>
Date: Wed Jan 10 23:57:01 2018

Adds metrics for how select-to-speak speech was started by the user.

go/chromeos-sts-selection-keystroke

Bug:  713303 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I815063788f00fc9df012fda5469141fa7c5d8666
Reviewed-on: https://chromium-review.googlesource.com/858300
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528493}
[modify] https://crrev.com/2e52721497af7891444d62a2a7fca043990b1728/chrome/browser/resources/chromeos/select_to_speak/select_to_speak.js
[modify] https://crrev.com/2e52721497af7891444d62a2a7fca043990b1728/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/2e52721497af7891444d62a2a7fca043990b1728/tools/metrics/histograms/histograms.xml

Project Member

Comment 12 by bugdroid1@chromium.org, Jan 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6923c326f7a892742c6006248e1901c4eddcad0c

commit 6923c326f7a892742c6006248e1901c4eddcad0c
Author: Katie Dektar <katydek@google.com>
Date: Thu Jan 11 23:22:09 2018

Add flag to enable Search+S to read selected text in Select-to-Speak.

Once the feature is approved this can be reverted and the feature
can simply be enabled always. This makes the feature accessible for
testing until it is done with the approval process.

Bug:  713303 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I058bfd5f8d67d88f96061ec469688d7454aef650
Reviewed-on: https://chromium-review.googlesource.com/857689
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528806}
[modify] https://crrev.com/6923c326f7a892742c6006248e1901c4eddcad0c/chrome/app/settings_strings.grdp
[modify] https://crrev.com/6923c326f7a892742c6006248e1901c4eddcad0c/chrome/browser/resources/chromeos/select_to_speak/compiled_resources2.gyp
[modify] https://crrev.com/6923c326f7a892742c6006248e1901c4eddcad0c/chrome/browser/resources/chromeos/select_to_speak/manifest.json.jinja2
[modify] https://crrev.com/6923c326f7a892742c6006248e1901c4eddcad0c/chrome/browser/resources/chromeos/select_to_speak/select_to_speak.js
[modify] https://crrev.com/6923c326f7a892742c6006248e1901c4eddcad0c/chrome/browser/resources/chromeos/select_to_speak/test_support.js
[modify] https://crrev.com/6923c326f7a892742c6006248e1901c4eddcad0c/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

Comment 13 by katie@chromium.org, Jan 11 2018

Status: Fixed (was: Started)
Marking as fixed since this is in behind a flag. May need more tweaks but will file separate bugs for any issues.

Testers, I'd love your help verifying that this is working well (or with bugs where it doesn't.)
Blocking: 801410
Labels: -a11y-testing
Status: Verified (was: Fixed)
Google Chrome 67.0.3369.0 (Official Build) canary (64-bit)
Firmware Version Google_Samus.6300.276.0
Flag enabled: #enable-experimental-accessibility-features

I've been using Search + s all over the UI while verifying various bugs. I found some discrepancies in 812683 when it's used in Google Docs, Sheets, etc. but it turned out that it was expected behavior. Therefore, I'm going to mark this as verified. 
Components: UI>Accessibility>SelectToSpeak
Moving from just having STS label to also having the UI>Accessibility>SelectToSpeak component to make searching easier in the future. 

Sign in to add a comment