New issue
Advanced search Search tips

Issue 713301 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 675877



Sign in to add a comment

ContainerNode firstChild/lastChild should not be uppercase

Project Member Reported by esprehn@chromium.org, Apr 19 2017

Issue description

https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/dom/ContainerNode.h?l=87

These are just the non-branching versions of Node::firstChild, they shouldn't be uppercase.
 

Comment 1 by dcheng@chromium.org, Apr 19 2017

Cc: lukasza@chromium.org
Status: Assigned (was: Untriaged)
I think probably a lot of other things on here should be fixed. At first glance:

QuerySelector
QuerySelectorAll
Children
InsertBefore
ReplaceChild
RemoveChild
AppendChild

Comment 2 by dcheng@chromium.org, Apr 21 2017

Blocking: 675877
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/17a207e062459d1d720824e03c96128901f7f531

commit 17a207e062459d1d720824e03c96128901f7f531
Author: Daniel Cheng <dcheng@chromium.org>
Date: Mon Apr 24 05:40:59 2017

Use lowercase names for ContainerNode::firstChild/ContainerNode::lastChild

Bug: 713301
Change-Id: I5877de2dbb00cbf676a23435aacf91fc1d4ae9d3

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Change-Id: I5877de2dbb00cbf676a23435aacf91fc1d4ae9d3
Reviewed-on: https://chromium-review.googlesource.com/484729
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#466589}
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/css/SelectorChecker.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/dom/ChildNodeList.h
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/dom/ContainerNode.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/dom/ContainerNode.h
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/dom/DocumentTest.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/dom/Element.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/dom/MutationObserverTest.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/dom/Node.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/dom/NodeTraversal.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/dom/Range.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/dom/RangeTest.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/dom/StaticRangeTest.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/dom/TextTest.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/dom/VisitedLinkState.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/dom/shadow/ElementShadowV0.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/dom/shadow/FlatTreeTraversal.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/dom/shadow/FlatTreeTraversalTest.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/editing/Editor.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/editing/EditorTest.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/editing/FrameCaretTest.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/editing/GranularityStrategyTest.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/editing/SelectionAdjuster.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/editing/SelectionControllerTest.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/editing/SelectionTemplateTest.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/editing/SurroundingTextTest.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/editing/VisiblePositionTest.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/editing/VisibleUnitsTest.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommandTest.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/editing/commands/FormatBlockCommand.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/editing/commands/InsertIncrementalTextCommandTest.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/editing/commands/InsertListCommandTest.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/editing/commands/MergeIdenticalElementsCommand.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommandTest.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/editing/commands/SetCharacterDataCommandTest.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/editing/commands/SimplifyMarkupCommand.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/editing/commands/SplitElementCommand.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/editing/commands/SplitTextNodeContainingElementCommand.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/editing/iterators/CharacterIteratorTest.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/editing/iterators/TextIteratorTest.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/editing/serializers/Serialization.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/editing/serializers/StyledMarkupSerializerTest.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/editing/spellcheck/SpellCheckerTest.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/frame/LocalFrameTest.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/html/HTMLDetailsElement.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/html/HTMLInputElementTest.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/html/HTMLLinkElementTest.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/html/HTMLObjectElement.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/html/HTMLOptionElement.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/html/HTMLSelectElementTest.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/html/HTMLTableElement.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/html/HTMLTitleElement.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/html/HTMLVideoElement.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/html/TextControlElement.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/html/forms/BaseButtonInputType.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/html/forms/ChooserOnlyTemporalInputTypeView.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/html/forms/ColorInputType.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/html/forms/DateTimeEditElement.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/html/forms/DateTimeFieldElement.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/html/forms/FileInputType.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/html/forms/OptionListTest.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/html/forms/PasswordInputTypeTest.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/html/parser/HTMLConstructionSite.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/html/track/vtt/VTTCue.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/input/EventHandlerTest.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/inspector/DOMPatchSupport.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/layout/ImageQualityControllerTest.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/layout/LayoutFileUploadControl.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/layout/LayoutObjectTest.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/layout/LayoutTableCellTest.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/layout/LayoutTableRowTest.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/page/FocusControllerTest.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/paint/HTMLCanvasPainterTest.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/paint/PaintControllerPaintTest.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/paint/TextPainterTest.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/paint/VideoPainterTest.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/svg/SVGUseElement.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/xml/DocumentXSLT.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/core/xml/parser/XMLErrors.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/web/tests/LinkSelectionTest.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/web/tests/TextFinderTest.cpp
[modify] https://crrev.com/17a207e062459d1d720824e03c96128901f7f531/third_party/WebKit/Source/web/tests/TouchActionTest.cpp

Sign in to add a comment