Revert button inserts Chrome-specific processes into CrOS commits |
|||||||
Issue descriptionsince the new UI, hitting revert inserts a bunch of tags that only make sense to Chrome repos: TBR=... NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true these should only be added for the repos where they make sense
,
Apr 18 2017
,
Apr 18 2017
I am assuming this is happening for a repo that does not have CQ enabled in chromium-review. IIRC there was an open bug to hide this behavior for non-CQ repos.
,
Apr 18 2017
Aaron, this is not a Gerrit bug, can you move it to the appropriate Chromium component?
,
Apr 18 2017
by "CQ", i'm assuming you mean "Chromium CQ". CrOS has long had a CQ in Gerrit (since the beginning of Gerrit actually). so if you're binding to "repo has Commit-Queue label", that is incorrect.
,
Apr 18 2017
Example CL? I see this in commitqueue.js - https://cs.corp.google.com/piper///depot/google3/devtools/gerritcodereview/plugins/commitqueue/commitqueue.js?l=141 Maybe we need that check in more places.
,
Apr 18 2017
just search for one of those strings to find plenty of examples: https://chromium-review.googlesource.com/q/NOPRESUBMIT%253Dtrue https://chromium-review.googlesource.com/479357 https://chromium-review.googlesource.com/478172 https://chromium-review.googlesource.com/477440 https://chromium-review.googlesource.com/471812 https://chromium-review.googlesource.com/471873 no repo under chromiumos/ should have these Chromium-specific things added imo.
,
Apr 18 2017
I am assuming continuing to carry over "BUG=.*" to reverts will be useful. Is there any other string that you want carried over?
,
Apr 18 2017
extracting BUG= from the commit message and automatically copying it over should be fine. i'm not seeing any other tags that make sense for us in there.
,
Apr 19 2017
,
Apr 19 2017
,
Apr 21 2017
,
May 9 2017
This is now live. Tested by clicking on Revert here: https://chromium-review.googlesource.com/c/500287/ Marking as fixed.
,
May 9 2017
thanks! |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by jrn@google.com
, Apr 18 2017