New issue
Advanced search Search tips

Issue 713279 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug


Previous locations:
gerrit:6008


Sign in to add a comment

Revert button inserts Chrome-specific processes into CrOS commits

Project Member Reported by vapier@chromium.org, Apr 14 2017

Issue description

since the new UI, hitting revert inserts a bunch of tags that only make sense to Chrome repos:
TBR=...
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

these should only be added for the repos where they make sense
 

Comment 1 by jrn@google.com, Apr 18 2017

The CQ plugin (commitqueue.js) is what does this.

Comment 2 by jrn@google.com, Apr 18 2017

Cc: rmis...@chromium.org

Comment 3 by rmis...@google.com, Apr 18 2017

Cc: aga...@chromium.org
I am assuming this is happening for a repo that does not have CQ enabled in chromium-review. IIRC there was an open bug to hide this behavior for non-CQ repos.
Components: -PolyGerrit
Aaron, this is not a Gerrit bug, can you move it to the appropriate Chromium component?

Comment 5 by vapier@chromium.org, Apr 18 2017

by "CQ", i'm assuming you mean "Chromium CQ".  CrOS has long had a CQ in Gerrit (since the beginning of Gerrit actually).  so if you're binding to "repo has Commit-Queue label", that is incorrect.

Comment 6 by rmis...@google.com, Apr 18 2017

Example CL?

I see this in commitqueue.js - https://cs.corp.google.com/piper///depot/google3/devtools/gerritcodereview/plugins/commitqueue/commitqueue.js?l=141
Maybe we need that check in more places.

Comment 8 by rmis...@google.com, Apr 18 2017

I am assuming continuing to carry over "BUG=.*" to reverts will be useful.
Is there any other string that you want carried over?

Comment 9 by vapier@chromium.org, Apr 18 2017

extracting BUG= from the commit message and automatically copying it over should be fine.  i'm not seeing any other tags that make sense for us in there.

Comment 10 by rmis...@google.com, Apr 19 2017

Project: chromium
Moved issue gerrit:6008 to now be  issue chromium:713279 .

Comment 11 by rmis...@google.com, Apr 19 2017

Components: Infra>Codereview>Gerrit
Labels: Pri-2 Type-Bug
Owner: rmis...@google.com
Status: Started (was: New)
Summary: Revert button inserts Chrome-specific processes into CrOS commits (was: revert button inserts Chrome-specific processes into commits now)
Labels: Milestone-Afterglow
Status: Fixed (was: Started)
This is now live.
Tested by clicking on Revert here: https://chromium-review.googlesource.com/c/500287/

Marking as fixed.
thanks!

Sign in to add a comment