New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 713268 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

[headless][json api] json/close/ is broken

Reported by vincent....@algolia.com, Apr 19 2017

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3074.0 Safari/537.36

Steps to reproduce the problem:
1. launch chrome canary 60.0.3074.0 (64 bits)  with --headless --remote-debugging-port=9222 https://www.google.com
2. get target id with curl -vg http://127.0.0.1:9222/json/list (69b0f834-1b35-4a92-9b00-4f7f68d9b043)
3. try to close target with curl -vg http://127.0.0.1:9222/json/close/69b0f834-1b35-4a92-9b00-4f7f68d9b043
4. get the list of active targets via curl -vg  http://127.0.0.1:9222/json/list

What is the expected behavior?
List should be empty, target should be closed

What went wrong?
Target is still opened, there's no way to close it. Chrome 59 was ok.

Did this work before? Yes Latest 59

Chrome version: 60.0.3074.0  Channel: canary
OS Version: OS X 10.12.4
Flash Version: 

Linked to https://github.com/cyrus-and/chrome-remote-interface/issues/107#issuecomment-295357937
 

Comment 1 by caseq@chromium.org, Apr 19 2017

Labels: -OS-Mac OS-All
Owner: dgozman@chromium.org
Status: Assigned (was: Unconfirmed)
Works for me on Linux, version 60.0.3076.0 (Developer Build) (64-bit)
89c1673e0dd340f486eba92816998f839706d8f9-refs/heads/master@{#465736}

Mac specific?
Cc: dgozman@chromium.org
Labels: -OS-All Proj-Headless OS-Mac
Owner: skyos...@chromium.org
Tested on Mac version 60.0.3075.0 (Developer Build) (64-bit) 1c304d5beae8ffe9b9317353609abb31537656ac-refs/heads/master@{#465132}.
Works perfectly without --headless flag. Does not work with --headless.

Assigning to Sami for triage. To summarize: this only manifests on Mac with --headless.
Cc: skyos...@chromium.org
Owner: dvallet@chromium.org
Works on Linux too (with --headless), so this is probably mac-specific. David, could you take a look please?
Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ae6a5e9c0b09c7c856a0eb160e2ad071d6ef7d7f

commit ae6a5e9c0b09c7c856a0eb160e2ad071d6ef7d7f
Author: dvallet <dvallet@chromium.org>
Date: Fri Apr 28 21:26:00 2017

Always return false on IsHandlingSendingEvent
This fixes an issue on closing Web contents on headless Mac, since it makes think Web contents that the current view is still handling UI events. See https://cs.chromium.org/chromium/src/content/browser/web_contents/web_contents_view.h?rcl=e0bef062337921727eb9b670b417ebd0b6d86fd6&l=131

BUG= 713268 

Review-Url: https://codereview.chromium.org/2853473002
Cr-Commit-Position: refs/heads/master@{#468132}

[modify] https://crrev.com/ae6a5e9c0b09c7c856a0eb160e2ad071d6ef7d7f/headless/lib/browser/headless_shell_application_mac.mm

Status: Fixed (was: Started)

Sign in to add a comment