New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 713253 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Remove old implementation of media remoting UI

Project Member Reported by x...@chromium.org, Apr 19 2017

Issue description

The new implementation is already landed in M59. The old one should be removed to avoid the overlapping of both during the transition.
 

Comment 1 by x...@chromium.org, Apr 19 2017

CL: https://codereview.chromium.org/2801853002/

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2504c4da27a272a4906a7fd1bde697c8bdf7def1

commit 2504c4da27a272a4906a7fd1bde697c8bdf7def1
Author: xjz <xjz@chromium.org>
Date: Tue Apr 18 18:50:14 2017

Media Remoting: Remove old interstitial implementation.

Remove old implementation that renders the interstitial on a video
frame. The new implemenation is committed:
https://codereview.chromium.org/2767823002/

BUG= 700572 ,  697672 

Review-Url: https://codereview.chromium.org/2801853002
Cr-Commit-Position: refs/heads/master@{#465303}

[modify] https://crrev.com/2504c4da27a272a4906a7fd1bde697c8bdf7def1/chrome/app/generated_resources.grd
[modify] https://crrev.com/2504c4da27a272a4906a7fd1bde697c8bdf7def1/chrome/common/media/media_resource_provider.cc
[modify] https://crrev.com/2504c4da27a272a4906a7fd1bde697c8bdf7def1/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/2504c4da27a272a4906a7fd1bde697c8bdf7def1/media/base/localized_strings.h
[modify] https://crrev.com/2504c4da27a272a4906a7fd1bde697c8bdf7def1/media/base/media_observer.h
[modify] https://crrev.com/2504c4da27a272a4906a7fd1bde697c8bdf7def1/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/2504c4da27a272a4906a7fd1bde697c8bdf7def1/media/blink/webmediaplayer_impl.h
[modify] https://crrev.com/2504c4da27a272a4906a7fd1bde697c8bdf7def1/media/remoting/BUILD.gn
[modify] https://crrev.com/2504c4da27a272a4906a7fd1bde697c8bdf7def1/media/remoting/DEPS
[modify] https://crrev.com/2504c4da27a272a4906a7fd1bde697c8bdf7def1/media/remoting/courier_renderer.cc
[modify] https://crrev.com/2504c4da27a272a4906a7fd1bde697c8bdf7def1/media/remoting/courier_renderer.h
[delete] https://crrev.com/e3b1b256fd85fa0c846e49240e681d4f5cee91f7/media/remoting/interstitial.cc
[delete] https://crrev.com/e3b1b256fd85fa0c846e49240e681d4f5cee91f7/media/remoting/interstitial.h
[modify] https://crrev.com/2504c4da27a272a4906a7fd1bde697c8bdf7def1/media/remoting/renderer_controller.cc
[modify] https://crrev.com/2504c4da27a272a4906a7fd1bde697c8bdf7def1/media/remoting/renderer_controller.h

Comment 2 by x...@chromium.org, Apr 19 2017

Status: Fixed (was: Started)

Comment 3 by x...@chromium.org, Apr 19 2017

Labels: Merge-Request-59
Requesting to merge to M59. Very low risk.
Project Member

Comment 4 by sheriffbot@chromium.org, Apr 20 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by x...@chromium.org, Apr 20 2017

Labels: -Merge-Approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2828b8c2d6fd95fccb8145129deb99c33790ec80

commit 2828b8c2d6fd95fccb8145129deb99c33790ec80
Author: xjz <xjz@chromium.org>
Date: Thu Apr 20 20:01:17 2017

Merge M59: Media Remoting: Remove old interstitial implementation.

Remove old implementation that renders the interstitial on a video
frame. The new implemenation is committed:
https://codereview.chromium.org/2767823002/

BUG= 700572 ,  697672 
NOTRY=true
NOPRESUBMIT=true
TBR=miu@chromium.org,sandersd@chromium.org,jochen@chromium.org

Review-Url: https://codereview.chromium.org/2801853002
Cr-Commit-Position: refs/heads/master@{#465303}
(cherry picked from commit 2504c4da27a272a4906a7fd1bde697c8bdf7def1)

Review-Url: https://codereview.chromium.org/2829003004
Cr-Commit-Position: refs/branch-heads/3071@{#97}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/2828b8c2d6fd95fccb8145129deb99c33790ec80/chrome/app/generated_resources.grd
[modify] https://crrev.com/2828b8c2d6fd95fccb8145129deb99c33790ec80/chrome/common/media/media_resource_provider.cc
[modify] https://crrev.com/2828b8c2d6fd95fccb8145129deb99c33790ec80/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/2828b8c2d6fd95fccb8145129deb99c33790ec80/media/base/localized_strings.h
[modify] https://crrev.com/2828b8c2d6fd95fccb8145129deb99c33790ec80/media/base/media_observer.h
[modify] https://crrev.com/2828b8c2d6fd95fccb8145129deb99c33790ec80/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/2828b8c2d6fd95fccb8145129deb99c33790ec80/media/blink/webmediaplayer_impl.h
[modify] https://crrev.com/2828b8c2d6fd95fccb8145129deb99c33790ec80/media/remoting/BUILD.gn
[modify] https://crrev.com/2828b8c2d6fd95fccb8145129deb99c33790ec80/media/remoting/DEPS
[modify] https://crrev.com/2828b8c2d6fd95fccb8145129deb99c33790ec80/media/remoting/courier_renderer.cc
[modify] https://crrev.com/2828b8c2d6fd95fccb8145129deb99c33790ec80/media/remoting/courier_renderer.h
[delete] https://crrev.com/cb1817af2f491075b8a594ea74255da02904ace9/media/remoting/interstitial.cc
[delete] https://crrev.com/cb1817af2f491075b8a594ea74255da02904ace9/media/remoting/interstitial.h
[modify] https://crrev.com/2828b8c2d6fd95fccb8145129deb99c33790ec80/media/remoting/renderer_controller.cc
[modify] https://crrev.com/2828b8c2d6fd95fccb8145129deb99c33790ec80/media/remoting/renderer_controller.h

Sign in to add a comment