New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 713246 link

Starred by 1 user

Issue metadata

Status: Available
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug


Show other hotlists

Hotlists containing this issue:
Hotlist-1


Sign in to add a comment

Session task ids should be restored when tab is restored

Project Member Reported by zea@chromium.org, Apr 19 2017

Issue description

There are three kinds of tab restores:
1. Those from a previous session of this device (session restore)
2. Those coming from another device (open a foreign tab)
3. Those previously closed on this device (opening a recently closed tab)

For task id tracking, #1 is probably the most common, and hence the most important. It requires doing a match between the currently open tabs and the previously synced open tabs for this device. Now that  bug 639009  is fixed (restoring previously synced open tabs into the SyncedSessionTracker on startup), this should be feasible, but might require that on Desktop we start persisting the tab sync id (see TabContentsSyncedTabDelegate::[Set/Get]SyncId).

#2 should be relatively straightforward, as Sync is the source of the data to be restored.

#3 might involve some complexity, unless, we start storing the task id itself in the SessionTab object that is used for restoring?
 

Comment 1 by pav...@chromium.org, Jan 17 2018

Labels: SyncHandoff2018
Components: UI>Browser>Mobile>TabSwitcher
Owner: davidjm@chromium.org
Hey David, here's a tracking bug for task restoration I filed a while ago, when this was part of sync still.

Sync folks heads up that we're planning to pull the bulk of this logic out of the sync code.

Comment 3 Deleted

Ok - thanks for sharing, Nicolas. I'll reference this Bug in my CLs.

Sign in to add a comment