New issue
Advanced search Search tips

Issue 713243 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 701939



Sign in to add a comment

Integrate offline pages prefetcher with the Android background scheduler.

Project Member Reported by dewittj@chromium.org, Apr 19 2017

Issue description

Almost all the prefetching work needs to be done in the background, and we will use JobScheduler et al to do this work.  This is a tracking bug.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4b3550fa52e020ed2aebb55f4a5220f4005435a3

commit 4b3550fa52e020ed2aebb55f4a5220f4005435a3
Author: dewittj <dewittj@chromium.org>
Date: Wed May 03 21:44:38 2017

[Offline Prefetch] Create a new JobScheduler task to wake up for net activity.

This includes:
* Only waking up on unmetered networks
* Responding to JobScheduler events such as stopping job
* Calling back to Android when the job is finished
* An integration with chrome://offline-internals.

BUG= 713243 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2820263002
Cr-Commit-Position: refs/heads/master@{#469139}

[modify] https://crrev.com/4b3550fa52e020ed2aebb55f4a5220f4005435a3/chrome/android/BUILD.gn
[add] https://crrev.com/4b3550fa52e020ed2aebb55f4a5220f4005435a3/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/prefetch/PrefetchBackgroundTask.java
[modify] https://crrev.com/4b3550fa52e020ed2aebb55f4a5220f4005435a3/chrome/android/java_sources.gni
[modify] https://crrev.com/4b3550fa52e020ed2aebb55f4a5220f4005435a3/chrome/android/junit/DEPS
[add] https://crrev.com/4b3550fa52e020ed2aebb55f4a5220f4005435a3/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/prefetch/PrefetchBackgroundTaskTest.java
[modify] https://crrev.com/4b3550fa52e020ed2aebb55f4a5220f4005435a3/chrome/browser/BUILD.gn
[modify] https://crrev.com/4b3550fa52e020ed2aebb55f4a5220f4005435a3/chrome/browser/android/chrome_jni_registrar.cc
[add] https://crrev.com/4b3550fa52e020ed2aebb55f4a5220f4005435a3/chrome/browser/android/offline_pages/prefetch/prefetch_background_task.cc
[add] https://crrev.com/4b3550fa52e020ed2aebb55f4a5220f4005435a3/chrome/browser/android/offline_pages/prefetch/prefetch_background_task.h
[modify] https://crrev.com/4b3550fa52e020ed2aebb55f4a5220f4005435a3/chrome/browser/resources/offline_pages/offline_internals.html
[modify] https://crrev.com/4b3550fa52e020ed2aebb55f4a5220f4005435a3/chrome/browser/resources/offline_pages/offline_internals.js
[modify] https://crrev.com/4b3550fa52e020ed2aebb55f4a5220f4005435a3/chrome/browser/resources/offline_pages/offline_internals_browser_proxy.js
[modify] https://crrev.com/4b3550fa52e020ed2aebb55f4a5220f4005435a3/chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc
[modify] https://crrev.com/4b3550fa52e020ed2aebb55f4a5220f4005435a3/chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.h
[modify] https://crrev.com/4b3550fa52e020ed2aebb55f4a5220f4005435a3/components/background_task_scheduler/android/java/src/org/chromium/components/background_task_scheduler/TaskIds.java
[modify] https://crrev.com/4b3550fa52e020ed2aebb55f4a5220f4005435a3/components/offline_pages/content/suggested_articles_observer_unittest.cc
[modify] https://crrev.com/4b3550fa52e020ed2aebb55f4a5220f4005435a3/components/offline_pages/core/prefetch/prefetch_service.h
[modify] https://crrev.com/4b3550fa52e020ed2aebb55f4a5220f4005435a3/components/offline_pages/core/prefetch/prefetch_service_impl.cc
[modify] https://crrev.com/4b3550fa52e020ed2aebb55f4a5220f4005435a3/components/offline_pages/core/prefetch/prefetch_service_impl.h

Status: Fixed (was: Started)
This also seems to be all done. I believe most CLs were finally linked to the Prefetching umbrella issue 701939.

Sign in to add a comment