New issue
Advanced search Search tips
Starred by 1 user
Status: Fixed
Owner:
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment
Report opt out and previews type in the DRP pingback
Project Member Reported by ryansturm@chromium.org, Apr 19 2017 Back to list
The DataReductionProxy pingback reports various page load information, and it should also report opt outs and server preview type.
 
Project Member Comment 1 by bugdroid1@chromium.org, Apr 21 2017
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ffce94e929ce46e50e364b726e07e2b4773c82b

commit 6ffce94e929ce46e50e364b726e07e2b4773c82b
Author: ryansturm <ryansturm@chromium.org>
Date: Fri Apr 21 17:25:28 2017

Adding opt out and previews type information to DRP pingback

This CL adds the previews type that was shown for a page load and also
reports when a page load was an opt out (clicked show original). Due to
backgrounding behavior, when app background occurs or there is not a
previews shown a third opt out state of unknown is reported. LoFi page
state is determined if any subresources were LoFi images. Lite page uses
the main resource to determine preview state.

BUG= 713236 

Review-Url: https://codereview.chromium.org/2833523002
Cr-Commit-Position: refs/heads/master@{#466376}

[modify] https://crrev.com/6ffce94e929ce46e50e364b726e07e2b4773c82b/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc
[modify] https://crrev.com/6ffce94e929ce46e50e364b726e07e2b4773c82b/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
[modify] https://crrev.com/6ffce94e929ce46e50e364b726e07e2b4773c82b/chrome/browser/page_load_metrics/metrics_web_contents_observer.h
[modify] https://crrev.com/6ffce94e929ce46e50e364b726e07e2b4773c82b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/6ffce94e929ce46e50e364b726e07e2b4773c82b/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.cc
[modify] https://crrev.com/6ffce94e929ce46e50e364b726e07e2b4773c82b/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.h
[modify] https://crrev.com/6ffce94e929ce46e50e364b726e07e2b4773c82b/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_unittest.cc
[modify] https://crrev.com/6ffce94e929ce46e50e364b726e07e2b4773c82b/chrome/browser/page_load_metrics/observers/media_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/6ffce94e929ce46e50e364b726e07e2b4773c82b/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc
[modify] https://crrev.com/6ffce94e929ce46e50e364b726e07e2b4773c82b/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer_unittest.cc
[modify] https://crrev.com/6ffce94e929ce46e50e364b726e07e2b4773c82b/chrome/browser/page_load_metrics/observers/tab_restore_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/6ffce94e929ce46e50e364b726e07e2b4773c82b/chrome/browser/page_load_metrics/page_load_metrics_observer.cc
[modify] https://crrev.com/6ffce94e929ce46e50e364b726e07e2b4773c82b/chrome/browser/page_load_metrics/page_load_metrics_observer.h
[modify] https://crrev.com/6ffce94e929ce46e50e364b726e07e2b4773c82b/chrome/browser/previews/previews_infobar_delegate.cc
[modify] https://crrev.com/6ffce94e929ce46e50e364b726e07e2b4773c82b/chrome/browser/previews/previews_infobar_delegate_unittest.cc
[modify] https://crrev.com/6ffce94e929ce46e50e364b726e07e2b4773c82b/chrome/browser/previews/previews_infobar_tab_helper.cc
[modify] https://crrev.com/6ffce94e929ce46e50e364b726e07e2b4773c82b/chrome/browser/previews/previews_infobar_tab_helper.h
[modify] https://crrev.com/6ffce94e929ce46e50e364b726e07e2b4773c82b/chrome/browser/previews/previews_infobar_tab_helper_unittest.cc
[modify] https://crrev.com/6ffce94e929ce46e50e364b726e07e2b4773c82b/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.h
[modify] https://crrev.com/6ffce94e929ce46e50e364b726e07e2b4773c82b/components/data_reduction_proxy/core/browser/data_reduction_proxy_data.cc
[modify] https://crrev.com/6ffce94e929ce46e50e364b726e07e2b4773c82b/components/data_reduction_proxy/core/browser/data_reduction_proxy_data.h
[modify] https://crrev.com/6ffce94e929ce46e50e364b726e07e2b4773c82b/components/data_reduction_proxy/core/browser/data_reduction_proxy_data_unittest.cc
[modify] https://crrev.com/6ffce94e929ce46e50e364b726e07e2b4773c82b/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc
[modify] https://crrev.com/6ffce94e929ce46e50e364b726e07e2b4773c82b/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.h
[modify] https://crrev.com/6ffce94e929ce46e50e364b726e07e2b4773c82b/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc
[modify] https://crrev.com/6ffce94e929ce46e50e364b726e07e2b4773c82b/components/data_reduction_proxy/core/browser/data_reduction_proxy_pingback_client.cc
[modify] https://crrev.com/6ffce94e929ce46e50e364b726e07e2b4773c82b/components/data_reduction_proxy/core/browser/data_reduction_proxy_pingback_client.h
[modify] https://crrev.com/6ffce94e929ce46e50e364b726e07e2b4773c82b/components/data_reduction_proxy/core/browser/data_reduction_proxy_pingback_client_unittest.cc
[modify] https://crrev.com/6ffce94e929ce46e50e364b726e07e2b4773c82b/components/data_reduction_proxy/core/common/data_reduction_proxy_page_load_timing.cc
[modify] https://crrev.com/6ffce94e929ce46e50e364b726e07e2b4773c82b/components/data_reduction_proxy/core/common/data_reduction_proxy_page_load_timing.h
[modify] https://crrev.com/6ffce94e929ce46e50e364b726e07e2b4773c82b/components/data_reduction_proxy/proto/pageload_metrics.proto

Labels: Merge-Request-59
Project Member Comment 3 by sheriffbot@chromium.org, Apr 24 2017
Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member Comment 4 by bugdroid1@chromium.org, Apr 24 2017
Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54667fee87a5328ebda89064a3c2bfb7864f64b8

commit 54667fee87a5328ebda89064a3c2bfb7864f64b8
Author: Ryan Sturm <ryansturm@chromium.org>
Date: Mon Apr 24 17:04:26 2017

Adding opt out and previews type information to DRP pingback

This CL adds the previews type that was shown for a page load and also
reports when a page load was an opt out (clicked show original). Due to
backgrounding behavior, when app background occurs or there is not a
previews shown a third opt out state of unknown is reported. LoFi page
state is determined if any subresources were LoFi images. Lite page uses
the main resource to determine preview state.

BUG= 713236 

Review-Url: https://codereview.chromium.org/2833523002
Cr-Commit-Position: refs/heads/master@{#466376}
(cherry picked from commit 6ffce94e929ce46e50e364b726e07e2b4773c82b)

Review-Url: https://codereview.chromium.org/2841623004 .
Cr-Commit-Position: refs/branch-heads/3071@{#165}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/54667fee87a5328ebda89064a3c2bfb7864f64b8/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc
[modify] https://crrev.com/54667fee87a5328ebda89064a3c2bfb7864f64b8/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
[modify] https://crrev.com/54667fee87a5328ebda89064a3c2bfb7864f64b8/chrome/browser/page_load_metrics/metrics_web_contents_observer.h
[modify] https://crrev.com/54667fee87a5328ebda89064a3c2bfb7864f64b8/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/54667fee87a5328ebda89064a3c2bfb7864f64b8/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.cc
[modify] https://crrev.com/54667fee87a5328ebda89064a3c2bfb7864f64b8/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.h
[modify] https://crrev.com/54667fee87a5328ebda89064a3c2bfb7864f64b8/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_unittest.cc
[modify] https://crrev.com/54667fee87a5328ebda89064a3c2bfb7864f64b8/chrome/browser/page_load_metrics/observers/media_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/54667fee87a5328ebda89064a3c2bfb7864f64b8/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc
[modify] https://crrev.com/54667fee87a5328ebda89064a3c2bfb7864f64b8/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer_unittest.cc
[modify] https://crrev.com/54667fee87a5328ebda89064a3c2bfb7864f64b8/chrome/browser/page_load_metrics/observers/tab_restore_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/54667fee87a5328ebda89064a3c2bfb7864f64b8/chrome/browser/page_load_metrics/page_load_metrics_observer.cc
[modify] https://crrev.com/54667fee87a5328ebda89064a3c2bfb7864f64b8/chrome/browser/page_load_metrics/page_load_metrics_observer.h
[modify] https://crrev.com/54667fee87a5328ebda89064a3c2bfb7864f64b8/chrome/browser/previews/previews_infobar_delegate.cc
[modify] https://crrev.com/54667fee87a5328ebda89064a3c2bfb7864f64b8/chrome/browser/previews/previews_infobar_delegate_unittest.cc
[modify] https://crrev.com/54667fee87a5328ebda89064a3c2bfb7864f64b8/chrome/browser/previews/previews_infobar_tab_helper.cc
[modify] https://crrev.com/54667fee87a5328ebda89064a3c2bfb7864f64b8/chrome/browser/previews/previews_infobar_tab_helper.h
[modify] https://crrev.com/54667fee87a5328ebda89064a3c2bfb7864f64b8/chrome/browser/previews/previews_infobar_tab_helper_unittest.cc
[modify] https://crrev.com/54667fee87a5328ebda89064a3c2bfb7864f64b8/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.h
[modify] https://crrev.com/54667fee87a5328ebda89064a3c2bfb7864f64b8/components/data_reduction_proxy/core/browser/data_reduction_proxy_data.cc
[modify] https://crrev.com/54667fee87a5328ebda89064a3c2bfb7864f64b8/components/data_reduction_proxy/core/browser/data_reduction_proxy_data.h
[modify] https://crrev.com/54667fee87a5328ebda89064a3c2bfb7864f64b8/components/data_reduction_proxy/core/browser/data_reduction_proxy_data_unittest.cc
[modify] https://crrev.com/54667fee87a5328ebda89064a3c2bfb7864f64b8/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc
[modify] https://crrev.com/54667fee87a5328ebda89064a3c2bfb7864f64b8/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.h
[modify] https://crrev.com/54667fee87a5328ebda89064a3c2bfb7864f64b8/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc
[modify] https://crrev.com/54667fee87a5328ebda89064a3c2bfb7864f64b8/components/data_reduction_proxy/core/browser/data_reduction_proxy_pingback_client.cc
[modify] https://crrev.com/54667fee87a5328ebda89064a3c2bfb7864f64b8/components/data_reduction_proxy/core/browser/data_reduction_proxy_pingback_client.h
[modify] https://crrev.com/54667fee87a5328ebda89064a3c2bfb7864f64b8/components/data_reduction_proxy/core/browser/data_reduction_proxy_pingback_client_unittest.cc
[modify] https://crrev.com/54667fee87a5328ebda89064a3c2bfb7864f64b8/components/data_reduction_proxy/core/common/data_reduction_proxy_page_load_timing.cc
[modify] https://crrev.com/54667fee87a5328ebda89064a3c2bfb7864f64b8/components/data_reduction_proxy/core/common/data_reduction_proxy_page_load_timing.h
[modify] https://crrev.com/54667fee87a5328ebda89064a3c2bfb7864f64b8/components/data_reduction_proxy/proto/pageload_metrics.proto

Status: Fixed
Sign in to add a comment