New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 713227 link

Starred by 1 user
Status: Fixed
Owner:
█ zhaobin@chromium.org
Last visit > 30 days ago
Closed: May 2017
Cc:
mfo...@chromium.org
btolsch@chromium.org
powerb@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature


Participants' hotlists:
presentation-api-1ua


Sign in to add a comment

[Presentation API] Remove closed connections from PresentationConnectionList

Project Member Reported by mfo...@chromium.org, Apr 19 2017 
Per spec change https://github.com/w3c/presentation-api/pull/426 we will now remove receiver connections from the PresentationConnectionList when they are closed.

This issue tracks the work to implement and update LayoutTests etc.

I do not expect any web compatiblity issues.  Not sure this justifies an intent to implement.

Comment 1 by mfo...@chromium.org, Apr 19 2017

Components: Blink>PresentationAPI

Comment 2 by sko...@chromium.org, Apr 19 2017

Cc: -zhaobin@chromium.org
Owner: zhaobin@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, May 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e17728ae5d18e371378473c0b4637940f95c3967

commit e17728ae5d18e371378473c0b4637940f95c3967
Author: zhaobin <zhaobin@chromium.org>
Date: Tue May 23 01:19:08 2017

[Presentation API] Remove closed connections from PresentationConnectionList

- Added WebPresentationReceiver::RemoveConnection() API
- Added WebPresentationReceiver pointer to ReceiverConnectionProxy. WebPresentationReceiver::RemoveConnection() is invoked when receiver connection changes to 'closed'
- In PresentationDispatcher::OnReceiverConnectionAvailable, pass receiver_ pointer to ReceiverConnectionProxy

BUG= 713227 

Review-Url: https://codereview.chromium.org/2874483002
Cr-Commit-Position: refs/heads/master@{#473773}

[modify] https://crrev.com/e17728ae5d18e371378473c0b4637940f95c3967/content/renderer/presentation/presentation_connection_proxy.cc
[modify] https://crrev.com/e17728ae5d18e371378473c0b4637940f95c3967/content/renderer/presentation/presentation_connection_proxy.h
[modify] https://crrev.com/e17728ae5d18e371378473c0b4637940f95c3967/content/renderer/presentation/presentation_connection_proxy_unittest.cc
[modify] https://crrev.com/e17728ae5d18e371378473c0b4637940f95c3967/content/renderer/presentation/presentation_dispatcher.cc
[modify] https://crrev.com/e17728ae5d18e371378473c0b4637940f95c3967/content/renderer/presentation/presentation_dispatcher_unittest.cc
[modify] https://crrev.com/e17728ae5d18e371378473c0b4637940f95c3967/third_party/WebKit/LayoutTests/presentation/presentation-controller-close-connection.html
[modify] https://crrev.com/e17728ae5d18e371378473c0b4637940f95c3967/third_party/WebKit/LayoutTests/presentation/resources/presentation-receiver-close-connection.html
[modify] https://crrev.com/e17728ae5d18e371378473c0b4637940f95c3967/third_party/WebKit/Source/modules/presentation/PresentationConnectionList.cpp
[modify] https://crrev.com/e17728ae5d18e371378473c0b4637940f95c3967/third_party/WebKit/Source/modules/presentation/PresentationConnectionList.h
[modify] https://crrev.com/e17728ae5d18e371378473c0b4637940f95c3967/third_party/WebKit/Source/modules/presentation/PresentationReceiver.cpp
[modify] https://crrev.com/e17728ae5d18e371378473c0b4637940f95c3967/third_party/WebKit/Source/modules/presentation/PresentationReceiver.h
[modify] https://crrev.com/e17728ae5d18e371378473c0b4637940f95c3967/third_party/WebKit/Source/modules/presentation/PresentationReceiverTest.cpp
[modify] https://crrev.com/e17728ae5d18e371378473c0b4637940f95c3967/third_party/WebKit/public/platform/modules/presentation/WebPresentationReceiver.h

Comment 4 by sko...@chromium.org, May 31 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment