New issue
Advanced search Search tips

Issue 713222 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocked on:
issue 720002
issue 753408
issue 763854

Blocking:
issue 712694



Sign in to add a comment

Improve Telemetry Test Story Disabling

Project Member Reported by rnep...@chromium.org, Apr 19 2017

Issue description

There are currently several different ways to disable telemetry tests/stories.

This document outlines the current methods:
https://docs.google.com/a/google.com/document/d/18d_7oM0wniBYzNl1ZtMY-eldY4-OHXR818VTDJG-I9w/edit?usp=sharing

We want a better solution for disabling at the story level than what we currently have. 

 
Blocking: 712694
Components: Speed>Telemetry Speed>Benchmarks
Status: Assigned (was: Untriaged)
Blockedon: 720002
Project Member

Comment 5 by bugdroid1@chromium.org, May 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a0429db8b4530814d217a23c580f636d2366d62

commit 3a0429db8b4530814d217a23c580f636d2366d62
Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org>
Date: Thu May 25 02:55:52 2017

Roll src/third_party/catapult/ 6bd7ec034..518df5345 (4 commits)

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/6bd7ec034804..518df53454b5

$ git log 6bd7ec034..518df5345 --date=short --no-merges --format='%ad %ae %s'
2017-05-24 rnephew [Telemetry] Do not have benchmarks validate story name in expectations during runs.
2017-05-24 simonhatch Dashboard - Set internal_only in add_histogram_queue.
2017-05-24 simonhatch Dashboard - Add /get_histogram endpoint.
2017-05-24 benjhayden Remove tr.b.group in favor of groupIntoMap.

Created with:
  roll-dep src/third_party/catapult
BUG=713222


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Ie6ec1a9239bf16ab926bcaa58e0ee0a65ec110ae
Reviewed-on: https://chromium-review.googlesource.com/514484
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#474537}
[modify] https://crrev.com/3a0429db8b4530814d217a23c580f636d2366d62/DEPS

Project Member

Comment 6 by bugdroid1@chromium.org, May 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96ce0d19bedf3ed68b0ba5d342f22ada734dd26f

commit 96ce0d19bedf3ed68b0ba5d342f22ada734dd26f
Author: rnephew <rnephew@chromium.org>
Date: Thu May 25 20:37:26 2017

[Telemetry] Add presubmit to tools/perf that validates story expectations.

It checks that the name of the expectation is under 50 characters and that
the name used matches a name in the benchmarks story set.

Bug:713222

Change-Id: I7291a0e0287b788a956894badd32d545640ec707
Reviewed-on: https://chromium-review.googlesource.com/513162
Commit-Queue: rnephew <rnephew@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#474785}
[modify] https://crrev.com/96ce0d19bedf3ed68b0ba5d342f22ada734dd26f/tools/perf/PRESUBMIT.py
[modify] https://crrev.com/96ce0d19bedf3ed68b0ba5d342f22ada734dd26f/tools/perf/core/benchmark_finders.py
[add] https://crrev.com/96ce0d19bedf3ed68b0ba5d342f22ada734dd26f/tools/perf/core/story_expectation_validator.py
[add] https://crrev.com/96ce0d19bedf3ed68b0ba5d342f22ada734dd26f/tools/perf/validate_story_expectation_data

Project Member

Comment 7 by bugdroid1@chromium.org, May 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd33d604d7e749f71571fd34fd59a41b10e13bce

commit bd33d604d7e749f71571fd34fd59a41b10e13bce
Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org>
Date: Fri May 26 05:46:06 2017

Roll src/third_party/catapult/ 621c724fe..45f760062 (1 commit)

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/621c724fe4f9..45f760062ed4

$ git log 621c724fe..45f760062 --date=short --no-merges --format='%ad %ae %s'
2017-05-25 rnephew [Telemetry] Add ability to check if device has AOSP build to android platform backend.

Created with:
  roll-dep src/third_party/catapult
BUG=713222


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I41e298e1e172af495c7930c82a4a0bf1608b8897
Reviewed-on: https://chromium-review.googlesource.com/516510
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#474929}
[modify] https://crrev.com/bd33d604d7e749f71571fd34fd59a41b10e13bce/DEPS

Project Member

Comment 8 by bugdroid1@chromium.org, Jun 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/82df308c87cb67ae50f5f05196f25e238492adba

commit 82df308c87cb67ae50f5f05196f25e238492adba
Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org>
Date: Thu Jun 01 06:08:01 2017

Roll src/third_party/catapult/ e6ad06342..de3ade508 (5 commits)

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/e6ad06342efb..de3ade508f3f

$ git log e6ad06342..de3ade508 --date=short --no-merges --format='%ad %ae %s'
2017-05-31 bpastene Revert of devil: Add physical port num to device_status.py (patchset #2 id:20001 of https://codereview.chromium.org/2914063002/ )
2017-05-31 sullivan Fix exception in presubmit when a change has not been uploaded.
2017-05-31 dtu [pinpoint] Rename isolated to isolate.
2017-05-31 bpastene devil: Add physical port num to device_status.py
2017-05-31 rnephew [Telemetry] Add ability to disable stories on android webview.

Created with:
  roll-dep src/third_party/catapult
BUG=719093,719093,713222


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Ie60a7867d795a9b1dd42c9abc256f471a38783da
Reviewed-on: https://chromium-review.googlesource.com/520691
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476207}
[modify] https://crrev.com/82df308c87cb67ae50f5f05196f25e238492adba/DEPS

Project Member

Comment 9 by bugdroid1@chromium.org, Jun 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b80a8570e2b0a3fe8ac5e45b84614c08f4584ee1

commit b80a8570e2b0a3fe8ac5e45b84614c08f4584ee1
Author: rnephew <rnephew@chromium.org>
Date: Thu Jun 01 19:39:20 2017

[Telemetry] Move system_health disabling of stories to StoryExpectations

Bug: 713222
Change-Id: I89dc5253a173a6d64ead697db765181282a14b6b
Reviewed-on: https://chromium-review.googlesource.com/515622
Commit-Queue: rnephew <rnephew@chromium.org>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#476390}
[modify] https://crrev.com/b80a8570e2b0a3fe8ac5e45b84614c08f4584ee1/tools/perf/benchmarks/system_health.py
[modify] https://crrev.com/b80a8570e2b0a3fe8ac5e45b84614c08f4584ee1/tools/perf/benchmarks/v8_browsing.py
[modify] https://crrev.com/b80a8570e2b0a3fe8ac5e45b84614c08f4584ee1/tools/perf/page_sets/system_health/background_stories.py
[modify] https://crrev.com/b80a8570e2b0a3fe8ac5e45b84614c08f4584ee1/tools/perf/page_sets/system_health/browsing_stories.py
[modify] https://crrev.com/b80a8570e2b0a3fe8ac5e45b84614c08f4584ee1/tools/perf/page_sets/system_health/chrome_stories.py
[add] https://crrev.com/b80a8570e2b0a3fe8ac5e45b84614c08f4584ee1/tools/perf/page_sets/system_health/expectations.py
[modify] https://crrev.com/b80a8570e2b0a3fe8ac5e45b84614c08f4584ee1/tools/perf/page_sets/system_health/loading_stories.py
[modify] https://crrev.com/b80a8570e2b0a3fe8ac5e45b84614c08f4584ee1/tools/perf/page_sets/system_health/long_running_stories.py
[modify] https://crrev.com/b80a8570e2b0a3fe8ac5e45b84614c08f4584ee1/tools/perf/page_sets/system_health/media_stories.py
[modify] https://crrev.com/b80a8570e2b0a3fe8ac5e45b84614c08f4584ee1/tools/perf/page_sets/system_health/system_health_story.py

Project Member

Comment 10 by bugdroid1@chromium.org, Jun 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e5a4b69c4ad2212f5c0439f2c41e2a21d22e29cb

commit e5a4b69c4ad2212f5c0439f2c41e2a21d22e29cb
Author: rnephew <rnephew@chromium.org>
Date: Thu Jun 01 22:32:53 2017

[Telemetry] Move dromaeo story disabling to StoryExpectations

Bug: 713222
Change-Id: Ice1cd5d0061aff3470aa61420de0244a6fd414a4
Reviewed-on: https://chromium-review.googlesource.com/521662
Commit-Queue: rnephew <rnephew@chromium.org>
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476458}
[modify] https://crrev.com/e5a4b69c4ad2212f5c0439f2c41e2a21d22e29cb/tools/perf/benchmarks/dromaeo.py

Project Member

Comment 11 by bugdroid1@chromium.org, Jun 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f60316be0f468141bba7f418f5a003f8f25bc38a

commit f60316be0f468141bba7f418f5a003f8f25bc38a
Author: rnephew <rnephew@chromium.org>
Date: Fri Jun 02 02:51:15 2017

[Telemetry] Move loading_mobile story disabling to StoryExpectations

Bug: 713222
Change-Id: I39e246f090e86f204d2251323eef457dca2c944b
Reviewed-on: https://chromium-review.googlesource.com/521264
Commit-Queue: rnephew <rnephew@chromium.org>
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476533}
[modify] https://crrev.com/f60316be0f468141bba7f418f5a003f8f25bc38a/tools/perf/benchmarks/loading.py
[modify] https://crrev.com/f60316be0f468141bba7f418f5a003f8f25bc38a/tools/perf/page_sets/loading_mobile.py

Project Member

Comment 12 by bugdroid1@chromium.org, Jun 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/262af58e6478903922ab48a4cd37cf334283fb25

commit 262af58e6478903922ab48a4cd37cf334283fb25
Author: rnephew <rnephew@chromium.org>
Date: Mon Jun 05 23:41:43 2017

[Telemetry] Move v8.runtimestats.* to StoryExpectations

TBR=charliea@chromium.org

Bug: 713222
Change-Id: I7f047732498cb5db0af358d1b1652674a05cbf22
Reviewed-on: https://chromium-review.googlesource.com/521869
Commit-Queue: rnephew <rnephew@chromium.org>
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Reviewed-by: rnephew <rnephew@chromium.org>
Cr-Commit-Position: refs/heads/master@{#477121}
[modify] https://crrev.com/262af58e6478903922ab48a4cd37cf334283fb25/tools/perf/benchmarks/v8_browsing.py

Project Member

Comment 13 by bugdroid1@chromium.org, Jun 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f3fccd6c63f904e99c987636f981d33044e5a048

commit f3fccd6c63f904e99c987636f981d33044e5a048
Author: rnephew <rnephew@chromium.org>
Date: Tue Jun 13 21:27:47 2017

[Telemetry] Move blink_perf benchmarks disabling to StoryExpectations

(No longer relies on this CL)
Requires catapult cl to land and roll:
https://codereview.chromium.org/2913383005/

Requires this CL to land as well:
https://codereview.chromium.org/2912253002/

Bug: 713222
Change-Id: I4de3ffae59fb8ddefb26b342170908365e8f1c23
Reviewed-on: https://chromium-review.googlesource.com/521885
Commit-Queue: rnephew <rnephew@chromium.org>
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#479159}
[modify] https://crrev.com/f3fccd6c63f904e99c987636f981d33044e5a048/tools/perf/benchmarks/blink_perf.py

Project Member

Comment 14 by bugdroid1@chromium.org, Jun 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f00df07d83dcea37e0ee7bb76e53c055445a601f

commit f00df07d83dcea37e0ee7bb76e53c055445a601f
Author: rnephew <rnephew@chromium.org>
Date: Thu Jun 15 18:47:07 2017

[Telemetry] Move BattOr benchmarks to StoryExpectations.

TBR=charliea@chromium.org

Bug: 713222
Change-Id: I40324a5eac634a3978bb37bcd8c908b514d1d99e
Reviewed-on: https://chromium-review.googlesource.com/537092
Commit-Queue: rnephew <rnephew@chromium.org>
Reviewed-by: rnephew <rnephew@chromium.org>
Cr-Commit-Position: refs/heads/master@{#479767}
[modify] https://crrev.com/f00df07d83dcea37e0ee7bb76e53c055445a601f/tools/perf/benchmarks/battor.py
[modify] https://crrev.com/f00df07d83dcea37e0ee7bb76e53c055445a601f/tools/perf/page_sets/idle_after_loading_stories.py
[modify] https://crrev.com/f00df07d83dcea37e0ee7bb76e53c055445a601f/tools/perf/page_sets/trivial_sites.py

Project Member

Comment 15 by bugdroid1@chromium.org, Jun 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e800cdd4b314370ae8d49d55c1dc9cc73f9b8659

commit e800cdd4b314370ae8d49d55c1dc9cc73f9b8659
Author: rnephew <rnephew@chromium.org>
Date: Thu Jun 15 20:36:58 2017

[Telemetry[ Move blink_perf.xml_http_request to StoryExpectations.

Bug: 713222
Change-Id: I5f4b87b967c45e9b34f66986afca3f0f2b6daa37
Reviewed-on: https://chromium-review.googlesource.com/537214
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Commit-Queue: rnephew <rnephew@chromium.org>
Cr-Commit-Position: refs/heads/master@{#479815}
[modify] https://crrev.com/e800cdd4b314370ae8d49d55c1dc9cc73f9b8659/tools/perf/contrib/blink_perf_xml_http_request/blink_perf_xml_http_request.py

Project Member

Comment 16 by bugdroid1@chromium.org, Jun 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/89855d819d8254a1fdded4d51d8bf5c734cee31b

commit 89855d819d8254a1fdded4d51d8bf5c734cee31b
Author: rnephew <rnephew@chromium.org>
Date: Fri Jun 16 02:36:14 2017

[Telemetry] Move blob_storage benchmarks to StoryExpectations.

TBR=charliea@chromium.org

Bug: 713222
Change-Id: I484a3a76281efc23f17e7baec31a9e4968a6d6d2
Reviewed-on: https://chromium-review.googlesource.com/537732
Reviewed-by: rnephew <rnephew@chromium.org>
Commit-Queue: rnephew <rnephew@chromium.org>
Cr-Commit-Position: refs/heads/master@{#479928}
[modify] https://crrev.com/89855d819d8254a1fdded4d51d8bf5c734cee31b/tools/perf/benchmarks/blob_storage.py
[modify] https://crrev.com/89855d819d8254a1fdded4d51d8bf5c734cee31b/tools/perf/page_sets/blob_workshop.py

Project Member

Comment 17 by bugdroid1@chromium.org, Jun 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07711ae8ada95f59bfa6f9390f8dfb99f1f97618

commit 07711ae8ada95f59bfa6f9390f8dfb99f1f97618
Author: rnephew <rnephew@chromium.org>
Date: Fri Jun 16 03:09:00 2017

[Telemetry] Move dummy benchmarks to story expectations.

TBR=charliea@chromium.org

Bug: 713222
Change-Id: I85026fcef1e6d7675c5f68aa4c8ecd51893e6b08
Reviewed-on: https://chromium-review.googlesource.com/538055
Reviewed-by: rnephew <rnephew@chromium.org>
Commit-Queue: rnephew <rnephew@chromium.org>
Cr-Commit-Position: refs/heads/master@{#479936}
[modify] https://crrev.com/07711ae8ada95f59bfa6f9390f8dfb99f1f97618/tools/perf/benchmarks/dummy_benchmark.py
[modify] https://crrev.com/07711ae8ada95f59bfa6f9390f8dfb99f1f97618/tools/perf/page_sets/dummy_story_set.py

Project Member

Comment 18 by bugdroid1@chromium.org, Jun 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e01f337974ea2929002a37a7fb0f7cdd9a75d1f

commit 9e01f337974ea2929002a37a7fb0f7cdd9a75d1f
Author: rnephew <rnephew@chromium.org>
Date: Fri Jun 16 03:18:50 2017

[Telemetry] Move contrib/dromaeo_extra benchmarks to StoryExpectations.

TBR=charliea@chromium.org

Bug: 713222
Change-Id: I446b483102401da4a85e6a722ce5637bedd08534
Reviewed-on: https://chromium-review.googlesource.com/537141
Reviewed-by: rnephew <rnephew@chromium.org>
Commit-Queue: rnephew <rnephew@chromium.org>
Cr-Commit-Position: refs/heads/master@{#479937}
[modify] https://crrev.com/9e01f337974ea2929002a37a7fb0f7cdd9a75d1f/tools/perf/contrib/dromaeo_extras/dromaeo_extras.py

Project Member

Comment 20 by bugdroid1@chromium.org, Jun 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/588c2a7ea03e082bad299146518d35f2aca951e8

commit 588c2a7ea03e082bad299146518d35f2aca951e8
Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org>
Date: Sat Jun 17 00:51:20 2017

Roll src/third_party/catapult/ e9dc4c57f..57e600c76 (3 commits)

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/e9dc4c57fb00..57e600c76c9f

$ git log e9dc4c57f..57e600c76 --date=short --no-merges --format='%ad %ae %s'
2017-06-16 benjhayden Manage focus in overlays.
2017-06-16 rnephew [Telemetry] Allow story expectation names longer than 50 characters if its a url.
2017-06-16 nednguyen Fix style of telemetry/__init__.py

Created with:
  roll-dep src/third_party/catapult
BUG= 733991 ,713222


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I36965ba9628ee21568d9d7ad1a57d87a39309164
Reviewed-on: https://chromium-review.googlesource.com/539056
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480252}
[modify] https://crrev.com/588c2a7ea03e082bad299146518d35f2aca951e8/DEPS

Project Member

Comment 21 by bugdroid1@chromium.org, Jun 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/783f0ba8e99665eb08f13f7b32e75a64a90d6509

commit 783f0ba8e99665eb08f13f7b32e75a64a90d6509
Author: rnephew <rnephew@chromium.org>
Date: Tue Jun 20 23:14:03 2017

[Telemetry] Move contrib/ benchmarks to story expectations.
TBR=charliea@chromium.org

Bug: 713222
Change-Id: I012ede587d5445937b1a92f0c985853a91e6d55c
Reviewed-on: https://chromium-review.googlesource.com/540827
Reviewed-by: rnephew <rnephew@chromium.org>
Commit-Queue: rnephew <rnephew@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481017}
[modify] https://crrev.com/783f0ba8e99665eb08f13f7b32e75a64a90d6509/tools/perf/contrib/blink_perf_cmdline/blink_perf_cmdline.py
[modify] https://crrev.com/783f0ba8e99665eb08f13f7b32e75a64a90d6509/tools/perf/contrib/cros_benchmarks/page_cycler_v2.py
[modify] https://crrev.com/783f0ba8e99665eb08f13f7b32e75a64a90d6509/tools/perf/contrib/cros_benchmarks/tab_switching_bench.py
[modify] https://crrev.com/783f0ba8e99665eb08f13f7b32e75a64a90d6509/tools/perf/contrib/oilpan/oilpan_benchmarks.py
[modify] https://crrev.com/783f0ba8e99665eb08f13f7b32e75a64a90d6509/tools/perf/page_sets/intl_ar_fa_he.py
[modify] https://crrev.com/783f0ba8e99665eb08f13f7b32e75a64a90d6509/tools/perf/page_sets/intl_es_fr_pt-BR.py
[modify] https://crrev.com/783f0ba8e99665eb08f13f7b32e75a64a90d6509/tools/perf/page_sets/intl_hi_ru.py
[modify] https://crrev.com/783f0ba8e99665eb08f13f7b32e75a64a90d6509/tools/perf/page_sets/intl_ja_zh.py
[modify] https://crrev.com/783f0ba8e99665eb08f13f7b32e75a64a90d6509/tools/perf/page_sets/intl_ko_th_vi.py
[modify] https://crrev.com/783f0ba8e99665eb08f13f7b32e75a64a90d6509/tools/perf/page_sets/key_mobile_sites_smooth.py
[modify] https://crrev.com/783f0ba8e99665eb08f13f7b32e75a64a90d6509/tools/perf/page_sets/top_10_mobile.py
[modify] https://crrev.com/783f0ba8e99665eb08f13f7b32e75a64a90d6509/tools/perf/page_sets/tough_animation_cases.py
[modify] https://crrev.com/783f0ba8e99665eb08f13f7b32e75a64a90d6509/tools/perf/page_sets/typical_25.py

Cc: charliea@chromium.org
Project Member

Comment 25 by bugdroid1@chromium.org, Jun 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09d842cd48364ad7cb992ae0b84415a6bdeb148e

commit 09d842cd48364ad7cb992ae0b84415a6bdeb148e
Author: rnephew <rnephew@chromium.org>
Date: Thu Jun 29 23:18:01 2017

[Telemetry] Renable disabled blink_perf benchmarks.

Many of them have been disabled > a year without any movement. Its possible
that they are working now. This will disable them, and if they are still broken
will disable failing storis with the new story expectations.

TBR=charliea@chromium.org

Bug: 713222
Change-Id: Ie725da1885b79f7818c110fa129cf94fc1e642ac
Reviewed-on: https://chromium-review.googlesource.com/553541
Reviewed-by: rnephew <rnephew@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: rnephew <rnephew@chromium.org>
Cr-Commit-Position: refs/heads/master@{#483538}
[modify] https://crrev.com/09d842cd48364ad7cb992ae0b84415a6bdeb148e/testing/buildbot/chromium.perf.fyi.json
[modify] https://crrev.com/09d842cd48364ad7cb992ae0b84415a6bdeb148e/testing/buildbot/chromium.perf.json
[modify] https://crrev.com/09d842cd48364ad7cb992ae0b84415a6bdeb148e/tools/perf/benchmark.csv
[modify] https://crrev.com/09d842cd48364ad7cb992ae0b84415a6bdeb148e/tools/perf/benchmarks/blink_perf.py

Project Member

Comment 26 by bugdroid1@chromium.org, Jun 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/27c9115e89397f5d9d0b442237b56e42395d25f7

commit 27c9115e89397f5d9d0b442237b56e42395d25f7
Author: rnephew <rnephew@chromium.org>
Date: Fri Jun 30 16:22:40 2017

[Telemetry] Re-enable disabled blob_storage benchmarks.

Bug: 713222
Change-Id: I4b3bad6d687ce84cbc2856662e1a60afbb74f456
Reviewed-on: https://chromium-review.googlesource.com/556902
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: rnephew <rnephew@chromium.org>
Cr-Commit-Position: refs/heads/master@{#483724}
[modify] https://crrev.com/27c9115e89397f5d9d0b442237b56e42395d25f7/testing/buildbot/chromium.perf.fyi.json
[modify] https://crrev.com/27c9115e89397f5d9d0b442237b56e42395d25f7/testing/buildbot/chromium.perf.json
[modify] https://crrev.com/27c9115e89397f5d9d0b442237b56e42395d25f7/tools/perf/benchmarks/blob_storage.py

Project Member

Comment 27 by bugdroid1@chromium.org, Jun 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d6f1f465b8d6388fe7beca00f08c4adc12e63475

commit d6f1f465b8d6388fe7beca00f08c4adc12e63475
Author: rnephew <rnephew@chromium.org>
Date: Fri Jun 30 16:23:44 2017

[Telemetry] Disable blink_perf.canvas.putImageData.html on Nexus 6 perf bot.

TBR=charliea@chromium.org,nednguyen@google.com

Bug: 713222,  738453 
Change-Id: I5c9b80c4d47139641fc6b703785fd105d46c8c3b
Reviewed-on: https://chromium-review.googlesource.com/557942
Reviewed-by: rnephew <rnephew@chromium.org>
Commit-Queue: rnephew <rnephew@chromium.org>
Cr-Commit-Position: refs/heads/master@{#483725}
[modify] https://crrev.com/d6f1f465b8d6388fe7beca00f08c4adc12e63475/tools/perf/benchmarks/blink_perf.py

Project Member

Comment 28 by bugdroid1@chromium.org, Jul 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ebbcedf82d6e1cf0432d67a41bc3ec95ed15f11

commit 8ebbcedf82d6e1cf0432d67a41bc3ec95ed15f11
Author: rnephew <rnephew@chromium.org>
Date: Thu Jul 06 05:40:46 2017

[Telemetry] Re-enable disabled indexdb benchmarks.

Bug: 713222
Change-Id: Icdfa15fe96d04aea6986f12fb4894fe47cdaa8fb
Reviewed-on: https://chromium-review.googlesource.com/559975
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: rnephew <rnephew@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484471}
[modify] https://crrev.com/8ebbcedf82d6e1cf0432d67a41bc3ec95ed15f11/tools/perf/benchmarks/indexeddb_perf.py

Project Member

Comment 29 by bugdroid1@chromium.org, Jul 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/826c70473fa082907987b6c43d9b76391f0f1e58

commit 826c70473fa082907987b6c43d9b76391f0f1e58
Author: rnephew <rnephew@chromium.org>
Date: Fri Jul 07 16:55:46 2017

Telemetry] Re-enable disabled tab_switching benchmark.

Bug: 713222
Change-Id: I32f5bc2ca5d9b7669444b62f57299e13b75a9377
Reviewed-on: https://chromium-review.googlesource.com/561970
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: rnephew <rnephew@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484959}
[modify] https://crrev.com/826c70473fa082907987b6c43d9b76391f0f1e58/testing/buildbot/chromium.perf.fyi.json
[modify] https://crrev.com/826c70473fa082907987b6c43d9b76391f0f1e58/testing/buildbot/chromium.perf.json
[modify] https://crrev.com/826c70473fa082907987b6c43d9b76391f0f1e58/tools/perf/benchmarks/tab_switching.py

Project Member

Comment 30 by bugdroid1@chromium.org, Jul 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a48898a4799e39dec12c12a4bf148b8d1b965b03

commit a48898a4799e39dec12c12a4bf148b8d1b965b03
Author: rnephew <rnephew@chromium.org>
Date: Mon Jul 10 18:56:10 2017

[Telemetry] Disable tab_switching benchmark on android.

Benchmark was acidentally re-enable on android even though
it is meant to be a desktop only benchmark.

TBR=charliea@chromium.org

Bug:  740581 , 713222
Change-Id: I59548ffaa2a3a6c5528d2282f23bd16096b41f79
Reviewed-on: https://chromium-review.googlesource.com/565322
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: rnephew <rnephew@chromium.org>
Commit-Queue: rnephew <rnephew@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485329}
[modify] https://crrev.com/a48898a4799e39dec12c12a4bf148b8d1b965b03/tools/perf/benchmarks/tab_switching.py

Project Member

Comment 32 by bugdroid1@chromium.org, Jul 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/426d7913740b47fcd9632732dade27ab7f12ed62

commit 426d7913740b47fcd9632732dade27ab7f12ed62
Author: rnephew <rnephew@chromium.org>
Date: Wed Jul 12 05:30:57 2017

[Telemetry] Disable startup.large_profile benchmarks on android.

Should never have been re-enabled on android. Did not read the bug
associated with the disabling close enough. Will need to be more
careful in the future.

TBR=charliea@chromium.org

Bug: 713222
Change-Id: Ib8908be570e772791167b38a57e7a96358ae8274
Reviewed-on: https://chromium-review.googlesource.com/567110
Reviewed-by: rnephew <rnephew@chromium.org>
Commit-Queue: rnephew <rnephew@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485868}
[modify] https://crrev.com/426d7913740b47fcd9632732dade27ab7f12ed62/tools/perf/benchmarks/startup.py

Project Member

Comment 33 by bugdroid1@chromium.org, Jul 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e7585ae6856f4d19ad2c1cfd9a422272ea98e63

commit 7e7585ae6856f4d19ad2c1cfd9a422272ea98e63
Author: nednguyen <nednguyen@google.com>
Date: Fri Jul 21 19:10:15 2017

Add Randy as OWNERS of tools/perf for test disabling changes

NOTRY=true # This doesn't affect any code

Bug: 713222
Change-Id: Ie2fd992e7b99dbfb81e74c0028e9190f3d9df226
Reviewed-on: https://chromium-review.googlesource.com/581873
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: rnephew <rnephew@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488728}
[modify] https://crrev.com/7e7585ae6856f4d19ad2c1cfd9a422272ea98e63/tools/perf/OWNERS

Project Member

Comment 34 by bugdroid1@chromium.org, Jul 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea0e4e3999d5bd78dbc21441c1ff3a4ced5de546

commit ea0e4e3999d5bd78dbc21441c1ff3a4ced5de546
Author: rnephew <rnephew@chromium.org>
Date: Tue Jul 25 01:32:38 2017

[Telemetry] Make perf_data_generator use StoryExpectations.

StoryExpectations is a new way to disable Stories and to permanently disable
benchmarks for telemetry tests. In order to not have the waterfall trigger jobs
that will not actually run tests, perf_data_generator needs to know how to use
story expectations.

Bug: 713222
Change-Id: Id35e252efaf17a6a82546de0f08ba9b4dd7a97d1
Reviewed-on: https://chromium-review.googlesource.com/546897
Commit-Queue: rnephew <rnephew@chromium.org>
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489178}
[modify] https://crrev.com/ea0e4e3999d5bd78dbc21441c1ff3a4ced5de546/testing/buildbot/chromium.perf.fyi.json
[modify] https://crrev.com/ea0e4e3999d5bd78dbc21441c1ff3a4ced5de546/testing/buildbot/chromium.perf.json
[modify] https://crrev.com/ea0e4e3999d5bd78dbc21441c1ff3a4ced5de546/tools/perf/core/perf_data_generator.py
[modify] https://crrev.com/ea0e4e3999d5bd78dbc21441c1ff3a4ced5de546/tools/perf/core/perf_data_generator_unittest.py

Project Member

Comment 35 by bugdroid1@chromium.org, Jul 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec96c46d506e3f7eb138ec2f19a26f2dd1bade6d

commit ec96c46d506e3f7eb138ec2f19a26f2dd1bade6d
Author: rnephew <rnephew@chromium.org>
Date: Tue Jul 25 18:28:07 2017

[Telemetry] Add comment to perf_data_generator to get rid of StoryExpectations.

We currently disable some benchmarks using story_expectations.PermanentlyDisableBenchmark().
Because of this changes needed to be made to perf_data_generator to not schedule these tests.
When we no longer use this to disable benchmarks, these parts of per_data_generator should
be removed.

TBR=charliea@chromium.org, nednguyen@google.com

Bug: 713222
Change-Id: Ic953015f280cd44fc9f8d66b5b58aa770dc5d5fd
Reviewed-on: https://chromium-review.googlesource.com/584945
Reviewed-by: rnephew <rnephew@chromium.org>
Commit-Queue: rnephew <rnephew@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489377}
[modify] https://crrev.com/ec96c46d506e3f7eb138ec2f19a26f2dd1bade6d/tools/perf/core/perf_data_generator.py

Project Member

Comment 36 by bugdroid1@chromium.org, Aug 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5dc438aca416be722ae65ae09d7521c1ec48b4f4

commit 5dc438aca416be722ae65ae09d7521c1ec48b4f4
Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org>
Date: Tue Aug 01 08:27:50 2017

Roll src/third_party/catapult/ 9e69c3388..4d5d88c3e (12 commits)

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/9e69c338846a..4d5d88c3e04c

$ git log 9e69c3388..4d5d88c3e --date=short --no-merges --format='%ad %ae %s'
2017-07-31 benjhayden Fix object-instance-track heading.
2017-07-31 loloangela Remove pylintrc bad-continuation and fix resulting errors pt.42
2017-07-31 rnephew [Telemetry] Add ability to disable by mac os version number.
2017-07-31 loloangela Fixed errors related to bad-continuation pt.41
2017-07-31 xunjieli [wpr-go] Allow disabling script injection
2017-07-31 loloangela Fixed errors related to bad-continuation pt.40
2017-07-31 benjhayden Fix ObjectSnapshot.userFriendlyName.
2017-07-31 simonhatch Dashboard - Add entities to _INTERNAL_ONLY_KINDS in datastore_hooks
2017-07-31 loloangela Fixed errors related to bad-continuation pt.39
2017-07-31 sullivan Set bug status to 'Assigned' when assigning to culprit author.
2017-07-31 loloangela Fixed errors related to bad-continuation pt.38
2017-07-31 charliea Upload a new version of the BattOr agent firmware

Created with:
  roll-dep src/third_party/catapult
BUG=713222, 728496 


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: If6aca002e8592ed8dc89391f6964933fab5bcea6
Reviewed-on: https://chromium-review.googlesource.com/595226
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490917}
[modify] https://crrev.com/5dc438aca416be722ae65ae09d7521c1ec48b4f4/DEPS

Project Member

Comment 37 by bugdroid1@chromium.org, Aug 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c1ed31a62e86def5d061df57bf01d3cce7c1293

commit 8c1ed31a62e86def5d061df57bf01d3cce7c1293
Author: Charlie Andrews <charliea@chromium.org>
Date: Wed Aug 02 22:27:01 2017

Reenable rasterize_and_record_micro benchmarks on all platforms

TBR=nednguyen@google.com

Bug: 713222
Change-Id: Icc17c0d1b782f1c553ff2995dfddad422086e821
Reviewed-on: https://chromium-review.googlesource.com/598191
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Reviewed-by: rnephew <rnephew@chromium.org>
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491531}
[modify] https://crrev.com/8c1ed31a62e86def5d061df57bf01d3cce7c1293/testing/buildbot/chromium.perf.json
[modify] https://crrev.com/8c1ed31a62e86def5d061df57bf01d3cce7c1293/tools/perf/benchmarks/rasterize_and_record_micro.py

Project Member

Comment 38 by bugdroid1@chromium.org, Aug 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/13cafbacd9615ec782dceee6b8a57c05650566fa

commit 13cafbacd9615ec782dceee6b8a57c05650566fa
Author: rnephew <rnephew@chromium.org>
Date: Mon Aug 07 23:34:58 2017

[Telemetry][Refactor] Move StoryExpectation declaration to benchmarks/ directory

Before they were split between benchmarks/ and page_sets/. This moves them to benchmarks/

Bug: 713222
Change-Id: If7613f6c738e2f93cf8afff73a1351e5ac33198d
Reviewed-on: https://chromium-review.googlesource.com/601253
Reviewed-by: rnephew <rnephew@chromium.org>
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: rnephew <rnephew@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492449}
[modify] https://crrev.com/13cafbacd9615ec782dceee6b8a57c05650566fa/tools/perf/benchmarks/battor.py
[modify] https://crrev.com/13cafbacd9615ec782dceee6b8a57c05650566fa/tools/perf/benchmarks/blob_storage.py
[modify] https://crrev.com/13cafbacd9615ec782dceee6b8a57c05650566fa/tools/perf/benchmarks/dummy_benchmark.py
[modify] https://crrev.com/13cafbacd9615ec782dceee6b8a57c05650566fa/tools/perf/benchmarks/image_decoding.py
[modify] https://crrev.com/13cafbacd9615ec782dceee6b8a57c05650566fa/tools/perf/benchmarks/indexeddb_perf.py
[modify] https://crrev.com/13cafbacd9615ec782dceee6b8a57c05650566fa/tools/perf/benchmarks/loading.py
[modify] https://crrev.com/13cafbacd9615ec782dceee6b8a57c05650566fa/tools/perf/benchmarks/media.py
[modify] https://crrev.com/13cafbacd9615ec782dceee6b8a57c05650566fa/tools/perf/benchmarks/memory.py
[modify] https://crrev.com/13cafbacd9615ec782dceee6b8a57c05650566fa/tools/perf/benchmarks/power.py
[modify] https://crrev.com/13cafbacd9615ec782dceee6b8a57c05650566fa/tools/perf/benchmarks/rasterize_and_record_micro.py
[modify] https://crrev.com/13cafbacd9615ec782dceee6b8a57c05650566fa/tools/perf/benchmarks/service_worker.py
[modify] https://crrev.com/13cafbacd9615ec782dceee6b8a57c05650566fa/tools/perf/benchmarks/smoothness.py
[modify] https://crrev.com/13cafbacd9615ec782dceee6b8a57c05650566fa/tools/perf/benchmarks/start_with_url.py
[modify] https://crrev.com/13cafbacd9615ec782dceee6b8a57c05650566fa/tools/perf/benchmarks/thread_times.py
[modify] https://crrev.com/13cafbacd9615ec782dceee6b8a57c05650566fa/tools/perf/benchmarks/v8.py
[modify] https://crrev.com/13cafbacd9615ec782dceee6b8a57c05650566fa/tools/perf/benchmarks/webrtc.py
[modify] https://crrev.com/13cafbacd9615ec782dceee6b8a57c05650566fa/tools/perf/contrib/cros_benchmarks/page_cycler_v2.py
[modify] https://crrev.com/13cafbacd9615ec782dceee6b8a57c05650566fa/tools/perf/contrib/memory_extras/memory_extras.py
[modify] https://crrev.com/13cafbacd9615ec782dceee6b8a57c05650566fa/tools/perf/contrib/oilpan/oilpan_benchmarks.py
[modify] https://crrev.com/13cafbacd9615ec782dceee6b8a57c05650566fa/tools/perf/page_sets/blob_workshop.py
[modify] https://crrev.com/13cafbacd9615ec782dceee6b8a57c05650566fa/tools/perf/page_sets/desktop_memory.py
[modify] https://crrev.com/13cafbacd9615ec782dceee6b8a57c05650566fa/tools/perf/page_sets/dual_browser_story.py
[modify] https://crrev.com/13cafbacd9615ec782dceee6b8a57c05650566fa/tools/perf/page_sets/dummy_story_set.py
[modify] https://crrev.com/13cafbacd9615ec782dceee6b8a57c05650566fa/tools/perf/page_sets/idle_platform.py
[modify] https://crrev.com/13cafbacd9615ec782dceee6b8a57c05650566fa/tools/perf/page_sets/indexeddb_endure_page.py
[modify] https://crrev.com/13cafbacd9615ec782dceee6b8a57c05650566fa/tools/perf/page_sets/key_hit_test_cases.py
[modify] https://crrev.com/13cafbacd9615ec782dceee6b8a57c05650566fa/tools/perf/page_sets/key_idle_power_cases.py
[modify] https://crrev.com/13cafbacd9615ec782dceee6b8a57c05650566fa/tools/perf/page_sets/key_mobile_sites.py
[modify] https://crrev.com/13cafbacd9615ec782dceee6b8a57c05650566fa/tools/perf/page_sets/key_noop_cases.py
[modify] https://crrev.com/13cafbacd9615ec782dceee6b8a57c05650566fa/tools/perf/page_sets/key_silk_cases.py
[modify] https://crrev.com/13cafbacd9615ec782dceee6b8a57c05650566fa/tools/perf/page_sets/loading_desktop.py
[modify] https://crrev.com/13cafbacd9615ec782dceee6b8a57c05650566fa/tools/perf/page_sets/loading_mobile.py
[modify] https://crrev.com/13cafbacd9615ec782dceee6b8a57c05650566fa/tools/perf/page_sets/long_running_idle_google_cases.py
[modify] https://crrev.com/13cafbacd9615ec782dceee6b8a57c05650566fa/tools/perf/page_sets/media_cns_cases.py
[modify] https://crrev.com/13cafbacd9615ec782dceee6b8a57c05650566fa/tools/perf/page_sets/memory_top_10_mobile.py
[modify] https://crrev.com/13cafbacd9615ec782dceee6b8a57c05650566fa/tools/perf/page_sets/mse_cases.py
[modify] https://crrev.com/13cafbacd9615ec782dceee6b8a57c05650566fa/tools/perf/page_sets/partial_invalidation_cases.py
[modify] https://crrev.com/13cafbacd9615ec782dceee6b8a57c05650566fa/tools/perf/page_sets/polymer.py
[modify] https://crrev.com/13cafbacd9615ec782dceee6b8a57c05650566fa/tools/perf/page_sets/service_worker.py
[modify] https://crrev.com/13cafbacd9615ec782dceee6b8a57c05650566fa/tools/perf/page_sets/service_worker_micro_benchmark.py
[modify] https://crrev.com/13cafbacd9615ec782dceee6b8a57c05650566fa/tools/perf/page_sets/simple_mobile_sites.py
[modify] https://crrev.com/13cafbacd9615ec782dceee6b8a57c05650566fa/tools/perf/page_sets/startup_pages.py
[modify] https://crrev.com/13cafbacd9615ec782dceee6b8a57c05650566fa/tools/perf/page_sets/top_10_mobile.py
[modify] https://crrev.com/13cafbacd9615ec782dceee6b8a57c05650566fa/tools/perf/page_sets/tough_animation_cases.py
[modify] https://crrev.com/13cafbacd9615ec782dceee6b8a57c05650566fa/tools/perf/page_sets/tough_compositor_cases.py
[modify] https://crrev.com/13cafbacd9615ec782dceee6b8a57c05650566fa/tools/perf/page_sets/tough_scrolling_cases.py
[modify] https://crrev.com/13cafbacd9615ec782dceee6b8a57c05650566fa/tools/perf/page_sets/tough_video_cases.py
[modify] https://crrev.com/13cafbacd9615ec782dceee6b8a57c05650566fa/tools/perf/page_sets/trivial_sites.py
[modify] https://crrev.com/13cafbacd9615ec782dceee6b8a57c05650566fa/tools/perf/page_sets/typical_10_mobile.py
[modify] https://crrev.com/13cafbacd9615ec782dceee6b8a57c05650566fa/tools/perf/page_sets/typical_25.py
[modify] https://crrev.com/13cafbacd9615ec782dceee6b8a57c05650566fa/tools/perf/page_sets/webrtc_cases.py

Blockedon: 753408
Project Member

Comment 40 by bugdroid1@chromium.org, Aug 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c07d31868646f95b3bdc165a13bbf8db59647c67

commit c07d31868646f95b3bdc165a13bbf8db59647c67
Author: Charlie Andrews <charliea@chromium.org>
Date: Tue Aug 08 16:39:14 2017

Reenable some smoothness benchmarks on all platforms

The three benchmarks being reenabled everywhere are:

  - smoothness.maps
  - smoothness.key_desktop_move_cases
  - smoothness.tough_pinch_zoom_cases

This is part of the benchmark reenabling fix-it, where we're aiming to
bring the stories that are disabled in line with the stories that are
actually still failing. We're also migrating from wholesale benchmark
disabling to per-story disabling when a story fails.

NOTRY=true

Bug: 713222
Change-Id: If18f9804aca817d15ac1c2db33eb4c215109e6e7
Reviewed-on: https://chromium-review.googlesource.com/606349
Reviewed-by: rnephew <rnephew@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492654}
[modify] https://crrev.com/c07d31868646f95b3bdc165a13bbf8db59647c67/testing/buildbot/chromium.perf.json
[modify] https://crrev.com/c07d31868646f95b3bdc165a13bbf8db59647c67/tools/perf/benchmarks/smoothness.py

Project Member

Comment 41 by bugdroid1@chromium.org, Aug 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a8f5e589ba81ef6e155457e3066d31e32ff99be

commit 5a8f5e589ba81ef6e155457e3066d31e32ff99be
Author: Juan A. Navarro Perez <perezju@chromium.org>
Date: Tue Aug 08 16:42:11 2017

[tools/perf] Re-enable start_wit_ext.* benchmarks

The two benchmarks being reenabled everywhere are:

- startup_with_ext.cold.blank_page
- startup_with_ext.warm.blank_page

This is part of the benchmark reenabling fix-it, where we're aiming to
bring the stories that are disabled in line with the stories that are
actually still failing. We're also migrating from wholesale benchmark
disabling to per-story disabling when a story fails.

NOTRY=true

Bug:  753408 ,713222
Change-Id: Ie5e188a6a7cea2112583df55b40e1424b241cff2
Reviewed-on: https://chromium-review.googlesource.com/606427
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: rnephew <rnephew@chromium.org>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492657}
[modify] https://crrev.com/5a8f5e589ba81ef6e155457e3066d31e32ff99be/testing/buildbot/chromium.perf.json
[modify] https://crrev.com/5a8f5e589ba81ef6e155457e3066d31e32ff99be/tools/perf/benchmarks/start_with_ext.py

Project Member

Comment 42 by bugdroid1@chromium.org, Aug 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/22acad3fa9d770e7a5f841fb25bb3a7649e554db

commit 22acad3fa9d770e7a5f841fb25bb3a7649e554db
Author: Juan A. Navarro Perez <perezju@chromium.org>
Date: Tue Aug 08 16:43:34 2017

[tools/perf] Reenable tracing.tracing_with_background_memory_infra

Reenable this benchmark on reference builds. Will probably still fail
but failures on reference builds are not considered failures.

This is part of the benchmark reenabling fix-it, where we're aiming to
bring the stories that are disabled in line with the stories that are
actually still failing. We're also migrate from wholesale benchmark
disabling to per-story disabling when a story fails.

NOTRY=true

Bug: 621195,713222
Change-Id: I569f53ac5c4a0f223bea15852d4e30a6dbf3a201
Reviewed-on: https://chromium-review.googlesource.com/606468
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: rnephew <rnephew@chromium.org>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492658}
[modify] https://crrev.com/22acad3fa9d770e7a5f841fb25bb3a7649e554db/tools/perf/benchmarks/tracing.py

Project Member

Comment 43 by bugdroid1@chromium.org, Aug 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb5d43903a7bb942cefc0122d8a49689a6018448

commit cb5d43903a7bb942cefc0122d8a49689a6018448
Author: Juan A. Navarro Perez <perezju@chromium.org>
Date: Tue Aug 08 16:55:33 2017

[tools/perf] Reenable service_worker.service_worker_micro_benchmark

Renable the benchmark on webview to see if individual pages can be
disabled instead.

This is part of the benchmark reenabling fix-it, where we're aiming to
bring the stories that are disabled in line with the stories that are
actually still failing. We're also migrating from wholesale benchmark
disabling to per-story disabling when a story fails.

NOTRY=true

Bug:  653924 ,713222
Change-Id: Ia1c2f0dbd9b6346bc9ea30680c20eb7d43638768
Reviewed-on: https://chromium-review.googlesource.com/606248
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#492662}
[modify] https://crrev.com/cb5d43903a7bb942cefc0122d8a49689a6018448/tools/perf/benchmarks/service_worker.py

Project Member

Comment 44 by bugdroid1@chromium.org, Aug 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6e91fde7d4dbe7c742d1b1059d407aaa6e7188d2

commit 6e91fde7d4dbe7c742d1b1059d407aaa6e7188d2
Author: nednguyen <nednguyen@google.com>
Date: Tue Aug 08 18:29:46 2017

Enable smoothness.tough_image_decode_cases benchmark on all platforms

Bug: 713222
Change-Id: Id105d5c41ff71ab3d3201f907ed6b75cd780eead
Reviewed-on: https://chromium-review.googlesource.com/606114
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: rnephew <rnephew@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#492705}
[modify] https://crrev.com/6e91fde7d4dbe7c742d1b1059d407aaa6e7188d2/testing/buildbot/chromium.perf.json
[modify] https://crrev.com/6e91fde7d4dbe7c742d1b1059d407aaa6e7188d2/tools/perf/benchmarks/smoothness.py

Project Member

Comment 45 by bugdroid1@chromium.org, Aug 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64e25a27ab028610e6097f6458c749a26eea3050

commit 64e25a27ab028610e6097f6458c749a26eea3050
Author: Ashley Enstad <ashleymarie@chromium.org>
Date: Tue Aug 08 18:53:52 2017

Reenabling some smoothness benchmarks at the should disable level

smoothness.tough_pinch_zoom_cases
smoothness.gpu_rasterization.tough_pinch_zoom_cases

Bug:  631015 , 610021 ,713222
Change-Id: I29326bef864f00edb2d1f1ed738a35bee4903951
Reviewed-on: https://chromium-review.googlesource.com/606449
Reviewed-by: rnephew <rnephew@chromium.org>
Commit-Queue: Ashley Enstad <ashleymarie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492715}
[modify] https://crrev.com/64e25a27ab028610e6097f6458c749a26eea3050/tools/perf/benchmarks/smoothness.py

Project Member

Comment 46 by bugdroid1@chromium.org, Aug 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/afc7dd011216d97d717336c698d0bac4b6802a15

commit afc7dd011216d97d717336c698d0bac4b6802a15
Author: rnephew <rnephew@chromium.org>
Date: Tue Aug 08 21:46:54 2017

Revert "[tools/perf] Re-enable start_wit_ext.* benchmarks"

This reverts commit 5a8f5e589ba81ef6e155457e3066d31e32ff99be.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> [tools/perf] Re-enable start_wit_ext.* benchmarks
> 
> The two benchmarks being reenabled everywhere are:
> 
> - startup_with_ext.cold.blank_page
> - startup_with_ext.warm.blank_page
> 
> This is part of the benchmark reenabling fix-it, where we're aiming to
> bring the stories that are disabled in line with the stories that are
> actually still failing. We're also migrating from wholesale benchmark
> disabling to per-story disabling when a story fails.
> 
> NOTRY=true
> 
> Bug:  753408 ,713222
> Change-Id: Ie5e188a6a7cea2112583df55b40e1424b241cff2
> Reviewed-on: https://chromium-review.googlesource.com/606427
> Reviewed-by: Ned Nguyen <nednguyen@google.com>
> Reviewed-by: rnephew <rnephew@chromium.org>
> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#492657}

TBR=perezju@chromium.org,nednguyen@google.com,rnephew@chromium.org

Change-Id: Ie4866fbaf72f4ddf0e0c16d410a69415dc5e51af
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  753408 , 713222
Reviewed-on: https://chromium-review.googlesource.com/606738
Reviewed-by: rnephew <rnephew@chromium.org>
Commit-Queue: rnephew <rnephew@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492756}
[modify] https://crrev.com/afc7dd011216d97d717336c698d0bac4b6802a15/testing/buildbot/chromium.perf.json
[modify] https://crrev.com/afc7dd011216d97d717336c698d0bac4b6802a15/tools/perf/benchmarks/start_with_ext.py

Project Member

Comment 47 by bugdroid1@chromium.org, Aug 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4c8077e9017d25b8a254765a9d47e09af006019

commit a4c8077e9017d25b8a254765a9d47e09af006019
Author: rnephew <rnephew@chromium.org>
Date: Wed Aug 09 06:34:16 2017

[Telemetry] Double the perf waterfall timeout from 10h to 20h.

We're reenabling disabled benchmarks on platforms where they should be
enabled, but this will increase the overall cycle time. We need to
increase the overall perf waterfall timeout to reflect that.

TBR=charliea@chromium.org

Bug: 713222,  753367 
Change-Id: I841d5e86d7932ad48ddfe0c08ac25693a786a268
Reviewed-on: https://chromium-review.googlesource.com/607389
Reviewed-by: rnephew <rnephew@chromium.org>
Commit-Queue: rnephew <rnephew@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492858}
[modify] https://crrev.com/a4c8077e9017d25b8a254765a9d47e09af006019/testing/buildbot/chromium.perf.fyi.json
[modify] https://crrev.com/a4c8077e9017d25b8a254765a9d47e09af006019/testing/buildbot/chromium.perf.json
[modify] https://crrev.com/a4c8077e9017d25b8a254765a9d47e09af006019/tools/perf/core/perf_data_generator.py
[modify] https://crrev.com/a4c8077e9017d25b8a254765a9d47e09af006019/tools/perf/core/perf_data_generator_unittest.py

Project Member

Comment 48 by bugdroid1@chromium.org, Aug 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/53cc69508d6b7237022b27e73140434c3c62f589

commit 53cc69508d6b7237022b27e73140434c3c62f589
Author: Hector Dearman <hjd@google.com>
Date: Wed Aug 09 14:26:27 2017

Reenable smoothness.gpu_rasterization_and_decoding.image_decoding_cases on Android

Renabling for perf benchmark re-enabling fix-it.

Bug: 513699, 713222
Change-Id: Iae4bc20464d608470b3f547de0bbc950a748da73
Reviewed-on: https://chromium-review.googlesource.com/606467
Commit-Queue: Hector Dearman <hjd@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: rnephew <rnephew@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492968}
[modify] https://crrev.com/53cc69508d6b7237022b27e73140434c3c62f589/testing/buildbot/chromium.perf.json
[modify] https://crrev.com/53cc69508d6b7237022b27e73140434c3c62f589/tools/perf/benchmarks/smoothness.py

Project Member

Comment 49 by bugdroid1@chromium.org, Aug 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9abb1c6ab3281a09632a543ee9117f3f2a9f2cc9

commit 9abb1c6ab3281a09632a543ee9117f3f2a9f2cc9
Author: nednguyen <nednguyen@google.com>
Date: Wed Aug 09 16:05:28 2017

Reenable smoothness.image_decoding_cases on all platforms

Bug: 713222
Change-Id: I9f2dbd396aa3c331fdf083bfcd62bf0b12219df9
Reviewed-on: https://chromium-review.googlesource.com/606450
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: rnephew <rnephew@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493007}
[modify] https://crrev.com/9abb1c6ab3281a09632a543ee9117f3f2a9f2cc9/testing/buildbot/chromium.perf.json
[modify] https://crrev.com/9abb1c6ab3281a09632a543ee9117f3f2a9f2cc9/tools/perf/benchmarks/smoothness.py

Project Member

Comment 50 by bugdroid1@chromium.org, Aug 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4e91f6968e7768275d7e37608c1228effd181d11

commit 4e91f6968e7768275d7e37608c1228effd181d11
Author: Ashley Enstad <ashleymarie@chromium.org>
Date: Wed Aug 09 16:42:53 2017

Reenabling some smoothness benchmarks

smoothness.tough_pinch_zoom_cases
smoothness.gpu_rasterization.tough_pinch_zoom_cases
smoothness.gpu_rasterization.tough_scrolling_cases

Bug:  631015 , 610021 , 667489 ,713222
Change-Id: I401beed0229fe2a6c990ecdbab9a01e5ac239c7d
Reviewed-on: https://chromium-review.googlesource.com/606113
Commit-Queue: Ashley Enstad <ashleymarie@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: rnephew <rnephew@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493021}
[modify] https://crrev.com/4e91f6968e7768275d7e37608c1228effd181d11/testing/buildbot/chromium.perf.fyi.json
[modify] https://crrev.com/4e91f6968e7768275d7e37608c1228effd181d11/testing/buildbot/chromium.perf.json
[modify] https://crrev.com/4e91f6968e7768275d7e37608c1228effd181d11/tools/perf/benchmarks/smoothness.py

Project Member

Comment 51 by bugdroid1@chromium.org, Aug 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/293f5f237cfe139aaf85eaba7365797056e89f53

commit 293f5f237cfe139aaf85eaba7365797056e89f53
Author: rnephew <rnephew@chromium.org>
Date: Wed Aug 09 16:46:26 2017

[Telemetry] Re-enable media benchmarks.

Bug: 713222
Change-Id: Ibdd7de926ff666d99cdd819bc60894df1b6b9a43
Reviewed-on: https://chromium-review.googlesource.com/606129
Commit-Queue: rnephew <rnephew@chromium.org>
Reviewed-by: rnephew <rnephew@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#493024}
[modify] https://crrev.com/293f5f237cfe139aaf85eaba7365797056e89f53/tools/perf/benchmarks/media.py

Project Member

Comment 52 by bugdroid1@chromium.org, Aug 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/85e7be23fce77a47d085b038d4b8e7d0ad15716f

commit 85e7be23fce77a47d085b038d4b8e7d0ad15716f
Author: Emily Hanley <eyaich@chromium.org>
Date: Wed Aug 09 18:54:15 2017

reenabled tough_scheduling_cases for benchmark re-enable fixit 

Bug: chromium:713222, chromium:549428 
Change-Id: I92bfc2bcf0fc408b697240ac45915deba09b97fc
Reviewed-on: https://chromium-review.googlesource.com/608308
Commit-Queue: Emily Hanley <eyaich@chromium.org>
Reviewed-by: rnephew <rnephew@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493078}
[modify] https://crrev.com/85e7be23fce77a47d085b038d4b8e7d0ad15716f/tools/perf/benchmarks/smoothness.py

Project Member

Comment 53 by bugdroid1@chromium.org, Aug 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d2c30ff07c17a327dadbdde372d798f57da3fa9b

commit d2c30ff07c17a327dadbdde372d798f57da3fa9b
Author: Charlie Andrews <charliea@chromium.org>
Date: Thu Aug 10 17:51:54 2017

Disable still-failing smoothness benchmarks

This disables all failing smoothness benchmarks for:

  - smoothness.tough_pinch_zoom_cases
  - smoothness.maps

smoothness.maps was failing on Webview and Windows due to the bugs
linked to in the disables. smoothness.tough_pinch_zoom_cases is an
Android-specific benchmark that shouldn't have been enabled on desktop
platforms.

NOTRY=true
TBR=rnephew@chromium.org,nednguyen@chromium.org

Bug:  753862 , 713222
Change-Id: I0ba4deeb2658282ae5c94025729472147d38a1dc
Reviewed-on: https://chromium-review.googlesource.com/609229
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Reviewed-by: rnephew <rnephew@chromium.org>
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493455}
[modify] https://crrev.com/d2c30ff07c17a327dadbdde372d798f57da3fa9b/testing/buildbot/chromium.perf.fyi.json
[modify] https://crrev.com/d2c30ff07c17a327dadbdde372d798f57da3fa9b/testing/buildbot/chromium.perf.json
[modify] https://crrev.com/d2c30ff07c17a327dadbdde372d798f57da3fa9b/tools/perf/benchmarks/smoothness.py

Project Member

Comment 54 by bugdroid1@chromium.org, Aug 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/413e72f9569c5b502335883143d9b96f6cd1474c

commit 413e72f9569c5b502335883143d9b96f6cd1474c
Author: Ashley Enstad <ashleymarie@chromium.org>
Date: Fri Aug 11 21:14:15 2017

Disabling failing smoothness.*.tough_pinch_zoom_cases

Every tough_pinch_zoom_cases story is still failing on the Android platforms
and smoothness.tough_pinch_zoom_cases is still failing on Win as well
so this change re-disables the tests using StoryExpectations

BUG= 631015 , 713222,  610021 

Change-Id: Ie2d53baeb5950c36ad08e247bb1874272521da63
Reviewed-on: https://chromium-review.googlesource.com/612367
Reviewed-by: rnephew <rnephew@chromium.org>
Commit-Queue: Ashley Enstad <ashleymarie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493858}
[modify] https://crrev.com/413e72f9569c5b502335883143d9b96f6cd1474c/tools/perf/benchmarks/smoothness.py

Project Member

Comment 55 by bugdroid1@chromium.org, Aug 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62a75552b011f0c227a7f0a7e573dfe696c99a46

commit 62a75552b011f0c227a7f0a7e573dfe696c99a46
Author: Juan A. Navarro Perez <perezju@chromium.org>
Date: Tue Aug 15 11:03:29 2017

Reland "[tools/perf] Re-enable start_wit_ext.* benchmarks"

Changes: Keep the story disabled on Windows where it is
still failing.

This reverts commit afc7dd011216d97d717336c698d0bac4b6802a15.

Original change's description:
> Revert "[tools/perf] Re-enable start_wit_ext.* benchmarks"
> 
> This reverts commit 5a8f5e589ba81ef6e155457e3066d31e32ff99be.
> 
> Reason for revert: <INSERT REASONING HERE>
> 
> Original change's description:
> > [tools/perf] Re-enable start_wit_ext.* benchmarks
> > 
> > The two benchmarks being reenabled everywhere are:
> > 
> > - startup_with_ext.cold.blank_page
> > - startup_with_ext.warm.blank_page
> > 
> > This is part of the benchmark reenabling fix-it, where we're aiming to
> > bring the stories that are disabled in line with the stories that are
> > actually still failing. We're also migrating from wholesale benchmark
> > disabling to per-story disabling when a story fails.
> > 
> > NOTRY=true
> > 
> > Bug:  753408 ,713222
> > Change-Id: Ie5e188a6a7cea2112583df55b40e1424b241cff2
> > Reviewed-on: https://chromium-review.googlesource.com/606427
> > Reviewed-by: Ned Nguyen <nednguyen@google.com>
> > Reviewed-by: rnephew <rnephew@chromium.org>
> > Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#492657}
> 
> TBR=perezju@chromium.org,nednguyen@google.com,rnephew@chromium.org
> 
> Change-Id: Ie4866fbaf72f4ddf0e0c16d410a69415dc5e51af
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug:  753408 , 713222
> Reviewed-on: https://chromium-review.googlesource.com/606738
> Reviewed-by: rnephew <rnephew@chromium.org>
> Commit-Queue: rnephew <rnephew@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#492756}

TBR=nednguyen@google.com,rnephew@chromium.org

Bug:  753408 , 713222
Change-Id: I6744feef2ec391e787d9ca3c7582c5738e16eb6b
Reviewed-on: https://chromium-review.googlesource.com/613160
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494358}
[modify] https://crrev.com/62a75552b011f0c227a7f0a7e573dfe696c99a46/testing/buildbot/chromium.perf.json
[modify] https://crrev.com/62a75552b011f0c227a7f0a7e573dfe696c99a46/tools/perf/benchmarks/start_with_ext.py

Project Member

Comment 56 by bugdroid1@chromium.org, Aug 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b678f0b35d8f9ad8bdc7bac1fad366ac1e22a95b

commit b678f0b35d8f9ad8bdc7bac1fad366ac1e22a95b
Author: Reilly Grant <reillyg@chromium.org>
Date: Tue Aug 15 19:25:10 2017

Revert "[tools/perf] Re-enable start_wit_ext.* benchmarks"

This reverts commit 62a75552b011f0c227a7f0a7e573dfe696c99a46.

Reason for revert: Also still failing on Mac10.10: https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.10%20Tests/builds/22219

Original change's description:
> Reland "[tools/perf] Re-enable start_wit_ext.* benchmarks"
> 
> Changes: Keep the story disabled on Windows where it is
> still failing.
> 
> This reverts commit afc7dd011216d97d717336c698d0bac4b6802a15.
> 
> Original change's description:
> > Revert "[tools/perf] Re-enable start_wit_ext.* benchmarks"
> > 
> > This reverts commit 5a8f5e589ba81ef6e155457e3066d31e32ff99be.
> > 
> > Reason for revert: <INSERT REASONING HERE>
> > 
> > Original change's description:
> > > [tools/perf] Re-enable start_wit_ext.* benchmarks
> > > 
> > > The two benchmarks being reenabled everywhere are:
> > > 
> > > - startup_with_ext.cold.blank_page
> > > - startup_with_ext.warm.blank_page
> > > 
> > > This is part of the benchmark reenabling fix-it, where we're aiming to
> > > bring the stories that are disabled in line with the stories that are
> > > actually still failing. We're also migrating from wholesale benchmark
> > > disabling to per-story disabling when a story fails.
> > > 
> > > NOTRY=true
> > > 
> > > Bug:  753408 ,713222
> > > Change-Id: Ie5e188a6a7cea2112583df55b40e1424b241cff2
> > > Reviewed-on: https://chromium-review.googlesource.com/606427
> > > Reviewed-by: Ned Nguyen <nednguyen@google.com>
> > > Reviewed-by: rnephew <rnephew@chromium.org>
> > > Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#492657}
> > 
> > TBR=perezju@chromium.org,nednguyen@google.com,rnephew@chromium.org
> > 
> > Change-Id: Ie4866fbaf72f4ddf0e0c16d410a69415dc5e51af
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug:  753408 , 713222
> > Reviewed-on: https://chromium-review.googlesource.com/606738
> > Reviewed-by: rnephew <rnephew@chromium.org>
> > Commit-Queue: rnephew <rnephew@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#492756}
> 
> TBR=nednguyen@google.com,rnephew@chromium.org
> 
> Bug:  753408 , 713222
> Change-Id: I6744feef2ec391e787d9ca3c7582c5738e16eb6b
> Reviewed-on: https://chromium-review.googlesource.com/613160
> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
> Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#494358}

TBR=perezju@chromium.org,nednguyen@google.com,rnephew@chromium.org

Change-Id: I10dc772157f150a5d0d34c88f580c1d13ee96cd5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  753408 , 713222
Reviewed-on: https://chromium-review.googlesource.com/615741
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494492}
[modify] https://crrev.com/b678f0b35d8f9ad8bdc7bac1fad366ac1e22a95b/testing/buildbot/chromium.perf.json
[modify] https://crrev.com/b678f0b35d8f9ad8bdc7bac1fad366ac1e22a95b/tools/perf/benchmarks/start_with_ext.py

Project Member

Comment 57 by bugdroid1@chromium.org, Aug 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c33f57534a091eeb47c095fea3784f2f0fe6e62

commit 0c33f57534a091eeb47c095fea3784f2f0fe6e62
Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org>
Date: Wed Aug 16 01:04:51 2017

Roll src/third_party/catapult/ 08373e7c2..c6627de4e (1 commit)

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/08373e7c2804..c6627de4ef49

$ git log 08373e7c2..c6627de4e --date=short --no-merges --format='%ad %ae %s'
2017-08-15 rnephew [Telemetry] Add StoryExpectation ability to disable on android but not webview.

Created with:
  roll-dep src/third_party/catapult
BUG=713222


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I7c29207acb02478a089aa718e2478c66d95fdb6f
Reviewed-on: https://chromium-review.googlesource.com/616070
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494648}
[modify] https://crrev.com/0c33f57534a091eeb47c095fea3784f2f0fe6e62/DEPS

Project Member

Comment 58 by bugdroid1@chromium.org, Aug 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/105c5ec34497453d0d56d662ed3f08e7ca953f24

commit 105c5ec34497453d0d56d662ed3f08e7ca953f24
Author: rnephew <rnephew@chromium.org>
Date: Thu Aug 17 16:31:43 2017

[Telemetry][Documentation] Update story disabling documentation for perfbot sheriffs.

Bug: 713222
Change-Id: Ib6c946727653ede722cb4933378ce75e1b99090c
Reviewed-on: https://chromium-review.googlesource.com/602505
Commit-Queue: rnephew <rnephew@chromium.org>
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#495192}
[modify] https://crrev.com/105c5ec34497453d0d56d662ed3f08e7ca953f24/docs/speed/perf_bot_sheriffing.md

Project Member

Comment 59 by bugdroid1@chromium.org, Aug 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c0d15c37eccbfe357e6cb544501fdaa9a728180

commit 9c0d15c37eccbfe357e6cb544501fdaa9a728180
Author: rnephew <rnephew@chromium.org>
Date: Thu Aug 17 18:21:06 2017

[Telemetry] Move remaining .Disabled annotations to story expectations.

The remaining ones are all 'Shouldnt run' cases such as adroid only
test shouldnt run on desktop platforms. Thats why they were not part
of the fixit.

Bug: 713222,  664318 
Change-Id: I50a5551c02ea91185e30ff348513c8edea10122b
Reviewed-on: https://chromium-review.googlesource.com/617364
Commit-Queue: rnephew <rnephew@chromium.org>
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#495233}
[modify] https://crrev.com/9c0d15c37eccbfe357e6cb544501fdaa9a728180/testing/buildbot/chromium.perf.fyi.json
[modify] https://crrev.com/9c0d15c37eccbfe357e6cb544501fdaa9a728180/testing/buildbot/chromium.perf.json
[modify] https://crrev.com/9c0d15c37eccbfe357e6cb544501fdaa9a728180/tools/perf/benchmarks/benchmark_unittest.py
[modify] https://crrev.com/9c0d15c37eccbfe357e6cb544501fdaa9a728180/tools/perf/benchmarks/loading.py
[modify] https://crrev.com/9c0d15c37eccbfe357e6cb544501fdaa9a728180/tools/perf/benchmarks/media.py
[modify] https://crrev.com/9c0d15c37eccbfe357e6cb544501fdaa9a728180/tools/perf/benchmarks/memory.py
[modify] https://crrev.com/9c0d15c37eccbfe357e6cb544501fdaa9a728180/tools/perf/benchmarks/oopif.py
[modify] https://crrev.com/9c0d15c37eccbfe357e6cb544501fdaa9a728180/tools/perf/benchmarks/oortonline.py
[modify] https://crrev.com/9c0d15c37eccbfe357e6cb544501fdaa9a728180/tools/perf/benchmarks/smoothness.py
[modify] https://crrev.com/9c0d15c37eccbfe357e6cb544501fdaa9a728180/tools/perf/benchmarks/start_with_url.py
[modify] https://crrev.com/9c0d15c37eccbfe357e6cb544501fdaa9a728180/tools/perf/benchmarks/startup.py
[modify] https://crrev.com/9c0d15c37eccbfe357e6cb544501fdaa9a728180/tools/perf/benchmarks/system_health.py
[modify] https://crrev.com/9c0d15c37eccbfe357e6cb544501fdaa9a728180/tools/perf/benchmarks/tab_switching.py
[modify] https://crrev.com/9c0d15c37eccbfe357e6cb544501fdaa9a728180/tools/perf/benchmarks/thread_times.py
[modify] https://crrev.com/9c0d15c37eccbfe357e6cb544501fdaa9a728180/tools/perf/benchmarks/v8.py
[modify] https://crrev.com/9c0d15c37eccbfe357e6cb544501fdaa9a728180/tools/perf/benchmarks/v8_browsing.py
[modify] https://crrev.com/9c0d15c37eccbfe357e6cb544501fdaa9a728180/tools/perf/page_sets/system_health/expectations.py

Project Member

Comment 61 by bugdroid1@chromium.org, Aug 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee7d6d4eadc2a070ec6d6210412aab9577b8ffbf

commit ee7d6d4eadc2a070ec6d6210412aab9577b8ffbf
Author: rnephew <rnephew@chromium.org>
Date: Mon Aug 21 19:15:42 2017

[Telemetry] Make benchmark unittests use decorators in decorators.py

We are moving telemetry benchmarks to use story expectations. Part of this
effort will remove benchmark.Disabled and benchmark.Enabled annotations.
Unittests will still use annotations, so this moves benchmark unittests
to use the non benchmark.py annotations.

Bug: 713222
Change-Id: Ia877c37761cd2d7c07309dd329f3e84996b306a9
Reviewed-on: https://chromium-review.googlesource.com/624181
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: rnephew <rnephew@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496016}
[modify] https://crrev.com/ee7d6d4eadc2a070ec6d6210412aab9577b8ffbf/tools/perf/benchmarks/benchmark_smoke_unittest.py
[modify] https://crrev.com/ee7d6d4eadc2a070ec6d6210412aab9577b8ffbf/tools/perf/benchmarks/benchmark_unittest.py

Project Member

Comment 62 by bugdroid1@chromium.org, Aug 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d4cf65417ef150e4f68fd137e2d314044f89dab3

commit d4cf65417ef150e4f68fd137e2d314044f89dab3
Author: rnephew <rnephew@chromium.org>
Date: Tue Aug 22 16:35:30 2017

[Telemetry] Reenable oortonline for windows and linux.

The bug says it was disabled because it was causing timeouts in
telemetry_perf_unittest, this CL also disables it from running
as part of that test suite.

Bug: 713222
Change-Id: I37bd527a5a4ddfdbb2d2c0df57f897c638ea034f
Reviewed-on: https://chromium-review.googlesource.com/624526
Commit-Queue: rnephew <rnephew@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496327}
[modify] https://crrev.com/d4cf65417ef150e4f68fd137e2d314044f89dab3/tools/perf/benchmarks/benchmark_smoke_unittest.py
[modify] https://crrev.com/d4cf65417ef150e4f68fd137e2d314044f89dab3/tools/perf/benchmarks/oortonline.py

Project Member

Comment 63 by bugdroid1@chromium.org, Aug 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b5e5034db7515a371796c9d760e2b6f4f00ef626

commit b5e5034db7515a371796c9d760e2b6f4f00ef626
Author: rnephew <rnephew@chromium.org>
Date: Tue Aug 22 19:50:23 2017

[Telemetry] Reenable Blob Storage benchmark.

This got passed over in the fixit by accident.

Bug: 713222
Change-Id: Icd1c2960e0e317a9d0b0fda56a683a67392730c8
Reviewed-on: https://chromium-review.googlesource.com/626678
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: rnephew <rnephew@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496412}
[modify] https://crrev.com/b5e5034db7515a371796c9d760e2b6f4f00ef626/testing/buildbot/chromium.perf.json
[modify] https://crrev.com/b5e5034db7515a371796c9d760e2b6f4f00ef626/tools/perf/benchmarks/blob_storage.py

Project Member

Comment 64 by bugdroid1@chromium.org, Aug 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f2036777c6e6cb45d868726aa042a3463675f3c

commit 4f2036777c6e6cb45d868726aa042a3463675f3c
Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org>
Date: Tue Aug 22 20:57:50 2017

Roll src/third_party/catapult/ a28c28f82..e8b279805 (3 commits)

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/a28c28f82bf0..e8b2798057d5

$ git log a28c28f82..e8b279805 --date=short --no-merges --format='%ad %ae %s'
2017-08-22 simonhatch Pinpoint - Surface info from executions for display in UI.
2017-08-22 rnephew [Telemetry] Add CanRunOnPlatform to story_runner and benchmark class.
2017-08-22 dtu [pinpoint] Support multiple Swarming tasks.

Created with:
  roll-dep src/third_party/catapult
BUG=713222


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: If0f43acb80d648e1fe5a7cd408ed6a745c747584
Reviewed-on: https://chromium-review.googlesource.com/627084
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496437}
[modify] https://crrev.com/4f2036777c6e6cb45d868726aa042a3463675f3c/DEPS

Project Member

Comment 65 by bugdroid1@chromium.org, Aug 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d0436aa8cf768320fdb196053ed65f6152f6094

commit 1d0436aa8cf768320fdb196053ed65f6152f6094
Author: rnephew <rnephew@chromium.org>
Date: Wed Aug 23 20:29:31 2017

[Telemetry] Use SUPPORTED_PLATFORMS to determine if a benchmark is supported on a given platform.

This is not to be confused with StoryExpectations, which is how we disable at
the story level. This is used to disable the entire bencmark when that benchmark
was never intended to run on the given platform (mobile benchmarks not running
on desktop for example).

This requires https://codereview.chromium.org/3001873002/ to roll first.

Bug: 713222
Change-Id: I37a5d57801e3dab452ef90cbb811097a51627d71
Reviewed-on: https://chromium-review.googlesource.com/627086
Commit-Queue: rnephew <rnephew@chromium.org>
Reviewed-by: Ned Nguyen (ooo til 08/30) <nednguyen@google.com>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496791}
[modify] https://crrev.com/1d0436aa8cf768320fdb196053ed65f6152f6094/testing/buildbot/chromium.perf.json
[modify] https://crrev.com/1d0436aa8cf768320fdb196053ed65f6152f6094/tools/perf/benchmarks/battor.py
[modify] https://crrev.com/1d0436aa8cf768320fdb196053ed65f6152f6094/tools/perf/benchmarks/loading.py
[modify] https://crrev.com/1d0436aa8cf768320fdb196053ed65f6152f6094/tools/perf/benchmarks/media.py
[modify] https://crrev.com/1d0436aa8cf768320fdb196053ed65f6152f6094/tools/perf/benchmarks/memory.py
[modify] https://crrev.com/1d0436aa8cf768320fdb196053ed65f6152f6094/tools/perf/benchmarks/oopif.py
[modify] https://crrev.com/1d0436aa8cf768320fdb196053ed65f6152f6094/tools/perf/benchmarks/oortonline.py
[modify] https://crrev.com/1d0436aa8cf768320fdb196053ed65f6152f6094/tools/perf/benchmarks/power.py
[modify] https://crrev.com/1d0436aa8cf768320fdb196053ed65f6152f6094/tools/perf/benchmarks/smoothness.py
[modify] https://crrev.com/1d0436aa8cf768320fdb196053ed65f6152f6094/tools/perf/benchmarks/start_with_url.py
[modify] https://crrev.com/1d0436aa8cf768320fdb196053ed65f6152f6094/tools/perf/benchmarks/startup.py
[modify] https://crrev.com/1d0436aa8cf768320fdb196053ed65f6152f6094/tools/perf/benchmarks/system_health.py
[modify] https://crrev.com/1d0436aa8cf768320fdb196053ed65f6152f6094/tools/perf/benchmarks/tab_switching.py
[modify] https://crrev.com/1d0436aa8cf768320fdb196053ed65f6152f6094/tools/perf/benchmarks/thread_times.py
[modify] https://crrev.com/1d0436aa8cf768320fdb196053ed65f6152f6094/tools/perf/benchmarks/v8_browsing.py
[modify] https://crrev.com/1d0436aa8cf768320fdb196053ed65f6152f6094/tools/perf/core/perf_data_generator.py
[modify] https://crrev.com/1d0436aa8cf768320fdb196053ed65f6152f6094/tools/perf/core/perf_data_generator_unittest.py
[modify] https://crrev.com/1d0436aa8cf768320fdb196053ed65f6152f6094/tools/perf/page_sets/system_health/expectations.py

Project Member

Comment 66 by bugdroid1@chromium.org, Aug 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb2256b5945c75be4487293a16f684e028162582

commit cb2256b5945c75be4487293a16f684e028162582
Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org>
Date: Wed Aug 23 21:34:55 2017

Roll src/third_party/catapult/ 454be6747..9ff441388 (2 commits)

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/454be6747cda..9ff44138889f

$ git log 454be6747..9ff441388 --date=short --no-merges --format='%ad %ae %s'
2017-08-23 rnephew [Telemetry] Add Nexus5x/Nexus6 webview disabling to StoryExpectations.
2017-08-23 benjhayden Delete BuildbotInfo diagnostic.

Created with:
  roll-dep src/third_party/catapult
BUG=713222


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Ia0b0693bbcbca2ebe21ab7ab3d444ffc854a82ff
Reviewed-on: https://chromium-review.googlesource.com/629677
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496811}
[modify] https://crrev.com/cb2256b5945c75be4487293a16f684e028162582/DEPS

Project Member

Comment 67 by bugdroid1@chromium.org, Aug 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b814e719f9327db72f3f9c53626554f532e46db4

commit b814e719f9327db72f3f9c53626554f532e46db4
Author: rnephew <rnephew@chromium.org>
Date: Wed Aug 23 23:13:33 2017

[Telemetry] Disable failing blob_storage telemetry stories.

Requires https://codereview.chromium.org/3002183002/

Bug: 713222
Change-Id: I6ca81df412a12240a2678d220e8b064ca413089f
Reviewed-on: https://chromium-review.googlesource.com/629159
Commit-Queue: rnephew <rnephew@chromium.org>
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Reviewed-by: rnephew <rnephew@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496853}
[modify] https://crrev.com/b814e719f9327db72f3f9c53626554f532e46db4/tools/perf/benchmarks/blob_storage.py

Project Member

Comment 68 by bugdroid1@chromium.org, Aug 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/82449789aa7f3e10189458761b770990a50c384b

commit 82449789aa7f3e10189458761b770990a50c384b
Author: rnephew <rnephew@chromium.org>
Date: Thu Aug 24 07:55:32 2017

[Telemetry] Move system_health_smoke_test to use Disabling decorators in decorators.py

Bug: 713222
Change-Id: Ia7f4f642eaa32cc11695278d076b6c8808b2f95d
Reviewed-on: https://chromium-review.googlesource.com/626757
Reviewed-by: Ned Nguyen (ooo til 08/30) <nednguyen@google.com>
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Commit-Queue: rnephew <rnephew@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496978}
[modify] https://crrev.com/82449789aa7f3e10189458761b770990a50c384b/tools/perf/benchmarks/system_health_smoke_test.py

Project Member

Comment 69 by bugdroid1@chromium.org, Aug 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0862626ed40676dc758841001f63cf00c572e4d9

commit 0862626ed40676dc758841001f63cf00c572e4d9
Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org>
Date: Fri Aug 25 04:55:21 2017

Roll src/third_party/catapult/ e37aa9d60..0ed8f7f45 (8 commits)

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/e37aa9d6016b..0ed8f7f45c8a

$ git log e37aa9d60..0ed8f7f45 --date=short --no-merges --format='%ad %ae %s'
2017-08-24 dtu [pinpoint] Add GTest support to quest_generator.
2017-08-24 simonhatch Pinpoint - Remove sinebow from chart colours.
2017-08-24 simonhatch Pinpoint - Add loading spinner to change-info.
2017-08-24 simonhatch Pinpoint - Transpose header table.
2017-08-24 dtu [pinpoint] Refactor Quest Generator.
2017-08-24 benjhayden Sort metrics in metrics-side-panel selector.
2017-08-24 simonhatch Pinpoint - Working job page with graph
2017-08-24 rnephew [Telemetry] Rename PermanentlyDisableBenchmark to DisableBenchmark.

Created with:
  roll-dep src/third_party/catapult
BUG=713222


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I23eb615bcfdbf9b57a3f54f5137160ad0efec6f7
Reviewed-on: https://chromium-review.googlesource.com/634583
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497323}
[modify] https://crrev.com/0862626ed40676dc758841001f63cf00c572e4d9/DEPS

Project Member

Comment 71 by bugdroid1@chromium.org, Aug 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62cb3f151695fe559684b559fd16a6ee257c2253

commit 62cb3f151695fe559684b559fd16a6ee257c2253
Author: rnephew <rnephew@chromium.org>
Date: Fri Aug 25 18:49:52 2017

[Telemetry] Update perf bot health sheriff documentation to include DisableBenchmark

This method is used when we expect the benchmark to run on a given platfrom
(platform is set in SUPPORTED_PLATFORMS) but for some reason the test is failing.

Bug: 713222
Change-Id: I0cccaa0fdf96e5ec2cccc0edd46c260553a611a8
Reviewed-on: https://chromium-review.googlesource.com/635671
Commit-Queue: rnephew <rnephew@chromium.org>
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497476}
[modify] https://crrev.com/62cb3f151695fe559684b559fd16a6ee257c2253/docs/speed/perf_bot_sheriffing.md

Project Member

Comment 72 by bugdroid1@chromium.org, Aug 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c9cf7d7ce8918f761b220a193520664ad82b2af

commit 5c9cf7d7ce8918f761b220a193520664ad82b2af
Author: rnephew <rnephew@chromium.org>
Date: Sat Aug 26 02:26:07 2017

[Telemetry] PermanentlyDisableBenchmark -> DisableBenchmark in perf_data_generator_unittest

TBR=charliea@chromium.org

Bug: 713222
Change-Id: Ia2cfc9614178cc29cfbf2aa330f773f725724e60
Reviewed-on: https://chromium-review.googlesource.com/636190
Reviewed-by: rnephew <rnephew@chromium.org>
Commit-Queue: rnephew <rnephew@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497639}
[modify] https://crrev.com/5c9cf7d7ce8918f761b220a193520664ad82b2af/tools/perf/core/perf_data_generator_unittest.py

Project Member

Comment 73 by bugdroid1@chromium.org, Sep 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ceb062c7b6580505ddd0866efdc7211bf839be2

commit 1ceb062c7b6580505ddd0866efdc7211bf839be2
Author: rnephew <rnephew@chromium.org>
Date: Thu Sep 07 06:15:59 2017

[Telemetry] Move dummy_benchmark from PermanentlyDisableBenchmark to DisableBenchmark

Bug: 713222
Change-Id: Iac062bf96869bc804c6be3748e2e60f6b39f581a
Reviewed-on: https://chromium-review.googlesource.com/653585
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: rnephew <rnephew@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500232}
[modify] https://crrev.com/1ceb062c7b6580505ddd0866efdc7211bf839be2/tools/perf/benchmarks/dummy_benchmark.py

Project Member

Comment 74 by bugdroid1@chromium.org, Sep 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54468efa2d28668d7547404902aa4915a79b09a4

commit 54468efa2d28668d7547404902aa4915a79b09a4
Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org>
Date: Thu Sep 07 18:48:20 2017

Roll src/third_party/catapult/ c9667ecd2..29f450ae4 (16 commits)

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/c9667ecd29cb..29f450ae4dcb

$ git log c9667ecd2..29f450ae4 --date=short --no-merges --format='%ad %ae %s'
2017-09-07 littlecvr [Telemetry] Add ChromeOS to desktop platform list
2017-09-07 dtu [pinpoint] Separate Execution exceptions from result_values.
2017-09-07 lalitm Update memtrack binary version for ARMv7 devices
2017-09-07 nednguyen Revert of Smoke test for heap profiler. (patchset #2 id:20001 of https://codereview.chromium.org/3010173002/ )
2017-09-06 rnephew [Telemetry] Fully get rid of PermanentlyDisableBenchmark.
2017-09-06 benjhayden Add traceUrls to CSVs.
2017-09-06 benjhayden Format traceUrls in generic-set-span.
2017-09-06 benjhayden Remove incorrect test testGet_WithFinish_LabelsBugWithLowestMilestonePossible
2017-09-06 benjhayden Produce all statistics in CSVBuilder.
2017-09-06 sullivan Add CORS headers for whitelisted origins.
2017-09-06 xunjieli [wpr-go] Update comment in telemtry/bin/update_wpr_go_binary
2017-09-06 simonhatch Dashboard - Add calls to graph_revisions and find_anomalies in add_histograms_queue
2017-09-06 loloangela Fix errors related to invalid-name pt. 10
2017-09-06 dtu [pinpoint] Limit executions to one test run each + device sharding.
2017-09-06 xunjieli [Telemetry] Use --ignore-certificate-errors-spki-list to bypass cert errors
2017-09-06 kraynov Smoke test for heap profiler.

Created with:
  roll-dep src/third_party/catapult
BUG=753279, 670828 ,713222, 753948 , 670828 


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I81717857fe493d9edb734becf08f69534f3adbb5
Reviewed-on: https://chromium-review.googlesource.com/655362
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500345}
[modify] https://crrev.com/54468efa2d28668d7547404902aa4915a79b09a4/DEPS

Blockedon: 763854
Project Member

Comment 76 by bugdroid1@chromium.org, Sep 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0bc4a74d23ae37b1d1db3920a0c9cced5a421ff

commit f0bc4a74d23ae37b1d1db3920a0c9cced5a421ff
Author: rnephew <rnephew@chromium.org>
Date: Mon Sep 11 23:24:45 2017

[Telemetry] Reschedule temporarily disable benchmarks.

Previously, benchmarks that were permanently disabled via expectatoins used
PermanentlyDisableBenchmark. Those were migrated to SUPPORTED_PLATFORMS (which
will still not be scheduled since they are not intended to run on some platforms)
and the remaining tests disabled via expectations now use DisableBenchmark
which is intended for temporarily disabling failing benchmarks. These should
still be scheduled on those platforms though, so that they are considered
when sharding tests.

Bug: 713222
Change-Id: I6686612d955ac879c9ae8c2d94325d7eb6ab1082
Reviewed-on: https://chromium-review.googlesource.com/660421
Commit-Queue: rnephew <rnephew@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501090}
[modify] https://crrev.com/f0bc4a74d23ae37b1d1db3920a0c9cced5a421ff/testing/buildbot/chromium.perf.fyi.json
[modify] https://crrev.com/f0bc4a74d23ae37b1d1db3920a0c9cced5a421ff/testing/buildbot/chromium.perf.json
[modify] https://crrev.com/f0bc4a74d23ae37b1d1db3920a0c9cced5a421ff/tools/perf/benchmark.csv
[modify] https://crrev.com/f0bc4a74d23ae37b1d1db3920a0c9cced5a421ff/tools/perf/core/perf_data_generator.py
[modify] https://crrev.com/f0bc4a74d23ae37b1d1db3920a0c9cced5a421ff/tools/perf/core/perf_data_generator_unittest.py

Project Member

Comment 77 by bugdroid1@chromium.org, Sep 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5136cc20c3980f201853b975a9d3c25527c2b837

commit 5136cc20c3980f201853b975a9d3c25527c2b837
Author: rnephew <rnephew@chromium.org>
Date: Tue Sep 12 23:10:27 2017

[Telemetry] Move ShouldDisable to StoryExpectations where possible.

There are some ShouldDisables that cannot switch over, such as
BattOr detecting and reference build detecting.

Bug: 713222
Change-Id: Ie6ce17c6f41d7df3c480b47d7560246f4b129ed7
Reviewed-on: https://chromium-review.googlesource.com/661943
Commit-Queue: rnephew <rnephew@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501443}
[modify] https://crrev.com/5136cc20c3980f201853b975a9d3c25527c2b837/testing/buildbot/chromium.perf.fyi.json
[modify] https://crrev.com/5136cc20c3980f201853b975a9d3c25527c2b837/testing/buildbot/chromium.perf.json
[modify] https://crrev.com/5136cc20c3980f201853b975a9d3c25527c2b837/tools/perf/benchmarks/loading.py
[modify] https://crrev.com/5136cc20c3980f201853b975a9d3c25527c2b837/tools/perf/benchmarks/memory.py
[modify] https://crrev.com/5136cc20c3980f201853b975a9d3c25527c2b837/tools/perf/benchmarks/oortonline.py
[modify] https://crrev.com/5136cc20c3980f201853b975a9d3c25527c2b837/tools/perf/benchmarks/smoothness.py
[modify] https://crrev.com/5136cc20c3980f201853b975a9d3c25527c2b837/tools/perf/benchmarks/start_with_url.py
[modify] https://crrev.com/5136cc20c3980f201853b975a9d3c25527c2b837/tools/perf/benchmarks/v8.py
[modify] https://crrev.com/5136cc20c3980f201853b975a9d3c25527c2b837/tools/perf/core/perf_data_generator.py

Project Member

Comment 78 by bugdroid1@chromium.org, Sep 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1eaf2fbdcdf5aa3c32b39810f71ca7b40fc8a928

commit 1eaf2fbdcdf5aa3c32b39810f71ca7b40fc8a928
Author: rnephew <rnephew@chromium.org>
Date: Thu Sep 21 20:41:43 2017

[Telemetry] Get rid of last references to benchmark.Enabled/Disabled

For benchmarks, this means moving to expectations. For unit tests this
means moving to decorators.Enabled()/Disabled()

TBR=bustamante@chromium.org

Bug: 713222
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester
Change-Id: Ia67b2ce6734740770d33d012f7b557879c47321d
Reviewed-on: https://chromium-review.googlesource.com/663664
Commit-Queue: rnephew <rnephew@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503550}
[modify] https://crrev.com/1eaf2fbdcdf5aa3c32b39810f71ca7b40fc8a928/components/cronet/android/test/javaperftests/run.py
[modify] https://crrev.com/1eaf2fbdcdf5aa3c32b39810f71ca7b40fc8a928/tools/chrome_proxy/integration_tests/chrome_proxy_benchmark.py
[modify] https://crrev.com/1eaf2fbdcdf5aa3c32b39810f71ca7b40fc8a928/tools/perf/benchmarks/dromaeo.py
[modify] https://crrev.com/1eaf2fbdcdf5aa3c32b39810f71ca7b40fc8a928/tools/perf/contrib/cros_benchmarks/page_cycler_v2.py
[modify] https://crrev.com/1eaf2fbdcdf5aa3c32b39810f71ca7b40fc8a928/tools/perf/contrib/cros_benchmarks/tab_switching_bench.py
[modify] https://crrev.com/1eaf2fbdcdf5aa3c32b39810f71ca7b40fc8a928/tools/perf/contrib/oilpan/oilpan_benchmarks.py
[modify] https://crrev.com/1eaf2fbdcdf5aa3c32b39810f71ca7b40fc8a928/tools/perf/core/trybot_command_unittest.py
[modify] https://crrev.com/1eaf2fbdcdf5aa3c32b39810f71ca7b40fc8a928/tools/perf/measurements/clock_domain_test.py
[modify] https://crrev.com/1eaf2fbdcdf5aa3c32b39810f71ca7b40fc8a928/tools/perf/measurements/tab_switching_unittest.py

Project Member

Comment 79 by bugdroid1@chromium.org, Sep 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/45d54bf2978e4a04e29021e3295e9b04773a5d86

commit 45d54bf2978e4a04e29021e3295e9b04773a5d86
Author: rnephew <rnephew@chromium.org>
Date: Mon Sep 25 18:54:02 2017

[Telemetry] Add presubmit check to ensure no one disables benchmarks with decorators.

Bug: 713222
Change-Id: I9d13330ef71bd6bfb27232e6472b35b404b19b0a
Reviewed-on: https://chromium-review.googlesource.com/682109
Commit-Queue: rnephew <rnephew@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#504114}
[modify] https://crrev.com/45d54bf2978e4a04e29021e3295e9b04773a5d86/tools/perf/benchmarks/tracing.py
[modify] https://crrev.com/45d54bf2978e4a04e29021e3295e9b04773a5d86/tools/perf/core/story_expectation_validator.py

Project Member

Comment 80 by bugdroid1@chromium.org, Sep 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d3d471e40a1d3a2017c0e39b68a26ebeb63a6ae

commit 9d3d471e40a1d3a2017c0e39b68a26ebeb63a6ae
Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org>
Date: Mon Sep 25 22:31:42 2017

Roll src/third_party/catapult/ 2d5148d57..f7cc2170e (4 commits)

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/2d5148d57e6e..f7cc2170e1ab

$ git log 2d5148d57..f7cc2170e --date=short --no-merges --format='%ad %ae %s'
2017-09-25 rnephew [Telemetry]  Let --also-run-disabled-tests override StoryExpectations.DisableBenchmark
2017-09-25 rnephew [Telemetry] Remove Enabled/Disabled decorators from benchmark.py
2017-09-25 bpastene devil: Log output when forwarder has trouble exiting.
2017-09-25 bpastene devil: Don't check exit code when grep'ing through lsof.

Created with:
  roll-dep src/third_party/catapult
BUG=713222,767956,739899


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I6b80c0705eb3457b30d9cb36480bb46a01b9644d
Reviewed-on: https://chromium-review.googlesource.com/682772
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504190}
[modify] https://crrev.com/9d3d471e40a1d3a2017c0e39b68a26ebeb63a6ae/DEPS

Project Member

Comment 81 by bugdroid1@chromium.org, Sep 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eaebb092facd1b1a6e9c16030f9c9edffd7f508c

commit eaebb092facd1b1a6e9c16030f9c9edffd7f508c
Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org>
Date: Tue Sep 26 21:12:06 2017

Roll src/third_party/catapult/ 0b563bed3..cf05c91b6 (2 commits)

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/0b563bed301e..cf05c91b6757

$ git log 0b563bed3..cf05c91b6 --date=short --no-merges --format='%ad %ae %s'
2017-09-26 rnephew [Telemetry] Make `run_benchmark list` support SUPPORTED_PLATFORMS and StoryExpectations.
2017-09-26 bokan Fix telemetry's IsBrowserRunning check

Created with:
  roll-dep src/third_party/catapult
BUG=713222


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Ib18dd6f4f4d74929f8bd689ab2ecbf07e5466632
Reviewed-on: https://chromium-review.googlesource.com/685509
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504485}
[modify] https://crrev.com/eaebb092facd1b1a6e9c16030f9c9edffd7f508c/DEPS

Project Member

Comment 82 by bugdroid1@chromium.org, Oct 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/fe511b3686feddb035898d390b5e0c0de54722be

commit fe511b3686feddb035898d390b5e0c0de54722be
Author: rnephew <rnephew@chromium.org>
Date: Mon Oct 09 15:18:56 2017

[Telemetry] Remove IsBenchmarkEnabled from decorators.

Bug: chromium:713222
Change-Id: I3523c6e6a8b82083e5fc4d8731b643609c8bdeb9
Reviewed-on: https://chromium-review.googlesource.com/705273
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: rnephew <rnephew@chromium.org>

[modify] https://crrev.com/fe511b3686feddb035898d390b5e0c0de54722be/telemetry/telemetry/internal/story_runner.py
[modify] https://crrev.com/fe511b3686feddb035898d390b5e0c0de54722be/telemetry/telemetry/decorators.py

Project Member

Comment 83 by bugdroid1@chromium.org, Oct 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6d009b6579f1c2dc9c784e65f027ef78031f0f07

commit 6d009b6579f1c2dc9c784e65f027ef78031f0f07
Author: rnephew <rnephew@chromium.org>
Date: Thu Oct 12 01:51:39 2017

[Telemetry] Remove references to ShouldDisable from benchmarks.

This is now accomplished by StoryExpectations. The few benchmarks that were
disabling based on battor detection are safe to delete because we can use
other metrics such as cpu percentage as proxies if battors are not present, so
they are still useful to run.

Bug: 713222
Change-Id: I7f793efe4294ee582586ce875d5030e33ebec2b7
Reviewed-on: https://chromium-review.googlesource.com/710215
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: rnephew <rnephew@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508215}
[modify] https://crrev.com/6d009b6579f1c2dc9c784e65f027ef78031f0f07/tools/perf/benchmarks/battor.py
[modify] https://crrev.com/6d009b6579f1c2dc9c784e65f027ef78031f0f07/tools/perf/benchmarks/power.py
[modify] https://crrev.com/6d009b6579f1c2dc9c784e65f027ef78031f0f07/tools/perf/benchmarks/v8.py
[modify] https://crrev.com/6d009b6579f1c2dc9c784e65f027ef78031f0f07/tools/perf/page_sets/system_health/long_running_stories.py
[modify] https://crrev.com/6d009b6579f1c2dc9c784e65f027ef78031f0f07/tools/perf/page_sets/system_health/system_health_story.py

Project Member

Comment 84 by bugdroid1@chromium.org, Oct 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/309cd1c1527bd53b6d7255371b4642830ede0935

commit 309cd1c1527bd53b6d7255371b4642830ede0935
Author: rnephew <rnephew@chromium.org>
Date: Thu Oct 12 03:28:06 2017

Revert "[Telemetry] Remove references to ShouldDisable from benchmarks."

This reverts commit 6d009b6579f1c2dc9c784e65f027ef78031f0f07.

Reason for revert:  crbug.com/773949 

Original change's description:
> [Telemetry] Remove references to ShouldDisable from benchmarks.
> 
> This is now accomplished by StoryExpectations. The few benchmarks that were
> disabling based on battor detection are safe to delete because we can use
> other metrics such as cpu percentage as proxies if battors are not present, so
> they are still useful to run.
> 
> Bug: 713222
> Change-Id: I7f793efe4294ee582586ce875d5030e33ebec2b7
> Reviewed-on: https://chromium-review.googlesource.com/710215
> Reviewed-by: Ned Nguyen <nednguyen@google.com>
> Commit-Queue: rnephew <rnephew@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#508215}

TBR=nednguyen@google.com,charliea@chromium.org,rnephew@chromium.org

Change-Id: Ia2dbae474dbb1d89baa40f3aa7922d07a728d7a0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 713222
Reviewed-on: https://chromium-review.googlesource.com/714856
Reviewed-by: rnephew <rnephew@chromium.org>
Commit-Queue: rnephew <rnephew@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508245}
[modify] https://crrev.com/309cd1c1527bd53b6d7255371b4642830ede0935/tools/perf/benchmarks/battor.py
[modify] https://crrev.com/309cd1c1527bd53b6d7255371b4642830ede0935/tools/perf/benchmarks/power.py
[modify] https://crrev.com/309cd1c1527bd53b6d7255371b4642830ede0935/tools/perf/benchmarks/v8.py
[modify] https://crrev.com/309cd1c1527bd53b6d7255371b4642830ede0935/tools/perf/page_sets/system_health/long_running_stories.py
[modify] https://crrev.com/309cd1c1527bd53b6d7255371b4642830ede0935/tools/perf/page_sets/system_health/system_health_story.py

Project Member

Comment 85 by bugdroid1@chromium.org, Oct 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/f5cd07b220ab0a660b0277c86f867d418ad3249a

commit f5cd07b220ab0a660b0277c86f867d418ad3249a
Author: rnephew <rnephew@chromium.org>
Date: Thu Oct 12 06:08:21 2017

Revert "[Telemetry] Remove IsBenchmarkEnabled from decorators."

This reverts commit fe511b3686feddb035898d390b5e0c0de54722be.

Reason for revert:  crbug.com/773949 

Original change's description:
> [Telemetry] Remove IsBenchmarkEnabled from decorators.
> 
> Bug: chromium:713222
> Change-Id: I3523c6e6a8b82083e5fc4d8731b643609c8bdeb9
> Reviewed-on: https://chromium-review.googlesource.com/705273
> Reviewed-by: Ned Nguyen <nednguyen@google.com>
> Commit-Queue: rnephew <rnephew@chromium.org>

TBR=nednguyen@google.com,rnephew@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:713222
Change-Id: Ib41e0d1771abaaae794bbc92fd21c575b5503cfe
Reviewed-on: https://chromium-review.googlesource.com/714618
Reviewed-by: rnephew <rnephew@chromium.org>
Commit-Queue: rnephew <rnephew@chromium.org>

[modify] https://crrev.com/f5cd07b220ab0a660b0277c86f867d418ad3249a/telemetry/telemetry/internal/story_runner.py
[modify] https://crrev.com/f5cd07b220ab0a660b0277c86f867d418ad3249a/telemetry/telemetry/decorators.py

Project Member

Comment 86 by bugdroid1@chromium.org, Oct 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca4f6cfcd80797a797280462290a787994362267

commit ca4f6cfcd80797a797280462290a787994362267
Author: rnephew <rnephew@chromium.org>
Date: Thu Oct 12 21:00:51 2017

Revert "Revert "[Telemetry] Remove references to ShouldDisable from benchmarks.""

This reverts commit 309cd1c1527bd53b6d7255371b4642830ede0935.

Reason for revert: Benchmark disabled on failing platforms. (They were before as well, but this undisables them, and they are not disabled via StoryExpectations)

Original change's description:
> Revert "[Telemetry] Remove references to ShouldDisable from benchmarks."
> 
> This reverts commit 6d009b6579f1c2dc9c784e65f027ef78031f0f07.
> 
> Reason for revert:  crbug.com/773949 
> 
> Original change's description:
> > [Telemetry] Remove references to ShouldDisable from benchmarks.
> > 
> > This is now accomplished by StoryExpectations. The few benchmarks that were
> > disabling based on battor detection are safe to delete because we can use
> > other metrics such as cpu percentage as proxies if battors are not present, so
> > they are still useful to run.
> > 
> > Bug: 713222
> > Change-Id: I7f793efe4294ee582586ce875d5030e33ebec2b7
> > Reviewed-on: https://chromium-review.googlesource.com/710215
> > Reviewed-by: Ned Nguyen <nednguyen@google.com>
> > Commit-Queue: rnephew <rnephew@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#508215}
> 
> TBR=nednguyen@google.com,charliea@chromium.org,rnephew@chromium.org
> 
> Change-Id: Ia2dbae474dbb1d89baa40f3aa7922d07a728d7a0
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 713222
> Reviewed-on: https://chromium-review.googlesource.com/714856
> Reviewed-by: rnephew <rnephew@chromium.org>
> Commit-Queue: rnephew <rnephew@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#508245}

TBR=nednguyen@google.com,charliea@chromium.org,rnephew@chromium.org

Change-Id: If4c114f7cd561df8fc6d37c269a61864a4dcf3a4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 713222
Reviewed-on: https://chromium-review.googlesource.com/716600
Reviewed-by: rnephew <rnephew@chromium.org>
Commit-Queue: rnephew <rnephew@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508461}
[modify] https://crrev.com/ca4f6cfcd80797a797280462290a787994362267/tools/perf/benchmarks/battor.py
[modify] https://crrev.com/ca4f6cfcd80797a797280462290a787994362267/tools/perf/benchmarks/power.py
[modify] https://crrev.com/ca4f6cfcd80797a797280462290a787994362267/tools/perf/benchmarks/v8.py
[modify] https://crrev.com/ca4f6cfcd80797a797280462290a787994362267/tools/perf/page_sets/system_health/long_running_stories.py
[modify] https://crrev.com/ca4f6cfcd80797a797280462290a787994362267/tools/perf/page_sets/system_health/system_health_story.py

Project Member

Comment 87 by bugdroid1@chromium.org, Oct 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/78c307b7fe18cd9dd6ee6f9b636c4537f0da3ef9

commit 78c307b7fe18cd9dd6ee6f9b636c4537f0da3ef9
Author: rnephew <rnephew@chromium.org>
Date: Thu Oct 12 21:04:51 2017

Revert "Revert "[Telemetry] Remove IsBenchmarkEnabled from decorators.""

This reverts commit f5cd07b220ab0a660b0277c86f867d418ad3249a.

Reason for revert: Benchmark disabled on failing platforms. (They were before as well, but this undisables them, and they are not disabled via StoryExpectations)

Original change's description:
> Revert "[Telemetry] Remove IsBenchmarkEnabled from decorators."
> 
> This reverts commit fe511b3686feddb035898d390b5e0c0de54722be.
> 
> Reason for revert:  crbug.com/773949 
> 
> Original change's description:
> > [Telemetry] Remove IsBenchmarkEnabled from decorators.
> > 
> > Bug: chromium:713222
> > Change-Id: I3523c6e6a8b82083e5fc4d8731b643609c8bdeb9
> > Reviewed-on: https://chromium-review.googlesource.com/705273
> > Reviewed-by: Ned Nguyen <nednguyen@google.com>
> > Commit-Queue: rnephew <rnephew@chromium.org>
> 
> TBR=nednguyen@google.com,rnephew@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: chromium:713222
> Change-Id: Ib41e0d1771abaaae794bbc92fd21c575b5503cfe
> Reviewed-on: https://chromium-review.googlesource.com/714618
> Reviewed-by: rnephew <rnephew@chromium.org>
> Commit-Queue: rnephew <rnephew@chromium.org>

TBR=nednguyen@google.com,rnephew@chromium.org

Change-Id: I7bf6d43f6d9fb2282bc46054265d0dda8b8fe736
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:713222
Reviewed-on: https://chromium-review.googlesource.com/716666
Reviewed-by: rnephew <rnephew@chromium.org>
Commit-Queue: rnephew <rnephew@chromium.org>

[modify] https://crrev.com/78c307b7fe18cd9dd6ee6f9b636c4537f0da3ef9/telemetry/telemetry/internal/story_runner.py
[modify] https://crrev.com/78c307b7fe18cd9dd6ee6f9b636c4537f0da3ef9/telemetry/telemetry/decorators.py

Project Member

Comment 90 by bugdroid1@chromium.org, Oct 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/27dcb11f0d137172a169fd27b6df14aa21f6f7eb

commit 27dcb11f0d137172a169fd27b6df14aa21f6f7eb
Author: rnephew <rnephew@chromium.org>
Date: Tue Oct 17 19:20:37 2017

[Telemetry] Remove reference to ShouldDisable from telemetry system health smoke test.

Bug: 713222,  775560 
Change-Id: I720321450eff6bf27c7f0648d9b777a46fb301b7
Reviewed-on: https://chromium-review.googlesource.com/723641
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: rnephew <rnephew@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509481}
[modify] https://crrev.com/27dcb11f0d137172a169fd27b6df14aa21f6f7eb/tools/perf/benchmarks/system_health_smoke_test.py

Components: Tests>Disabled
Labels: Test-Disabled
Owner: ----
Status: Available (was: Assigned)
Components: Test>Telemetry
Components: -Speed>Telemetry

Sign in to add a comment