New issue
Advanced search Search tips

Issue 713218 link

Starred by 2 users
Status: Verified
Owner:
chaopeng@chromium.org
Closed: May 2017
Cc:
tbuck...@chromium.org
sgabr...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 307091



Sign in to add a comment

Aura overlay scrollbars should expand only when mouse is near thumb

Project Member Reported by bokan@chromium.org, Apr 19 2017 
Chrome Version: 60.0.3074.1
OS: ChromeOS

What steps will reproduce the problem?
(Ensure chrome://flags/#overlay-scrollbars are enabled)
(1) Go to scrollable page 
(2) Scroll to show scrollbars
(3) Move mouse to near the right window edge but far from the thumb

What is the expected result?
The scrollbars remain thin

What happens instead?
The scrollbar expands to the thick state

The thickening animation should only be applied when the mouse approaches the thumb. The current behavior invokes the existence of an invisible scrollbar track in the user's mental model.

This behavior should also be applied while the scrollbar is hidden. That is, when we hover over the window edge but far from the thumb, the scrollbar should appear, but it should appear thin.
Project Member

Comment 1 by bugdroid1@chromium.org, May 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/982642b47574426b124f75c2e0b74f83c8705161

commit 982642b47574426b124f75c2e0b74f83c8705161
Author: chaopeng <chaopeng@chromium.org>
Date: Mon May 01 21:45:30 2017

Overlay scrollbars expand only when mouse is near thumb

Overlay scrollbars expand when mouse is near the whole scrollbar today.
In this patch, we change it to expand only when mouse is near thumb.

We pass mouse position to SingleScrollbarAnimationControllerThinning
instead of calculating the distance from mouse position to scrollbar in
LayerTreeHostImpl.

In SingleScrollbarAnimationControllerThinning::DidMouseMove we
calculate:

1. distance from mouse to scrollbar: determind should scrollbar keep
appear, fade out or hover fade in.
2. distance from mouse to scrollbar thumb: determind should thick/thin
scrollbar

BUG= 713218 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2841943002
Cr-Commit-Position: refs/heads/master@{#468428}

[modify] https://crrev.com/982642b47574426b124f75c2e0b74f83c8705161/cc/input/scrollbar_animation_controller.cc
[modify] https://crrev.com/982642b47574426b124f75c2e0b74f83c8705161/cc/input/scrollbar_animation_controller.h
[modify] https://crrev.com/982642b47574426b124f75c2e0b74f83c8705161/cc/input/scrollbar_animation_controller_unittest.cc
[modify] https://crrev.com/982642b47574426b124f75c2e0b74f83c8705161/cc/input/single_scrollbar_animation_controller_thinning.cc
[modify] https://crrev.com/982642b47574426b124f75c2e0b74f83c8705161/cc/input/single_scrollbar_animation_controller_thinning.h
[modify] https://crrev.com/982642b47574426b124f75c2e0b74f83c8705161/cc/input/single_scrollbar_animation_controller_thinning_unittest.cc
[modify] https://crrev.com/982642b47574426b124f75c2e0b74f83c8705161/cc/layers/scrollbar_layer_impl_base.cc
[modify] https://crrev.com/982642b47574426b124f75c2e0b74f83c8705161/cc/layers/scrollbar_layer_impl_base.h
[modify] https://crrev.com/982642b47574426b124f75c2e0b74f83c8705161/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/982642b47574426b124f75c2e0b74f83c8705161/cc/trees/layer_tree_host_impl.h
[modify] https://crrev.com/982642b47574426b124f75c2e0b74f83c8705161/cc/trees/layer_tree_host_impl_unittest.cc

Comment 2 by bokan@chromium.org, May 9 2017

Labels: Merge-Request-59
Project Member

Comment 3 by sheriffbot@chromium.org, May 9 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by sheriffbot@chromium.org, May 15 2017 

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by bokan@chromium.org, May 17 2017

Status: Fixed (was: Assigned)
We no longer need to merge this as we're disabling the feature in M59.
Project Member

Comment 6 by sheriffbot@chromium.org, May 19 2017 

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 7 by bokan@chromium.org, May 19 2017

Labels: -Merge-Approved-59
Removing merge-approved as the feature's been disabled on beta branch.

Comment 8 by sdantul...@chromium.org, May 22 2017

Labels: -Hotlist-Merge-Approved
Status: Verified (was: Fixed)
ChromeOS 9574.0.0, 60.0.3105.0
►

Sign in to add a comment