New issue
Advanced search Search tips

Issue 713211 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 825063



Sign in to add a comment

Release tag DEPS files have misleading variables

Project Member Reported by jbroman@chromium.org, Apr 19 2017

Issue description

Suppose I wish to look up the revision of V8 used in the current dev channel release, 59.0.3071.9.

I can view the published DEPS:
https://chromium.googlesource.com/chromium/src/+/59.0.3071.9/DEPS

Here I see in the "vars" section:
  'v8_revision':
    'fe9bb7e6e251159852770160cfb21dad3cf03523'

In the master DEPS (and at the time of branch, before anything has been cherry-picked), this would be the correct answer. However, any subsequent change is not reflected here, but instead appears below in the "deps" section:
  'src/v8':
    (Var("chromium_git")) + '/v8/v8.git@55f70d7c905599846dfe841afede63273aa6a782'

At master, this uses Var("v8_revision") to share the revision of V8 declared above. But 55f70d7 is the actual revision I should be looking at, not fe9bb7e. This just tripped me up while trying to track what revision included a merged commit.

Is it possible to modify chrome-release-bot to either update the v8_revision variable (and use that in the deps section), or at least remove it vars section so that there is no red herring?
 

Comment 1 by mmoss@chromium.org, Jan 18 2018

Blockedon: 456273
Cc: dpranke@chromium.org
Owner: mmoss@chromium.org
Status: Assigned (was: Untriaged)
This should "just work" once the public branch DEPS files become the source-of-truth for branches (i.e. chrome-release-bot won't even really need to process them anymore because they'll already have all the right information).
Blockedon: -456273 825063
Status: Fixed (was: Assigned)
Should be fixed by Issue 825063, as described in #1

Sign in to add a comment