New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 713206 link

Starred by 1 user
Status: Fixed
Owner:
rouslan@chromium.org
Closed: Apr 2017
Cc:
█ mattgaunt@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Improve error message for PaymentRequest.abort()

Project Member Reported by rouslan@chromium.org, Apr 19 2017 
Calling PaymentRequest.abort() will reject the show() promise with a message "DOMException: The user aborted a request." This is misleading, because the abort() was initiated by the merchant.

Comment 1 by rouslan@chromium.org, Apr 19 2017 

Matt: is this message good?

  "The website has aborted the payment"
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58ee54b41b1703b1cb78d5d281611ed3629b8e78

commit 58ee54b41b1703b1cb78d5d281611ed3629b8e78
Author: rouslan <rouslan@chromium.org>
Date: Wed Apr 19 19:13:39 2017

Improve error message for PaymentRequest.abort().

Before this patch, calling PaymentRequest.abort() would reject the
PaymentRequest.show() promise with a message "DOMException: The user
aborted a request." This is misleading, because it is the merchant
that's initiating the abort.

The fix is to change the message to "The website has aborted the
payment."

BUG= 713206 

Review-Url: https://codereview.chromium.org/2825333004
Cr-Commit-Position: refs/heads/master@{#465697}

[modify] https://crrev.com/58ee54b41b1703b1cb78d5d281611ed3629b8e78/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp

Comment 3 by rouslan@chromium.org, Apr 19 2017

Status: Fixed (was: Started)
►

Sign in to add a comment