Implement a stable and fine grained memory metric for unittest in telemetry |
|||
Issue descriptionMemory/Desktop tests in telemetry needs a stable and fine grained metric to be able to detect leaks regression. The metric must reduce the current noise. On windows, the malloc dump allocator is using HeapWalk and is much more noisy. We implemented a prototype using the MemoryInfra objects count and the metric was much more fine grained and stable.
,
May 10 2017
,
May 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9af9d8069f1a0e3862c5c8526e20ef529f402134 commit 9af9d8069f1a0e3862c5c8526e20ef529f402134 Author: etienneb <etienneb@chromium.org> Date: Wed May 24 21:07:27 2017 Turn on heap profiling for memory.desktop benchmark The memory metric related to malloc used by telemetry is noisy because it is based on the HeapWalk implementation and affected by the tracing infra-structure. A shim_allocated_size / shim_allocated_objects metric is added to provide a more precise metric based on objects allocated through the shim. This metric is much more precise but require heap-profiling to be turn on. Related to: https://codereview.chromium.org/2865333002 https://codereview.chromium.org/2801153004 Note to Perf sheriffs, this CL may: * affect memory consumption for the 'memory.desktop' benchmarks * slowdown 'memory.desktop'benchmarks by adding an extra cost for tracking allocations. R=erikchen BUG= 713191 Review-Url: https://codereview.chromium.org/2900223002 Cr-Commit-Position: refs/heads/master@{#474423} [modify] https://crrev.com/9af9d8069f1a0e3862c5c8526e20ef529f402134/tools/perf/benchmarks/memory.py
,
May 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ff38fa7d607bdbb3d5ea69fc649dd60f7186a076 commit ff38fa7d607bdbb3d5ea69fc649dd60f7186a076 Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org> Date: Thu May 25 22:51:19 2017 Roll src/third_party/catapult/ 91cd4274e..43f23c5d1 (2 commits) https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/91cd4274ef67..43f23c5d1d94 $ git log 91cd4274e..43f23c5d1 --date=short --no-merges --format='%ad %ae %s' 2017-05-25 etienneb Adding malloc allocator metric for objects allocated through shim 2017-05-25 benjhayden Clarify assertion order in style guide. Created with: roll-dep src/third_party/catapult BUG= 713191 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ife90342839ecdc9e01c9bbad43944f14afca24b8 Reviewed-on: https://chromium-review.googlesource.com/516204 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#474831} [modify] https://crrev.com/ff38fa7d607bdbb3d5ea69fc649dd60f7186a076/DEPS
,
Jun 28 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, May 10 2017