New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 713190 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Security



Sign in to add a comment

Heap-use-after-free in blink::LayoutBox::findAutoscrollable

Project Member Reported by ClusterFuzz, Apr 19 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6546588857270272

Fuzzer: marty_html_twiddler
Job Type: windows_asan_chrome_no_sandbox
Platform Id: windows

Crash Type: Heap-use-after-free READ 4
Crash Address: 0x07c39180
Crash State:
  blink::LayoutBox::findAutoscrollable
  blink::AutoscrollController::startAutoscrollForSelection
  blink::HTMLSelectElement::listBoxDefaultEventHandler
  
Sanitizer: address (ASAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_chrome_no_sandbox&range=437055:437094

Reproducer Testcase: https://clusterfuzz.com/download/AMIfv97XJ7b6AP9dwzWwvS4_4d1HowLhRWu_hn2uQSmZqSEMBxg4RbyKHBtmvFnP6jrYjxs28j42cJyc2wmevdU1Onz1ScOV3weAYqwu5GL_bwTTX0M8LMavs_i2akuzH6iB8OFxi8MadXm7NxYSmc0HhZSavd5V9ZSr-cX21fWG0KW-W-7s4WXuv-3LVNDcyAhqi7lGzMUBN_Onr5KMpjxKVDZdTPqV_gIMIdGllOO1ttNXbtuPQw1ca6_mq8AfSfrKCrbl7gXztJ5RLB0JcYcIWD5Y85yHWJuSRw7eDDYTf83xMAWH1SllsuECv26fQgo_2Yiz1TAjR6RDln5aTZCHp2hL6eZmBYjj0tJwjekucgZEUGl0rAKh6jnL7W8zf-TNKWattB5mKkDFzbMKnGe9U5-GILPGOQ?testcase_id=6546588857270272


Additional requirements: Requires Gestures

Issue filed automatically.

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 

Comment 1 by mea...@chromium.org, Apr 19 2017

Components: Blink>Layout
Labels: Pri-1
Owner: msten...@opera.com
Status: Assigned (was: Untriaged)
The only related change in the regression range seems to be https://chromium.googlesource.com/chromium/src/+/95342a4986af56783818b4a7f578f4b3b2bf5f2b

mstensho: Can you please take a look?
Project Member

Comment 2 by sheriffbot@chromium.org, Apr 20 2017

Labels: M-58

Comment 3 by msten...@opera.com, Apr 25 2017

Cc: msten...@opera.com
Owner: chrishtr@chromium.org
I can reproduce this. Dragging with the mouse seems to be required (which is also suggested by the call stack).

AutoscrollController::StartAutoscrollForSelection() is called with a healthy layout object. Then layout_object->GetFrameView()->UpdateAllLifecyclePhasesExceptPaint() kills layout_object.

This (updating life cycle phases and expecting that the LayoutObject pointer is valid afterwards) was introduced by https://codereview.chromium.org/2549353002
Labels: -M-58 ReleaseBlock-Stable M-59 Merge-Request-59
Project Member

Comment 6 by ClusterFuzz, Apr 29 2017

ClusterFuzz has detected this issue as fixed in range 468057:468112.

Detailed report: https://clusterfuzz.com/testcase?key=6546588857270272

Fuzzer: marty_html_twiddler
Job Type: windows_asan_chrome_no_sandbox
Platform Id: windows

Crash Type: Heap-use-after-free READ 4
Crash Address: 0x07c39180
Crash State:
  blink::LayoutBox::findAutoscrollable
  blink::AutoscrollController::startAutoscrollForSelection
  blink::HTMLSelectElement::listBoxDefaultEventHandler
  
Sanitizer: address (ASAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_chrome_no_sandbox&range=437055:437094
Fixed: https://clusterfuzz.com/revisions?job=windows_asan_chrome_no_sandbox&range=468057:468112

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6546588857270272


Additional requirements: Requires Gestures

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 7 by ClusterFuzz, Apr 29 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6546588857270272 is verified as fixed, so closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 8 by sheriffbot@chromium.org, Apr 29 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Project Member

Comment 9 by sheriffbot@chromium.org, Apr 29 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 10 by sheriffbot@chromium.org, May 3 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 11 by sheriffbot@chromium.org, May 8 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: Merge-Merged
The patch has already been merged.
Project Member

Comment 13 by ClusterFuzz, May 11 2017

ClusterFuzz has detected this issue as fixed in range 468057:468112.

Detailed report: https://clusterfuzz.com/testcase?key=6546588857270272

Fuzzer: marty_html_twiddler
Job Type: windows_asan_chrome_no_sandbox
Platform Id: windows

Crash Type: Heap-use-after-free READ 4
Crash Address: 0x07c39180
Crash State:
  blink::LayoutBox::findAutoscrollable
  blink::AutoscrollController::startAutoscrollForSelection
  blink::HTMLSelectElement::listBoxDefaultEventHandler
  
Sanitizer: address (ASAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_chrome_no_sandbox&range=437055:437094
Fixed: https://clusterfuzz.com/revisions?job=windows_asan_chrome_no_sandbox&range=468057:468112

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6546588857270272


Additional requirements: Requires Gestures

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Labels: -Merge-Merged -Hotlist-Merge-Approved -ReleaseBlock-Stable merge-merged-3071
For reference, the merge was https://chromium.googlesource.com/chromium/src.git/+/6deb87d4ab4c0d3be8af55492fed6252c3e6c2ed
Please merge your change to M59 branch 3071 by 4:00 PM PT, Monday (05/15) so we can take it in for next week beta release. Thank you.
It's already merged.
Labels: -Merge-Approved-59
Removing "Merge-Approved-59" label per comment #16.
Labels: Release-0-M59
Project Member

Comment 19 by sheriffbot@chromium.org, Aug 5 2017

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment