New issue
Advanced search Search tips

Issue 713188 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

[Cronet] Remove obsolete ios/crnet

Project Member Reported by mef@chromium.org, Apr 19 2017

Issue description

CrNet for iOS located in ios/crnet has been replaced by Cronet in components/cronet/ios.

We need to remove old source code to avoid confusion and reduce maintenance.

 

Comment 1 by sczs@chromium.org, Apr 19 2017

Cc: droger@chromium.org mef@chromium.org marq@chromium.org
Owner: kapishnikov@chromium.org
Status: Assigned (was: Untriaged)
Hi kapishnikov@ could you please take a look.
Sounds good. I or somebody else from the Cronet team will fix it.

Comment 3 by mef@chromium.org, Jul 10 2017

Owner: mef@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5903186bf35f85ec282dfa20966a5ee911f16c9a

commit 5903186bf35f85ec282dfa20966a5ee911f16c9a
Author: Misha Efimov <mef@chromium.org>
Date: Wed Jul 12 22:32:45 2017

[Cronet] Remove legacy //ios/crnet replaced by //components/cronet.

Bug:  713188 
Change-Id: If8d923129a063160caaef22d3908f6f5f7aef2bc
Reviewed-on: https://chromium-review.googlesource.com/565446
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486141}
[modify] https://crrev.com/5903186bf35f85ec282dfa20966a5ee911f16c9a/ios/BUILD.gn
[delete] https://crrev.com/79b69b21b2072ba533544d80de2c692a370f011c/ios/crnet/BUILD.gn
[delete] https://crrev.com/79b69b21b2072ba533544d80de2c692a370f011c/ios/crnet/CrNet.h
[delete] https://crrev.com/79b69b21b2072ba533544d80de2c692a370f011c/ios/crnet/CrNet.mm
[delete] https://crrev.com/79b69b21b2072ba533544d80de2c692a370f011c/ios/crnet/DEPS
[delete] https://crrev.com/79b69b21b2072ba533544d80de2c692a370f011c/ios/crnet/Info.plist
[delete] https://crrev.com/79b69b21b2072ba533544d80de2c692a370f011c/ios/crnet/OWNERS
[delete] https://crrev.com/79b69b21b2072ba533544d80de2c692a370f011c/ios/crnet/Resources/Localization/am.lproj/Localizable.strings
[delete] https://crrev.com/79b69b21b2072ba533544d80de2c692a370f011c/ios/crnet/Resources/Localization/ar.lproj/Localizable.strings
[delete] https://crrev.com/79b69b21b2072ba533544d80de2c692a370f011c/ios/crnet/Resources/Localization/bg.lproj/Localizable.strings
[delete] https://crrev.com/79b69b21b2072ba533544d80de2c692a370f011c/ios/crnet/Resources/Localization/bn.lproj/Localizable.strings
[delete] https://crrev.com/79b69b21b2072ba533544d80de2c692a370f011c/ios/crnet/Resources/Localization/ca.lproj/Localizable.strings
[delete] https://crrev.com/79b69b21b2072ba533544d80de2c692a370f011c/ios/crnet/Resources/Localization/cs.lproj/Localizable.strings
[delete] https://crrev.com/79b69b21b2072ba533544d80de2c692a370f011c/ios/crnet/Resources/Localization/da.lproj/Localizable.strings
[delete] https://crrev.com/79b69b21b2072ba533544d80de2c692a370f011c/ios/crnet/Resources/Localization/de.lproj/Localizable.strings
[delete] https://crrev.com/79b69b21b2072ba533544d80de2c692a370f011c/ios/crnet/Resources/Localization/el.lproj/Localizable.strings
[delete] https://crrev.com/79b69b21b2072ba533544d80de2c692a370f011c/ios/crnet/Resources/Localization/en-GB.lproj/Localizable.strings
[delete] https://crrev.com/79b69b21b2072ba533544d80de2c692a370f011c/ios/crnet/Resources/Localization/en.lproj/Localizable.strings
[delete] https://crrev.com/79b69b21b2072ba533544d80de2c692a370f011c/ios/crnet/Resources/Localization/es-419.lproj/Localizable.strings
[delete] https://crrev.com/79b69b21b2072ba533544d80de2c692a370f011c/ios/crnet/Resources/Localization/es.lproj/Localizable.strings
[delete] https://crrev.com/79b69b21b2072ba533544d80de2c692a370f011c/ios/crnet/Resources/Localization/et.lproj/Localizable.strings
[delete] https://crrev.com/79b69b21b2072ba533544d80de2c692a370f011c/ios/crnet/Resources/Localization/fa.lproj/Localizable.strings
[delete] https://crrev.com/79b69b21b2072ba533544d80de2c692a370f011c/ios/crnet/Resources/Localization/fi.lproj/Localizable.strings
[delete] https://crrev.com/79b69b21b2072ba533544d80de2c692a370f011c/ios/crnet/Resources/Localization/fil.lproj/Localizable.strings
[delete] https://crrev.com/79b69b21b2072ba533544d80de2c692a370f011c/ios/crnet/Resources/Localization/fr.lproj/Localizable.strings
[delete] https://crrev.com/79b69b21b2072ba533544d80de2c692a370f011c/ios/crnet/Resources/Localization/gu.lproj/Localizable.strings
[delete] https://crrev.com/79b69b21b2072ba533544d80de2c692a370f011c/ios/crnet/Resources/Localization/he.lproj/Localizable.strings
[delete] https://crrev.com/79b69b21b2072ba533544d80de2c692a370f011c/ios/crnet/Resources/Localization/hi.lproj/Localizable.strings
[delete] https://crrev.com/79b69b21b2072ba533544d80de2c692a370f011c/ios/crnet/Resources/Localization/hr.lproj/Localizable.strings
[delete] https://crrev.com/79b69b21b2072ba533544d80de2c692a370f011c/ios/crnet/Resources/Localization/hu.lproj/Localizable.strings
[delete] https://crrev.com/79b69b21b2072ba533544d80de2c692a370f011c/ios/crnet/Resources/Localization/id.lproj/Localizable.strings
[delete] https://crrev.com/79b69b21b2072ba533544d80de2c692a370f011c/ios/crnet/Resources/Localization/it.lproj/Localizable.strings
[delete] https://crrev.com/79b69b21b2072ba533544d80de2c692a370f011c/ios/crnet/Resources/Localization/ja.lproj/Localizable.strings
[delete] https://crrev.com/79b69b21b2072ba533544d80de2c692a370f011c/ios/crnet/Resources/Localization/kn.lproj/Localizable.strings
[delete] https://crrev.com/79b69b21b2072ba533544d80de2c692a370f011c/ios/crnet/Resources/Localization/ko.lproj/Localizable.strings
[delete] https://crrev.com/79b69b21b2072ba533544d80de2c692a370f011c/ios/crnet/Resources/Localization/lt.lproj/Localizable.strings
[delete] https://crrev.com/79b69b21b2072ba533544d80de2c692a370f011c/ios/crnet/Resources/Localization/lv.lproj/Localizable.strings
[delete] https://crrev.com/79b69b21b2072ba533544d80de2c692a370f011c/ios/crnet/Resources/Localization/ml.lproj/Localizable.strings
[delete] https://crrev.com/79b69b21b2072ba533544d80de2c692a370f011c/ios/crnet/Resources/Localization/mr.lproj/Localizable.strings
[delete] https://crrev.com/79b69b21b2072ba533544d80de2c692a370f011c/ios/crnet/Resources/Localization/ms.lproj/Localizable.strings
[delete] https://crrev.com/79b69b21b2072ba533544d80de2c692a370f011c/ios/crnet/Resources/Localization/nb.lproj/Localizable.strings
[delete] https://crrev.com/79b69b21b2072ba533544d80de2c692a370f011c/ios/crnet/Resources/Localization/nl.lproj/Localizable.strings
[delete] https://crrev.com/79b69b21b2072ba533544d80de2c692a370f011c/ios/crnet/Resources/Localization/pl.lproj/Localizable.strings
[delete] https://crrev.com/79b69b21b2072ba533544d80de2c692a370f011c/ios/crnet/Resources/Localization/pt-BR.lproj/Localizable.strings
[delete] https://crrev.com/79b69b21b2072ba533544d80de2c692a370f011c/ios/crnet/Resources/Localization/pt-PT.lproj/Localizable.strings
[delete] https://crrev.com/79b69b21b2072ba533544d80de2c692a370f011c/ios/crnet/Resources/Localization/pt.lproj/Localizable.strings
[delete] https://crrev.com/79b69b21b2072ba533544d80de2c692a370f011c/ios/crnet/Resources/Localization/ro.lproj/Localizable.strings
[delete] https://crrev.com/79b69b21b2072ba533544d80de2c692a370f011c/ios/crnet/Resources/Localization/ru.lproj/Localizable.strings
[delete] https://crrev.com/79b69b21b2072ba533544d80de2c692a370f011c/ios/crnet/Resources/Localization/sk.lproj/Localizable.strings
[delete] https://crrev.com/79b69b21b2072ba533544d80de2c692a370f011c/ios/crnet/Resources/Localization/sl.lproj/Localizable.strings
[delete] https://crrev.com/79b69b21b2072ba533544d80de2c692a370f011c/ios/crnet/Resources/Localization/sr.lproj/Localizable.strings
[delete] https://crrev.com/79b69b21b2072ba533544d80de2c692a370f011c/ios/crnet/Resources/Localization/sv.lproj/Localizable.strings
[delete] https://crrev.com/79b69b21b2072ba533544d80de2c692a370f011c/ios/crnet/Resources/Localization/sw.lproj/Localizable.strings
[delete] https://crrev.com/79b69b21b2072ba533544d80de2c692a370f011c/ios/crnet/Resources/Localization/ta.lproj/Localizable.strings
[delete] https://crrev.com/79b69b21b2072ba533544d80de2c692a370f011c/ios/crnet/Resources/Localization/te.lproj/Localizable.strings
[delete] https://crrev.com/79b69b21b2072ba533544d80de2c692a370f011c/ios/crnet/Resources/Localization/th.lproj/Localizable.strings
[delete] https://crrev.com/79b69b21b2072ba533544d80de2c692a370f011c/ios/crnet/Resources/Localization/tr.lproj/Localizable.strings
[delete] https://crrev.com/79b69b21b2072ba533544d80de2c692a370f011c/ios/crnet/Resources/Localization/uk.lproj/Localizable.strings
[delete] https://crrev.com/79b69b21b2072ba533544d80de2c692a370f011c/ios/crnet/Resources/Localization/vi.lproj/Localizable.strings
[delete] https://crrev.com/79b69b21b2072ba533544d80de2c692a370f011c/ios/crnet/Resources/Localization/zh-Hans.lproj/Localizable.strings
[delete] https://crrev.com/79b69b21b2072ba533544d80de2c692a370f011c/ios/crnet/Resources/Localization/zh-Hant.lproj/Localizable.strings
[delete] https://crrev.com/79b69b21b2072ba533544d80de2c692a370f011c/ios/crnet/Resources/Localization/zh.lproj/Localizable.strings
[delete] https://crrev.com/79b69b21b2072ba533544d80de2c692a370f011c/ios/crnet/Resources/README
[delete] https://crrev.com/79b69b21b2072ba533544d80de2c692a370f011c/ios/crnet/build.py
[delete] https://crrev.com/79b69b21b2072ba533544d80de2c692a370f011c/ios/crnet/crnet_environment.h
[delete] https://crrev.com/79b69b21b2072ba533544d80de2c692a370f011c/ios/crnet/crnet_environment.mm
[delete] https://crrev.com/79b69b21b2072ba533544d80de2c692a370f011c/ios/crnet/sdch_owner_pref_storage.cc
[delete] https://crrev.com/79b69b21b2072ba533544d80de2c692a370f011c/ios/crnet/sdch_owner_pref_storage.h
[delete] https://crrev.com/79b69b21b2072ba533544d80de2c692a370f011c/ios/crnet/test/BUILD.gn
[delete] https://crrev.com/79b69b21b2072ba533544d80de2c692a370f011c/ios/crnet/test/crnet_http_tests.mm
[delete] https://crrev.com/79b69b21b2072ba533544d80de2c692a370f011c/ios/crnet/test/crnet_test_runner.mm
[modify] https://crrev.com/5903186bf35f85ec282dfa20966a5ee911f16c9a/ios/web_view/BUILD.gn

Comment 5 by mef@chromium.org, Jul 13 2017

Status: Fixed (was: Started)

Sign in to add a comment