New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 713182 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

pylint docstring checker fails

Project Member Reported by mnissler@chromium.org, Apr 19 2017

Issue description

I'm seeing this exception on the pylint invocation triggered by repo upload:

            * Hook script "./utils/run_pylint.py" failed with code 1:
              Warning: option include-ids is deprecated and ignored.
              Traceback (most recent call last):
                File "./utils/run_pylint.py", line 461, in <module>
                  main()
                File "./utils/run_pylint.py", line 454, in main
                  pylint_base_opts)
                File "./utils/run_pylint.py", line 394, in check_committed_files
                  batch_check_files(temp_files, pylint_base_opts)
                File "./utils/run_pylint.py", line 243, in batch_check_files
                  exit=False)
                File "/usr/lib64/python2.7/site-packages/pylint/lint.py", line 1266, in __init__
                  linter.check(args)
                File "/usr/lib64/python2.7/site-packages/pylint/lint.py", line 674, in check
                  self._do_check(files_or_modules)
                File "/usr/lib64/python2.7/site-packages/pylint/lint.py", line 805, in _do_check
                  self.check_astroid_module(ast_node, walker, rawcheckers, tokencheckers)
                File "/usr/lib64/python2.7/site-packages/pylint/lint.py", line 881, in check_astroid_module
                  walker.walk(ast_node)
                File "/usr/lib64/python2.7/site-packages/pylint/utils.py", line 869, in walk
                  self.walk(child)
                File "/usr/lib64/python2.7/site-packages/pylint/utils.py", line 869, in walk
                  self.walk(child)
                File "/usr/lib64/python2.7/site-packages/pylint/utils.py", line 866, in walk
                  cb(astroid)
                File "./utils/run_pylint.py", line 183, in visit_function
                  super(CustomDocStringChecker, self).visit_function(node)
                File "/usr/lib64/python2.7/site-packages/pylint/checkers/base.py", line 1159, in visit_function
                  confidence=confidence)
              TypeError: _check_docstring() got an unexpected keyword argument 'report_missing'


The root cause is probably a change to pylint so the assumptions that are made in run_pylint.py's _check_docstring override (which looks like a hack since it access internal pylint state) no longer hold: https://cs.corp.google.com/chromeos_public/src/third_party/autotest/files/utils/run_pylint.py?rcl=c5289fbf3af062deb4fc295ddea23a6fba60b382&l=195

Not sure what suitable are suitable component / labels, using Hardware-Lab since that was used on previous changes to the code.
 
Components: Infra>Client>ChromeOS
Labels: -Hardware-Lab
Owner: pho...@chromium.org
Status: WontFix (was: Untriaged)
Is this still happening?

Sign in to add a comment