Pawel, would you have a look since this is related to analyze?
Or, else should this be forwarded to sheriffs?

Pawel, friendly ping :)

In the first patchset on that CL, you only modified changes in //cc . Unfortunately, due to the fact that the layout tests weren't able to run under swarming, we don't run them on every change we should, only on a whitelisted set of directories. And, due to the way the build recipes are written, it happens that blink_platform_unittests isn't built for //cc either.

We now have the layout tests working under swarming, so we're working on making sure we have the capacity and are running things properly; you can track the progress in  bug 524758 .

I don't see mention of blink_platform_unittests on 524758 since 2015, should I expect it to be improving the analyze for blink_platform_unittests also? Is there anything I could contribute to help, as this greatly impacts the graphics team.

Thanks!

blink_platform_unittests works under swarming now, and it's fast, so there's really no reason we couldn't move it over to run unconditionally, we've just never gotten around to it. So, if you wanted, you could post CLs to start running it and the other gtest-based tests and that would be one less thing for mcgreevy@ and tansell@ to worry about as they're getting the layout tests running everywhere.

Sure. Can you point me where I would do this? I tried searching cc_unittests as an example but theres 4 pages of results and it's not clear to me, since blink_platform_tests is running, but just conditionally.

All of the weird conditional logic is in https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/chromium_tests/api.py?l=29.

The logic is applied on three builders: {linux,mac,win}_chromium_rel_ng. 

The list of gtest-based tests are here:

https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/chromium_tests/api.py?l=902

So, I think you can just add those four tests to the correct entries for the "matching" waterfall bots in the //testing/buildbot/*.json files: Linux Tests, Mac10.9 Tests, Win Tests (1) (as determined from

https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/chromium_tests/trybots.py?l=292
https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/chromium_tests/trybots.py?l=441
https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/chromium_tests/trybots.py?l=525

).

I think you can add them in a single CL in src, and then get bonus points for deleting those five lines in a follow-up build-side CL.

Is that enough to go on?

https://codereview.chromium.org/2849673002/# for chromium bots.
https://chromium-review.googlesource.com/c/489447/ to remove the wekbit logic.

FYI - The bug we are using to track removing that special logic is https://bugs.chromium.org/p/chromium/issues/detail?id=703894

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa07565e88d7bf456ece9dc4cf2673b7aad656dc

commit aa07565e88d7bf456ece9dc4cf2673b7aad656dc
Author: danakj <danakj@chromium.org>
Date: Fri Apr 28 14:46:49 2017

Add blink unit tests to the linux/mac/windows builders.

This will run the unit test suites for the try bots and on the main
chromium waterfall. Once this is done, we can remove them from the
separate webkit waterfall.

R=dpranke@chromium.org
BUG= 713180 ,  703894 

Review-Url: https://codereview.chromium.org/2849673002
Cr-Commit-Position: refs/heads/master@{#467993}

[modify] https://crrev.com/aa07565e88d7bf456ece9dc4cf2673b7aad656dc/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/aa07565e88d7bf456ece9dc4cf2673b7aad656dc/testing/buildbot/chromium.mac.json
[modify] https://crrev.com/aa07565e88d7bf456ece9dc4cf2673b7aad656dc/testing/buildbot/chromium.win.json

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/ff03caced30e039dd5e90ee265f8a8cd4490018d

commit ff03caced30e039dd5e90ee265f8a8cd4490018d
Author: danakj <danakj@chromium.org>
Date: Mon May 01 04:02:25 2017

Remove gtests from the webkit waterfall.

These tests should run as part of the usual chromium win/mac/linux
builders instead, so they can run on all CLs that affect them as
determined by analyze.

R=dpranke@chromium.org

Bug:  713180 , 703894 
Change-Id: Ib16178babaa74a43f05e6dc4511a00b5fcee1e32
Reviewed-on: https://chromium-review.googlesource.com/489447
Commit-Queue: Tim 'mithro' Ansell <tansell@chromium.org>
Reviewed-by: Tim 'mithro' Ansell <tansell@chromium.org>

[modify] https://crrev.com/ff03caced30e039dd5e90ee265f8a8cd4490018d/scripts/slave/recipe_modules/chromium_tests/tests/api/trybot_steps.expected/blink_linux.json
[modify] https://crrev.com/ff03caced30e039dd5e90ee265f8a8cd4490018d/scripts/slave/recipes/chromium_trybot.expected/add_swarming_layout_tests_via_manual_diff_inspection_that_fails.json
[modify] https://crrev.com/ff03caced30e039dd5e90ee265f8a8cd4490018d/scripts/slave/recipes/chromium_trybot.expected/add_swarming_layout_tests_via_manual_diff_inspection.json
[modify] https://crrev.com/ff03caced30e039dd5e90ee265f8a8cd4490018d/scripts/slave/recipes/chromium_trybot.expected/add_layout_tests_via_manual_diff_inspection.json
[modify] https://crrev.com/ff03caced30e039dd5e90ee265f8a8cd4490018d/scripts/slave/recipe_modules/chromium_tests/api.py
[modify] https://crrev.com/ff03caced30e039dd5e90ee265f8a8cd4490018d/scripts/slave/recipes/chromium_trybot.expected/use_v8_patch_on_chromium_trybot.json
[modify] https://crrev.com/ff03caced30e039dd5e90ee265f8a8cd4490018d/scripts/slave/recipe_modules/chromium_tests/tests/api/trybot_steps.expected/blink_mac.json
[modify] https://crrev.com/ff03caced30e039dd5e90ee265f8a8cd4490018d/scripts/slave/recipes/chromium_trybot.expected/use_skia_patch_on_chromium_trybot.json

thanks!

Thanks for your help, instructions made it easy :)