New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 3 users
Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment
"org.chromium.chrome.browser.CopylessPasteTest#testCache" is flaky
Project Member Reported by chromium...@appspot.gserviceaccount.com, Apr 19 2017 Back to list
"org.chromium.chrome.browser.CopylessPasteTest#testCache" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 11 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyQgsSBUZsYWtlIjdvcmcuY2hyb21pdW0uY2hyb21lLmJyb3dzZXIuQ29weWxlc3NQYXN0ZVRlc3QjdGVzdENhY2hlDA.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Labels: OS-Android
Owner: wychen@chromium.org
Status: Assigned
Assigning to the feature owner, and disabling in the meantime.
Comment 2 by ojan@chromium.org, Apr 19 2017
Labels: -Sheriff-Chromium
Removing Sheriff-Chromium label since the test was disabled.
Comment 3 by ojan@chromium.org, Apr 19 2017
Disabling patch had the wrong bug number. Was disabled in https://codereview.chromium.org/2830673003.
Comment 4 Deleted
testValid is also flakey. Disabling this test as well. Seems to have been introduced in the same CL so it's probably got the same cause.
Project Member Comment 7 by bugdroid1@chromium.org, Apr 21 2017
Project Member Comment 8 by bugdroid1@chromium.org, Jul 12
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0982cbaa2225d8a7a895aebaaed64be032b418a1

commit 0982cbaa2225d8a7a895aebaaed64be032b418a1
Author: wychen <wychen@chromium.org>
Date: Wed Jul 12 05:10:09 2017

Enable all tests in CopylessPasteTest

The following tests are re-enabled:
- testValid
- testNoMeta
- testCache

All flaky failures in CopylessPasteTest are due to timeout in
CallbackHelper.waitForCallback(). Wait for longer to see if it gets
better.

Reference:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chrome_public_test_apk%20(with%20patch)&showAllRuns=true&tests=org.chromium.chrome.browser.CopylessPasteTest%23

BUG=713172, 713895 , 713878 , 693650 

Review-Url: https://codereview.chromium.org/2826253004
Cr-Commit-Position: refs/heads/master@{#485865}

[modify] https://crrev.com/0982cbaa2225d8a7a895aebaaed64be032b418a1/chrome/android/javatests/src/org/chromium/chrome/browser/CopylessPasteTest.java

Cc: wychen@chromium.org
 Issue 713895  has been merged into this issue.
 Issue 713878  has been merged into this issue.
Cc: -wychen@chromium.org dproctor@google.com
According to the dashboard, the failure rate since re-enabling is much lower than last time.
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&testType=chrome_public_test_apk&showExpectations=true&tests=org.chromium.chrome.browser.CopylessPasteTest%23
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&testType=chrome_public_test_apk%20(with%20patch)&showExpectations=true&tests=org.chromium.chrome.browser.CopylessPasteTest%23

Looks like the hypothesis was right. The test does take longer. I think we can further relax the timeout to make the failure rate even lower.
Project Member Comment 12 by bugdroid1@chromium.org, Jul 20
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9ab17245e9677a467e2e53f8ec2e9af874fb6167

commit 9ab17245e9677a467e2e53f8ec2e9af874fb6167
Author: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Date: Thu Jul 20 22:32:55 2017

Use longer timeout for tests in CopylessPasteTest

Increasing timeout (https://codereview.chromium.org/2826253004)
lowered the failure rate. This indicates the tests are not inherently
flaky. They just run for longer.

Bug: 713172, 747073
Change-Id: I20a039776aa2aa9f70560e8d688f27ef34e6eb6a
Reviewed-on: https://chromium-review.googlesource.com/580256
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488448}
[modify] https://crrev.com/9ab17245e9677a467e2e53f8ec2e9af874fb6167/chrome/android/javatests/src/org/chromium/chrome/browser/CopylessPasteTest.java

Unfortunately it seems the longer timeout wasn't enough to stop one of the tests turning the Android Tests build red here: https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/44035 :(

Might be worth a @RetryOnFailure ?
Project Member Comment 14 by bugdroid1@chromium.org, Jul 24
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ab04c29c830dde25549fe4ce1d5a4c875296910

commit 6ab04c29c830dde25549fe4ce1d5a4c875296910
Author: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Date: Mon Jul 24 22:57:12 2017

Add @RetryOnFailure on flaky CopylessPasteTest

This allows more investigation without making bots red.

Bug: 713172
Change-Id: I27e9b49ae816fa743e18ebb6c34931ac733d472a
Reviewed-on: https://chromium-review.googlesource.com/583715
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489117}
[modify] https://crrev.com/6ab04c29c830dde25549fe4ce1d5a4c875296910/chrome/android/javatests/src/org/chromium/chrome/browser/CopylessPasteTest.java

Cc: aelias@chromium.org
 Issue 749370  has been merged into this issue.
Sign in to add a comment