New issue
Advanced search Search tips

Issue 713138 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Fix erroneous inclusion of .cc files instead of .h

Project Member Reported by emaxx@chromium.org, Apr 19 2017

Issue description

It seems that there are several places in the code base that include .cc files instead of the header files.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c24f121f6d56c1447d4a28d2954d8b7b8c4a30cb

commit c24f121f6d56c1447d4a28d2954d8b7b8c4a30cb
Author: emaxx <emaxx@chromium.org>
Date: Wed Apr 19 12:38:52 2017

Fix wrong inclusion of .cc file in services/ui/ws/

BUG= 713138 

Review-Url: https://codereview.chromium.org/2819383004
Cr-Commit-Position: refs/heads/master@{#465562}

[modify] https://crrev.com/c24f121f6d56c1447d4a28d2954d8b7b8c4a30cb/services/ui/ws/frame_generator_unittest.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a726a72d1a958dc24579fbe7d191ef11ad18357

commit 7a726a72d1a958dc24579fbe7d191ef11ad18357
Author: emaxx <emaxx@chromium.org>
Date: Wed Apr 19 13:38:37 2017

Fix wrong inclusion of .cc file in policy/

BUG= 713138 

Review-Url: https://codereview.chromium.org/2824883007
Cr-Commit-Position: refs/heads/master@{#465581}

[modify] https://crrev.com/7a726a72d1a958dc24579fbe7d191ef11ad18357/chrome/browser/chromeos/policy/device_cloud_policy_browsertest.cc

Comment 4 by emaxx@chromium.org, Apr 19 2017

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/895210ec83415ea001f540529e81e55329497e50

commit 895210ec83415ea001f540529e81e55329497e50
Author: emaxx <emaxx@chromium.org>
Date: Wed Apr 19 14:37:30 2017

Fix wrong inclusion of .cc file in extensions/

BUG= 713138 

Review-Url: https://codereview.chromium.org/2823413003
Cr-Commit-Position: refs/heads/master@{#465600}

[modify] https://crrev.com/895210ec83415ea001f540529e81e55329497e50/chrome/browser/extensions/extension_crash_recovery_browsertest.cc

Comment 8 by emaxx@chromium.org, Apr 19 2017

Status: Fixed (was: Started)
Project Member

Comment 9 by bugdroid1@chromium.org, Feb 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e7639bb0f9dde7a6f89b992556499705a1b8079

commit 7e7639bb0f9dde7a6f89b992556499705a1b8079
Author: Pavol Marko <pmarko@chromium.org>
Date: Tue Feb 20 17:59:50 2018

Fix accidental inclusion of .cc files

These .cc files have been included accidentally.
Include the header file instead.

Bug:  713138 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: If9ee44765e1bbd7d4d4d5c4a6367457dc62fd01f
Reviewed-on: https://chromium-review.googlesource.com/926583
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Commit-Queue: Pavol Marko <pmarko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537815}
[modify] https://crrev.com/7e7639bb0f9dde7a6f89b992556499705a1b8079/chrome/test/media_router/media_router_integration_browsertest.cc
[modify] https://crrev.com/7e7639bb0f9dde7a6f89b992556499705a1b8079/ios/chrome/browser/passwords/account_select_fill_data_unittest.cc

Sign in to add a comment