Issue metadata
Sign in to add a comment
|
7.5% regression in image_decoding.image_decoding_measurement at 463674:463724 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Apr 19 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8981888002596247264
,
Apr 19 2017
=== BISECT JOB RESULTS === Bisect was unable to run to completion Please try rerunning the bisect. If failures persist contact the team (see below) and report the error. Bisect Details Configuration: winx64ati_perf_bisect Benchmark : image_decoding.image_decoding_measurement Metric : ImageDecoding_avg/ImageDecoding_avg Change : 8.43% | 42.333775 -> 45.90375 Revision Result N chromium@463673 42.3338 +- 0.440413 6 good chromium@463686 42.3588 +- 0.371829 6 good chromium@463693 42.6854 +- 0.333283 6 good chromium@463694 42.2324 +- 0.286305 6 good chromium@463694,skia@7a542c559a 45.025 +- 0.459657 6 bad chromium@463695 45.0537 +- 0.256578 6 bad chromium@463696 45.1573 +- 0.459889 6 bad chromium@463699 44.8662 +- 0.337707 6 bad chromium@463724 45.9037 +- 0.489993 6 bad To Run This Test src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests image_decoding.image_decoding_measurement Debug Info https://chromeperf.appspot.com/buildbucket_job_status/8981888002596247264 Is this bisect wrong? https://chromeperf.appspot.com/bad_bisect?try_job_id=5878704883892224 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Speed>Bisection. Thank you!
,
Apr 19 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8981865432768309440
,
Apr 19 2017
=== Auto-CCing suspected CL author reed@google.com === Hi reed@google.com, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : Mike Reed Commit : 7a542c559a6e584107b94e6254ac3c7f9f24b591 Date : Tue Apr 11 16:38:17 2017 Subject: Change bitmapcache to not rely on lockpixels. Bisect Details Configuration: winx64ati_perf_bisect Benchmark : image_decoding.image_decoding_measurement Metric : ImageDecoding_avg/ImageDecoding_avg Change : 7.85% | 42.3858166667 -> 45.711575 Revision Result N chromium@463673 42.3858 +- 0.465159 6 good chromium@463686 42.2155 +- 0.474052 6 good chromium@463693 42.6782 +- 0.371481 6 good chromium@463694 42.3052 +- 0.21472 6 good chromium@463694,skia@77443974ea 42.3658 +- 0.299602 6 good chromium@463694,skia@7a542c559a 44.8951 +- 0.430124 6 bad <-- chromium@463695 45.0872 +- 0.432768 6 bad chromium@463696 45.1909 +- 0.406581 6 bad chromium@463699 44.9693 +- 0.530582 6 bad chromium@463724 45.7116 +- 0.512022 6 bad To Run This Test src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests image_decoding.image_decoding_measurement Debug Info https://chromeperf.appspot.com/buildbucket_job_status/8981865432768309440 Is this bisect wrong? https://chromeperf.appspot.com/bad_bisect?try_job_id=5878704883892224 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Speed>Bisection. Thank you!
,
Apr 24 2017
Issue 713117 has been merged into this issue.
,
Apr 26 2017
,
Jul 27 2017
Explictly assigning. A CL you landed tripped one of the speed metrics we measure in the lab. If this is the first time this has happened to one of your CLs, or if it's been a while, please read: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/addressing_performance_regressions.md We're looking for one of the following: 1. Justification via explanation 2. Plan to revert or fix 3. Angry rage throwing of equipment at my head Just be aware that I'm trained in trumpet playing and First Aid and am not afraid to use it. Note: This was a bulk edit message and not very personal.
,
Jul 27 2017
lending to Florin while I'm out-of-town
,
Sep 18 2017
fmalita: any progress here?
,
Sep 19 2017
This is a very old CL, with lots of other changes piled on top. Going through all the associated graphs, they fall into two categories: 1) metrics which have recovered - e.g. https://chromeperf.appspot.com/report?sid=4bb94a371621ec8d291b50555b18f1c091ebba52a94a126dd01c94b2724dabf0&start_rev=459031&end_rev=502823 2) metrics with data points only in [ 4/7/2017 - 4/18/2017 ] https://chromeperf.appspot.com/report?sid=20a64bbffbe0689f10ce3bc3bc6c10fbabceea8645057c758bbdfdc0bedaaab9 Not sure why the graphs in #2 are missing data outside that date range, but it's safe to assume they can be discarded (most likely also recovered, but no way to verify). This doesn't leave much to investigate, closing. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by alexclarke@chromium.org
, Apr 19 2017