New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 713095 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Sep 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1%-6.7% regression in system_health.memory_mobile at 463572:463774

Project Member Reported by alexclarke@chromium.org, Apr 19 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Apr 21 2017


=== BISECT JOB RESULTS ===
NO Perf regression found, tests failed to produce values

Bisect Details
  Configuration: android_webview_arm64_aosp_perf_bisect
  Benchmark    : system_health.memory_mobile
  Metric       : memory:chrome:all_processes:reported_by_os:system_memory:java_heap:proportional_resident_size_avg/load_news/load_news_qq


Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=load.news.qq system_health.memory_mobile

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8981888370349803600

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5906032418619392


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Apr 23 2017


=== BISECT JOB RESULTS ===
NO Perf regression found, tests failed to produce values

Bisect Details
  Configuration: android_webview_arm64_aosp_perf_bisect
  Benchmark    : system_health.memory_mobile
  Metric       : memory:chrome:all_processes:reported_by_os:system_memory:java_heap:proportional_resident_size_avg/load_news/load_news_qq


Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=load.news.qq system_health.memory_mobile

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8981704971521989936

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5906032418619392


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Project Member

Comment 7 by 42576172...@developer.gserviceaccount.com, Apr 24 2017

Cc: littledan@chromium.org
Owner: littledan@chromium.org

=== Auto-CCing suspected CL author littledan@chromium.org ===

Hi littledan@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : littledan
  Commit : 38c5394ccb50a9e87cda5ab297fba34a36387276
  Date   : Tue Apr 11 12:51:41 2017
  Subject: [intl] Fix NumberFormat options handling spec compliance issues

Bisect Details
  Configuration: android_nexus6_perf_bisect
  Benchmark    : system_health.memory_mobile
  Metric       : memory:chrome:all_processes:reported_by_chrome:v8:effective_size_avg/load_news/load_news_hackernews
  Change       : 2.34% | 2204516.0 -> 2256068.0

Revision                           Result                  N
chromium@463697                    2204516 +- 0.0          6      good
chromium@463700                    2204516 +- 0.0          6      good
chromium@463700,v8@790b2d341c      2201743 +- 15190.2      6      good
chromium@463700,v8@7deb682187      2201743 +- 15190.2      6      good
chromium@463700,v8@38c5394ccb      2258765 +- 26562.7      6      bad       <--
chromium@463700,v8@30439676db      2261615 +- 14207.4      6      bad
chromium@463701                    2258841 +- 26562.7      6      bad
chromium@463702                    2265716 +- 0.0          6      bad
chromium@463707                    2265716 +- 0.0          6      bad
chromium@463717                    2263665 +- 11232.0      6      bad
chromium@463736                    2256068 +- 26599.4      6      bad
chromium@463774                    2256068 +- 33421.7      6      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=load.news.hackernews system_health.memory_mobile

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8981432664592928096

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5906032418619392


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Status: Assigned (was: Untriaged)
Explictly assigning. A CL you landed tripped one of the speed metrics we measure in the lab. If this is the first time this has happened to one of your CLs, or if it's been a while, please read: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/addressing_performance_regressions.md

We're looking for one of the following:
1. Justification via explanation
2. Plan to revert or fix
3. Angry rage throwing of equipment at my head

Just be aware that I'm trained in trumpet playing and First Aid and am not afraid to use it.

Note: This was a bulk edit message and not very personal.
Status: WontFix (was: Assigned)
Original CL author did not respond, and it's been months :(

Fortunately, this looks like a small regression so closing.

Sign in to add a comment