Issue metadata
Sign in to add a comment
|
1.6%-2% regression in memory.top_10_mobile_stress at 464868:464873 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Apr 19 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8981888467428263216
,
Apr 19 2017
=== Auto-CCing suspected CL author adamk@chromium.org === Hi adamk@chromium.org, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : Adam Klein Commit : a9e04c5ff1efb01cee4e3aa3c0a6e480f6451111 Date : Fri Apr 14 22:49:55 2017 Subject: Move setup of Object.prototype.toString to bootstrapper Bisect Details Configuration: android_nexus7_perf_bisect Benchmark : memory.top_10_mobile_stress Metric : memory:chrome:all_processes:reported_by_chrome:v8:effective_size_avg/background/after_http_search_yahoo_com_search__ylt_p_google Change : 5.21% | 5832214.0 -> 6136082.0 Revision Result N chromium@464867 5832214 +- 35836.7 6 good chromium@464870 5876776 +- 334681 9 good chromium@464871 5905228 +- 400337 14 good chromium@464871,v8@d9f6dd896c 5886262 +- 329178 9 good chromium@464871,v8@dc83caa6fb 5902626 +- 252436 9 good chromium@464871,v8@e8cfc5b7ca 5893276 +- 367328 14 good chromium@464871,v8@003f818ac5 5989771 +- 597226 14 good chromium@464871,v8@a9e04c5ff1 6162879 +- 360485 14 bad <-- chromium@464871,v8@c5aad5f284 6142063 +- 431622 14 bad chromium@464872 6153935 +- 313966 9 bad chromium@464873 6136082 +- 299851 6 bad Please refer to the following doc on diagnosing memory regressions: https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md To Run This Test src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests memory.top_10_mobile_stress Debug Info https://chromeperf.appspot.com/buildbucket_job_status/8981888467428263216 Is this bisect wrong? https://chromeperf.appspot.com/bad_bisect?try_job_id=5854726886785024 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Speed>Bisection. Thank you!
,
Apr 19 2017
This benchmark seems to have recovered somewhat since my change. I also suspect my change simply changed some allocation ordering, nothing fundamental (I didn't add anything that wasn't in memory already). Marking as WontFix, feel free to reopen if you feel that's inappropriate for some reason. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by alexclarke@chromium.org
, Apr 19 2017