New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 713086 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Apr 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

12.1% regression in speedometer at 464689:464734

Project Member Reported by alexclarke@chromium.org, Apr 19 2017

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=713086

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDggv-BngkM


Bot(s) for this bug's original alert(s):

win-zenbook
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Apr 19 2017


=== BISECT JOB RESULTS ===
NO Perf regression found

Bisect Details
  Configuration: winx64_zen_perf_bisect
  Benchmark    : speedometer
  Metric       : Total/Total

Revision             Result                  N
chromium@464688      7092.64 +- 256.442      21      good
chromium@464734      7195.94 +- 1462.2       21      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests speedometer

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8981888494703376560

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5779699176833024


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Apr 19 2017

Cc: sungmann...@navercorp.com
Owner: sungmann...@navercorp.com

=== Auto-CCing suspected CL author sungmann.cho@navercorp.com ===

Hi sungmann.cho@navercorp.com, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : sungmann.cho
  Commit : d1040f6d95719c52a3ec442c76be29d5c0630bf4
  Date   : Fri Apr 14 07:28:34 2017
  Subject: [Mac] The infobar's top arrow should be hidden while the omnibox popup is shown

Bisect Details
  Configuration: winx64_zen_perf_bisect
  Benchmark    : speedometer
  Metric       : Total/Total
  Change       : 7.67% | 5332.2765 -> 5741.12466667

Revision             Result                  N
chromium@464688      5332.28 +- 78.0767      6      good
chromium@464694      5460.88 +- 141.751      6      good
chromium@464697      5515.82 +- 882.793      9      good
chromium@464699      5567.72 +- 84.5217      6      good
chromium@464700      6043.87 +- 656.864      6      bad       <--
chromium@464711      5868.99 +- 188.664      6      bad
chromium@464734      5741.12 +- 857.827      6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests speedometer

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8981876818319204976

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5779699176833024


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
First of all, this is the first time to receive a perf regression mail, so I
don't know what I have to do to fix this. The suspected patch
(https://codereview.chromium.org/2196203002) is 100% macOS-only. I'm wondering
how the macOS-only patch can cause performance degradation on Windows.
Cc: rsesek@chromium.org
@rsesek: Could you please help me resolve this issue?
Owner: ----
Status: WontFix (was: Untriaged)
Sorry about this! Looking at the graph and the numbers from the bisect in #5, the test is very noisy, and the reference build moves up and down with ToT. I don't think this is a real regression. I think it only blamed the patch because the noisy test happened to spike at r464700, and happened to have higher results after that, but the overall numbers don't look convincing that there is a real regression.

Sign in to add a comment