New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 713050 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Under invalidation of container's backgrounds when cell changes geometry

Project Member Reported by yhirano@chromium.org, Apr 19 2017

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Apr 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8394028f0c1d57def2917345e79b68ffa6b87803

commit 8394028f0c1d57def2917345e79b68ffa6b87803
Author: yhirano <yhirano@chromium.org>
Date: Wed Apr 19 11:06:17 2017

Mark color-profile-reflection.html and  bug113424 .html as flaky

BUG=713049,  713050 
TBR=kouhei@chromium.org

NOTRY=true

Review-Url: https://codereview.chromium.org/2823303004
Cr-Commit-Position: refs/heads/master@{#465552}

[modify] https://crrev.com/8394028f0c1d57def2917345e79b68ffa6b87803/third_party/WebKit/LayoutTests/TestExpectations

Comment 2 by shans@chromium.org, Apr 20 2017

Labels: Update-Fortnightly

Comment 3 by suzyh@chromium.org, Apr 20 2017

Components: -Blink>CSS -Blink>Layout Blink>Layout>Table
Status: Untriaged (was: Available)
Looking at the images diff for an arbitrary failure of this test, some vertical table boundaries are in the wrong place. It doesn't seem to be a delay in image loading, since the output includes the same images. Layout folks, would you mind taking a pass over this?

Comment 4 by e...@chromium.org, Apr 24 2017

Owner: dgro...@chromium.org
Status: Assigned (was: Untriaged)
Possibly dupe of issue 666730.
Cc: dgro...@chromium.org
Owner: robhogan@chromium.org
I've got this.
A simpler test is attached. The cause is that we missed invalidation of row (and other containers) background when cell geometry changes.
td.html
257 bytes View Download
Components: -Blink>Layout>Table Blink>Paint>Invalidation
Labels: -Type-Bug -Pri-3 ReleaseBlock-Stable M-59 Pri-1 Type-Bug-Regression
I think this is a regression caused by my https://codereview.chromium.org/2786463004/.

robhogan@ feel free to assign to me if you would like me to fix it.

Cc: robhogan@chromium.org
Owner: wangxianzhu@chromium.org
Sounds like you have a patch all but written! If you don't get to it I'll pick it up in a few days.
Summary: Under invalidation of container's backgrounds when cell changes geometry (was: Layout Test tables/mozilla/bugs/bug113424.html is flaky)
Project Member

Comment 11 by bugdroid1@chromium.org, Apr 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/91f1e343eb3fcc6694c740548e2928519b0350f3

commit 91f1e343eb3fcc6694c740548e2928519b0350f3
Author: wangxianzhu <wangxianzhu@chromium.org>
Date: Fri Apr 28 17:58:40 2017

Invalidate row/section for backgrounds when cell's geometry changes

https://codereview.chromium.org/2786463004/ caused the regression.
Now we paint cell's container backgrounds as display item of row/section
instead of cell, so when cell's geometry changes we need to invalidate
the container's backgrounds.

BUG= 713050 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2851553002
Cr-Commit-Position: refs/heads/master@{#468056}

[add] https://crrev.com/91f1e343eb3fcc6694c740548e2928519b0350f3/third_party/WebKit/LayoutTests/paint/invalidation/table/container-backgrounds-on-cell-resize-expected.html
[add] https://crrev.com/91f1e343eb3fcc6694c740548e2928519b0350f3/third_party/WebKit/LayoutTests/paint/invalidation/table/container-backgrounds-on-cell-resize.html
[modify] https://crrev.com/91f1e343eb3fcc6694c740548e2928519b0350f3/third_party/WebKit/Source/core/layout/LayoutTableCell.cpp
[modify] https://crrev.com/91f1e343eb3fcc6694c740548e2928519b0350f3/third_party/WebKit/Source/core/layout/LayoutTableCell.h
[modify] https://crrev.com/91f1e343eb3fcc6694c740548e2928519b0350f3/third_party/WebKit/Source/core/paint/BUILD.gn
[add] https://crrev.com/91f1e343eb3fcc6694c740548e2928519b0350f3/third_party/WebKit/Source/core/paint/TableCellPaintInvalidator.cpp
[add] https://crrev.com/91f1e343eb3fcc6694c740548e2928519b0350f3/third_party/WebKit/Source/core/paint/TableCellPaintInvalidator.h

Labels: Merge-Request-59
Project Member

Comment 13 by sheriffbot@chromium.org, Apr 29 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 14 by bugdroid1@chromium.org, May 1 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b8e291ddfeaafc8efa847d11ff89f3db2b027ed

commit 6b8e291ddfeaafc8efa847d11ff89f3db2b027ed
Author: wangxianzhu <wangxianzhu@chromium.org>
Date: Mon May 01 16:15:51 2017

Invalidate row/section for backgrounds when cell's geometry changes

https://codereview.chromium.org/2786463004/ caused the regression.
Now we paint cell's container backgrounds as display item of row/section
instead of cell, so when cell's geometry changes we need to invalidate
the container's backgrounds.

BUG= 713050 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2851553002
Cr-Commit-Position: refs/heads/master@{#468056}
TBR=wangxianzhu@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2854623002
Cr-Commit-Position: refs/branch-heads/3071@{#323}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[add] https://crrev.com/6b8e291ddfeaafc8efa847d11ff89f3db2b027ed/third_party/WebKit/LayoutTests/paint/invalidation/table/container-backgrounds-on-cell-resize-expected.html
[add] https://crrev.com/6b8e291ddfeaafc8efa847d11ff89f3db2b027ed/third_party/WebKit/LayoutTests/paint/invalidation/table/container-backgrounds-on-cell-resize.html
[modify] https://crrev.com/6b8e291ddfeaafc8efa847d11ff89f3db2b027ed/third_party/WebKit/Source/core/layout/LayoutTableCell.cpp
[modify] https://crrev.com/6b8e291ddfeaafc8efa847d11ff89f3db2b027ed/third_party/WebKit/Source/core/layout/LayoutTableCell.h
[modify] https://crrev.com/6b8e291ddfeaafc8efa847d11ff89f3db2b027ed/third_party/WebKit/Source/core/paint/BUILD.gn
[add] https://crrev.com/6b8e291ddfeaafc8efa847d11ff89f3db2b027ed/third_party/WebKit/Source/core/paint/TableCellPaintInvalidator.cpp
[add] https://crrev.com/6b8e291ddfeaafc8efa847d11ff89f3db2b027ed/third_party/WebKit/Source/core/paint/TableCellPaintInvalidator.h

Status: Fixed (was: Assigned)
Project Member

Comment 16 by bugdroid1@chromium.org, May 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2fb6d3be1ab6a20735406528fecb19ec718ae110

commit 2fb6d3be1ab6a20735406528fecb19ec718ae110
Author: qyearsley <qyearsley@chromium.org>
Date: Tue May 16 02:09:01 2017

Remove flaky expectations for tests that no longer appear flaky.

Again, done with update-test-expectations.

Flakiness dashboard:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&tests=virtual/gpu/fast/canvas/painting-on-bad-canvas.html,fast/events/message-port-start-and-close-different-microtask.html,virtual/mojo-loading/http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-overridesexpires.html,virtual/threaded/animations/display-inline-style-adjust.html,fast/selectors/007a.html,http/tests/workers/terminate-during-sync-operation-file.html,virtual/mojo-loading/http/tests/workers/terminate-during-sync-operation-file.html,virtual/threaded/inspector/tracing/decode-resize.html,external/wpt/service-workers/service-worker/fetch-canvas-tainting.https.html,external/wpt/service-workers/service-worker/fetch-cors-xhr.https.html,external/wpt/service-workers/service-worker/fetch-csp.https.html,external/wpt/service-workers/service-worker/fetch-event-async-respond-with.https.html,external/wpt/service-workers/service-worker/fetch-event-respond-with-stops-propagation.https.html,external/wpt/service-workers/service-worker/fetch-request-css-base-url.https.html,external/wpt/service-workers/service-worker/fetch-response-xhr.https.html,external/wpt/service-workers/service-worker/getregistrations.https.html,http/tests/security/link-crossorigin-preload-no-cors.html,virtual/mojo-loading/http/tests/inspector/tracing/timeline-script-parse.html,tables/mozilla/bugs/bug113424.html,fast/backgrounds/background-image-relative-url-in-iframe.html,crypto/subtle/worker-subtle-crypto-concurrent.html,fast/workers/termination-early.html,fast/dnd/dropEffect-for-effectAllowed.html

BUG= 404597 , 520174 , 520194 , 596752 , 619539 , 619539 , 638693 , 658997 ,664839, 678489 , 708934 , 713050 ,713419, 713509 , 713685 , 719298 

Review-Url: https://codereview.chromium.org/2884793002
Cr-Commit-Position: refs/heads/master@{#471981}

[modify] https://crrev.com/2fb6d3be1ab6a20735406528fecb19ec718ae110/third_party/WebKit/LayoutTests/TestExpectations

Sign in to add a comment