The following layout test is flaky images/color-profile-reflection.html https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&tests=images%2Fcolor-profile-reflection.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8394028f0c1d57def2917345e79b68ffa6b87803 commit 8394028f0c1d57def2917345e79b68ffa6b87803 Author: yhirano <yhirano@chromium.org> Date: Wed Apr 19 11:06:17 2017 Mark color-profile-reflection.html and bug113424 .html as flaky BUG=713049, 713050 TBR=kouhei@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2823303004 Cr-Commit-Position: refs/heads/master@{#465552} [modify] https://crrev.com/8394028f0c1d57def2917345e79b68ffa6b87803/third_party/WebKit/LayoutTests/TestExpectations
Looks like we need to wait for a repaint, rather than use setTimeout. When it fails we are displaying nothing.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3182feed58c8d7838cf85f3f4b620606ea06f7a5 commit 3182feed58c8d7838cf85f3f4b620606ea06f7a5 Author: schenney <schenney@chromium.org> Date: Thu Apr 20 20:51:57 2017 Update TestExpectations and rebase some tests. Try reducing flakes for images/color-profile-reflection.html by switching to runAfterLayoutAndPaint. Rebaseline canvas drawing tests after path tesselation patch landed. Remove expectations for no-longer-failing images/color-profile-reflection.html and virtual/gpu/fast/canvas/canvas-ImageData-neutered-source.html TBR=junov@chromium.org BUG= 642376 , 706375 ,713049, 713462 Review-Url: https://codereview.chromium.org/2831953002 Cr-Commit-Position: refs/heads/master@{#466120} [modify] https://crrev.com/3182feed58c8d7838cf85f3f4b620606ea06f7a5/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/3182feed58c8d7838cf85f3f4b620606ea06f7a5/third_party/WebKit/LayoutTests/images/color-profile-reflection.html [modify] https://crrev.com/3182feed58c8d7838cf85f3f4b620606ea06f7a5/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/canvas-arc-circumference-expected.png [modify] https://crrev.com/3182feed58c8d7838cf85f3f4b620606ea06f7a5/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/canvas-incremental-repaint-expected.png [delete] https://crrev.com/e8227a0e1c5fc7f230fe575086e1816a4e9fa6ae/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/gpu/fast/canvas/canvas-arc-circumference-expected.png [delete] https://crrev.com/e8227a0e1c5fc7f230fe575086e1816a4e9fa6ae/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/gpu/fast/canvas/canvas-arc-circumference-fill-expected.png [delete] https://crrev.com/e8227a0e1c5fc7f230fe575086e1816a4e9fa6ae/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/gpu/fast/canvas/canvas-ellipse-circumference-expected.png [delete] https://crrev.com/e8227a0e1c5fc7f230fe575086e1816a4e9fa6ae/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/gpu/fast/canvas/canvas-ellipse-circumference-fill-expected.png [delete] https://crrev.com/e8227a0e1c5fc7f230fe575086e1816a4e9fa6ae/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/gpu/fast/canvas/canvas-incremental-repaint-expected.png [delete] https://crrev.com/e8227a0e1c5fc7f230fe575086e1816a4e9fa6ae/third_party/WebKit/LayoutTests/platform/mac-retina/virtual/gpu/fast/canvas/canvas-arc-circumference-expected.png [delete] https://crrev.com/e8227a0e1c5fc7f230fe575086e1816a4e9fa6ae/third_party/WebKit/LayoutTests/platform/mac-retina/virtual/gpu/fast/canvas/canvas-arc-circumference-fill-expected.png [delete] https://crrev.com/e8227a0e1c5fc7f230fe575086e1816a4e9fa6ae/third_party/WebKit/LayoutTests/platform/mac-retina/virtual/gpu/fast/canvas/canvas-ellipse-circumference-expected.png [delete] https://crrev.com/e8227a0e1c5fc7f230fe575086e1816a4e9fa6ae/third_party/WebKit/LayoutTests/platform/mac-retina/virtual/gpu/fast/canvas/canvas-ellipse-circumference-fill-expected.png [delete] https://crrev.com/e8227a0e1c5fc7f230fe575086e1816a4e9fa6ae/third_party/WebKit/LayoutTests/platform/mac-retina/virtual/gpu/fast/canvas/canvas-incremental-repaint-expected.png [add] https://crrev.com/3182feed58c8d7838cf85f3f4b620606ea06f7a5/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu/fast/canvas/canvas-arc-circumference-expected.png [delete] https://crrev.com/e8227a0e1c5fc7f230fe575086e1816a4e9fa6ae/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu/fast/canvas/canvas-arc-circumference-fill-expected.png [modify] https://crrev.com/3182feed58c8d7838cf85f3f4b620606ea06f7a5/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu/fast/canvas/canvas-incremental-repaint-expected.png [modify] https://crrev.com/3182feed58c8d7838cf85f3f4b620606ea06f7a5/third_party/WebKit/LayoutTests/platform/win/virtual/gpu/fast/canvas/canvas-arc-circumference-expected.png [delete] https://crrev.com/e8227a0e1c5fc7f230fe575086e1816a4e9fa6ae/third_party/WebKit/LayoutTests/platform/win/virtual/gpu/fast/canvas/canvas-arc-circumference-fill-expected.png [delete] https://crrev.com/e8227a0e1c5fc7f230fe575086e1816a4e9fa6ae/third_party/WebKit/LayoutTests/platform/win/virtual/gpu/fast/canvas/canvas-ellipse-circumference-expected.png [delete] https://crrev.com/e8227a0e1c5fc7f230fe575086e1816a4e9fa6ae/third_party/WebKit/LayoutTests/platform/win/virtual/gpu/fast/canvas/canvas-ellipse-circumference-fill-expected.png [modify] https://crrev.com/3182feed58c8d7838cf85f3f4b620606ea06f7a5/third_party/WebKit/LayoutTests/platform/win/virtual/gpu/fast/canvas/canvas-incremental-repaint-expected.png [delete] https://crrev.com/e8227a0e1c5fc7f230fe575086e1816a4e9fa6ae/third_party/WebKit/LayoutTests/virtual/gpu/fast/canvas/canvas-arc-circumference-expected.png [add] https://crrev.com/3182feed58c8d7838cf85f3f4b620606ea06f7a5/third_party/WebKit/LayoutTests/virtual/gpu/fast/canvas/canvas-arc-circumference-fill-expected.png [modify] https://crrev.com/3182feed58c8d7838cf85f3f4b620606ea06f7a5/third_party/WebKit/LayoutTests/virtual/gpu/fast/canvas/canvas-ellipse-circumference-expected.png [modify] https://crrev.com/3182feed58c8d7838cf85f3f4b620606ea06f7a5/third_party/WebKit/LayoutTests/virtual/gpu/fast/canvas/canvas-ellipse-circumference-fill-expected.png
Not sure if the above change helped. Making the test runAfterLayoutAndPaint seems harmless though. Note a subsequent change [1] added two levels of runAfterLayoutAndPaint to the color-profile-reflection.html test. I'm pretty sure we only need one level and I've uploaded a patch to remove the extra level if you'd like to review: https://chromium-review.googlesource.com/c/558540/ [1] https://chromium.googlesource.com/chromium/src/+/f83728155df4b26ad4cd2eed5238eb109b74c609
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/15f30857bfb843416d4fc0760031563e28e95d22 commit 15f30857bfb843416d4fc0760031563e28e95d22 Author: Noel Gordon <noel@chromium.org> Date: Fri Jul 07 23:32:51 2017 color-profile-reflection: try using one level of runAfterLayoutAndPaint Test is using two levels of runAfterLayoutAndPaint and is failing on the some bots (see bug 713049). Try using one runAfterLayoutAndPaint since that's all that should be needed after changing the element box-reflection CSS style. Bug: 713049 Change-Id: I448b6908044786cb9da45945b2aed370336c1353 Reviewed-on: https://chromium-review.googlesource.com/558540 Reviewed-by: Stephen Chenney <schenney@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#485101} [modify] https://crrev.com/15f30857bfb843416d4fc0760031563e28e95d22/third_party/WebKit/LayoutTests/images/color-profile-reflection.html
setTimeout removed, runAfterLayoutAndPaint added, but no joy. Something else is causing the result-not-painted problem, best I can tell.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/57f97ecf23621874edbb0092b44b57b28914ba86 commit 57f97ecf23621874edbb0092b44b57b28914ba86 Author: Alexei Filippov <alph@chromium.org> Date: Tue Jul 18 18:16:12 2017 Update virtual/gpu-rasterization/images/color-profile-reflection.html expectations NOTRY=true TBR=rogerta Bug: 713049 Change-Id: I33dbfdd3de58f03472d95f42abd60977f2749a0b Reviewed-on: https://chromium-review.googlesource.com/576254 Reviewed-by: Alexei Filippov <alph@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#487527} [modify] https://crrev.com/57f97ecf23621874edbb0092b44b57b28914ba86/third_party/WebKit/LayoutTests/TestExpectations
Comment 1 by bugdroid1@chromium.org
, Apr 19 2017