New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 713046 link

Starred by 1 user
Status: Fixed
Owner:
█ dschuyler@chromium.org
Last visit > 30 days ago
Closed: Apr 2017
Cc:
nyerramilli@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Iron Icon appears small in size on changing browser language on chrome://md-settings/siteSettings.

Reported by aiman.an...@etouch.net, Apr 19 2017 
Chrome Version: 58.0.3029.81 (Official Build) ac0bae59f0aa5b391517e132bf172144b1939333-refs/branch-heads/3029@{#746}(32/64 Bit).

OS:  Windows(7,8,10).

Steps to reproduce:
1.Launch Chrome, go to chrome://md-settings, change browser language to 'Greek' from chrome://md-settings/languages.
2.Relaunch chrome, go to chrome://md-settings/appearacne and change Font Size to 'Very Large' .
3.Go to chrome://md-settings/siteSettings, scroll down and observe the iron icons.


Actual Result: Iron Icon appears small in size.
Expected Result: Iron Icon should appear in regular form.

This is regression issue broken in 'M 55' and will soon update the bisect info:

Manual Bisect Info: 
Good Build 55.0.2846.0
Bad Build 55.0.2847.0

Note: Issue is not reproducible on MAC and LINUX OS.
Result.png
101 KB View Download

Comment 1 by jmukthavaram@chromium.org, Apr 19 2017

Labels: -Pri-2 -M-58 hasbisect-per-revision M-60 Pri-1
Owner: dschuyler@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue in Windows 7 using latest Canary #60.0.3074.0
Manual Bisect:
--------------
Good Build 55.0.2846.0-Revision-415833
Bad Build 55.0.2847.0-Revision-416149

Per revision bisect info:
------------------------
You are probably looking for a change made after 416116 (known good), but no later than 416117 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspectas some perf builds might get missing due to failure.
https://chromium.googlesource.com/chromium/src/+log/8ad01a3783fd1655ef91b93a62fb854951ba5e16..05b5db68bf23918ab865837f1720525e11f3c72f

Review-Url: https://codereview.chromium.org/2297663003
@dschuyler- Kindly take a look and please help us to reassign this issue to a right owner if not with respect to this change.
Thanks..!!

Comment 2 by jmukthavaram@chromium.org, Apr 19 2017

Labels: Proj-MaterialDesign-WebUI

Comment 3 by dschuyler@chromium.org, Apr 19 2017

Status: Started (was: Assigned)
CL at https://codereview.chromium.org/2830993002/
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64baf346da1faee0f9779b681c67f74c810dfe5b

commit 64baf346da1faee0f9779b681c67f74c810dfe5b
Author: dschuyler <dschuyler@chromium.org>
Date: Thu Apr 20 19:34:15 2017

[MD settings] Prevent distortion of icons in cramped UI

This CL is a CSS change to stop iron-icons from shrinking when the UI
becomes crowded.

BUG= 713046 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2830993002
Cr-Commit-Position: refs/heads/master@{#466092}

[modify] https://crrev.com/64baf346da1faee0f9779b681c67f74c810dfe5b/chrome/browser/resources/settings/settings_shared_css.html

Comment 5 by dschuyler@chromium.org, Apr 20 2017

Status: Fixed (was: Started)

Comment 6 by jmukthavaram@chromium.org, Apr 26 2017

Labels: TE-Verified-M60 TE-Verified-60.0.3080.5
Tested the issue on windows 7 using chrome version# 60.0.3080.5 with the steps mentioned in comment #0.Observed that the Iron Icons are displayed normal in size in chrome://md-settings/siteSettings page after changing the language to Greek.As it is working as intended ,adding TE-Verified labels.

Please find the attached screenshot for the same.
Thanks!!
713046.PNG
211 KB View Download
►

Sign in to add a comment