New issue
Advanced search Search tips

Issue 713018 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Task



Sign in to add a comment

Rename Worklet.import() to Worklet.addModule()

Project Member Reported by nhiroki@chromium.org, Apr 19 2017

Issue description

Hi Nhiroki,

I would like to work on this , please let me know if I can check this.

Thanks.
Owner: nhiroki@chromium.org
Status: Started (was: Available)
nikhil.sahni@: Yes, you can! :)

Let me tentatively assign this issue to myself because apparently you don't have a bug-edit permission yet.
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71e2c38925b47383e6a7f3fafe7296d99d8baa1c

commit 71e2c38925b47383e6a7f3fafe7296d99d8baa1c
Author: nikhil.sahni <nikhil.sahni@samsung.com>
Date: Fri Apr 21 07:07:37 2017

Rename Worklet.import() to Worklet.addModule().

Rename Worklet.import() to Worklet.addModule()
as per spec change : https://github.com/w3c/
css-houdini-drafts/issues/374.

BUG= 713018 

Review-Url: https://codereview.chromium.org/2826983002
Cr-Commit-Position: refs/heads/master@{#466279}

[modify] https://crrev.com/71e2c38925b47383e6a7f3fafe7296d99d8baa1c/third_party/WebKit/LayoutTests/csspaint/resources/test-runner-geometry-logging.js
[modify] https://crrev.com/71e2c38925b47383e6a7f3fafe7296d99d8baa1c/third_party/WebKit/LayoutTests/csspaint/resources/test-runner-invalidation-logging.js
[modify] https://crrev.com/71e2c38925b47383e6a7f3fafe7296d99d8baa1c/third_party/WebKit/LayoutTests/csspaint/resources/test-runner-paint-helper.js
[modify] https://crrev.com/71e2c38925b47383e6a7f3fafe7296d99d8baa1c/third_party/WebKit/LayoutTests/csspaint/resources/test-runner-paint-worklet.js
[modify] https://crrev.com/71e2c38925b47383e6a7f3fafe7296d99d8baa1c/third_party/WebKit/LayoutTests/csspaint/valid-image-after-load.html
[modify] https://crrev.com/71e2c38925b47383e6a7f3fafe7296d99d8baa1c/third_party/WebKit/LayoutTests/csspaint/valid-image-before-load.html
[modify] https://crrev.com/71e2c38925b47383e6a7f3fafe7296d99d8baa1c/third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/worklet-import-blocked.html
[modify] https://crrev.com/71e2c38925b47383e6a7f3fafe7296d99d8baa1c/third_party/WebKit/LayoutTests/http/tests/worklet/chromium/import-on-detached-iframe.html
[modify] https://crrev.com/71e2c38925b47383e6a7f3fafe7296d99d8baa1c/third_party/WebKit/LayoutTests/http/tests/worklet/resources/import-tests.js
[modify] https://crrev.com/71e2c38925b47383e6a7f3fafe7296d99d8baa1c/third_party/WebKit/LayoutTests/http/tests/worklet/webexposed/global-interface-listing-paint-worklet.html
[modify] https://crrev.com/71e2c38925b47383e6a7f3fafe7296d99d8baa1c/third_party/WebKit/LayoutTests/inspector/console/console-on-paint-worklet.html
[modify] https://crrev.com/71e2c38925b47383e6a7f3fafe7296d99d8baa1c/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/71e2c38925b47383e6a7f3fafe7296d99d8baa1c/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/71e2c38925b47383e6a7f3fafe7296d99d8baa1c/third_party/WebKit/Source/core/workers/MainThreadWorklet.cpp
[modify] https://crrev.com/71e2c38925b47383e6a7f3fafe7296d99d8baa1c/third_party/WebKit/Source/core/workers/MainThreadWorklet.h
[modify] https://crrev.com/71e2c38925b47383e6a7f3fafe7296d99d8baa1c/third_party/WebKit/Source/core/workers/ThreadedWorklet.cpp
[modify] https://crrev.com/71e2c38925b47383e6a7f3fafe7296d99d8baa1c/third_party/WebKit/Source/core/workers/ThreadedWorklet.h
[modify] https://crrev.com/71e2c38925b47383e6a7f3fafe7296d99d8baa1c/third_party/WebKit/Source/core/workers/Worklet.h
[modify] https://crrev.com/71e2c38925b47383e6a7f3fafe7296d99d8baa1c/third_party/WebKit/Source/core/workers/Worklet.idl

Labels: M-60
Status: Fixed (was: Started)
Thank you :)

Comment 6 Deleted

Sign in to add a comment