Issue 713009 link

Starred by 2 users

Issue metadata

Status:	Fixed
Owner:	cjgrant@chromium.org
Closed:	Aug 2017
Components:	Blink>WebXR
EstimatedDays:	----
NextAction:	----
OS:	Windows
Pri:	2
Type:	Bug
Arch-x86_64 Proj-VR VR-Desktop Via-Wizard-API
Proj-XR

Double listing of vr_export.h in device/vr/BUILD.gn

Reported by ningxin...@intel.com, Apr 19 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3075.0 Safari/537.36

Steps to reproduce the problem:
vr_export.h is listed in both

https://chromium.googlesource.com/chromium/src/+/master/device/vr/BUILD.gn#26

and 

https://chromium.googlesource.com/chromium/src/+/master/device/vr/BUILD.gn#49

What is the expected behavior?
It should be listed once

What went wrong?
It is listed twice. It causes Visual Studio fail to load vr project generated by "gn gen --ide=vs".

Did this work before? N/A 

Does this work in other browsers? N/A

Chrome version: 60.0.3075.0  Channel: n/a
OS Version: 10.0
Flash Version:

Project Member

Comment 1 by bugdroid1@chromium.org, Apr 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/11dd1d920e974ab8734ef9808f8001cf03f18dcb

commit 11dd1d920e974ab8734ef9808f8001cf03f18dcb
Author: ningxin.hu <ningxin.hu@intel.com>
Date: Wed Apr 19 15:44:54 2017

Fix double listing of vr_export.h in BUILD.gn

BUG= 713009 

Review-Url: https://codereview.chromium.org/2829463004
Cr-Commit-Position: refs/heads/master@{#465620}

[modify] https://crrev.com/11dd1d920e974ab8734ef9808f8001cf03f18dcb/device/vr/BUILD.gn