Hide cold mode idle time spellchecker behind a flag |
||
Issue descriptionThe two modes of idle time spellchecker are very different: Hot mode does everything that the existing spellchecker is supposed to do, so it can be considered as a re-architecture of an existing component. It's also considered as an important performance optimization. Cold mode introduces new behavior, so it should be considered as a new feature. It has nothing to do with performance optimization for the existing spellchecker. Hence, we shouldn't bind and ship them together. It's better to experiment and ship them separately. So we should hide cold mode behind a flag.
,
Apr 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/234a68c81bb610d29c3bcabc08dcd4485ee58f06 commit 234a68c81bb610d29c3bcabc08dcd4485ee58f06 Author: xiaochengh <xiaochengh@chromium.org> Date: Thu Apr 20 01:49:00 2017 Hide cold mode idle time spellchecker behind a flag This patch adds a new runtime flag IdleTimeColdModeSpellChecking, so that idle time spellchecker enters cold mode only when the flag is enabled --- otherwise it enters the inactive state instead. The unit tests are modified accordingly so that the lifecycle transition without the flag is also tested. The purpose of the new flag is for shipping hot and cold modes of idle time spellchecker separately. BUG= 713006 Review-Url: https://codereview.chromium.org/2827903002 Cr-Commit-Position: refs/heads/master@{#465855} [modify] https://crrev.com/234a68c81bb610d29c3bcabc08dcd4485ee58f06/third_party/WebKit/Source/core/editing/spellcheck/IdleSpellCheckCallback.cpp [modify] https://crrev.com/234a68c81bb610d29c3bcabc08dcd4485ee58f06/third_party/WebKit/Source/core/editing/spellcheck/IdleSpellCheckCallbackTest.cpp [modify] https://crrev.com/234a68c81bb610d29c3bcabc08dcd4485ee58f06/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5
,
Apr 20 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by xiaoche...@chromium.org
, Apr 19 2017