New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 712995 link

Starred by 1 user
Status: Fixed
Owner:
█ paezagon@chromium.org
Email to this user bounced
Closed: Apr 2017
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Weird code is seen in context menu in chrome://bookmarks.

Reported by avsha...@etouch.net, Apr 19 2017 
Chrome Version : 60.0.3074.0 (Official Build) 147bd1eedea8ce66f162faa43535d60137817d91-refs/heads/master@{#465085} 32/64 bit
OS : Windows (7,8,10), Mac (10.11.6, 10.12.1, 10.12), Linux (14.04 LTS)

What steps will reproduce the problem?
1. Launch chrome and navigate to chrome://bookmarks.
2. In 'Organize' section, right click in blank area and observe the first 3 options in context menu.

Actual : Weird code is seen for the first 3 options of context menu in chrome://bookmarks.

Expected : Context menu should show all options properly.

This is a regression issue broken in ‘M-60’, below is the Manual Regression range and will soon update other info.
Good build : 60.0.3073.0
Bad build : 60.0.3074.0
Actual_Bookmarks.mp4
786 KB View Download
Expected_Bookmarks.mp4
343 KB View Download

Comment 1 by rbasuvula@chromium.org, Apr 19 2017

Cc: rbasuvula@chromium.org
Labels: hasbisect-per-revision ReleaseBlock-Beta
Owner: paezagon@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build:60.0.3073.0 (Revision:464873).
Bad build:60.0.3074.0 (Revision:465085).

You are probably looking for a change made after 464948 (known good), but no later than 464949 (first known bad).

CHANGE-LOG URL:
---------------
https://chromium.googlesource.com/chromium/src/+log/e0122c897d6339f118cea81d8c0d196561892119..ae360640e5b0475e52f8cee25d755ce484faf6e4

From the CL above, assigning the issue to the concern owner

@paezagon : Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Review-Url:  https://codereview.chromium.org/2809003002
Note :Able to reproduce the issue in Win 10.0,Ubuntu 14.04 & Mac 10.12.3 and Able to reproduce in latest Canary #60.0.3074.0
Adding Release Block-Beta for this issue.Please remove if not the case.

Comment 2 by paezagon@chromium.org, Apr 19 2017

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c32cfc7c2ca9fbc0c289dba04d7878ea8a65d7e9

commit c32cfc7c2ca9fbc0c289dba04d7878ea8a65d7e9
Author: paezagon <paezagon@chromium.org>
Date: Thu Apr 20 17:16:13 2017

Fixing display issue in bookmark manager.

Splitting bookmark strings into two sets, the original strings and the new strings, because the original strings are still needed for the bookmark manager until how to get the pluralization to work is figured out.

BUG= 708815 ,  712995 

Review-Url: https://codereview.chromium.org/2828873003
Cr-Commit-Position: refs/heads/master@{#466038}

[modify] https://crrev.com/c32cfc7c2ca9fbc0c289dba04d7878ea8a65d7e9/chrome/app/bookmarks_strings.grdp
[modify] https://crrev.com/c32cfc7c2ca9fbc0c289dba04d7878ea8a65d7e9/chrome/browser/ui/bookmarks/bookmark_context_menu_controller.cc
[modify] https://crrev.com/c32cfc7c2ca9fbc0c289dba04d7878ea8a65d7e9/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge.mm
[modify] https://crrev.com/c32cfc7c2ca9fbc0c289dba04d7878ea8a65d7e9/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge_unittest.mm

Comment 4 by paezagon@chromium.org, Apr 20 2017

Status: Fixed (was: Started)

Comment 5 by sureshkumari@chromium.org, Apr 26 2017

Labels: TE-Verified-M60 TE-Verified-60.0.3080.5
Tested the issue on Windows-7,Mac-10.12.4 and Linux Ubuntu-14.04 using chrome version# 60.0.3080.5
Observed that the fix is working as expected. Hence adding TE-Verified labels.
Please find the attached screen cast for the same.

Thanks!!
712995.mp4
213 KB View Download
►

Sign in to add a comment