Crash in blink::FlatTreeTraversal::traverseChild |
||||||
Issue descriptionDetailed report: https://clusterfuzz.com/testcase?key=6281372445704192 Fuzzer: bj_broddelwerk Job Type: windows_syzyasan_chrome Platform Id: windows Crash Type: UNKNOWN Crash Address: 0x0000000b Crash State: blink::FlatTreeTraversal::traverseChild blink::FlatTreeTraversal::childAt blink::PositionIteratorAlgorithm<blink::EditingAlgorithm<blink::FlatTreeTraversa Memory Tool: SYZYASAN Regressed: https://clusterfuzz.com/revisions?job=windows_syzyasan_chrome&range=454233:454289 Reproducer Testcase: https://clusterfuzz.com/download/AMIfv96uMWMDfKvBnth0Z-O_jtTvlXlGE3oIEoi1AfPmpFjbVH6z-mIeiLXofXLH3FYSRHLgLVJanoveunW7citShu8JuHn4xuWXuJJK7DPGvvv5MuRSwSkPzUuEYo8xcAmubaUkqQv9tbHuptKUjU2vsFeBqDcJuKhXcCUfdrjqV4Bz1RTl4QLzm7rKiqb4hGyXE_qmQ0zt6x1BZq0OliFjT3zj7iW5a8fH0fbD2aodLtY4lYv6fxplQx6WCNqsnK4l4MfL_NN-fV2slAZGlM0dI8mCM6Y7KbqdjaYzP-mZKI3-kZUyAl5zHOIjLhP76no1ZnbZZni23YGS6mMnIDfyqGqcOhrL6n8wcPkYOK4eYwyxOGDC4K4?testcase_id=6281372445704192 Issue filed automatically. See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
,
Apr 26 2017
This looks like a gimme, null deref.
,
Apr 27 2017
Seems to be a dup as issue 702756 : canonicalizing a PositionInFlatTree of type AfterAnchor anchored at a child node of a shadow host. I think we should land the fix in crrev.com/2772233002.
,
Apr 27 2017
,
Apr 27 2017
Lower to Pri-2, since this issue caused by unusual HTML.
,
Apr 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0cbb9fc2999813a837b8ee0483f77e3879cc25e0 commit 0cbb9fc2999813a837b8ee0483f77e3879cc25e0 Author: xiaochengh <xiaochengh@chromium.org> Date: Thu Apr 27 15:04:10 2017 Stop flat tree selection canonicalization from using invalid positions There are some valid DOM positions (*) that do not have corresponding valid flat tree positions. This patch adds special handling of such DOM positions, so that when computing VisibleSelectionInFlatTree from SelectionInDOMTree, such positions are converted to NULL instead of invalid flat tree positions, so that the renderer does not crash. (*) If NODE is a direct child of a shadow host but is not distributed into the flat tree, NODE@BeforeAnchor and NODE@AfterAnchor are valid Position but invalid PositionInFlatTree. This patch handles these two kind of positions. BUG= 702756 , 709872 , 712984 TEST=FrameSelectionTest.SelectInvalidPositionInFlatTreeDoesntCrash Review-Url: https://codereview.chromium.org/2850443002 Cr-Commit-Position: refs/heads/master@{#467676} [modify] https://crrev.com/0cbb9fc2999813a837b8ee0483f77e3879cc25e0/third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp [modify] https://crrev.com/0cbb9fc2999813a837b8ee0483f77e3879cc25e0/third_party/WebKit/Source/core/editing/Position.cpp [modify] https://crrev.com/0cbb9fc2999813a837b8ee0483f77e3879cc25e0/third_party/WebKit/Source/core/editing/SelectionEditor.cpp
,
Apr 28 2017
With the fix landed, will redo next week.
,
Apr 29 2017
ClusterFuzz has detected this issue as fixed in range 456626:457730. Detailed report: https://clusterfuzz.com/testcase?key=6281372445704192 Fuzzer: bj_broddelwerk Job Type: windows_syzyasan_chrome Platform Id: windows Crash Type: UNKNOWN Crash Address: 0x0000000b Crash State: blink::FlatTreeTraversal::traverseChild blink::FlatTreeTraversal::childAt blink::PositionIteratorAlgorithm<blink::EditingAlgorithm<blink::FlatTreeTraversa Memory Tool: SYZYASAN Regressed: https://clusterfuzz.com/revisions?job=windows_syzyasan_chrome&range=454233:454289 Fixed: https://clusterfuzz.com/revisions?job=windows_syzyasan_chrome&range=456626:457730 Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6281372445704192 See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information. If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
,
Apr 29 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by msrchandra@chromium.org
, Apr 19 2017Components: Blink>Editing
Labels: Test-Predator-Correct-CLs M-58
Owner: yosin@chromium.org
Status: Assigned (was: Untriaged)