New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 712963 link

Starred by 4 users
Status: Fixed
Owner:
slangley@chromium.org
Closed: Aug 2017
Cc:
█ sashab@chromium.org
haraken@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 353585
issue 715382
issue 734450
Blocking:
issue 731490



Sign in to add a comment

Merge Source/web/ into modules/ & core/

Project Member Reported by slangley@chromium.org, Apr 19 2017 
Design Doc: http://bit.ly/2njib8d
Showing comments 4 - 103 of 103 Older ›

Comment 4 by jbroman@chromium.org, Apr 25 2017 

Issue 603795 has been merged into this issue.

Comment 5 by sashab@chromium.org, Apr 26 2017

Cc: sashab@chromium.org

Comment 6 by sashab@chromium.org, Apr 26 2017

Blockedon: 715382
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff3d745c3a244f84d791ea20bd70dd3c9b86a160

commit ff3d745c3a244f84d791ea20bd70dd3c9b86a160
Author: slangley <slangley@chromium.org>
Date: Fri Apr 28 05:40:02 2017

Introduce the abstract class WebViewBase, to decouple WebViewImpl.

In Source/web/ there are many cyclic dependencies. These cycles make it very
difficult to discretely move class implementation from web/ to either core/ or
modules/.

An example cycle is WebViewImpl and WebLocalFrameImpl. Each refer to the other,
rather than the least derived types of WebView and WebLocalFrame (or WebFrame).
It is impossible to use the least derived type as methods have been added to the
*Impl class definitions that are consumed by other classes in Source/web.

To break the cycle we introduce the class WebViewBase, so that the inheritance
hierarchy is now WebView <- WebViewBase <- WebViewImpl (<- = implements).

Methods that were defined in WebViewImpl are made pure virtual in WebViewBase,
and now classes that were taking a dependency on WebViewImpl instead now take a
dependency on WebViewBase. This breaks the dependency chain and allows us to
start moving these classes out of Source/web into new homes in modules or core.
Note: WebViewBase is defined in core/exported/WebViewBase.h as is implements
public/web/WebView.h. Once this refactoring is complete WebViewBase will be
removed and these changes effectively reverted.

This CL moves the first portion of classes to use WebViewBase rather than
WebViewImpl, a followup CL will complete this move.

BUG=712963

Review-Url: https://codereview.chromium.org/2848513002
Cr-Commit-Position: refs/heads/master@{#467905}

[modify] https://crrev.com/ff3d745c3a244f84d791ea20bd70dd3c9b86a160/third_party/WebKit/Source/core/exported/BUILD.gn
[add] https://crrev.com/ff3d745c3a244f84d791ea20bd70dd3c9b86a160/third_party/WebKit/Source/core/exported/WebViewBase.h
[modify] https://crrev.com/ff3d745c3a244f84d791ea20bd70dd3c9b86a160/third_party/WebKit/Source/web/ChromeClientImpl.cpp
[modify] https://crrev.com/ff3d745c3a244f84d791ea20bd70dd3c9b86a160/third_party/WebKit/Source/web/ColorChooserPopupUIController.cpp
[modify] https://crrev.com/ff3d745c3a244f84d791ea20bd70dd3c9b86a160/third_party/WebKit/Source/web/ContextMenuClientImpl.cpp
[modify] https://crrev.com/ff3d745c3a244f84d791ea20bd70dd3c9b86a160/third_party/WebKit/Source/web/ContextMenuClientImpl.h
[modify] https://crrev.com/ff3d745c3a244f84d791ea20bd70dd3c9b86a160/third_party/WebKit/Source/web/DateTimeChooserImpl.cpp
[modify] https://crrev.com/ff3d745c3a244f84d791ea20bd70dd3c9b86a160/third_party/WebKit/Source/web/DedicatedWorkerMessagingProxyProviderImpl.cpp
[modify] https://crrev.com/ff3d745c3a244f84d791ea20bd70dd3c9b86a160/third_party/WebKit/Source/web/DevToolsEmulator.cpp
[modify] https://crrev.com/ff3d745c3a244f84d791ea20bd70dd3c9b86a160/third_party/WebKit/Source/web/DevToolsEmulator.h
[modify] https://crrev.com/ff3d745c3a244f84d791ea20bd70dd3c9b86a160/third_party/WebKit/Source/web/EditorClientImpl.cpp
[modify] https://crrev.com/ff3d745c3a244f84d791ea20bd70dd3c9b86a160/third_party/WebKit/Source/web/EditorClientImpl.h
[modify] https://crrev.com/ff3d745c3a244f84d791ea20bd70dd3c9b86a160/third_party/WebKit/Source/web/ExternalPopupMenu.cpp
[modify] https://crrev.com/ff3d745c3a244f84d791ea20bd70dd3c9b86a160/third_party/WebKit/Source/web/ExternalPopupMenu.h
[modify] https://crrev.com/ff3d745c3a244f84d791ea20bd70dd3c9b86a160/third_party/WebKit/Source/web/FullscreenController.cpp
[modify] https://crrev.com/ff3d745c3a244f84d791ea20bd70dd3c9b86a160/third_party/WebKit/Source/web/FullscreenController.h
[modify] https://crrev.com/ff3d745c3a244f84d791ea20bd70dd3c9b86a160/third_party/WebKit/Source/web/InspectorEmulationAgent.cpp
[modify] https://crrev.com/ff3d745c3a244f84d791ea20bd70dd3c9b86a160/third_party/WebKit/Source/web/InspectorEmulationAgent.h
[modify] https://crrev.com/ff3d745c3a244f84d791ea20bd70dd3c9b86a160/third_party/WebKit/Source/web/InspectorOverlayAgent.cpp
[modify] https://crrev.com/ff3d745c3a244f84d791ea20bd70dd3c9b86a160/third_party/WebKit/Source/web/LinkHighlightImpl.cpp
[modify] https://crrev.com/ff3d745c3a244f84d791ea20bd70dd3c9b86a160/third_party/WebKit/Source/web/LinkHighlightImpl.h
[modify] https://crrev.com/ff3d745c3a244f84d791ea20bd70dd3c9b86a160/third_party/WebKit/Source/web/LinkHighlightImplTest.cpp
[modify] https://crrev.com/ff3d745c3a244f84d791ea20bd70dd3c9b86a160/third_party/WebKit/Source/web/LocalFrameClientImpl.cpp
[modify] https://crrev.com/ff3d745c3a244f84d791ea20bd70dd3c9b86a160/third_party/WebKit/Source/web/PageOverlayTest.cpp
[modify] https://crrev.com/ff3d745c3a244f84d791ea20bd70dd3c9b86a160/third_party/WebKit/Source/web/PrerendererClientImpl.cpp
[modify] https://crrev.com/ff3d745c3a244f84d791ea20bd70dd3c9b86a160/third_party/WebKit/Source/web/SpellCheckerClientImpl.cpp
[modify] https://crrev.com/ff3d745c3a244f84d791ea20bd70dd3c9b86a160/third_party/WebKit/Source/web/SpellCheckerClientImpl.h
[modify] https://crrev.com/ff3d745c3a244f84d791ea20bd70dd3c9b86a160/third_party/WebKit/Source/web/StorageClientImpl.cpp
[modify] https://crrev.com/ff3d745c3a244f84d791ea20bd70dd3c9b86a160/third_party/WebKit/Source/web/StorageClientImpl.h
[modify] https://crrev.com/ff3d745c3a244f84d791ea20bd70dd3c9b86a160/third_party/WebKit/Source/web/TextCheckerClientImpl.cpp
[modify] https://crrev.com/ff3d745c3a244f84d791ea20bd70dd3c9b86a160/third_party/WebKit/Source/web/TextFinder.cpp
[modify] https://crrev.com/ff3d745c3a244f84d791ea20bd70dd3c9b86a160/third_party/WebKit/Source/web/WebAXObject.cpp
[modify] https://crrev.com/ff3d745c3a244f84d791ea20bd70dd3c9b86a160/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp
[modify] https://crrev.com/ff3d745c3a244f84d791ea20bd70dd3c9b86a160/third_party/WebKit/Source/web/WebDevToolsFrontendImpl.cpp
[modify] https://crrev.com/ff3d745c3a244f84d791ea20bd70dd3c9b86a160/third_party/WebKit/Source/web/WebFrameWidgetBase.cpp
[modify] https://crrev.com/ff3d745c3a244f84d791ea20bd70dd3c9b86a160/third_party/WebKit/Source/web/WebFrameWidgetBase.h
[modify] https://crrev.com/ff3d745c3a244f84d791ea20bd70dd3c9b86a160/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
[modify] https://crrev.com/ff3d745c3a244f84d791ea20bd70dd3c9b86a160/third_party/WebKit/Source/web/WebFrameWidgetImpl.h
[modify] https://crrev.com/ff3d745c3a244f84d791ea20bd70dd3c9b86a160/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
[modify] https://crrev.com/ff3d745c3a244f84d791ea20bd70dd3c9b86a160/third_party/WebKit/Source/web/WebLocalFrameImpl.h
[modify] https://crrev.com/ff3d745c3a244f84d791ea20bd70dd3c9b86a160/third_party/WebKit/Source/web/WebPluginContainerImpl.cpp
[modify] https://crrev.com/ff3d745c3a244f84d791ea20bd70dd3c9b86a160/third_party/WebKit/Source/web/WebStorageEventDispatcherImpl.cpp
[modify] https://crrev.com/ff3d745c3a244f84d791ea20bd70dd3c9b86a160/third_party/WebKit/Source/web/WebViewImpl.cpp
[modify] https://crrev.com/ff3d745c3a244f84d791ea20bd70dd3c9b86a160/third_party/WebKit/Source/web/WebViewImpl.h
[modify] https://crrev.com/ff3d745c3a244f84d791ea20bd70dd3c9b86a160/third_party/WebKit/Source/web/tests/ActiveConnectionThrottlingTest.cpp
[modify] https://crrev.com/ff3d745c3a244f84d791ea20bd70dd3c9b86a160/third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp
[modify] https://crrev.com/ff3d745c3a244f84d791ea20bd70dd3c9b86a160/third_party/WebKit/Source/web/tests/CompositorWorkerTest.cpp
[modify] https://crrev.com/ff3d745c3a244f84d791ea20bd70dd3c9b86a160/third_party/WebKit/Source/web/tests/DeferredLoadingTest.cpp
[modify] https://crrev.com/ff3d745c3a244f84d791ea20bd70dd3c9b86a160/third_party/WebKit/Source/web/tests/FrameSerializerTest.cpp
[modify] https://crrev.com/ff3d745c3a244f84d791ea20bd70dd3c9b86a160/third_party/WebKit/Source/web/tests/IntersectionObserverTest.cpp
[modify] https://crrev.com/ff3d745c3a244f84d791ea20bd70dd3c9b86a160/third_party/WebKit/Source/web/tests/NGInlineLayoutTest.cpp
[modify] https://crrev.com/ff3d745c3a244f84d791ea20bd70dd3c9b86a160/third_party/WebKit/Source/web/tests/ProgrammaticScrollTest.cpp
[modify] https://crrev.com/ff3d745c3a244f84d791ea20bd70dd3c9b86a160/third_party/WebKit/Source/web/tests/ResizeObserverTest.cpp
[modify] https://crrev.com/ff3d745c3a244f84d791ea20bd70dd3c9b86a160/third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp
[modify] https://crrev.com/ff3d745c3a244f84d791ea20bd70dd3c9b86a160/third_party/WebKit/Source/web/tests/TouchActionTest.cpp
[modify] https://crrev.com/ff3d745c3a244f84d791ea20bd70dd3c9b86a160/third_party/WebKit/Source/web/tests/WebFrameSerializerTest.cpp
[modify] https://crrev.com/ff3d745c3a244f84d791ea20bd70dd3c9b86a160/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
[modify] https://crrev.com/ff3d745c3a244f84d791ea20bd70dd3c9b86a160/third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp
[modify] https://crrev.com/ff3d745c3a244f84d791ea20bd70dd3c9b86a160/third_party/WebKit/Source/web/tests/WebPluginContainerTest.cpp
[modify] https://crrev.com/ff3d745c3a244f84d791ea20bd70dd3c9b86a160/third_party/WebKit/Source/web/tests/WebViewTest.cpp
[modify] https://crrev.com/ff3d745c3a244f84d791ea20bd70dd3c9b86a160/third_party/WebKit/Source/web/tests/sim/SimTest.cpp
Project Member

Comment 8 by bugdroid1@chromium.org, May 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/11511f6be6df08006e6a8c471eefef6f251a652e

commit 11511f6be6df08006e6a8c471eefef6f251a652e
Author: slangley <slangley@chromium.org>
Date: Mon May 01 11:21:14 2017

Move more methods from WebViewImpl to WebViewBase, and cut dependencies.

The work continues the effort to remove direct dependencies on web/WebViewImpl.h
by moving methods to a pure virtual base class, and updating references to use
the base class rather than the implementation.

We need to break cyclic dependencies in web/ to allow us to move files up into
core/ and modules/.

BUG=712963

Review-Url: https://codereview.chromium.org/2851993002
Cr-Commit-Position: refs/heads/master@{#468307}

[modify] https://crrev.com/11511f6be6df08006e6a8c471eefef6f251a652e/third_party/WebKit/Source/core/exported/WebViewBase.h
[modify] https://crrev.com/11511f6be6df08006e6a8c471eefef6f251a652e/third_party/WebKit/Source/web/ChromeClientImpl.cpp
[modify] https://crrev.com/11511f6be6df08006e6a8c471eefef6f251a652e/third_party/WebKit/Source/web/ChromeClientImpl.h
[modify] https://crrev.com/11511f6be6df08006e6a8c471eefef6f251a652e/third_party/WebKit/Source/web/PopupMenuImpl.cpp
[modify] https://crrev.com/11511f6be6df08006e6a8c471eefef6f251a652e/third_party/WebKit/Source/web/WebPagePopupImpl.cpp
[modify] https://crrev.com/11511f6be6df08006e6a8c471eefef6f251a652e/third_party/WebKit/Source/web/WebPagePopupImpl.h
[modify] https://crrev.com/11511f6be6df08006e6a8c471eefef6f251a652e/third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp
[modify] https://crrev.com/11511f6be6df08006e6a8c471eefef6f251a652e/third_party/WebKit/Source/web/WebViewImpl.cpp
[modify] https://crrev.com/11511f6be6df08006e6a8c471eefef6f251a652e/third_party/WebKit/Source/web/WebViewImpl.h
Project Member

Comment 9 by bugdroid1@chromium.org, May 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/660e8283b061c57654c8beb9791567b637842cf2

commit 660e8283b061c57654c8beb9791567b637842cf2
Author: slangley <slangley@chromium.org>
Date: Mon May 01 13:05:13 2017

Move WebViewFrameWidget to use WebViewBase rather than WebViewImpl.

We WebViewFrameWidget keeps a RefPtr to WebViewImpl we need to make WebViewBase
ref counted. Removed the ref counted from WebViewImpl when moving it to
WebViewBase.

BUG=712963

Review-Url: https://codereview.chromium.org/2850113002
Cr-Commit-Position: refs/heads/master@{#468310}

[modify] https://crrev.com/660e8283b061c57654c8beb9791567b637842cf2/third_party/WebKit/Source/core/exported/WebViewBase.h
[modify] https://crrev.com/660e8283b061c57654c8beb9791567b637842cf2/third_party/WebKit/Source/web/WebViewFrameWidget.cpp
[modify] https://crrev.com/660e8283b061c57654c8beb9791567b637842cf2/third_party/WebKit/Source/web/WebViewFrameWidget.h
[modify] https://crrev.com/660e8283b061c57654c8beb9791567b637842cf2/third_party/WebKit/Source/web/WebViewImpl.h
Project Member

Comment 10 by bugdroid1@chromium.org, May 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/57278545b2bb8e4d6b5ca3d241852bc346933d4e

commit 57278545b2bb8e4d6b5ca3d241852bc346933d4e
Author: slangley <slangley@chromium.org>
Date: Tue May 02 01:34:05 2017

Break dependency between ChromeClient and WebViewImpl, and ChromeClientImpl.

ChromeClientImpl implements core/page/ChromeClient (not public), and only one
method in ChromeClientImpl was missing from ChromeClient. This CL makes the
missing method pure virtual in ChromeClient and overrides it in ChromeClientImpl
and then changes WebViewImpl to return a ChromeClient reference rather than
a ChromeClientImpl reference.

Next we can remove direct references of ChromeClientImpl in other web/* classes.

BUG=712963

Review-Url: https://codereview.chromium.org/2852013002
Cr-Commit-Position: refs/heads/master@{#468527}

[modify] https://crrev.com/57278545b2bb8e4d6b5ca3d241852bc346933d4e/third_party/WebKit/Source/core/exported/WebViewBase.h
[modify] https://crrev.com/57278545b2bb8e4d6b5ca3d241852bc346933d4e/third_party/WebKit/Source/core/loader/EmptyClients.h
[modify] https://crrev.com/57278545b2bb8e4d6b5ca3d241852bc346933d4e/third_party/WebKit/Source/core/page/ChromeClient.h
[modify] https://crrev.com/57278545b2bb8e4d6b5ca3d241852bc346933d4e/third_party/WebKit/Source/web/ChromeClientImpl.h
[modify] https://crrev.com/57278545b2bb8e4d6b5ca3d241852bc346933d4e/third_party/WebKit/Source/web/WebViewImpl.h
Project Member

Comment 11 by bugdroid1@chromium.org, May 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ceb538b1bb7f9067f80535bd00f49b81344b8823

commit ceb538b1bb7f9067f80535bd00f49b81344b8823
Author: slangley <slangley@chromium.org>
Date: Tue May 02 07:55:18 2017

Remove the last references from production code to WebViewImpl.

This CL is a continuation of removing dependencies in the code on WebViewImpl, by
introducing the pure virtual class WebViewBase and moving methods from WebViewImpl
to virtual methods in WebViewBase and overriding them in WebViewImpl.

It also removes a few of the cast to WebViewImpl, and replaces them with a direct
static cast to WebViewBase.

BUG=712963

Review-Url: https://codereview.chromium.org/2854783003
Cr-Commit-Position: refs/heads/master@{#468580}

[modify] https://crrev.com/ceb538b1bb7f9067f80535bd00f49b81344b8823/third_party/WebKit/Source/core/exported/WebViewBase.h
[modify] https://crrev.com/ceb538b1bb7f9067f80535bd00f49b81344b8823/third_party/WebKit/Source/web/ChromeClientImpl.cpp
[modify] https://crrev.com/ceb538b1bb7f9067f80535bd00f49b81344b8823/third_party/WebKit/Source/web/ValidationMessageClientImpl.cpp
[modify] https://crrev.com/ceb538b1bb7f9067f80535bd00f49b81344b8823/third_party/WebKit/Source/web/ValidationMessageClientImpl.h
[modify] https://crrev.com/ceb538b1bb7f9067f80535bd00f49b81344b8823/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp
[modify] https://crrev.com/ceb538b1bb7f9067f80535bd00f49b81344b8823/third_party/WebKit/Source/web/WebFrameWidgetBase.cpp
[modify] https://crrev.com/ceb538b1bb7f9067f80535bd00f49b81344b8823/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
[modify] https://crrev.com/ceb538b1bb7f9067f80535bd00f49b81344b8823/third_party/WebKit/Source/web/WebFrameWidgetImpl.h
[modify] https://crrev.com/ceb538b1bb7f9067f80535bd00f49b81344b8823/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
[modify] https://crrev.com/ceb538b1bb7f9067f80535bd00f49b81344b8823/third_party/WebKit/Source/web/WebViewImpl.cpp
[modify] https://crrev.com/ceb538b1bb7f9067f80535bd00f49b81344b8823/third_party/WebKit/Source/web/WebViewImpl.h
Project Member

Comment 13 by bugdroid1@chromium.org, May 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba9abc4c70ae99cf7fc03adbd48258cea2514595

commit ba9abc4c70ae99cf7fc03adbd48258cea2514595
Author: slangley <slangley@chromium.org>
Date: Fri May 05 02:27:23 2017

Change all test cases to use WebViewBase instead of WebViewImpl.

This CL changes all of the test cases to use the abstract WebViewBase class in
place of WebViewImpl. This should be the final CL to decouple the use of
WebViewImpl in web/ and move everything over to WebViewBase.

As before, there were a number of methods defined in WebViewImpl that needed to
be made virtual in WebViewBase and then overridden in WebViewImpl.

Also, it was not possible to use CORE_EXPORT or MODULES_EXPORT to export the
statically defined symbols from WebViewBase, so I used PLATFORM_EXPORT instead.

A number of symbols were being transitively included, so in places needed to
add include files to bring the symbols into scope.

BUG=712963

Review-Url: https://codereview.chromium.org/2860673002
Cr-Commit-Position: refs/heads/master@{#469575}

[modify] https://crrev.com/ba9abc4c70ae99cf7fc03adbd48258cea2514595/third_party/WebKit/Source/core/exported/WebViewBase.h
[modify] https://crrev.com/ba9abc4c70ae99cf7fc03adbd48258cea2514595/third_party/WebKit/Source/web/ExternalPopupMenuTest.cpp
[modify] https://crrev.com/ba9abc4c70ae99cf7fc03adbd48258cea2514595/third_party/WebKit/Source/web/LinkHighlightImplTest.cpp
[modify] https://crrev.com/ba9abc4c70ae99cf7fc03adbd48258cea2514595/third_party/WebKit/Source/web/PageOverlayTest.cpp
[modify] https://crrev.com/ba9abc4c70ae99cf7fc03adbd48258cea2514595/third_party/WebKit/Source/web/WebViewImpl.cpp
[modify] https://crrev.com/ba9abc4c70ae99cf7fc03adbd48258cea2514595/third_party/WebKit/Source/web/WebViewImpl.h
[modify] https://crrev.com/ba9abc4c70ae99cf7fc03adbd48258cea2514595/third_party/WebKit/Source/web/tests/AnimationSimTest.cpp
[modify] https://crrev.com/ba9abc4c70ae99cf7fc03adbd48258cea2514595/third_party/WebKit/Source/web/tests/BrowserControlsTest.cpp
[modify] https://crrev.com/ba9abc4c70ae99cf7fc03adbd48258cea2514595/third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp
[modify] https://crrev.com/ba9abc4c70ae99cf7fc03adbd48258cea2514595/third_party/WebKit/Source/web/tests/CompositorWorkerTest.cpp
[modify] https://crrev.com/ba9abc4c70ae99cf7fc03adbd48258cea2514595/third_party/WebKit/Source/web/tests/DocumentLoaderTest.cpp
[modify] https://crrev.com/ba9abc4c70ae99cf7fc03adbd48258cea2514595/third_party/WebKit/Source/web/tests/FrameTestHelpers.cpp
[modify] https://crrev.com/ba9abc4c70ae99cf7fc03adbd48258cea2514595/third_party/WebKit/Source/web/tests/FrameTestHelpers.h
[modify] https://crrev.com/ba9abc4c70ae99cf7fc03adbd48258cea2514595/third_party/WebKit/Source/web/tests/ImeOnFocusTest.cpp
[modify] https://crrev.com/ba9abc4c70ae99cf7fc03adbd48258cea2514595/third_party/WebKit/Source/web/tests/LayoutGeometryMapTest.cpp
[modify] https://crrev.com/ba9abc4c70ae99cf7fc03adbd48258cea2514595/third_party/WebKit/Source/web/tests/LinkSelectionTest.cpp
[modify] https://crrev.com/ba9abc4c70ae99cf7fc03adbd48258cea2514595/third_party/WebKit/Source/web/tests/ProgrammaticScrollTest.cpp
[modify] https://crrev.com/ba9abc4c70ae99cf7fc03adbd48258cea2514595/third_party/WebKit/Source/web/tests/RootScrollerTest.cpp
[modify] https://crrev.com/ba9abc4c70ae99cf7fc03adbd48258cea2514595/third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp
[modify] https://crrev.com/ba9abc4c70ae99cf7fc03adbd48258cea2514595/third_party/WebKit/Source/web/tests/TouchActionTest.cpp
[modify] https://crrev.com/ba9abc4c70ae99cf7fc03adbd48258cea2514595/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp
[modify] https://crrev.com/ba9abc4c70ae99cf7fc03adbd48258cea2514595/third_party/WebKit/Source/web/tests/WebFrameSerializerTest.cpp
[modify] https://crrev.com/ba9abc4c70ae99cf7fc03adbd48258cea2514595/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
[modify] https://crrev.com/ba9abc4c70ae99cf7fc03adbd48258cea2514595/third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp
[modify] https://crrev.com/ba9abc4c70ae99cf7fc03adbd48258cea2514595/third_party/WebKit/Source/web/tests/WebPluginContainerTest.cpp
[modify] https://crrev.com/ba9abc4c70ae99cf7fc03adbd48258cea2514595/third_party/WebKit/Source/web/tests/WebViewTest.cpp
[modify] https://crrev.com/ba9abc4c70ae99cf7fc03adbd48258cea2514595/third_party/WebKit/Source/web/tests/sim/SimCompositor.cpp
[modify] https://crrev.com/ba9abc4c70ae99cf7fc03adbd48258cea2514595/third_party/WebKit/Source/web/tests/sim/SimCompositor.h
[modify] https://crrev.com/ba9abc4c70ae99cf7fc03adbd48258cea2514595/third_party/WebKit/Source/web/tests/sim/SimTest.cpp
[modify] https://crrev.com/ba9abc4c70ae99cf7fc03adbd48258cea2514595/third_party/WebKit/Source/web/tests/sim/SimTest.h
Project Member

Comment 14 by bugdroid1@chromium.org, May 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c08e365f4e2e5940d1632fd693573737f867ad6e

commit c08e365f4e2e5940d1632fd693573737f867ad6e
Author: slangley <slangley@chromium.org>
Date: Tue May 09 07:03:11 2017

EditorClientImpl changed to use WebLocalFrameBase instead of WebLocalFrameImpl.

This is a subset of https://codereview.chromium.org/2870773003 which did not
work as there were link errors on WebFrameClient::FrameDetached on windows
builds.

In general now I think i will just try and move existing usages of
WebLocalFrameImpl to WebLocalFrameBase as a first step, and then try to
move files into core as a second step, once we have moved the basic types
to core/exported (WebFrameClient, WebLocalFrame etc etc).

BUG=712963

Review-Url: https://codereview.chromium.org/2865163003
Cr-Commit-Position: refs/heads/master@{#470257}

[modify] https://crrev.com/c08e365f4e2e5940d1632fd693573737f867ad6e/third_party/WebKit/Source/web/EditorClientImpl.cpp
Project Member

Comment 16 by bugdroid1@chromium.org, May 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/44395608981a4f8ee6b25f048d69e68cd7b8498a

commit 44395608981a4f8ee6b25f048d69e68cd7b8498a
Author: slangley <slangley@chromium.org>
Date: Thu May 11 10:48:53 2017

Move many standalone files from web/ to (core|modules)/exported/.

This CL starts moving files from web/ that are implementations of classes defined
in public/web/ that have no other dependencies in web/.

Classes that have some dependency on modules/ move to modules/exported/, otherwise
classes move to core/exported.

This required setting up the modules/exported directory and BUILD file, and now
exposing WebKit/Source/modules via the blink_all build rule so that the symbols
are available.

In some cases this also required adding BLINK_EXPORT to some of the definitions in
public/web/, but these are all inside of BLINK_IMPLEMENTATION blocks which
indicates that there should be no dependence on these methods externally.

BUG=712963

Review-Url: https://codereview.chromium.org/2874713002
Cr-Commit-Position: refs/heads/master@{#470910}

[modify] https://crrev.com/44395608981a4f8ee6b25f048d69e68cd7b8498a/third_party/WebKit/Source/core/exported/BUILD.gn
[rename] https://crrev.com/44395608981a4f8ee6b25f048d69e68cd7b8498a/third_party/WebKit/Source/core/exported/WebCSSParser.cpp
[rename] https://crrev.com/44395608981a4f8ee6b25f048d69e68cd7b8498a/third_party/WebKit/Source/core/exported/WebColorSuggestion.cpp
[rename] https://crrev.com/44395608981a4f8ee6b25f048d69e68cd7b8498a/third_party/WebKit/Source/core/exported/WebCustomElement.cpp
[rename] https://crrev.com/44395608981a4f8ee6b25f048d69e68cd7b8498a/third_party/WebKit/Source/core/exported/WebDOMActivityLogger.cpp
[rename] https://crrev.com/44395608981a4f8ee6b25f048d69e68cd7b8498a/third_party/WebKit/Source/core/exported/WebDOMEvent.cpp
[rename] https://crrev.com/44395608981a4f8ee6b25f048d69e68cd7b8498a/third_party/WebKit/Source/core/exported/WebDateTimeSuggestion.cpp
[rename] https://crrev.com/44395608981a4f8ee6b25f048d69e68cd7b8498a/third_party/WebKit/Source/core/exported/WebFileChooserCompletionImpl.cpp
[rename] https://crrev.com/44395608981a4f8ee6b25f048d69e68cd7b8498a/third_party/WebKit/Source/core/exported/WebFileChooserCompletionImpl.h
[rename] https://crrev.com/44395608981a4f8ee6b25f048d69e68cd7b8498a/third_party/WebKit/Source/core/exported/WebHeap.cpp
[rename] https://crrev.com/44395608981a4f8ee6b25f048d69e68cd7b8498a/third_party/WebKit/Source/core/exported/WebImageCache.cpp
[rename] https://crrev.com/44395608981a4f8ee6b25f048d69e68cd7b8498a/third_party/WebKit/Source/core/exported/WebImageDecoder.cpp
[modify] https://crrev.com/44395608981a4f8ee6b25f048d69e68cd7b8498a/third_party/WebKit/Source/modules/BUILD.gn
[modify] https://crrev.com/44395608981a4f8ee6b25f048d69e68cd7b8498a/third_party/WebKit/Source/modules/DEPS
[add] https://crrev.com/44395608981a4f8ee6b25f048d69e68cd7b8498a/third_party/WebKit/Source/modules/exported/BUILD.gn
[rename] https://crrev.com/44395608981a4f8ee6b25f048d69e68cd7b8498a/third_party/WebKit/Source/modules/exported/WebCryptoNormalize.cpp
[rename] https://crrev.com/44395608981a4f8ee6b25f048d69e68cd7b8498a/third_party/WebKit/Source/modules/exported/WebDOMFileSystem.cpp
[rename] https://crrev.com/44395608981a4f8ee6b25f048d69e68cd7b8498a/third_party/WebKit/Source/modules/exported/WebDOMMediaStreamTrack.cpp
[rename] https://crrev.com/44395608981a4f8ee6b25f048d69e68cd7b8498a/third_party/WebKit/Source/modules/exported/WebDatabase.cpp
[modify] https://crrev.com/44395608981a4f8ee6b25f048d69e68cd7b8498a/third_party/WebKit/Source/web/BUILD.gn
[modify] https://crrev.com/44395608981a4f8ee6b25f048d69e68cd7b8498a/third_party/WebKit/Source/web/ChromeClientImpl.cpp
[modify] https://crrev.com/44395608981a4f8ee6b25f048d69e68cd7b8498a/third_party/WebKit/public/BUILD.gn
[modify] https://crrev.com/44395608981a4f8ee6b25f048d69e68cd7b8498a/third_party/WebKit/public/web/WebColorSuggestion.h
[modify] https://crrev.com/44395608981a4f8ee6b25f048d69e68cd7b8498a/third_party/WebKit/public/web/WebDOMEvent.h
[modify] https://crrev.com/44395608981a4f8ee6b25f048d69e68cd7b8498a/third_party/WebKit/public/web/WebDateTimeSuggestion.h
Project Member

Comment 17 by bugdroid1@chromium.org, May 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/411384cbbbe54a0a7f6e280705512f83c81f6540

commit 411384cbbbe54a0a7f6e280705512f83c81f6540
Author: slangley <slangley@chromium.org>
Date: Fri May 12 05:20:20 2017

Introduce WebRemoteFrameBase to break dependencies on WebRemoteFrameImpl.

The CL is a replica of what was done for WebLocalFrameImpl, namely:

1. Introduce WebRemoteFrameBase that derives from WebRemoteFrame.
2. Make WebRemoteFrameImpl derive from WebRemoteFrameBase.
3. Make it possible to case from a RemoteFrame to WebRemoteFrameBase using
ChromeClient.
4. Make WebRemoteFrameBase garbage collected and plumb through Trace calls.
5. Change WebFrame to use WebRemoteFrameBase instead of WebRemoteFrameImpl.
6. Make methods pure virtual in WebRemoteFrameBase and override in
WebRemoteFrameImpl.

BUG=712963

Review-Url: https://codereview.chromium.org/2878623002
Cr-Commit-Position: refs/heads/master@{#471226}

[modify] https://crrev.com/411384cbbbe54a0a7f6e280705512f83c81f6540/third_party/WebKit/Source/core/frame/BUILD.gn
[add] https://crrev.com/411384cbbbe54a0a7f6e280705512f83c81f6540/third_party/WebKit/Source/core/frame/WebRemoteFrameBase.cpp
[add] https://crrev.com/411384cbbbe54a0a7f6e280705512f83c81f6540/third_party/WebKit/Source/core/frame/WebRemoteFrameBase.h
[modify] https://crrev.com/411384cbbbe54a0a7f6e280705512f83c81f6540/third_party/WebKit/Source/core/page/ChromeClient.h
[modify] https://crrev.com/411384cbbbe54a0a7f6e280705512f83c81f6540/third_party/WebKit/Source/web/ChromeClientImpl.cpp
[modify] https://crrev.com/411384cbbbe54a0a7f6e280705512f83c81f6540/third_party/WebKit/Source/web/ChromeClientImpl.h
[modify] https://crrev.com/411384cbbbe54a0a7f6e280705512f83c81f6540/third_party/WebKit/Source/web/WebFrame.cpp
[modify] https://crrev.com/411384cbbbe54a0a7f6e280705512f83c81f6540/third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp
[modify] https://crrev.com/411384cbbbe54a0a7f6e280705512f83c81f6540/third_party/WebKit/Source/web/WebRemoteFrameImpl.h
Project Member

Comment 18 by bugdroid1@chromium.org, May 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d379a172ffe86d179a10a6207855004b0d781650

commit d379a172ffe86d179a10a6207855004b0d781650
Author: slangley <slangley@chromium.org>
Date: Mon May 15 00:57:23 2017

Move speech related files from web -> modules/(speech|exported).

WebSpeech* are implementations of public API and were moved to modules/exported.

SpeechRecognitionClientProxy was moved to modules/speech.

Also needed to fix some linter errors that appeared when the files were moved
to their new homes.

BUG=712963

Review-Url: https://codereview.chromium.org/2877303002
Cr-Commit-Position: refs/heads/master@{#471645}

[modify] https://crrev.com/d379a172ffe86d179a10a6207855004b0d781650/third_party/WebKit/Source/modules/exported/BUILD.gn
[rename] https://crrev.com/d379a172ffe86d179a10a6207855004b0d781650/third_party/WebKit/Source/modules/exported/WebSpeechGrammar.cpp
[rename] https://crrev.com/d379a172ffe86d179a10a6207855004b0d781650/third_party/WebKit/Source/modules/exported/WebSpeechRecognitionHandle.cpp
[rename] https://crrev.com/d379a172ffe86d179a10a6207855004b0d781650/third_party/WebKit/Source/modules/exported/WebSpeechRecognitionResult.cpp
[modify] https://crrev.com/d379a172ffe86d179a10a6207855004b0d781650/third_party/WebKit/Source/modules/speech/BUILD.gn
[rename] https://crrev.com/d379a172ffe86d179a10a6207855004b0d781650/third_party/WebKit/Source/modules/speech/SpeechRecognitionClientProxy.cpp
[rename] https://crrev.com/d379a172ffe86d179a10a6207855004b0d781650/third_party/WebKit/Source/modules/speech/SpeechRecognitionClientProxy.h
[modify] https://crrev.com/d379a172ffe86d179a10a6207855004b0d781650/third_party/WebKit/Source/web/BUILD.gn
[modify] https://crrev.com/d379a172ffe86d179a10a6207855004b0d781650/third_party/WebKit/Source/web/WebViewImpl.cpp
Project Member

Comment 19 by bugdroid1@chromium.org, May 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3012c22bf47687f565edd7bd2697bb1bf155303c

commit 3012c22bf47687f565edd7bd2697bb1bf155303c
Author: slangley <slangley@chromium.org>
Date: Mon May 15 08:41:33 2017

Move detached files from web/ to (core/modules)/exported.

This CL moves files from web/ that are implementations of classes defined
in public/web/ that have no other dependencies in web/.

Classes that have some dependency on modules/ move to modules/exported/, otherwise
classes move to core/exported.

This required setting up the modules/exported directory and BUILD file, and now
exposing WebKit/Source/modules via the blink_all build rule so that the symbols
are available.

In some cases this also required adding BLINK_EXPORT to some of the definitions in
public/web/, but these are all inside of BLINK_IMPLEMENTATION blocks which
indicates that there should be no dependence on these methods externally.

BUG=712963

Review-Url: https://codereview.chromium.org/2883793003
Cr-Commit-Position: refs/heads/master@{#471700}

[modify] https://crrev.com/3012c22bf47687f565edd7bd2697bb1bf155303c/third_party/WebKit/Source/core/exported/BUILD.gn
[rename] https://crrev.com/3012c22bf47687f565edd7bd2697bb1bf155303c/third_party/WebKit/Source/core/exported/WebHistoryItem.cpp
[rename] https://crrev.com/3012c22bf47687f565edd7bd2697bb1bf155303c/third_party/WebKit/Source/core/exported/WebMemoryStatistics.cpp
[rename] https://crrev.com/3012c22bf47687f565edd7bd2697bb1bf155303c/third_party/WebKit/Source/core/exported/WebPerformance.cpp
[rename] https://crrev.com/3012c22bf47687f565edd7bd2697bb1bf155303c/third_party/WebKit/Source/core/exported/WebRange.cpp
[rename] https://crrev.com/3012c22bf47687f565edd7bd2697bb1bf155303c/third_party/WebKit/Source/core/exported/WebRenderTheme.cpp
[rename] https://crrev.com/3012c22bf47687f565edd7bd2697bb1bf155303c/third_party/WebKit/Source/core/exported/WebScriptController.cpp
[rename] https://crrev.com/3012c22bf47687f565edd7bd2697bb1bf155303c/third_party/WebKit/Source/core/exported/WebScriptSource.cpp
[rename] https://crrev.com/3012c22bf47687f565edd7bd2697bb1bf155303c/third_party/WebKit/Source/core/exported/WebSecurityPolicy.cpp
[rename] https://crrev.com/3012c22bf47687f565edd7bd2697bb1bf155303c/third_party/WebKit/Source/core/exported/WebSelection.cpp
[rename] https://crrev.com/3012c22bf47687f565edd7bd2697bb1bf155303c/third_party/WebKit/Source/core/exported/WebSelector.cpp
[rename] https://crrev.com/3012c22bf47687f565edd7bd2697bb1bf155303c/third_party/WebKit/Source/core/exported/WebSerializedScriptValue.cpp
[modify] https://crrev.com/3012c22bf47687f565edd7bd2697bb1bf155303c/third_party/WebKit/Source/modules/exported/BUILD.gn
[rename] https://crrev.com/3012c22bf47687f565edd7bd2697bb1bf155303c/third_party/WebKit/Source/modules/exported/WebMediaDeviceChangeObserver.cpp
[rename] https://crrev.com/3012c22bf47687f565edd7bd2697bb1bf155303c/third_party/WebKit/Source/modules/exported/WebMediaStreamRegistry.cpp
[modify] https://crrev.com/3012c22bf47687f565edd7bd2697bb1bf155303c/third_party/WebKit/Source/web/BUILD.gn
[modify] https://crrev.com/3012c22bf47687f565edd7bd2697bb1bf155303c/third_party/WebKit/public/web/WebMediaDeviceChangeObserver.h
[modify] https://crrev.com/3012c22bf47687f565edd7bd2697bb1bf155303c/third_party/WebKit/public/web/WebPerformance.h
[modify] https://crrev.com/3012c22bf47687f565edd7bd2697bb1bf155303c/third_party/WebKit/public/web/WebRange.h
[modify] https://crrev.com/3012c22bf47687f565edd7bd2697bb1bf155303c/third_party/WebKit/public/web/WebScriptSource.h
[modify] https://crrev.com/3012c22bf47687f565edd7bd2697bb1bf155303c/third_party/WebKit/public/web/WebSerializedScriptValue.h
Project Member

Comment 20 by bugdroid1@chromium.org, May 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f14848339fac1c011fa60315db1859f67cd49818

commit f14848339fac1c011fa60315db1859f67cd49818
Author: sashab <sashab@chromium.org>
Date: Thu May 18 11:19:47 2017

Removed dependency of PopupMenuImpl on ChromeClientImpl

BUG=712963

Review-Url: https://codereview.chromium.org/2884803004
Cr-Commit-Position: refs/heads/master@{#472764}

[modify] https://crrev.com/f14848339fac1c011fa60315db1859f67cd49818/third_party/WebKit/Source/web/PopupMenuImpl.cpp
[modify] https://crrev.com/f14848339fac1c011fa60315db1859f67cd49818/third_party/WebKit/Source/web/PopupMenuImpl.h
Project Member

Comment 21 by bugdroid1@chromium.org, May 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/50d38ea52935abf060b3b7b6b9fb83bc7d1abc1e

commit 50d38ea52935abf060b3b7b6b9fb83bc7d1abc1e
Author: sashab <sashab@chromium.org>
Date: Thu May 18 11:38:39 2017

Removed dependency of ExternalDateTimeChooser on ChromeClientImpl

BUG=712963

Review-Url: https://codereview.chromium.org/2886653002
Cr-Commit-Position: refs/heads/master@{#472768}

[modify] https://crrev.com/50d38ea52935abf060b3b7b6b9fb83bc7d1abc1e/third_party/WebKit/Source/web/ExternalDateTimeChooser.cpp
[modify] https://crrev.com/50d38ea52935abf060b3b7b6b9fb83bc7d1abc1e/third_party/WebKit/Source/web/ExternalDateTimeChooser.h
Project Member

Comment 22 by bugdroid1@chromium.org, May 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/303acce5cc18d95d46342bd089e06957841bc21b

commit 303acce5cc18d95d46342bd089e06957841bc21b
Author: slangley <slangley@chromium.org>
Date: Thu May 18 15:03:50 2017

Introduce WebPluginContainerBase to abstract WebPluginContainerImpl.

Many classes in web/ take a dependancy on WebPluginContainerImpl, in some cases
this dependency is cyclic. In order to break this dependency we introduce a new
temporary abstraction WebPluginContainerBase, that derives from PlugingView,
WebPluginContainer and ContextClient.

Classes that were taking a dependency on WebPluginContainerImpl now take a
dependency on WebPluginContainerBase. In cases where there we methods that
were only defined in WebPluginContainerImpl we make them pure virtual in
WebPluginContainerBase and override them in WebPluginContainerImpl.

As WebPluginContainerImpl is garbage collected, we move this to
WebPluginContainerBase and define a virtual trace method.

The intention is for this abstraction to be temporary, once we move all of the
dependencies into core/ we can remove it.

I put the new class in core/exported as it derives from WebPluginContainer.

BUG=712963

Review-Url: https://codereview.chromium.org/2886113002
Cr-Commit-Position: refs/heads/master@{#472810}

[modify] https://crrev.com/303acce5cc18d95d46342bd089e06957841bc21b/third_party/WebKit/Source/core/exported/BUILD.gn
[add] https://crrev.com/303acce5cc18d95d46342bd089e06957841bc21b/third_party/WebKit/Source/core/exported/WebPluginContainerBase.cpp
[add] https://crrev.com/303acce5cc18d95d46342bd089e06957841bc21b/third_party/WebKit/Source/core/exported/WebPluginContainerBase.h
[modify] https://crrev.com/303acce5cc18d95d46342bd089e06957841bc21b/third_party/WebKit/Source/web/ChromeClientImpl.cpp
[modify] https://crrev.com/303acce5cc18d95d46342bd089e06957841bc21b/third_party/WebKit/Source/web/ContextMenuClientImpl.cpp
[modify] https://crrev.com/303acce5cc18d95d46342bd089e06957841bc21b/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
[modify] https://crrev.com/303acce5cc18d95d46342bd089e06957841bc21b/third_party/WebKit/Source/web/WebHelperPluginImpl.cpp
[modify] https://crrev.com/303acce5cc18d95d46342bd089e06957841bc21b/third_party/WebKit/Source/web/WebHelperPluginImpl.h
[modify] https://crrev.com/303acce5cc18d95d46342bd089e06957841bc21b/third_party/WebKit/Source/web/WebInputMethodControllerImpl.cpp
[modify] https://crrev.com/303acce5cc18d95d46342bd089e06957841bc21b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
[modify] https://crrev.com/303acce5cc18d95d46342bd089e06957841bc21b/third_party/WebKit/Source/web/WebLocalFrameImpl.h
[modify] https://crrev.com/303acce5cc18d95d46342bd089e06957841bc21b/third_party/WebKit/Source/web/WebNode.cpp
[modify] https://crrev.com/303acce5cc18d95d46342bd089e06957841bc21b/third_party/WebKit/Source/web/WebPluginContainerImpl.cpp
[modify] https://crrev.com/303acce5cc18d95d46342bd089e06957841bc21b/third_party/WebKit/Source/web/WebPluginContainerImpl.h
[modify] https://crrev.com/303acce5cc18d95d46342bd089e06957841bc21b/third_party/WebKit/Source/web/WebPluginDocument.cpp
[modify] https://crrev.com/303acce5cc18d95d46342bd089e06957841bc21b/third_party/WebKit/Source/web/WebViewImpl.cpp
[modify] https://crrev.com/303acce5cc18d95d46342bd089e06957841bc21b/third_party/WebKit/Source/web/tests/WebPluginContainerTest.cpp
Project Member

Comment 23 by bugdroid1@chromium.org, May 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba5159d871bb21b4b151262dd9234d0261b81331

commit ba5159d871bb21b4b151262dd9234d0261b81331
Author: jbroman <jbroman@chromium.org>
Date: Thu May 18 20:22:31 2017

Revert of Introduce WebPluginContainerBase to abstract WebPluginContainerImpl. (patchset #2 id:20001 of https://codereview.chromium.org/2886113002/ )

Reason for revert:
Causes leak failure in editing/selection/selection-plugin-clear-crash.html.

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20Leak/builds/4790

(and locally, I get crashes in debug)

Original issue's description:
> Introduce WebPluginContainerBase to abstract WebPluginContainerImpl.
>
> Many classes in web/ take a dependancy on WebPluginContainerImpl, in some cases
> this dependency is cyclic. In order to break this dependency we introduce a new
> temporary abstraction WebPluginContainerBase, that derives from PlugingView,
> WebPluginContainer and ContextClient.
>
> Classes that were taking a dependency on WebPluginContainerImpl now take a
> dependency on WebPluginContainerBase. In cases where there we methods that
> were only defined in WebPluginContainerImpl we make them pure virtual in
> WebPluginContainerBase and override them in WebPluginContainerImpl.
>
> As WebPluginContainerImpl is garbage collected, we move this to
> WebPluginContainerBase and define a virtual trace method.
>
> The intention is for this abstraction to be temporary, once we move all of the
> dependencies into core/ we can remove it.
>
> I put the new class in core/exported as it derives from WebPluginContainer.
>
>
> BUG=712963
>
> Review-Url: https://codereview.chromium.org/2886113002
> Cr-Commit-Position: refs/heads/master@{#472810}
> Committed: https://chromium.googlesource.com/chromium/src/+/303acce5cc18d95d46342bd089e06957841bc21b

TBR=tkent@chromium.org,dcheng@chromium.org,sashab@chromium.org,slangley@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=712963

Review-Url: https://codereview.chromium.org/2888283004
Cr-Commit-Position: refs/heads/master@{#472915}

[modify] https://crrev.com/ba5159d871bb21b4b151262dd9234d0261b81331/third_party/WebKit/Source/core/exported/BUILD.gn
[delete] https://crrev.com/6d7a0de064043e4322a39cab31cd99b2a5972d71/third_party/WebKit/Source/core/exported/WebPluginContainerBase.cpp
[delete] https://crrev.com/6d7a0de064043e4322a39cab31cd99b2a5972d71/third_party/WebKit/Source/core/exported/WebPluginContainerBase.h
[modify] https://crrev.com/ba5159d871bb21b4b151262dd9234d0261b81331/third_party/WebKit/Source/web/ChromeClientImpl.cpp
[modify] https://crrev.com/ba5159d871bb21b4b151262dd9234d0261b81331/third_party/WebKit/Source/web/ContextMenuClientImpl.cpp
[modify] https://crrev.com/ba5159d871bb21b4b151262dd9234d0261b81331/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
[modify] https://crrev.com/ba5159d871bb21b4b151262dd9234d0261b81331/third_party/WebKit/Source/web/WebHelperPluginImpl.cpp
[modify] https://crrev.com/ba5159d871bb21b4b151262dd9234d0261b81331/third_party/WebKit/Source/web/WebHelperPluginImpl.h
[modify] https://crrev.com/ba5159d871bb21b4b151262dd9234d0261b81331/third_party/WebKit/Source/web/WebInputMethodControllerImpl.cpp
[modify] https://crrev.com/ba5159d871bb21b4b151262dd9234d0261b81331/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
[modify] https://crrev.com/ba5159d871bb21b4b151262dd9234d0261b81331/third_party/WebKit/Source/web/WebLocalFrameImpl.h
[modify] https://crrev.com/ba5159d871bb21b4b151262dd9234d0261b81331/third_party/WebKit/Source/web/WebNode.cpp
[modify] https://crrev.com/ba5159d871bb21b4b151262dd9234d0261b81331/third_party/WebKit/Source/web/WebPluginContainerImpl.cpp
[modify] https://crrev.com/ba5159d871bb21b4b151262dd9234d0261b81331/third_party/WebKit/Source/web/WebPluginContainerImpl.h
[modify] https://crrev.com/ba5159d871bb21b4b151262dd9234d0261b81331/third_party/WebKit/Source/web/WebPluginDocument.cpp
[modify] https://crrev.com/ba5159d871bb21b4b151262dd9234d0261b81331/third_party/WebKit/Source/web/WebViewImpl.cpp
[modify] https://crrev.com/ba5159d871bb21b4b151262dd9234d0261b81331/third_party/WebKit/Source/web/tests/WebPluginContainerTest.cpp
Project Member

Comment 24 by bugdroid1@chromium.org, May 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f10adc089153731d35a4a04956d7673342db2e4

commit 7f10adc089153731d35a4a04956d7673342db2e4
Author: slangley <slangley@chromium.org>
Date: Fri May 19 06:54:19 2017

Introduce WebPluginContainerBase to abstract WebPluginContainerImpl.

Many classes in web/ take a dependancy on WebPluginContainerImpl, in some cases
this dependency is cyclic. In order to break this dependency we introduce a new
temporary abstraction WebPluginContainerBase, that derives from PlugingView,
WebPluginContainer and ContextClient.

Classes that were taking a dependency on WebPluginContainerImpl now take a
dependency on WebPluginContainerBase. In cases where there we methods that
were only defined in WebPluginContainerImpl we make them pure virtual in
WebPluginContainerBase and override them in WebPluginContainerImpl.

As WebPluginContainerImpl is garbage collected, we move this to
WebPluginContainerBase and define a virtual trace method.

The intention is for this abstraction to be temporary, once we move all of the
dependencies into core/ we can remove it.

I put the new class in core/exported as it derives from WebPluginContainer.

BUG=712963

Review-Url: https://codereview.chromium.org/2886113002
Cr-Original-Commit-Position: refs/heads/master@{#472810}
Committed: https://chromium.googlesource.com/chromium/src/+/303acce5cc18d95d46342bd089e06957841bc21b
Review-Url: https://codereview.chromium.org/2886113002
Cr-Commit-Position: refs/heads/master@{#473111}

[modify] https://crrev.com/7f10adc089153731d35a4a04956d7673342db2e4/third_party/WebKit/Source/core/exported/BUILD.gn
[add] https://crrev.com/7f10adc089153731d35a4a04956d7673342db2e4/third_party/WebKit/Source/core/exported/WebPluginContainerBase.cpp
[add] https://crrev.com/7f10adc089153731d35a4a04956d7673342db2e4/third_party/WebKit/Source/core/exported/WebPluginContainerBase.h
[modify] https://crrev.com/7f10adc089153731d35a4a04956d7673342db2e4/third_party/WebKit/Source/web/ChromeClientImpl.cpp
[modify] https://crrev.com/7f10adc089153731d35a4a04956d7673342db2e4/third_party/WebKit/Source/web/ContextMenuClientImpl.cpp
[modify] https://crrev.com/7f10adc089153731d35a4a04956d7673342db2e4/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
[modify] https://crrev.com/7f10adc089153731d35a4a04956d7673342db2e4/third_party/WebKit/Source/web/WebHelperPluginImpl.cpp
[modify] https://crrev.com/7f10adc089153731d35a4a04956d7673342db2e4/third_party/WebKit/Source/web/WebHelperPluginImpl.h
[modify] https://crrev.com/7f10adc089153731d35a4a04956d7673342db2e4/third_party/WebKit/Source/web/WebInputMethodControllerImpl.cpp
[modify] https://crrev.com/7f10adc089153731d35a4a04956d7673342db2e4/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
[modify] https://crrev.com/7f10adc089153731d35a4a04956d7673342db2e4/third_party/WebKit/Source/web/WebLocalFrameImpl.h
[modify] https://crrev.com/7f10adc089153731d35a4a04956d7673342db2e4/third_party/WebKit/Source/web/WebNode.cpp
[modify] https://crrev.com/7f10adc089153731d35a4a04956d7673342db2e4/third_party/WebKit/Source/web/WebPluginContainerImpl.cpp
[modify] https://crrev.com/7f10adc089153731d35a4a04956d7673342db2e4/third_party/WebKit/Source/web/WebPluginContainerImpl.h
[modify] https://crrev.com/7f10adc089153731d35a4a04956d7673342db2e4/third_party/WebKit/Source/web/WebPluginDocument.cpp
[modify] https://crrev.com/7f10adc089153731d35a4a04956d7673342db2e4/third_party/WebKit/Source/web/WebViewImpl.cpp
[modify] https://crrev.com/7f10adc089153731d35a4a04956d7673342db2e4/third_party/WebKit/Source/web/tests/WebPluginContainerTest.cpp
Project Member

Comment 26 by bugdroid1@chromium.org, May 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9f9768b2d76c8f09ffb715f5ba6eaa67ee243a7

commit c9f9768b2d76c8f09ffb715f5ba6eaa67ee243a7
Author: slangley <slangley@chromium.org>
Date: Mon May 22 07:47:00 2017

Move PreFinalizer to WebPluginContainerImpl.

Based on feedback in https://codereview.chromium.org/2886113002/ this moves the
finalizer to the concrete class WebPluginContainerImpl.

I tested using  editing/selection/selection-plugin-clear-crash.html
--enable-leak-detection that failed previously when finalizer was not being
called, and it passed.

BUG=712963

Review-Url: https://codereview.chromium.org/2901453002
Cr-Commit-Position: refs/heads/master@{#473522}

[modify] https://crrev.com/c9f9768b2d76c8f09ffb715f5ba6eaa67ee243a7/third_party/WebKit/Source/core/exported/WebPluginContainerBase.h
[modify] https://crrev.com/c9f9768b2d76c8f09ffb715f5ba6eaa67ee243a7/third_party/WebKit/Source/web/WebPluginContainerImpl.h
Project Member

Comment 27 by bugdroid1@chromium.org, May 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c9f28d128319e9d3f534440143ab8f1eeb2e3c4

commit 7c9f28d128319e9d3f534440143ab8f1eeb2e3c4
Author: slangley <slangley@chromium.org>
Date: Mon May 29 05:58:17 2017

Move WebInputMethodControllerImpl to core/exported/ & break dependencies.

It turns out that WebInputMethodControllerImpl does not define any additional
methods over WebInputMethodController, so in general we can change all of the
usage to the abstract class.

WebInputMethodControllerImpl::FromFrame is just a wrapper around WebLocalFrameBase
so removed that method and just call GetWebInputMethodController on
WebLocalFameBase instead.

Also, move WebInputMethodControllerImpl to core/exported/ as is implements the
public GetWebInputMethodController.

BUG=712963

Review-Url: https://codereview.chromium.org/2892393002
Cr-Commit-Position: refs/heads/master@{#475296}

[modify] https://crrev.com/7c9f28d128319e9d3f534440143ab8f1eeb2e3c4/third_party/WebKit/Source/core/exported/BUILD.gn
[rename] https://crrev.com/7c9f28d128319e9d3f534440143ab8f1eeb2e3c4/third_party/WebKit/Source/core/exported/WebInputMethodControllerImpl.cpp
[rename] https://crrev.com/7c9f28d128319e9d3f534440143ab8f1eeb2e3c4/third_party/WebKit/Source/core/exported/WebInputMethodControllerImpl.h
[modify] https://crrev.com/7c9f28d128319e9d3f534440143ab8f1eeb2e3c4/third_party/WebKit/Source/core/exported/WebViewBase.h
[modify] https://crrev.com/7c9f28d128319e9d3f534440143ab8f1eeb2e3c4/third_party/WebKit/Source/web/BUILD.gn
[modify] https://crrev.com/7c9f28d128319e9d3f534440143ab8f1eeb2e3c4/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
[modify] https://crrev.com/7c9f28d128319e9d3f534440143ab8f1eeb2e3c4/third_party/WebKit/Source/web/WebFrameWidgetImpl.h
[modify] https://crrev.com/7c9f28d128319e9d3f534440143ab8f1eeb2e3c4/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
[modify] https://crrev.com/7c9f28d128319e9d3f534440143ab8f1eeb2e3c4/third_party/WebKit/Source/web/WebLocalFrameImpl.h
[modify] https://crrev.com/7c9f28d128319e9d3f534440143ab8f1eeb2e3c4/third_party/WebKit/Source/web/WebViewFrameWidget.cpp
[modify] https://crrev.com/7c9f28d128319e9d3f534440143ab8f1eeb2e3c4/third_party/WebKit/Source/web/WebViewFrameWidget.h
[modify] https://crrev.com/7c9f28d128319e9d3f534440143ab8f1eeb2e3c4/third_party/WebKit/Source/web/WebViewImpl.cpp
[modify] https://crrev.com/7c9f28d128319e9d3f534440143ab8f1eeb2e3c4/third_party/WebKit/Source/web/WebViewImpl.h
[modify] https://crrev.com/7c9f28d128319e9d3f534440143ab8f1eeb2e3c4/third_party/WebKit/Source/web/tests/WebViewTest.cpp
Project Member

Comment 29 by bugdroid1@chromium.org, May 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4203fb9fe1e588b6932448b0b4e79ffb2d4cdc1d

commit 4203fb9fe1e588b6932448b0b4e79ffb2d4cdc1d
Author: slangley <slangley@chromium.org>
Date: Tue May 30 03:13:18 2017

Move more standalone files from web/ to core/exported/.

Some methods needed to be marked BLINK_EXPORT in WebPageImportanceSignals so they
were visible from libblink_core and could be linked against.

BUG=712963

Review-Url: https://codereview.chromium.org/2913653002
Cr-Commit-Position: refs/heads/master@{#475414}

[modify] https://crrev.com/4203fb9fe1e588b6932448b0b4e79ffb2d4cdc1d/third_party/WebKit/Source/core/exported/BUILD.gn
[rename] https://crrev.com/4203fb9fe1e588b6932448b0b4e79ffb2d4cdc1d/third_party/WebKit/Source/core/exported/WebPageImportanceSignals.cpp
[rename] https://crrev.com/4203fb9fe1e588b6932448b0b4e79ffb2d4cdc1d/third_party/WebKit/Source/core/exported/WebPluginScriptForbiddenScope.cpp
[rename] https://crrev.com/4203fb9fe1e588b6932448b0b4e79ffb2d4cdc1d/third_party/WebKit/Source/core/exported/WebScopedUserGesture.cpp
[rename] https://crrev.com/4203fb9fe1e588b6932448b0b4e79ffb2d4cdc1d/third_party/WebKit/Source/core/exported/WebUserGestureIndicator.cpp
[rename] https://crrev.com/4203fb9fe1e588b6932448b0b4e79ffb2d4cdc1d/third_party/WebKit/Source/core/exported/WebUserGestureToken.cpp
[modify] https://crrev.com/4203fb9fe1e588b6932448b0b4e79ffb2d4cdc1d/third_party/WebKit/Source/web/BUILD.gn
[modify] https://crrev.com/4203fb9fe1e588b6932448b0b4e79ffb2d4cdc1d/third_party/WebKit/public/web/WebPageImportanceSignals.h
Project Member

Comment 30 by bugdroid1@chromium.org, May 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d376e7d11c6d2efe83f46fa043f036b0f6246fe

commit 8d376e7d11c6d2efe83f46fa043f036b0f6246fe
Author: sashab <sashab@chromium.org>
Date: Tue May 30 07:16:21 2017

Introduced WebFactory and WebFactoryImpl for constructing web/ classes

Introduced WebFactory and WebFactoryImpl for constructing web/ classes
outside of core/.

This is a temporary class that will be removed once web/ is removed.

BUG=712963

Review-Url: https://codereview.chromium.org/2887523003
Cr-Commit-Position: refs/heads/master@{#475451}

[modify] https://crrev.com/8d376e7d11c6d2efe83f46fa043f036b0f6246fe/third_party/WebKit/Source/core/exported/BUILD.gn
[add] https://crrev.com/8d376e7d11c6d2efe83f46fa043f036b0f6246fe/third_party/WebKit/Source/core/exported/WebFactory.cpp
[add] https://crrev.com/8d376e7d11c6d2efe83f46fa043f036b0f6246fe/third_party/WebKit/Source/core/exported/WebFactory.h
[modify] https://crrev.com/8d376e7d11c6d2efe83f46fa043f036b0f6246fe/third_party/WebKit/Source/web/BUILD.gn
[add] https://crrev.com/8d376e7d11c6d2efe83f46fa043f036b0f6246fe/third_party/WebKit/Source/web/WebFactoryImpl.cpp
[add] https://crrev.com/8d376e7d11c6d2efe83f46fa043f036b0f6246fe/third_party/WebKit/Source/web/WebFactoryImpl.h
[modify] https://crrev.com/8d376e7d11c6d2efe83f46fa043f036b0f6246fe/third_party/WebKit/Source/web/WebKit.cpp
[modify] https://crrev.com/8d376e7d11c6d2efe83f46fa043f036b0f6246fe/third_party/WebKit/Source/web/WebViewImpl.cpp
[modify] https://crrev.com/8d376e7d11c6d2efe83f46fa043f036b0f6246fe/third_party/WebKit/Source/web/WebViewImpl.h
Project Member

Comment 31 by bugdroid1@chromium.org, May 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4415da9dfb0dbdff9331d61b18e7e8389adb7e5

commit a4415da9dfb0dbdff9331d61b18e7e8389adb7e5
Author: Stuart Langley <slangley@chromium.org>
Date: Tue May 30 12:59:52 2017

Move spell checking related files from web/ to new homes in core/.

- SpellCheckerClientImpl to core/page/.
- TextCheckerClientImpl to core/editing/spellcheck/.
- WebTextCheckingCompletionImpl to core/exported/.

Where required add CORE_EXPORT to make the symmols visible outside of
core.

Bug: 712963
Change-Id: If19c0f250b0c01102df8e561acc750bd36775252
Reviewed-on: https://chromium-review.googlesource.com/517471
Commit-Queue: Stuart Langley <slangley@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475507}
[modify] https://crrev.com/a4415da9dfb0dbdff9331d61b18e7e8389adb7e5/third_party/WebKit/Source/core/editing/BUILD.gn
[modify] https://crrev.com/a4415da9dfb0dbdff9331d61b18e7e8389adb7e5/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
[rename] https://crrev.com/a4415da9dfb0dbdff9331d61b18e7e8389adb7e5/third_party/WebKit/Source/core/editing/spellcheck/SpellCheckerClient.h
[rename] https://crrev.com/a4415da9dfb0dbdff9331d61b18e7e8389adb7e5/third_party/WebKit/Source/core/editing/spellcheck/SpellCheckerClientImpl.cpp
[rename] https://crrev.com/a4415da9dfb0dbdff9331d61b18e7e8389adb7e5/third_party/WebKit/Source/core/editing/spellcheck/SpellCheckerClientImpl.h
[rename] https://crrev.com/a4415da9dfb0dbdff9331d61b18e7e8389adb7e5/third_party/WebKit/Source/core/editing/spellcheck/TextCheckerClientImpl.cpp
[rename] https://crrev.com/a4415da9dfb0dbdff9331d61b18e7e8389adb7e5/third_party/WebKit/Source/core/editing/spellcheck/TextCheckerClientImpl.h
[modify] https://crrev.com/a4415da9dfb0dbdff9331d61b18e7e8389adb7e5/third_party/WebKit/Source/core/exported/BUILD.gn
[rename] https://crrev.com/a4415da9dfb0dbdff9331d61b18e7e8389adb7e5/third_party/WebKit/Source/core/exported/WebTextCheckingCompletionImpl.cpp
[rename] https://crrev.com/a4415da9dfb0dbdff9331d61b18e7e8389adb7e5/third_party/WebKit/Source/core/exported/WebTextCheckingCompletionImpl.h
[rename] https://crrev.com/a4415da9dfb0dbdff9331d61b18e7e8389adb7e5/third_party/WebKit/Source/core/exported/WebTextCheckingResult.cpp
[modify] https://crrev.com/a4415da9dfb0dbdff9331d61b18e7e8389adb7e5/third_party/WebKit/Source/core/loader/EmptyClients.h
[modify] https://crrev.com/a4415da9dfb0dbdff9331d61b18e7e8389adb7e5/third_party/WebKit/Source/core/page/BUILD.gn
[modify] https://crrev.com/a4415da9dfb0dbdff9331d61b18e7e8389adb7e5/third_party/WebKit/Source/web/BUILD.gn
[modify] https://crrev.com/a4415da9dfb0dbdff9331d61b18e7e8389adb7e5/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
[modify] https://crrev.com/a4415da9dfb0dbdff9331d61b18e7e8389adb7e5/third_party/WebKit/Source/web/WebViewImpl.h
Project Member

Comment 32 by bugdroid1@chromium.org, May 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/60f73b2110522209cd44f7c7328dd234def75ba6

commit 60f73b2110522209cd44f7c7328dd234def75ba6
Author: Henrik Kjellander <kjellander@chromium.org>
Date: Tue May 30 13:43:29 2017

Revert "Move spell checking related files from web/ to new homes in core/."

This reverts commit a4415da9dfb0dbdff9331d61b18e7e8389adb7e5.

Reason for revert: Breaks WebKit Win Builder (dbg) bot:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20Builder%20%28dbg%29/builds/120680 
FAILED: obj/third_party/WebKit/Source/core/editing/editing/TextCheckerClientImpl.obj 
ninja -t msvc -e environment.x86 -- E:\b\c\goma_client/gomacc.exe "E:\b\depot_tools\win_toolchain\vs_files\d3cb0e37bdd120ad0ac4650b674b09e81be45616\VC\bin\amd64_x86/cl.exe" /nologo /showIncludes /FC @obj/third_party/WebKit/Source/core/editing/editing/TextCheckerClientImpl.obj.rsp /c ../../third_party/WebKit/Source/core/editing/spellcheck/TextCheckerClientImpl.cpp /Foobj/third_party/WebKit/Source/core/editing/editing/TextCheckerClientImpl.obj /Fd"obj/third_party/WebKit/Source/core/editing/editing_cc.pdb"
e:\b\c\b\win_layout\src\third_party\webkit\source\core\exported\webtextcheckingcompletionimpl.h(43): error C2220: warning treated as error - no 'object' file generated
e:\b\c\b\win_layout\src\third_party\webkit\source\core\exported\webtextcheckingcompletionimpl.h(43): warning C4275: non dll-interface class 'blink::WebTextCheckingCompletion' used as base for dll-interface class 'blink::WebTextCheckingCompletionImpl'
e:\b\c\b\win_layout\src\third_party\webkit\public\web\webtextcheckingcompletion.h(43): note: see declaration of 'blink::WebTextCheckingCompletion'
e:\b\c\b\win_layout\src\third_party\webkit\source\core\exported\webtextcheckingcompletionimpl.h(43): note: see declaration of 'blink::WebTextCheckingCompletionImpl'

Original change's description:
> Move spell checking related files from web/ to new homes in core/.
> 
> - SpellCheckerClientImpl to core/page/.
> - TextCheckerClientImpl to core/editing/spellcheck/.
> - WebTextCheckingCompletionImpl to core/exported/.
> 
> Where required add CORE_EXPORT to make the symmols visible outside of
> core.
> 
> Bug: 712963
> Change-Id: If19c0f250b0c01102df8e561acc750bd36775252
> Reviewed-on: https://chromium-review.googlesource.com/517471
> Commit-Queue: Stuart Langley <slangley@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#475507}

TBR=haraken@chromium.org,slangley@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Bug: 712963

Change-Id: Ib45a17c025b26a54eaf545bf23aaa1e2a969ca10
Reviewed-on: https://chromium-review.googlesource.com/517499
Commit-Queue: Henrik Kjellander <kjellander@chromium.org>
Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475515}
[modify] https://crrev.com/60f73b2110522209cd44f7c7328dd234def75ba6/third_party/WebKit/Source/core/editing/BUILD.gn
[modify] https://crrev.com/60f73b2110522209cd44f7c7328dd234def75ba6/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
[modify] https://crrev.com/60f73b2110522209cd44f7c7328dd234def75ba6/third_party/WebKit/Source/core/exported/BUILD.gn
[modify] https://crrev.com/60f73b2110522209cd44f7c7328dd234def75ba6/third_party/WebKit/Source/core/loader/EmptyClients.h
[modify] https://crrev.com/60f73b2110522209cd44f7c7328dd234def75ba6/third_party/WebKit/Source/core/page/BUILD.gn
[rename] https://crrev.com/60f73b2110522209cd44f7c7328dd234def75ba6/third_party/WebKit/Source/core/page/SpellCheckerClient.h
[modify] https://crrev.com/60f73b2110522209cd44f7c7328dd234def75ba6/third_party/WebKit/Source/web/BUILD.gn
[rename] https://crrev.com/60f73b2110522209cd44f7c7328dd234def75ba6/third_party/WebKit/Source/web/SpellCheckerClientImpl.cpp
[rename] https://crrev.com/60f73b2110522209cd44f7c7328dd234def75ba6/third_party/WebKit/Source/web/SpellCheckerClientImpl.h
[rename] https://crrev.com/60f73b2110522209cd44f7c7328dd234def75ba6/third_party/WebKit/Source/web/TextCheckerClientImpl.cpp
[rename] https://crrev.com/60f73b2110522209cd44f7c7328dd234def75ba6/third_party/WebKit/Source/web/TextCheckerClientImpl.h
[modify] https://crrev.com/60f73b2110522209cd44f7c7328dd234def75ba6/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
[rename] https://crrev.com/60f73b2110522209cd44f7c7328dd234def75ba6/third_party/WebKit/Source/web/WebTextCheckingCompletionImpl.cpp
[rename] https://crrev.com/60f73b2110522209cd44f7c7328dd234def75ba6/third_party/WebKit/Source/web/WebTextCheckingCompletionImpl.h
[rename] https://crrev.com/60f73b2110522209cd44f7c7328dd234def75ba6/third_party/WebKit/Source/web/WebTextCheckingResult.cpp
[modify] https://crrev.com/60f73b2110522209cd44f7c7328dd234def75ba6/third_party/WebKit/Source/web/WebViewImpl.h
Project Member

Comment 33 by bugdroid1@chromium.org, May 31 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64a9be37ccf1e29e9e9cc302da2297f2d3661b5d

commit 64a9be37ccf1e29e9e9cc302da2297f2d3661b5d
Author: Stuart Langley <slangley@chromium.org>
Date: Wed May 31 01:28:21 2017

Move DevToolsEmulator from web/ to core/inspector/.

Bug: 712963
Change-Id: Ib2a85a23d3403f85c2f7c3abcc37a3d0bd84017c
Reviewed-on: https://chromium-review.googlesource.com/517807
Commit-Queue: Stuart Langley <slangley@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475721}
[modify] https://crrev.com/64a9be37ccf1e29e9e9cc302da2297f2d3661b5d/third_party/WebKit/Source/core/inspector/BUILD.gn
[rename] https://crrev.com/64a9be37ccf1e29e9e9cc302da2297f2d3661b5d/third_party/WebKit/Source/core/inspector/DevToolsEmulator.cpp
[rename] https://crrev.com/64a9be37ccf1e29e9e9cc302da2297f2d3661b5d/third_party/WebKit/Source/core/inspector/DevToolsEmulator.h
[modify] https://crrev.com/64a9be37ccf1e29e9e9cc302da2297f2d3661b5d/third_party/WebKit/Source/web/BUILD.gn
[modify] https://crrev.com/64a9be37ccf1e29e9e9cc302da2297f2d3661b5d/third_party/WebKit/Source/web/ChromeClientImpl.cpp
[modify] https://crrev.com/64a9be37ccf1e29e9e9cc302da2297f2d3661b5d/third_party/WebKit/Source/web/InspectorEmulationAgent.cpp
[modify] https://crrev.com/64a9be37ccf1e29e9e9cc302da2297f2d3661b5d/third_party/WebKit/Source/web/LocalFrameClientImpl.cpp
[modify] https://crrev.com/64a9be37ccf1e29e9e9cc302da2297f2d3661b5d/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp
[modify] https://crrev.com/64a9be37ccf1e29e9e9cc302da2297f2d3661b5d/third_party/WebKit/Source/web/WebSettingsImpl.cpp
[modify] https://crrev.com/64a9be37ccf1e29e9e9cc302da2297f2d3661b5d/third_party/WebKit/Source/web/WebViewImpl.cpp
[modify] https://crrev.com/64a9be37ccf1e29e9e9cc302da2297f2d3661b5d/third_party/WebKit/Source/web/tests/WebViewTest.cpp
Project Member

Comment 35 by bugdroid1@chromium.org, May 31 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54dae1cef7f1f646ad3523eb3cc749e912d0a92c

commit 54dae1cef7f1f646ad3523eb3cc749e912d0a92c
Author: Stuart Langley <slangley@chromium.org>
Date: Wed May 31 11:41:46 2017

Move WebStorageEventDispatcherImpl.cpp from web/ -> modules/exported/.

Bug: 712963
Change-Id: I0832b75f9bc67a68c6962410b8e88dde8f722011
Reviewed-on: https://chromium-review.googlesource.com/518703
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475879}
[modify] https://crrev.com/54dae1cef7f1f646ad3523eb3cc749e912d0a92c/third_party/WebKit/Source/modules/exported/BUILD.gn
[rename] https://crrev.com/54dae1cef7f1f646ad3523eb3cc749e912d0a92c/third_party/WebKit/Source/modules/exported/WebStorageEventDispatcherImpl.cpp
[modify] https://crrev.com/54dae1cef7f1f646ad3523eb3cc749e912d0a92c/third_party/WebKit/Source/web/BUILD.gn
Project Member

Comment 37 by bugdroid1@chromium.org, Jun 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac8cb56103c977cfba2a8949b1ce94de6b4da096

commit ac8cb56103c977cfba2a8949b1ce94de6b4da096
Author: Stuart Langley <slangley@chromium.org>
Date: Thu Jun 01 03:44:55 2017

Move InspectorEmulationAgent.* from web/ to core/inspector/.

In preperation for moving PageOverlay to core I also changed it to use
WebFrameWidgetBase rather than WebFrameWidgetImpl.

Bug: 712963
Change-Id: Ic20f42c7bb9cdbab82ddb9e940c08b185d7c6c46
Reviewed-on: https://chromium-review.googlesource.com/518602
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476176}
[modify] https://crrev.com/ac8cb56103c977cfba2a8949b1ce94de6b4da096/third_party/WebKit/Source/core/frame/WebFrameWidgetBase.h
[modify] https://crrev.com/ac8cb56103c977cfba2a8949b1ce94de6b4da096/third_party/WebKit/Source/core/frame/WebViewFrameWidget.cpp
[modify] https://crrev.com/ac8cb56103c977cfba2a8949b1ce94de6b4da096/third_party/WebKit/Source/core/frame/WebViewFrameWidget.h
[modify] https://crrev.com/ac8cb56103c977cfba2a8949b1ce94de6b4da096/third_party/WebKit/Source/core/inspector/BUILD.gn
[rename] https://crrev.com/ac8cb56103c977cfba2a8949b1ce94de6b4da096/third_party/WebKit/Source/core/inspector/InspectorEmulationAgent.cpp
[rename] https://crrev.com/ac8cb56103c977cfba2a8949b1ce94de6b4da096/third_party/WebKit/Source/core/inspector/InspectorEmulationAgent.h
[modify] https://crrev.com/ac8cb56103c977cfba2a8949b1ce94de6b4da096/third_party/WebKit/Source/web/BUILD.gn
[modify] https://crrev.com/ac8cb56103c977cfba2a8949b1ce94de6b4da096/third_party/WebKit/Source/web/PageOverlay.cpp
[modify] https://crrev.com/ac8cb56103c977cfba2a8949b1ce94de6b4da096/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp
[modify] https://crrev.com/ac8cb56103c977cfba2a8949b1ce94de6b4da096/third_party/WebKit/Source/web/WebDevToolsAgentImpl.h
[modify] https://crrev.com/ac8cb56103c977cfba2a8949b1ce94de6b4da096/third_party/WebKit/Source/web/WebFrameWidgetImpl.h
Project Member

Comment 38 by bugdroid1@chromium.org, Jun 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2553f2817c5d3bedc8ac060789595b74b4443369

commit 2553f2817c5d3bedc8ac060789595b74b4443369
Author: Stuart Langley <slangley@chromium.org>
Date: Thu Jun 01 03:49:40 2017

Move WebSettingsImpl from web/ to core/exported/.

Bug: 712963
Change-Id: Ie0cd96ec38a027ef6e62ef93debc7f6e93ca31c4
Reviewed-on: https://chromium-review.googlesource.com/520822
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476177}
[modify] https://crrev.com/2553f2817c5d3bedc8ac060789595b74b4443369/third_party/WebKit/Source/core/exported/BUILD.gn
[rename] https://crrev.com/2553f2817c5d3bedc8ac060789595b74b4443369/third_party/WebKit/Source/core/exported/WebSettingsImpl.cpp
[rename] https://crrev.com/2553f2817c5d3bedc8ac060789595b74b4443369/third_party/WebKit/Source/core/exported/WebSettingsImpl.h
[modify] https://crrev.com/2553f2817c5d3bedc8ac060789595b74b4443369/third_party/WebKit/Source/web/BUILD.gn
[modify] https://crrev.com/2553f2817c5d3bedc8ac060789595b74b4443369/third_party/WebKit/Source/web/ChromeClientImpl.cpp
[modify] https://crrev.com/2553f2817c5d3bedc8ac060789595b74b4443369/third_party/WebKit/Source/web/LinkHighlightImpl.cpp
[modify] https://crrev.com/2553f2817c5d3bedc8ac060789595b74b4443369/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp
[modify] https://crrev.com/2553f2817c5d3bedc8ac060789595b74b4443369/third_party/WebKit/Source/web/WebPagePopupImpl.cpp
[modify] https://crrev.com/2553f2817c5d3bedc8ac060789595b74b4443369/third_party/WebKit/Source/web/WebViewImpl.cpp
[modify] https://crrev.com/2553f2817c5d3bedc8ac060789595b74b4443369/third_party/WebKit/Source/web/tests/WebViewTest.cpp
Project Member

Comment 40 by bugdroid1@chromium.org, Jun 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc8303e30e9d84c918e984e9231edb314ff0fb07

commit bc8303e30e9d84c918e984e9231edb314ff0fb07
Author: Nicholas Verne <nverne@chromium.org>
Date: Fri Jun 02 05:10:27 2017

moved *WorkerProxyClientImpl => modules/compositorworker

moved CompositorProxyClientImpl to core/animation
as part of moving code from web/ to core/ or modules/

Bug: 712963
Change-Id: Ia0b8f74f83f594d02e12367d84101854e687bf5d
Reviewed-on: https://chromium-review.googlesource.com/522482
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Stuart Langley <slangley@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476576}
[modify] https://crrev.com/bc8303e30e9d84c918e984e9231edb314ff0fb07/third_party/WebKit/Source/core/animation/BUILD.gn
[rename] https://crrev.com/bc8303e30e9d84c918e984e9231edb314ff0fb07/third_party/WebKit/Source/core/animation/CompositorProxyClientImpl.cpp
[rename] https://crrev.com/bc8303e30e9d84c918e984e9231edb314ff0fb07/third_party/WebKit/Source/core/animation/CompositorProxyClientImpl.h
[rename] https://crrev.com/bc8303e30e9d84c918e984e9231edb314ff0fb07/third_party/WebKit/Source/modules/compositorworker/AnimationWorkletProxyClientImpl.cpp
[rename] https://crrev.com/bc8303e30e9d84c918e984e9231edb314ff0fb07/third_party/WebKit/Source/modules/compositorworker/AnimationWorkletProxyClientImpl.h
[modify] https://crrev.com/bc8303e30e9d84c918e984e9231edb314ff0fb07/third_party/WebKit/Source/modules/compositorworker/BUILD.gn
[rename] https://crrev.com/bc8303e30e9d84c918e984e9231edb314ff0fb07/third_party/WebKit/Source/modules/compositorworker/CompositorWorkerProxyClientImpl.cpp
[rename] https://crrev.com/bc8303e30e9d84c918e984e9231edb314ff0fb07/third_party/WebKit/Source/modules/compositorworker/CompositorWorkerProxyClientImpl.h
[modify] https://crrev.com/bc8303e30e9d84c918e984e9231edb314ff0fb07/third_party/WebKit/Source/web/BUILD.gn
[modify] https://crrev.com/bc8303e30e9d84c918e984e9231edb314ff0fb07/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
[modify] https://crrev.com/bc8303e30e9d84c918e984e9231edb314ff0fb07/third_party/WebKit/Source/web/WebViewImpl.cpp
Project Member

Comment 41 by bugdroid1@chromium.org, Jun 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/561142e1a233d2440a24f77633c7211249588c10

commit 561142e1a233d2440a24f77633c7211249588c10
Author: Stuart Langley <slangley@chromium.org>
Date: Sat Jun 03 04:33:29 2017

Move WebNode and many of it's dependent files from web/ -> core/exported/.

Classes moved (the implementation file only):
- WebNode
- WebElement
- WebDocument
- WebElementCollection
- WebFormControlElement
- WebFormElement
- WebInputElement
- WebLabelElement
- WebMetaElement
- WebOptionElement
- WebSelectElement

Also needed to make some of the definitions BLINK_EXPORTed so they
are visible from core/exported/ into web/ & modules/.

Bug: 712963
Change-Id: Ic980a7bae8d0f5feb25aeb48551bb404c1042819
Reviewed-on: https://chromium-review.googlesource.com/522262
Commit-Queue: Stuart Langley <slangley@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476888}
[modify] https://crrev.com/561142e1a233d2440a24f77633c7211249588c10/third_party/WebKit/Source/core/exported/BUILD.gn
[rename] https://crrev.com/561142e1a233d2440a24f77633c7211249588c10/third_party/WebKit/Source/core/exported/WebDocument.cpp
[rename] https://crrev.com/561142e1a233d2440a24f77633c7211249588c10/third_party/WebKit/Source/core/exported/WebElement.cpp
[rename] https://crrev.com/561142e1a233d2440a24f77633c7211249588c10/third_party/WebKit/Source/core/exported/WebElementCollection.cpp
[rename] https://crrev.com/561142e1a233d2440a24f77633c7211249588c10/third_party/WebKit/Source/core/exported/WebFormControlElement.cpp
[rename] https://crrev.com/561142e1a233d2440a24f77633c7211249588c10/third_party/WebKit/Source/core/exported/WebFormElement.cpp
[rename] https://crrev.com/561142e1a233d2440a24f77633c7211249588c10/third_party/WebKit/Source/core/exported/WebInputElement.cpp
[rename] https://crrev.com/561142e1a233d2440a24f77633c7211249588c10/third_party/WebKit/Source/core/exported/WebLabelElement.cpp
[rename] https://crrev.com/561142e1a233d2440a24f77633c7211249588c10/third_party/WebKit/Source/core/exported/WebMetaElement.cpp
[rename] https://crrev.com/561142e1a233d2440a24f77633c7211249588c10/third_party/WebKit/Source/core/exported/WebNode.cpp
[rename] https://crrev.com/561142e1a233d2440a24f77633c7211249588c10/third_party/WebKit/Source/core/exported/WebOptionElement.cpp
[rename] https://crrev.com/561142e1a233d2440a24f77633c7211249588c10/third_party/WebKit/Source/core/exported/WebSelectElement.cpp
[modify] https://crrev.com/561142e1a233d2440a24f77633c7211249588c10/third_party/WebKit/Source/web/BUILD.gn
[modify] https://crrev.com/561142e1a233d2440a24f77633c7211249588c10/third_party/WebKit/public/web/WebElement.h
[modify] https://crrev.com/561142e1a233d2440a24f77633c7211249588c10/third_party/WebKit/public/web/WebFormControlElement.h
[modify] https://crrev.com/561142e1a233d2440a24f77633c7211249588c10/third_party/WebKit/public/web/WebFormElement.h
[modify] https://crrev.com/561142e1a233d2440a24f77633c7211249588c10/third_party/WebKit/public/web/WebInputElement.h
[modify] https://crrev.com/561142e1a233d2440a24f77633c7211249588c10/third_party/WebKit/public/web/WebNode.h
[modify] https://crrev.com/561142e1a233d2440a24f77633c7211249588c10/third_party/WebKit/public/web/WebOptionElement.h
Project Member

Comment 43 by bugdroid1@chromium.org, Jun 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bfe8508c6562faa4857820da57c2ebee623b29be

commit bfe8508c6562faa4857820da57c2ebee623b29be
Author: Stuart Langley <slangley@chromium.org>
Date: Tue Jun 06 02:07:59 2017

Move some media related files from web to modules.

- WebUserMediaRequest to modules/exported/.
- UserMediaClientImpl to modules/mediastream/.

Where required, make the symbols visible using BLINK_EXPORT or
MODULES_EXPORT.

Bug: 712963
Change-Id: I7b26093ae65f1dcb410778453fa038264ba4d103
Reviewed-on: https://chromium-review.googlesource.com/523926
Commit-Queue: Stuart Langley <slangley@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#477155}
[modify] https://crrev.com/bfe8508c6562faa4857820da57c2ebee623b29be/third_party/WebKit/Source/modules/exported/BUILD.gn
[rename] https://crrev.com/bfe8508c6562faa4857820da57c2ebee623b29be/third_party/WebKit/Source/modules/exported/WebMediaDevicesRequest.cpp
[rename] https://crrev.com/bfe8508c6562faa4857820da57c2ebee623b29be/third_party/WebKit/Source/modules/exported/WebUserMediaRequest.cpp
[modify] https://crrev.com/bfe8508c6562faa4857820da57c2ebee623b29be/third_party/WebKit/Source/modules/mediastream/BUILD.gn
[rename] https://crrev.com/bfe8508c6562faa4857820da57c2ebee623b29be/third_party/WebKit/Source/modules/mediastream/UserMediaClientImpl.cpp
[rename] https://crrev.com/bfe8508c6562faa4857820da57c2ebee623b29be/third_party/WebKit/Source/modules/mediastream/UserMediaClientImpl.h
[modify] https://crrev.com/bfe8508c6562faa4857820da57c2ebee623b29be/third_party/WebKit/Source/web/BUILD.gn
[modify] https://crrev.com/bfe8508c6562faa4857820da57c2ebee623b29be/third_party/WebKit/Source/web/WebLocalFrameImpl.h
[modify] https://crrev.com/bfe8508c6562faa4857820da57c2ebee623b29be/third_party/WebKit/public/web/WebUserMediaRequest.h
Project Member

Comment 44 by bugdroid1@chromium.org, Jun 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b25f007b5254eaa159ed79aab8258211a622fb5d

commit b25f007b5254eaa159ed79aab8258211a622fb5d
Author: Stuart Langley <slangley@chromium.org>
Date: Tue Jun 06 19:05:06 2017

Move WebFrameContentDumper.cpp from web/ -> core/exported/.

Bug: 712963
Change-Id: I5e8650790120e78d316761c3930aa4303326db23
Reviewed-on: https://chromium-review.googlesource.com/525914
Commit-Queue: Stuart Langley <slangley@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#477359}
[modify] https://crrev.com/b25f007b5254eaa159ed79aab8258211a622fb5d/third_party/WebKit/Source/core/exported/BUILD.gn
[rename] https://crrev.com/b25f007b5254eaa159ed79aab8258211a622fb5d/third_party/WebKit/Source/core/exported/WebFrameContentDumper.cpp
[modify] https://crrev.com/b25f007b5254eaa159ed79aab8258211a622fb5d/third_party/WebKit/Source/web/BUILD.gn
Project Member

Comment 46 by bugdroid1@chromium.org, Jun 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e3f6bec14663381223e68665cf78a1e49d3f2f4a

commit e3f6bec14663381223e68665cf78a1e49d3f2f4a
Author: Sasha Bermeister <sashab@chromium.org>
Date: Thu Jun 08 05:08:04 2017

Move ColorChooser controllers from web/ to core/html/forms

This patch moves:
- ColorChooserPopupUIController
- ColorChooserUIController
from web/ to core/html/forms.

This is pre-work for moving ChromeClientImpl to core/.

Bug: 712963
Change-Id: I93ed2b559cbb37a54fead188f412f5e71419a1d7
Reviewed-on: https://chromium-review.googlesource.com/526895
Commit-Queue: Sasha Morrissey <sashab@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#477897}
[modify] https://crrev.com/e3f6bec14663381223e68665cf78a1e49d3f2f4a/third_party/WebKit/Source/core/html/BUILD.gn
[rename] https://crrev.com/e3f6bec14663381223e68665cf78a1e49d3f2f4a/third_party/WebKit/Source/core/html/forms/ColorChooserPopupUIController.cpp
[rename] https://crrev.com/e3f6bec14663381223e68665cf78a1e49d3f2f4a/third_party/WebKit/Source/core/html/forms/ColorChooserPopupUIController.h
[rename] https://crrev.com/e3f6bec14663381223e68665cf78a1e49d3f2f4a/third_party/WebKit/Source/core/html/forms/ColorChooserUIController.cpp
[rename] https://crrev.com/e3f6bec14663381223e68665cf78a1e49d3f2f4a/third_party/WebKit/Source/core/html/forms/ColorChooserUIController.h
[modify] https://crrev.com/e3f6bec14663381223e68665cf78a1e49d3f2f4a/third_party/WebKit/Source/web/BUILD.gn
[modify] https://crrev.com/e3f6bec14663381223e68665cf78a1e49d3f2f4a/third_party/WebKit/Source/web/ChromeClientImpl.cpp

Comment 47 by sashab@chromium.org, Jun 9 2017

Blocking: 731490
Project Member

Comment 48 by bugdroid1@chromium.org, Jun 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fd5c855b027d953b3a995041440bed83b9313197

commit fd5c855b027d953b3a995041440bed83b9313197
Author: Stuart Langley <slangley@chromium.org>
Date: Fri Jun 09 07:30:11 2017

Move RemoteFrame related classes from web/ to core/(frame|exported)/.

This CL moves all of the RemoteFrame classes and dependencies to core.

Classes moved:
- WebFrame.cpp -> core/exported/.
- WebRemoteFrameImpl.* -> core/exported/.
- OpenedFrameTracker.* -> core/frame/.
- RemoteFrameClientImpl.* -> core/frame/.
- RemoteFrameOwner.* -> core/frame/.

Also, changed ChromeClient::WebView to return a WebView* rather than
a void*, not sure why it was doing that. Had to rename the method
to GetWebView to avoid a name clash.

Use a factory to instantiate WebLocalFrameBase to avoid linker errors.

Update header locations and lint errors.

Bug: 712963
Change-Id: I853bd5bd1671ad44f0ced722710cbd19f7b4b073
Reviewed-on: https://chromium-review.googlesource.com/527737
Commit-Queue: Stuart Langley <slangley@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478225}
[modify] https://crrev.com/fd5c855b027d953b3a995041440bed83b9313197/third_party/WebKit/Source/core/exported/BUILD.gn
[rename] https://crrev.com/fd5c855b027d953b3a995041440bed83b9313197/third_party/WebKit/Source/core/exported/WebFrame.cpp
[rename] https://crrev.com/fd5c855b027d953b3a995041440bed83b9313197/third_party/WebKit/Source/core/exported/WebRemoteFrameImpl.cpp
[rename] https://crrev.com/fd5c855b027d953b3a995041440bed83b9313197/third_party/WebKit/Source/core/exported/WebRemoteFrameImpl.h
[modify] https://crrev.com/fd5c855b027d953b3a995041440bed83b9313197/third_party/WebKit/Source/core/exported/WebViewBase.h
[modify] https://crrev.com/fd5c855b027d953b3a995041440bed83b9313197/third_party/WebKit/Source/core/frame/BUILD.gn
[rename] https://crrev.com/fd5c855b027d953b3a995041440bed83b9313197/third_party/WebKit/Source/core/frame/OpenedFrameTracker.cpp
[rename] https://crrev.com/fd5c855b027d953b3a995041440bed83b9313197/third_party/WebKit/Source/core/frame/OpenedFrameTracker.h
[rename] https://crrev.com/fd5c855b027d953b3a995041440bed83b9313197/third_party/WebKit/Source/core/frame/RemoteFrameClientImpl.cpp
[rename] https://crrev.com/fd5c855b027d953b3a995041440bed83b9313197/third_party/WebKit/Source/core/frame/RemoteFrameClientImpl.h
[rename] https://crrev.com/fd5c855b027d953b3a995041440bed83b9313197/third_party/WebKit/Source/core/frame/RemoteFrameOwner.cpp
[rename] https://crrev.com/fd5c855b027d953b3a995041440bed83b9313197/third_party/WebKit/Source/core/frame/RemoteFrameOwner.h
[modify] https://crrev.com/fd5c855b027d953b3a995041440bed83b9313197/third_party/WebKit/Source/core/frame/WebRemoteFrameBase.h
[modify] https://crrev.com/fd5c855b027d953b3a995041440bed83b9313197/third_party/WebKit/Source/core/loader/EmptyClients.h
[modify] https://crrev.com/fd5c855b027d953b3a995041440bed83b9313197/third_party/WebKit/Source/core/page/ChromeClient.h
[modify] https://crrev.com/fd5c855b027d953b3a995041440bed83b9313197/third_party/WebKit/Source/web/BUILD.gn
[modify] https://crrev.com/fd5c855b027d953b3a995041440bed83b9313197/third_party/WebKit/Source/web/ChromeClientImpl.cpp
[modify] https://crrev.com/fd5c855b027d953b3a995041440bed83b9313197/third_party/WebKit/Source/web/ChromeClientImpl.h
[modify] https://crrev.com/fd5c855b027d953b3a995041440bed83b9313197/third_party/WebKit/Source/web/WebFrameSerializer.cpp
[modify] https://crrev.com/fd5c855b027d953b3a995041440bed83b9313197/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
[modify] https://crrev.com/fd5c855b027d953b3a995041440bed83b9313197/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
[modify] https://crrev.com/fd5c855b027d953b3a995041440bed83b9313197/third_party/WebKit/Source/web/WebPagePopupImpl.cpp
[modify] https://crrev.com/fd5c855b027d953b3a995041440bed83b9313197/third_party/WebKit/Source/web/WebViewImpl.cpp
[modify] https://crrev.com/fd5c855b027d953b3a995041440bed83b9313197/third_party/WebKit/Source/web/WebViewImpl.h
[modify] https://crrev.com/fd5c855b027d953b3a995041440bed83b9313197/third_party/WebKit/Source/web/tests/FrameTestHelpers.cpp
[modify] https://crrev.com/fd5c855b027d953b3a995041440bed83b9313197/third_party/WebKit/Source/web/tests/RootScrollerTest.cpp
[modify] https://crrev.com/fd5c855b027d953b3a995041440bed83b9313197/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
[modify] https://crrev.com/fd5c855b027d953b3a995041440bed83b9313197/third_party/WebKit/Source/web/tests/scheduler/FrameThrottlingTest.cpp
[modify] https://crrev.com/fd5c855b027d953b3a995041440bed83b9313197/third_party/WebKit/public/web/WebFrame.h
Project Member

Comment 49 by bugdroid1@chromium.org, Jun 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/af71c6accb262b633e7a000f55a99cbbddf20fb1

commit af71c6accb262b633e7a000f55a99cbbddf20fb1
Author: Stuart Langley <slangley@chromium.org>
Date: Sat Jun 10 19:01:44 2017

Move more files from web/ to core/exported/.

This CL moves more implementation files of public/web/ classes to
core/exported/. Files moved:

- WebDOMMessageEvent.cpp.
- WebContextFeatures.cpp.
- WebLanguageDetectionDetails.cpp
- WebPluginDocument.cpp.
- WebSearchableFormData.cpp
- WebScopedWindowFocusAllowedIndicator.cpp.

Bug: 712963
Change-Id: Ib9c92047516cd5401fd6f6406c1b9967f6d49b86
Reviewed-on: https://chromium-review.googlesource.com/530427
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478519}
[modify] https://crrev.com/af71c6accb262b633e7a000f55a99cbbddf20fb1/third_party/WebKit/Source/core/exported/BUILD.gn
[rename] https://crrev.com/af71c6accb262b633e7a000f55a99cbbddf20fb1/third_party/WebKit/Source/core/exported/WebContextFeatures.cpp
[rename] https://crrev.com/af71c6accb262b633e7a000f55a99cbbddf20fb1/third_party/WebKit/Source/core/exported/WebDOMMessageEvent.cpp
[rename] https://crrev.com/af71c6accb262b633e7a000f55a99cbbddf20fb1/third_party/WebKit/Source/core/exported/WebLanguageDetectionDetails.cpp
[rename] https://crrev.com/af71c6accb262b633e7a000f55a99cbbddf20fb1/third_party/WebKit/Source/core/exported/WebPluginDocument.cpp
[rename] https://crrev.com/af71c6accb262b633e7a000f55a99cbbddf20fb1/third_party/WebKit/Source/core/exported/WebScopedWindowFocusAllowedIndicator.cpp
[rename] https://crrev.com/af71c6accb262b633e7a000f55a99cbbddf20fb1/third_party/WebKit/Source/core/exported/WebSearchableFormData.cpp
[modify] https://crrev.com/af71c6accb262b633e7a000f55a99cbbddf20fb1/third_party/WebKit/Source/web/BUILD.gn
Project Member

Comment 51 by bugdroid1@chromium.org, Jun 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d6ffb136dcb41a03b83742a82893df0e90ad703

commit 2d6ffb136dcb41a03b83742a82893df0e90ad703
Author: Stuart Langley <slangley@chromium.org>
Date: Tue Jun 13 00:10:59 2017

Move NavigatorContentUtilsClientImpl.* from web/ -> modules/navigatorcontentutils/.

Note there is a NavigatorContentUtilsClientMock.cpp so trying to merge the
definition and the Impl is not that interesting.

Bug: 712963
Change-Id: I6c1c8fb5ebc521b8748866483e8283ab408ace16
Reviewed-on: https://chromium-review.googlesource.com/531913
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478831}
[modify] https://crrev.com/2d6ffb136dcb41a03b83742a82893df0e90ad703/third_party/WebKit/Source/modules/navigatorcontentutils/BUILD.gn
[rename] https://crrev.com/2d6ffb136dcb41a03b83742a82893df0e90ad703/third_party/WebKit/Source/modules/navigatorcontentutils/NavigatorContentUtilsClientImpl.cpp
[rename] https://crrev.com/2d6ffb136dcb41a03b83742a82893df0e90ad703/third_party/WebKit/Source/modules/navigatorcontentutils/NavigatorContentUtilsClientImpl.h
[modify] https://crrev.com/2d6ffb136dcb41a03b83742a82893df0e90ad703/third_party/WebKit/Source/web/BUILD.gn
[modify] https://crrev.com/2d6ffb136dcb41a03b83742a82893df0e90ad703/third_party/WebKit/Source/web/ChromeClientImpl.cpp
Project Member

Comment 54 by bugdroid1@chromium.org, Jun 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3e2294df0c1cba350f77b6496b09ce1c7da90147

commit 3e2294df0c1cba350f77b6496b09ce1c7da90147
Author: Joel Hockey <joelhockey@chromium.org>
Date: Tue Jun 13 07:59:08 2017

Move web/tests/FrameTestHelpers to core/frame.

Bug: 712963
Change-Id: I5e30161c130ce06014ede3222fd42a9722990a40
Reviewed-on: https://chromium-review.googlesource.com/532454
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478926}
[modify] https://crrev.com/3e2294df0c1cba350f77b6496b09ce1c7da90147/third_party/WebKit/Source/core/BUILD.gn
[rename] https://crrev.com/3e2294df0c1cba350f77b6496b09ce1c7da90147/third_party/WebKit/Source/core/frame/FrameTestHelpers.cpp
[rename] https://crrev.com/3e2294df0c1cba350f77b6496b09ce1c7da90147/third_party/WebKit/Source/core/frame/FrameTestHelpers.h
[modify] https://crrev.com/3e2294df0c1cba350f77b6496b09ce1c7da90147/third_party/WebKit/Source/web/BUILD.gn
[modify] https://crrev.com/3e2294df0c1cba350f77b6496b09ce1c7da90147/third_party/WebKit/Source/web/ExternalPopupMenuTest.cpp
[modify] https://crrev.com/3e2294df0c1cba350f77b6496b09ce1c7da90147/third_party/WebKit/Source/web/LinkHighlightImplTest.cpp
[modify] https://crrev.com/3e2294df0c1cba350f77b6496b09ce1c7da90147/third_party/WebKit/Source/web/PageOverlayTest.cpp
[modify] https://crrev.com/3e2294df0c1cba350f77b6496b09ce1c7da90147/third_party/WebKit/Source/web/WebAssociatedURLLoaderImplTest.cpp
[modify] https://crrev.com/3e2294df0c1cba350f77b6496b09ce1c7da90147/third_party/WebKit/Source/web/tests/ActivityLoggerTest.cpp
[modify] https://crrev.com/3e2294df0c1cba350f77b6496b09ce1c7da90147/third_party/WebKit/Source/web/tests/BrowserControlsTest.cpp
[modify] https://crrev.com/3e2294df0c1cba350f77b6496b09ce1c7da90147/third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp
[modify] https://crrev.com/3e2294df0c1cba350f77b6496b09ce1c7da90147/third_party/WebKit/Source/web/tests/CompositorWorkerTest.cpp
[modify] https://crrev.com/3e2294df0c1cba350f77b6496b09ce1c7da90147/third_party/WebKit/Source/web/tests/DocumentLoaderTest.cpp
[modify] https://crrev.com/3e2294df0c1cba350f77b6496b09ce1c7da90147/third_party/WebKit/Source/web/tests/FrameSerializerTest.cpp
[modify] https://crrev.com/3e2294df0c1cba350f77b6496b09ce1c7da90147/third_party/WebKit/Source/web/tests/ImeOnFocusTest.cpp
[modify] https://crrev.com/3e2294df0c1cba350f77b6496b09ce1c7da90147/third_party/WebKit/Source/web/tests/LayoutGeometryMapTest.cpp
[modify] https://crrev.com/3e2294df0c1cba350f77b6496b09ce1c7da90147/third_party/WebKit/Source/web/tests/LinkSelectionTest.cpp
[modify] https://crrev.com/3e2294df0c1cba350f77b6496b09ce1c7da90147/third_party/WebKit/Source/web/tests/ListenerLeakTest.cpp
[modify] https://crrev.com/3e2294df0c1cba350f77b6496b09ce1c7da90147/third_party/WebKit/Source/web/tests/LocalFrameClientImplTest.cpp
[modify] https://crrev.com/3e2294df0c1cba350f77b6496b09ce1c7da90147/third_party/WebKit/Source/web/tests/MHTMLTest.cpp
[modify] https://crrev.com/3e2294df0c1cba350f77b6496b09ce1c7da90147/third_party/WebKit/Source/web/tests/PrerenderingTest.cpp
[modify] https://crrev.com/3e2294df0c1cba350f77b6496b09ce1c7da90147/third_party/WebKit/Source/web/tests/ProgrammaticScrollTest.cpp
[modify] https://crrev.com/3e2294df0c1cba350f77b6496b09ce1c7da90147/third_party/WebKit/Source/web/tests/RootScrollerTest.cpp
[modify] https://crrev.com/3e2294df0c1cba350f77b6496b09ce1c7da90147/third_party/WebKit/Source/web/tests/ScreenWakeLockTest.cpp
[modify] https://crrev.com/3e2294df0c1cba350f77b6496b09ce1c7da90147/third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp
[modify] https://crrev.com/3e2294df0c1cba350f77b6496b09ce1c7da90147/third_party/WebKit/Source/web/tests/TextFinderTest.cpp
[modify] https://crrev.com/3e2294df0c1cba350f77b6496b09ce1c7da90147/third_party/WebKit/Source/web/tests/TouchActionTest.cpp
[modify] https://crrev.com/3e2294df0c1cba350f77b6496b09ce1c7da90147/third_party/WebKit/Source/web/tests/ViewportTest.cpp
[modify] https://crrev.com/3e2294df0c1cba350f77b6496b09ce1c7da90147/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp
[modify] https://crrev.com/3e2294df0c1cba350f77b6496b09ce1c7da90147/third_party/WebKit/Source/web/tests/WebDocumentSubresourceFilterTest.cpp
[modify] https://crrev.com/3e2294df0c1cba350f77b6496b09ce1c7da90147/third_party/WebKit/Source/web/tests/WebDocumentTest.cpp
[modify] https://crrev.com/3e2294df0c1cba350f77b6496b09ce1c7da90147/third_party/WebKit/Source/web/tests/WebFrameSerializerSanitizationTest.cpp
[modify] https://crrev.com/3e2294df0c1cba350f77b6496b09ce1c7da90147/third_party/WebKit/Source/web/tests/WebFrameSerializerTest.cpp
[modify] https://crrev.com/3e2294df0c1cba350f77b6496b09ce1c7da90147/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
[modify] https://crrev.com/3e2294df0c1cba350f77b6496b09ce1c7da90147/third_party/WebKit/Source/web/tests/WebHelperPluginTest.cpp
[modify] https://crrev.com/3e2294df0c1cba350f77b6496b09ce1c7da90147/third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp
[modify] https://crrev.com/3e2294df0c1cba350f77b6496b09ce1c7da90147/third_party/WebKit/Source/web/tests/WebPluginContainerTest.cpp
[modify] https://crrev.com/3e2294df0c1cba350f77b6496b09ce1c7da90147/third_party/WebKit/Source/web/tests/WebSearchableFormDataTest.cpp
[modify] https://crrev.com/3e2294df0c1cba350f77b6496b09ce1c7da90147/third_party/WebKit/Source/web/tests/WebViewTest.cpp
[modify] https://crrev.com/3e2294df0c1cba350f77b6496b09ce1c7da90147/third_party/WebKit/Source/web/tests/sim/SimTest.h
[modify] https://crrev.com/3e2294df0c1cba350f77b6496b09ce1c7da90147/third_party/WebKit/Source/web/tests/sim/SimWebFrameClient.h
[modify] https://crrev.com/3e2294df0c1cba350f77b6496b09ce1c7da90147/third_party/WebKit/Source/web/tests/sim/SimWebViewClient.h
Project Member

Comment 55 by bugdroid1@chromium.org, Jun 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/157a41f6b845be5481079b9482319e65b48cf9e1

commit 157a41f6b845be5481079b9482319e65b48cf9e1
Author: Joel Hockey <joelhockey@chromium.org>
Date: Tue Jun 13 11:00:07 2017

Move web/LinkHighlightImpl to core/paint.

Update core/DEPS to allow ui/gfx/geometry since
LinkHighLightImpl overrides 
public/platform/WebContentLayerClient::PaintableRegion()
which returns gfx::Rect.



Bug: 712963
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I0070131389425071fa4f00d7d66169d8d89ffa45
Reviewed-on: https://chromium-review.googlesource.com/532735
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478961}
[modify] https://crrev.com/157a41f6b845be5481079b9482319e65b48cf9e1/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/157a41f6b845be5481079b9482319e65b48cf9e1/third_party/WebKit/Source/core/DEPS
[modify] https://crrev.com/157a41f6b845be5481079b9482319e65b48cf9e1/third_party/WebKit/Source/core/paint/BUILD.gn
[rename] https://crrev.com/157a41f6b845be5481079b9482319e65b48cf9e1/third_party/WebKit/Source/core/paint/LinkHighlightImpl.cpp
[rename] https://crrev.com/157a41f6b845be5481079b9482319e65b48cf9e1/third_party/WebKit/Source/core/paint/LinkHighlightImpl.h
[rename] https://crrev.com/157a41f6b845be5481079b9482319e65b48cf9e1/third_party/WebKit/Source/core/paint/LinkHighlightImplTest.cpp
[modify] https://crrev.com/157a41f6b845be5481079b9482319e65b48cf9e1/third_party/WebKit/Source/web/BUILD.gn
[modify] https://crrev.com/157a41f6b845be5481079b9482319e65b48cf9e1/third_party/WebKit/Source/web/WebViewImpl.cpp
Project Member

Comment 56 by bugdroid1@chromium.org, Jun 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/137bcf790f007ee41c707d3cb533bc4a0b74ff14

commit 137bcf790f007ee41c707d3cb533bc4a0b74ff14
Author: Stuart Langley <slangley@chromium.org>
Date: Tue Jun 13 17:29:25 2017

Use a callback to register modules supplements on a LocalFrame.

This CL moves the code that registers supplements on a LocalFrame from
ChromeClientImpl to using a callback that is defined in ModulesInitializer.

This allows code that is defined in modules to register with a class that is
defined in core and not break layering. Note that we will be moving
ChromeClientImpl to core/ and ultiately removing it.

We preserve the current behaviour of EmptyChromeClient not registering any
suppliements by overriding the InstallSuppliment method in EmptyChromeClient. 

Bug: 712963
Change-Id: I2bce21fff5930dfdb87039214a16df22d1821bd8
Reviewed-on: https://chromium-review.googlesource.com/532093
Commit-Queue: Stuart Langley <slangley@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#479056}
[modify] https://crrev.com/137bcf790f007ee41c707d3cb533bc4a0b74ff14/third_party/WebKit/Source/core/loader/EmptyClients.h
[modify] https://crrev.com/137bcf790f007ee41c707d3cb533bc4a0b74ff14/third_party/WebKit/Source/core/page/ChromeClient.cpp
[modify] https://crrev.com/137bcf790f007ee41c707d3cb533bc4a0b74ff14/third_party/WebKit/Source/core/page/ChromeClient.h
[modify] https://crrev.com/137bcf790f007ee41c707d3cb533bc4a0b74ff14/third_party/WebKit/Source/modules/ModulesInitializer.cpp
[modify] https://crrev.com/137bcf790f007ee41c707d3cb533bc4a0b74ff14/third_party/WebKit/Source/web/ChromeClientImpl.cpp
[modify] https://crrev.com/137bcf790f007ee41c707d3cb533bc4a0b74ff14/third_party/WebKit/Source/web/ChromeClientImpl.h
Project Member

Comment 57 by bugdroid1@chromium.org, Jun 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ffb480444a84adb2b3b983c6934d3fd76f4bd223

commit ffb480444a84adb2b3b983c6934d3fd76f4bd223
Author: Stuart Langley <slangley@chromium.org>
Date: Wed Jun 14 00:09:37 2017

Fold ContentMenuClientImpl into ContextMenuClient.

Bug: 712963
Change-Id: I1e0511f7877c7363ce20771eb1b496cab2b8c1fe
Reviewed-on: https://chromium-review.googlesource.com/533734
Commit-Queue: Stuart Langley <slangley@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#479218}
[modify] https://crrev.com/ffb480444a84adb2b3b983c6934d3fd76f4bd223/third_party/WebKit/Source/core/loader/EmptyClients.h
[modify] https://crrev.com/ffb480444a84adb2b3b983c6934d3fd76f4bd223/third_party/WebKit/Source/core/page/BUILD.gn
[rename] https://crrev.com/ffb480444a84adb2b3b983c6934d3fd76f4bd223/third_party/WebKit/Source/core/page/ContextMenuClient.cpp
[modify] https://crrev.com/ffb480444a84adb2b3b983c6934d3fd76f4bd223/third_party/WebKit/Source/core/page/ContextMenuClient.h
[modify] https://crrev.com/ffb480444a84adb2b3b983c6934d3fd76f4bd223/third_party/WebKit/Source/web/BUILD.gn
[delete] https://crrev.com/37df2ae529148adcb5f8a867ed90aa1d05dd5fe8/third_party/WebKit/Source/web/ContextMenuClientImpl.h
[modify] https://crrev.com/ffb480444a84adb2b3b983c6934d3fd76f4bd223/third_party/WebKit/Source/web/WebViewImpl.cpp
[modify] https://crrev.com/ffb480444a84adb2b3b983c6934d3fd76f4bd223/third_party/WebKit/Source/web/WebViewImpl.h
Project Member

Comment 58 by bugdroid1@chromium.org, Jun 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6161a43f311f916bf63e88e8d95c6b725dc62c00

commit 6161a43f311f916bf63e88e8d95c6b725dc62c00
Author: Sasha Bermeister <sashab@chromium.org>
Date: Wed Jun 14 02:17:12 2017

Move a bunch of ChromeClientImpl dependencies out of web/

This patch moves the following classes out of web/:
- ExternalPopupMenu -> core/page
- PopupMenuImpl -> core/page
- ExternalDateTimeChooser -> core/html/forms
- NavigatorContentUtilsClientImpl -> modules/navigatorcontentutils

Bug: 712963
Change-Id: I7cb8801985db0a4d9563d5441b8fbeb255e9eb6a
Reviewed-on: https://chromium-review.googlesource.com/526536
Commit-Queue: Sasha Morrissey <sashab@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#479255}
[modify] https://crrev.com/6161a43f311f916bf63e88e8d95c6b725dc62c00/third_party/WebKit/Source/core/html/BUILD.gn
[rename] https://crrev.com/6161a43f311f916bf63e88e8d95c6b725dc62c00/third_party/WebKit/Source/core/html/forms/ExternalDateTimeChooser.cpp
[rename] https://crrev.com/6161a43f311f916bf63e88e8d95c6b725dc62c00/third_party/WebKit/Source/core/html/forms/ExternalDateTimeChooser.h
[modify] https://crrev.com/6161a43f311f916bf63e88e8d95c6b725dc62c00/third_party/WebKit/Source/core/page/BUILD.gn
[rename] https://crrev.com/6161a43f311f916bf63e88e8d95c6b725dc62c00/third_party/WebKit/Source/core/page/ExternalPopupMenu.cpp
[rename] https://crrev.com/6161a43f311f916bf63e88e8d95c6b725dc62c00/third_party/WebKit/Source/core/page/ExternalPopupMenu.h
[rename] https://crrev.com/6161a43f311f916bf63e88e8d95c6b725dc62c00/third_party/WebKit/Source/core/page/PopupMenuImpl.cpp
[rename] https://crrev.com/6161a43f311f916bf63e88e8d95c6b725dc62c00/third_party/WebKit/Source/core/page/PopupMenuImpl.h
[modify] https://crrev.com/6161a43f311f916bf63e88e8d95c6b725dc62c00/third_party/WebKit/Source/modules/navigatorcontentutils/NavigatorContentUtilsClientImpl.h
[modify] https://crrev.com/6161a43f311f916bf63e88e8d95c6b725dc62c00/third_party/WebKit/Source/platform/PopupMenu.h
[modify] https://crrev.com/6161a43f311f916bf63e88e8d95c6b725dc62c00/third_party/WebKit/Source/web/BUILD.gn
[modify] https://crrev.com/6161a43f311f916bf63e88e8d95c6b725dc62c00/third_party/WebKit/Source/web/ChromeClientImpl.cpp
[modify] https://crrev.com/6161a43f311f916bf63e88e8d95c6b725dc62c00/third_party/WebKit/Source/web/ExternalPopupMenuTest.cpp
Project Member

Comment 59 by bugdroid1@chromium.org, Jun 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/864784a313f583c72917cb706418088ca2311c52

commit 864784a313f583c72917cb706418088ca2311c52
Author: Sasha Bermeister <sashab@chromium.org>
Date: Wed Jun 14 04:11:34 2017

Move PopupMenu from platform/ to core/page

PopupMenu will be merged with PopupMenuImpl once it moves to core/page
as well.

Bug: 712963
Change-Id: Ib9e8b0da67dfbcf5bc86d3cefcd1d168c603eb62
Reviewed-on: https://chromium-review.googlesource.com/527015
Commit-Queue: Sasha Morrissey <sashab@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#479279}
[modify] https://crrev.com/864784a313f583c72917cb706418088ca2311c52/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp
[modify] https://crrev.com/864784a313f583c72917cb706418088ca2311c52/third_party/WebKit/Source/core/page/BUILD.gn
[modify] https://crrev.com/864784a313f583c72917cb706418088ca2311c52/third_party/WebKit/Source/core/page/ChromeClient.h
[modify] https://crrev.com/864784a313f583c72917cb706418088ca2311c52/third_party/WebKit/Source/core/page/ExternalPopupMenu.h
[rename] https://crrev.com/864784a313f583c72917cb706418088ca2311c52/third_party/WebKit/Source/core/page/PopupMenu.h
[modify] https://crrev.com/864784a313f583c72917cb706418088ca2311c52/third_party/WebKit/Source/core/page/PopupMenuImpl.h
[modify] https://crrev.com/864784a313f583c72917cb706418088ca2311c52/third_party/WebKit/Source/platform/BUILD.gn
[modify] https://crrev.com/864784a313f583c72917cb706418088ca2311c52/third_party/WebKit/Source/web/ExternalPopupMenuTest.cpp
Project Member

Comment 60 by bugdroid1@chromium.org, Jun 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/51a0a1b3c39c129f9c9e98b48f4c156b217d8722

commit 51a0a1b3c39c129f9c9e98b48f4c156b217d8722
Author: Stuart Langley <slangley@chromium.org>
Date: Wed Jun 14 17:59:46 2017

Fold EditorClientImpl into EditorClient.

Bug: 712963
Change-Id: I5b9b2a6a630be4b05272f7c6b186a852fbb7f897
Reviewed-on: https://chromium-review.googlesource.com/534093
Commit-Queue: Stuart Langley <slangley@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#479439}
[modify] https://crrev.com/51a0a1b3c39c129f9c9e98b48f4c156b217d8722/third_party/WebKit/Source/core/loader/EmptyClients.h
[modify] https://crrev.com/51a0a1b3c39c129f9c9e98b48f4c156b217d8722/third_party/WebKit/Source/core/page/BUILD.gn
[rename] https://crrev.com/51a0a1b3c39c129f9c9e98b48f4c156b217d8722/third_party/WebKit/Source/core/page/EditorClient.cpp
[modify] https://crrev.com/51a0a1b3c39c129f9c9e98b48f4c156b217d8722/third_party/WebKit/Source/core/page/EditorClient.h
[modify] https://crrev.com/51a0a1b3c39c129f9c9e98b48f4c156b217d8722/third_party/WebKit/Source/web/BUILD.gn
[delete] https://crrev.com/ca32aee9bb44fd79cf6f178064e333295f1fc860/third_party/WebKit/Source/web/EditorClientImpl.h
[modify] https://crrev.com/51a0a1b3c39c129f9c9e98b48f4c156b217d8722/third_party/WebKit/Source/web/WebViewImpl.cpp
[modify] https://crrev.com/51a0a1b3c39c129f9c9e98b48f4c156b217d8722/third_party/WebKit/Source/web/WebViewImpl.h
Project Member

Comment 61 by bugdroid1@chromium.org, Jun 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e7ba6263e5d7023a12ecf38dfa5b848ece9bda92

commit e7ba6263e5d7023a12ecf38dfa5b848ece9bda92
Author: Hiroki Nakagawa <nhiroki@chromium.org>
Date: Thu Jun 15 00:51:00 2017

ServiceWorker: Move WebEmbeddedWorkerImpl to modules/

As a part of the project to remove the Blink web/ layer[1], this CL moves files
as follows:

- web/WebEmbeddedWorkerImpl.{cpp,h} => modules/exported/
- web/WebEmbeddedWorkerImplTest.cpp => modules/serviceworkers/
- web/ServiceWorkerGlobalScopeClientImpl.{cpp, h} => modules/serviceworkers/
- web/ServiceWorkerGlobalScopeProxy.{cpp,h} => modules/serviceworkers/

[1] https://docs.google.com/document/d/1w1EAnl4WRjl0Utf4bKcgCPOLmmGVugj9kGOGCpFnQok/edit

Bug: 712963
Change-Id: If1666c9523221d178f7fadca313ea7a7fafc2541
Reviewed-on: https://chromium-review.googlesource.com/535302
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#479563}
[modify] https://crrev.com/e7ba6263e5d7023a12ecf38dfa5b848ece9bda92/third_party/WebKit/Source/modules/BUILD.gn
[modify] https://crrev.com/e7ba6263e5d7023a12ecf38dfa5b848ece9bda92/third_party/WebKit/Source/modules/exported/BUILD.gn
[rename] https://crrev.com/e7ba6263e5d7023a12ecf38dfa5b848ece9bda92/third_party/WebKit/Source/modules/exported/WebEmbeddedWorkerImpl.cpp
[rename] https://crrev.com/e7ba6263e5d7023a12ecf38dfa5b848ece9bda92/third_party/WebKit/Source/modules/exported/WebEmbeddedWorkerImpl.h
[modify] https://crrev.com/e7ba6263e5d7023a12ecf38dfa5b848ece9bda92/third_party/WebKit/Source/modules/serviceworkers/BUILD.gn
[modify] https://crrev.com/e7ba6263e5d7023a12ecf38dfa5b848ece9bda92/third_party/WebKit/Source/modules/serviceworkers/DEPS
[rename] https://crrev.com/e7ba6263e5d7023a12ecf38dfa5b848ece9bda92/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClientImpl.cpp
[rename] https://crrev.com/e7ba6263e5d7023a12ecf38dfa5b848ece9bda92/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClientImpl.h
[rename] https://crrev.com/e7ba6263e5d7023a12ecf38dfa5b848ece9bda92/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeProxy.cpp
[rename] https://crrev.com/e7ba6263e5d7023a12ecf38dfa5b848ece9bda92/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeProxy.h
[rename] https://crrev.com/e7ba6263e5d7023a12ecf38dfa5b848ece9bda92/third_party/WebKit/Source/modules/serviceworkers/WebEmbeddedWorkerImplTest.cpp
[modify] https://crrev.com/e7ba6263e5d7023a12ecf38dfa5b848ece9bda92/third_party/WebKit/Source/web/BUILD.gn
Project Member

Comment 62 by bugdroid1@chromium.org, Jun 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09ade96c5b78e78b21f4a5e2458fa2f2875cd5fb

commit 09ade96c5b78e78b21f4a5e2458fa2f2875cd5fb
Author: Nicholas Verne <nverne@chromium.org>
Date: Thu Jun 15 04:19:54 2017

Moves web/tests/sim to core/testing/sim

Many #include paths died to bring you this change.

Bug: 712963
Change-Id: I17d0ee6b39b0f8f09de116fbc95a26751779731a
Reviewed-on: https://chromium-review.googlesource.com/535264
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#479599}
[modify] https://crrev.com/09ade96c5b78e78b21f4a5e2458fa2f2875cd5fb/third_party/WebKit/Source/bindings/core/v8/BindingSecurityTest.cpp
[modify] https://crrev.com/09ade96c5b78e78b21f4a5e2458fa2f2875cd5fb/third_party/WebKit/Source/core/BUILD.gn
[rename] https://crrev.com/09ade96c5b78e78b21f4a5e2458fa2f2875cd5fb/third_party/WebKit/Source/core/testing/sim/SimCanvas.cpp
[rename] https://crrev.com/09ade96c5b78e78b21f4a5e2458fa2f2875cd5fb/third_party/WebKit/Source/core/testing/sim/SimCanvas.h
[rename] https://crrev.com/09ade96c5b78e78b21f4a5e2458fa2f2875cd5fb/third_party/WebKit/Source/core/testing/sim/SimCompositor.cpp
[rename] https://crrev.com/09ade96c5b78e78b21f4a5e2458fa2f2875cd5fb/third_party/WebKit/Source/core/testing/sim/SimCompositor.h
[rename] https://crrev.com/09ade96c5b78e78b21f4a5e2458fa2f2875cd5fb/third_party/WebKit/Source/core/testing/sim/SimDisplayItemList.cpp
[rename] https://crrev.com/09ade96c5b78e78b21f4a5e2458fa2f2875cd5fb/third_party/WebKit/Source/core/testing/sim/SimDisplayItemList.h
[rename] https://crrev.com/09ade96c5b78e78b21f4a5e2458fa2f2875cd5fb/third_party/WebKit/Source/core/testing/sim/SimNetwork.cpp
[rename] https://crrev.com/09ade96c5b78e78b21f4a5e2458fa2f2875cd5fb/third_party/WebKit/Source/core/testing/sim/SimNetwork.h
[rename] https://crrev.com/09ade96c5b78e78b21f4a5e2458fa2f2875cd5fb/third_party/WebKit/Source/core/testing/sim/SimPage.cpp
[rename] https://crrev.com/09ade96c5b78e78b21f4a5e2458fa2f2875cd5fb/third_party/WebKit/Source/core/testing/sim/SimPage.h
[rename] https://crrev.com/09ade96c5b78e78b21f4a5e2458fa2f2875cd5fb/third_party/WebKit/Source/core/testing/sim/SimRequest.cpp
[rename] https://crrev.com/09ade96c5b78e78b21f4a5e2458fa2f2875cd5fb/third_party/WebKit/Source/core/testing/sim/SimRequest.h
[rename] https://crrev.com/09ade96c5b78e78b21f4a5e2458fa2f2875cd5fb/third_party/WebKit/Source/core/testing/sim/SimTest.cpp
[rename] https://crrev.com/09ade96c5b78e78b21f4a5e2458fa2f2875cd5fb/third_party/WebKit/Source/core/testing/sim/SimTest.h
[rename] https://crrev.com/09ade96c5b78e78b21f4a5e2458fa2f2875cd5fb/third_party/WebKit/Source/core/testing/sim/SimWebFrameClient.cpp
[rename] https://crrev.com/09ade96c5b78e78b21f4a5e2458fa2f2875cd5fb/third_party/WebKit/Source/core/testing/sim/SimWebFrameClient.h
[rename] https://crrev.com/09ade96c5b78e78b21f4a5e2458fa2f2875cd5fb/third_party/WebKit/Source/core/testing/sim/SimWebViewClient.cpp
[rename] https://crrev.com/09ade96c5b78e78b21f4a5e2458fa2f2875cd5fb/third_party/WebKit/Source/core/testing/sim/SimWebViewClient.h
[modify] https://crrev.com/09ade96c5b78e78b21f4a5e2458fa2f2875cd5fb/third_party/WebKit/Source/web/BUILD.gn
[modify] https://crrev.com/09ade96c5b78e78b21f4a5e2458fa2f2875cd5fb/third_party/WebKit/Source/web/tests/AccessibilityObjectModelTest.cpp
[modify] https://crrev.com/09ade96c5b78e78b21f4a5e2458fa2f2875cd5fb/third_party/WebKit/Source/web/tests/AnimationSimTest.cpp
[modify] https://crrev.com/09ade96c5b78e78b21f4a5e2458fa2f2875cd5fb/third_party/WebKit/Source/web/tests/DeferredLoadingTest.cpp
[modify] https://crrev.com/09ade96c5b78e78b21f4a5e2458fa2f2875cd5fb/third_party/WebKit/Source/web/tests/DocumentLoadingRenderingTest.cpp
[modify] https://crrev.com/09ade96c5b78e78b21f4a5e2458fa2f2875cd5fb/third_party/WebKit/Source/web/tests/HTMLDocumentParserLoadingTest.cpp
[modify] https://crrev.com/09ade96c5b78e78b21f4a5e2458fa2f2875cd5fb/third_party/WebKit/Source/web/tests/HTMLImportSheetsTest.cpp
[modify] https://crrev.com/09ade96c5b78e78b21f4a5e2458fa2f2875cd5fb/third_party/WebKit/Source/web/tests/IntersectionObserverTest.cpp
[modify] https://crrev.com/09ade96c5b78e78b21f4a5e2458fa2f2875cd5fb/third_party/WebKit/Source/web/tests/LinkElementLoadingTest.cpp
[modify] https://crrev.com/09ade96c5b78e78b21f4a5e2458fa2f2875cd5fb/third_party/WebKit/Source/web/tests/MediaElementFillingViewportTest.cpp
[modify] https://crrev.com/09ade96c5b78e78b21f4a5e2458fa2f2875cd5fb/third_party/WebKit/Source/web/tests/NGInlineLayoutTest.cpp
[modify] https://crrev.com/09ade96c5b78e78b21f4a5e2458fa2f2875cd5fb/third_party/WebKit/Source/web/tests/ResizeObserverTest.cpp
[modify] https://crrev.com/09ade96c5b78e78b21f4a5e2458fa2f2875cd5fb/third_party/WebKit/Source/web/tests/ScrollMetricsTest.cpp
[modify] https://crrev.com/09ade96c5b78e78b21f4a5e2458fa2f2875cd5fb/third_party/WebKit/Source/web/tests/ScrollbarsTest.cpp
[modify] https://crrev.com/09ade96c5b78e78b21f4a5e2458fa2f2875cd5fb/third_party/WebKit/Source/web/tests/ShadowDOMV0Test.cpp
[modify] https://crrev.com/09ade96c5b78e78b21f4a5e2458fa2f2875cd5fb/third_party/WebKit/Source/web/tests/SmoothScrollTest.cpp
[modify] https://crrev.com/09ade96c5b78e78b21f4a5e2458fa2f2875cd5fb/third_party/WebKit/Source/web/tests/TextSelectionRepaintTest.cpp
[modify] https://crrev.com/09ade96c5b78e78b21f4a5e2458fa2f2875cd5fb/third_party/WebKit/Source/web/tests/VirtualTimeTest.cpp
[modify] https://crrev.com/09ade96c5b78e78b21f4a5e2458fa2f2875cd5fb/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
[modify] https://crrev.com/09ade96c5b78e78b21f4a5e2458fa2f2875cd5fb/third_party/WebKit/Source/web/tests/WebMeaningfulLayoutsTest.cpp
[modify] https://crrev.com/09ade96c5b78e78b21f4a5e2458fa2f2875cd5fb/third_party/WebKit/Source/web/tests/WindowProxyTest.cpp
[modify] https://crrev.com/09ade96c5b78e78b21f4a5e2458fa2f2875cd5fb/third_party/WebKit/Source/web/tests/scheduler/ActiveConnectionThrottlingTest.cpp
[modify] https://crrev.com/09ade96c5b78e78b21f4a5e2458fa2f2875cd5fb/third_party/WebKit/Source/web/tests/scheduler/FrameThrottlingTest.cpp
[modify] https://crrev.com/09ade96c5b78e78b21f4a5e2458fa2f2875cd5fb/third_party/WebKit/Source/web/tests/scheduler/ThrottlingTest.cpp
Project Member

Comment 65 by bugdroid1@chromium.org, Jun 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/473bc6358908c1b39ef6adba839b9173f8540c1a

commit 473bc6358908c1b39ef6adba839b9173f8540c1a
Author: Joel Hockey <joelhockey@chromium.org>
Date: Fri Jun 16 21:08:05 2017

Move linux, mac, win from web/ to core/

public/web/mac/WebScrollbarTheme.h -> public/platform/mac
web/mac/WebScrollbarTheme.mm -> platform/scroll
web/mac/WebSubstringUtil.mm -> core/editing
web/linux/WebFontRendering.cpp -> core/layout/WebFontRenderingDefault.cpp
web/win/WebFontRendering.cpp -> core/layout/WebFontRederingWin.cpp


Bug: 712963
Change-Id: I40fef289586e3705264da142854a7096c393563e
Reviewed-on: https://chromium-review.googlesource.com/537932
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480166}
[modify] https://crrev.com/473bc6358908c1b39ef6adba839b9173f8540c1a/content/browser/DEPS
[modify] https://crrev.com/473bc6358908c1b39ef6adba839b9173f8540c1a/content/browser/theme_helper_mac.h
[modify] https://crrev.com/473bc6358908c1b39ef6adba839b9173f8540c1a/content/common/DEPS
[modify] https://crrev.com/473bc6358908c1b39ef6adba839b9173f8540c1a/content/common/native_types_mac.typemap
[modify] https://crrev.com/473bc6358908c1b39ef6adba839b9173f8540c1a/content/common/view_messages.h
[modify] https://crrev.com/473bc6358908c1b39ef6adba839b9173f8540c1a/content/renderer/render_thread_impl.h
[modify] https://crrev.com/473bc6358908c1b39ef6adba839b9173f8540c1a/third_party/WebKit/Source/core/editing/BUILD.gn
[rename] https://crrev.com/473bc6358908c1b39ef6adba839b9173f8540c1a/third_party/WebKit/Source/core/editing/WebSubstringUtil.mm
[modify] https://crrev.com/473bc6358908c1b39ef6adba839b9173f8540c1a/third_party/WebKit/Source/core/layout/BUILD.gn
[copy] https://crrev.com/473bc6358908c1b39ef6adba839b9173f8540c1a/third_party/WebKit/Source/core/layout/WebFontRenderingAndroid.cpp
[rename] https://crrev.com/473bc6358908c1b39ef6adba839b9173f8540c1a/third_party/WebKit/Source/core/layout/WebFontRenderingLinux.cpp
[rename] https://crrev.com/473bc6358908c1b39ef6adba839b9173f8540c1a/third_party/WebKit/Source/core/layout/WebFontRenderingWin.cpp
[modify] https://crrev.com/473bc6358908c1b39ef6adba839b9173f8540c1a/third_party/WebKit/Source/platform/BUILD.gn
[rename] https://crrev.com/473bc6358908c1b39ef6adba839b9173f8540c1a/third_party/WebKit/Source/platform/scroll/WebScrollbarTheme.mm
[modify] https://crrev.com/473bc6358908c1b39ef6adba839b9173f8540c1a/third_party/WebKit/Source/web/BUILD.gn
[modify] https://crrev.com/473bc6358908c1b39ef6adba839b9173f8540c1a/third_party/WebKit/public/BUILD.gn
[rename] https://crrev.com/473bc6358908c1b39ef6adba839b9173f8540c1a/third_party/WebKit/public/platform/mac/WebScrollbarTheme.h
Project Member

Comment 66 by bugdroid1@chromium.org, Jun 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/97eb4351a2ef126bad62288e5a00ba93986c32dd

commit 97eb4351a2ef126bad62288e5a00ba93986c32dd
Author: Joel Hockey <joelhockey@chromium.org>
Date: Fri Jun 16 21:29:58 2017

Move web/resources to core/html/forms/

Bug: 712963
Change-Id: I8e35bf2f73282d4c1f810988a674db0e22933bad
Reviewed-on: https://chromium-review.googlesource.com/538172
Reviewed-by: Sasha Morrissey <sashab@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480176}
[modify] https://crrev.com/97eb4351a2ef126bad62288e5a00ba93986c32dd/third_party/WebKit/ManualTests/forms/calendar-picker.html
[modify] https://crrev.com/97eb4351a2ef126bad62288e5a00ba93986c32dd/third_party/WebKit/ManualTests/forms/color-suggestion-picker.html
[modify] https://crrev.com/97eb4351a2ef126bad62288e5a00ba93986c32dd/third_party/WebKit/ManualTests/forms/date-suggestion-picker.html
[modify] https://crrev.com/97eb4351a2ef126bad62288e5a00ba93986c32dd/third_party/WebKit/ManualTests/forms/list-picker.html
[rename] https://crrev.com/97eb4351a2ef126bad62288e5a00ba93986c32dd/third_party/WebKit/Source/core/html/forms/resources/.clang-format
[rename] https://crrev.com/97eb4351a2ef126bad62288e5a00ba93986c32dd/third_party/WebKit/Source/core/html/forms/resources/calendarPicker.css
[rename] https://crrev.com/97eb4351a2ef126bad62288e5a00ba93986c32dd/third_party/WebKit/Source/core/html/forms/resources/calendarPicker.js
[rename] https://crrev.com/97eb4351a2ef126bad62288e5a00ba93986c32dd/third_party/WebKit/Source/core/html/forms/resources/colorSuggestionPicker.css
[rename] https://crrev.com/97eb4351a2ef126bad62288e5a00ba93986c32dd/third_party/WebKit/Source/core/html/forms/resources/colorSuggestionPicker.js
[rename] https://crrev.com/97eb4351a2ef126bad62288e5a00ba93986c32dd/third_party/WebKit/Source/core/html/forms/resources/listPicker.css
[rename] https://crrev.com/97eb4351a2ef126bad62288e5a00ba93986c32dd/third_party/WebKit/Source/core/html/forms/resources/listPicker.js
[rename] https://crrev.com/97eb4351a2ef126bad62288e5a00ba93986c32dd/third_party/WebKit/Source/core/html/forms/resources/pickerButton.css
[rename] https://crrev.com/97eb4351a2ef126bad62288e5a00ba93986c32dd/third_party/WebKit/Source/core/html/forms/resources/pickerCommon.css
[rename] https://crrev.com/97eb4351a2ef126bad62288e5a00ba93986c32dd/third_party/WebKit/Source/core/html/forms/resources/pickerCommon.js
[rename] https://crrev.com/97eb4351a2ef126bad62288e5a00ba93986c32dd/third_party/WebKit/Source/core/html/forms/resources/suggestionPicker.css
[rename] https://crrev.com/97eb4351a2ef126bad62288e5a00ba93986c32dd/third_party/WebKit/Source/core/html/forms/resources/suggestionPicker.js
[delete] https://crrev.com/fd83a51df6653957aa077d1f1083bfe4118920c4/third_party/WebKit/Source/web/resources/OWNERS
[modify] https://crrev.com/97eb4351a2ef126bad62288e5a00ba93986c32dd/third_party/WebKit/public/blink_resources.grd

Comment 67 by slangley@chromium.org, Jun 19 2017

Blockedon: 734450
Project Member

Comment 68 by bugdroid1@chromium.org, Jun 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/06e980861f8b1a81c4d5da2f667f44336cab385d

commit 06e980861f8b1a81c4d5da2f667f44336cab385d
Author: Sasha Bermeister <sashab@chromium.org>
Date: Mon Jun 19 04:11:32 2017

Move WebFrameSerializer/Impl from web/ to core/exported

Move WebFrameSerializer and WebFrameSerializerImpl from web/ to
core/exported. These classes have no other dependencies in web/ so can
be moved directly.

Bug: 712963
Change-Id: Ie30efe392890fc536c2c5dfed28158a3b50b3a2e
Reviewed-on: https://chromium-review.googlesource.com/538313
Commit-Queue: Sasha Morrissey <sashab@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480341}
[modify] https://crrev.com/06e980861f8b1a81c4d5da2f667f44336cab385d/third_party/WebKit/Source/core/exported/BUILD.gn
[rename] https://crrev.com/06e980861f8b1a81c4d5da2f667f44336cab385d/third_party/WebKit/Source/core/exported/WebFrameSerializer.cpp
[modify] https://crrev.com/06e980861f8b1a81c4d5da2f667f44336cab385d/third_party/WebKit/Source/core/frame/BUILD.gn
[rename] https://crrev.com/06e980861f8b1a81c4d5da2f667f44336cab385d/third_party/WebKit/Source/core/frame/WebFrameSerializerImpl.cpp
[rename] https://crrev.com/06e980861f8b1a81c4d5da2f667f44336cab385d/third_party/WebKit/Source/core/frame/WebFrameSerializerImpl.h
[modify] https://crrev.com/06e980861f8b1a81c4d5da2f667f44336cab385d/third_party/WebKit/Source/web/BUILD.gn

Comment 69 by sashab@chromium.org, Jun 20 2017

Blockedon: 353585
Project Member

Comment 70 by bugdroid1@chromium.org, Jun 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c77b5e37a4c7a7437ed3882e0eef8fdb0d31133e

commit c77b5e37a4c7a7437ed3882e0eef8fdb0d31133e
Author: Matt Falkenhagen <falken@chromium.org>
Date: Wed Jun 21 05:43:56 2017

Documentation: README for core/exported and modules/exported

Based on https://docs.google.com/document/d/1w1EAnl4WRjl0Utf4bKcgCPOLmmGVugj9kGOGCpFnQok/edit

Bug: 712963
Change-Id: Ie3f636fabe26c1a9bb828cd3d7499cb9838ffcf2
Reviewed-on: https://chromium-review.googlesource.com/542297
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481118}
[add] https://crrev.com/c77b5e37a4c7a7437ed3882e0eef8fdb0d31133e/third_party/WebKit/Source/core/exported/README.md
[add] https://crrev.com/c77b5e37a4c7a7437ed3882e0eef8fdb0d31133e/third_party/WebKit/Source/modules/exported/README.md
Project Member

Comment 71 by bugdroid1@chromium.org, Jun 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d1e9baba16a19ca08fa1daa1f1cc6f929379fc44

commit d1e9baba16a19ca08fa1daa1f1cc6f929379fc44
Author: Nicholas Verne <nverne@chromium.org>
Date: Wed Jun 21 07:28:38 2017

Removes explicit use of WebFrameWidgetImpl.

It should now be possible to move WebDevToolsAgentImpl to core/ or modules/

Bug: 712963
Change-Id: Iabd0b5dd2fa4e9a91429c7b0d58213bd1bb4ad82
Reviewed-on: https://chromium-review.googlesource.com/542356
Reviewed-by: Stuart Langley <slangley@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481135}
[modify] https://crrev.com/d1e9baba16a19ca08fa1daa1f1cc6f929379fc44/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp
[modify] https://crrev.com/d1e9baba16a19ca08fa1daa1f1cc6f929379fc44/third_party/WebKit/Source/web/WebFrameWidgetImpl.h
Project Member

Comment 72 by bugdroid1@chromium.org, Jun 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9bc3c18fb351d8ab2297323a61a6c161629a1ec

commit d9bc3c18fb351d8ab2297323a61a6c161629a1ec
Author: Stuart Langley <slangley@chromium.org>
Date: Wed Jun 21 08:16:08 2017

Add DEPS rules to prevent new files taking a dependency on core/exported,
unless it is in core/exported.

Bug: 712963
Change-Id: I77c553ac62770b5b80be80463153752b3e11b697
Reviewed-on: https://chromium-review.googlesource.com/542098
Commit-Queue: Stuart Langley <slangley@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481142}
[modify] https://crrev.com/d9bc3c18fb351d8ab2297323a61a6c161629a1ec/third_party/WebKit/Source/core/DEPS
[modify] https://crrev.com/d9bc3c18fb351d8ab2297323a61a6c161629a1ec/third_party/WebKit/Source/core/exported/DEPS
Project Member

Comment 74 by bugdroid1@chromium.org, Jun 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e60abd9be8f422981b8cdd30afef672e5d222e0a

commit e60abd9be8f422981b8cdd30afef672e5d222e0a
Author: Stuart Langley <slangley@chromium.org>
Date: Thu Jun 22 03:16:56 2017

Move WebDevToolsFrontendImpl.* from web/ -> core/exported/.

WebDevToolsFrontendImpl is an implementation of public/web/WebDevToolsFrontend
so should have it's new home in core/exported/.

Bug: 712963
Change-Id: I7266b249ff8bf1a4fb22affa52d4a12b65e3e990
Reviewed-on: https://chromium-review.googlesource.com/540969
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481423}
[modify] https://crrev.com/e60abd9be8f422981b8cdd30afef672e5d222e0a/third_party/WebKit/Source/core/exported/BUILD.gn
[rename] https://crrev.com/e60abd9be8f422981b8cdd30afef672e5d222e0a/third_party/WebKit/Source/core/exported/WebDevToolsFrontendImpl.cpp
[rename] https://crrev.com/e60abd9be8f422981b8cdd30afef672e5d222e0a/third_party/WebKit/Source/core/exported/WebDevToolsFrontendImpl.h
[modify] https://crrev.com/e60abd9be8f422981b8cdd30afef672e5d222e0a/third_party/WebKit/Source/web/BUILD.gn
[modify] https://crrev.com/e60abd9be8f422981b8cdd30afef672e5d222e0a/third_party/WebKit/Source/web/LocalFrameClientImpl.cpp
Project Member

Comment 77 by bugdroid1@chromium.org, Jul 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/97796fd23c6dede6e98f2db61dea0d8e6f8aec9a

commit 97796fd23c6dede6e98f2db61dea0d8e6f8aec9a
Author: Joel Hockey <joelhockey@chromium.org>
Date: Mon Jul 03 02:23:19 2017

Move web/tests/scheduler tests to core/testing

These are end-to-end tests for platform/scheduler that were
previously in web/ since they had dependencies on web.  Now
they have dependencies on core/ and I have chosen
core/testing/scheduler.

First moved
modules/peerconnection/testing/TestingPlatformSupportWithRTC
to platform/testing/ so as to remove the dependency on modules.

With the modules dependency gone, the 3 tests in
web/tests/scheduler can be moved to core/testing.

Note that the presubmit gives an error of:
** Presubmit ERRORS **
Do not use Chromium class from namespace cc inside Blink core:
third_party/WebKit/Source/core/testing/scheduler/FrameThrottlingTest.cpp:50

I'm guessing that it is ok to ignore the error for this test which
is mocking a method which takes a type involving cc:PaintRecord.


Bug: 712963
Change-Id: Ifcbbdf57888af1760197676d4c99561b8161612f
Reviewed-on: https://chromium-review.googlesource.com/557700
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#483926}
[modify] https://crrev.com/97796fd23c6dede6e98f2db61dea0d8e6f8aec9a/third_party/WebKit/Source/core/BUILD.gn
[rename] https://crrev.com/97796fd23c6dede6e98f2db61dea0d8e6f8aec9a/third_party/WebKit/Source/core/scheduler/ActiveConnectionThrottlingTest.cpp
[rename] https://crrev.com/97796fd23c6dede6e98f2db61dea0d8e6f8aec9a/third_party/WebKit/Source/core/scheduler/FrameThrottlingTest.cpp
[rename] https://crrev.com/97796fd23c6dede6e98f2db61dea0d8e6f8aec9a/third_party/WebKit/Source/core/scheduler/OWNERS
[rename] https://crrev.com/97796fd23c6dede6e98f2db61dea0d8e6f8aec9a/third_party/WebKit/Source/core/scheduler/README.md
[rename] https://crrev.com/97796fd23c6dede6e98f2db61dea0d8e6f8aec9a/third_party/WebKit/Source/core/scheduler/ThrottlingTest.cpp
[modify] https://crrev.com/97796fd23c6dede6e98f2db61dea0d8e6f8aec9a/third_party/WebKit/Source/modules/BUILD.gn
[modify] https://crrev.com/97796fd23c6dede6e98f2db61dea0d8e6f8aec9a/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnectionTest.cpp
[modify] https://crrev.com/97796fd23c6dede6e98f2db61dea0d8e6f8aec9a/third_party/WebKit/Source/platform/BUILD.gn
[rename] https://crrev.com/97796fd23c6dede6e98f2db61dea0d8e6f8aec9a/third_party/WebKit/Source/platform/testing/TestingPlatformSupportWithWebRTC.cpp
[rename] https://crrev.com/97796fd23c6dede6e98f2db61dea0d8e6f8aec9a/third_party/WebKit/Source/platform/testing/TestingPlatformSupportWithWebRTC.h
[modify] https://crrev.com/97796fd23c6dede6e98f2db61dea0d8e6f8aec9a/third_party/WebKit/Source/web/BUILD.gn
Project Member

Comment 78 by bugdroid1@chromium.org, Jul 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f6f03d22a4e685b45849c3b0990865c06a4846b1

commit f6f03d22a4e685b45849c3b0990865c06a4846b1
Author: Nicholas Verne <nverne@chromium.org>
Date: Thu Jul 06 10:23:09 2017

Pre-work for moving WebFrameWidgetImpl to core

CreateAnimationWorkletProxyClient and CreateCompositorWorkerProxyClient
are no longer needed in ChromeClient and WebView/WebFrame classes.
Instead, WebViewBase and WebFrameWidgetBase expose their CompositorMutator.
AnimationWorklet and CompositorWorker in modules/ can now create their own impl
from a Document.

Bug: 712963
Change-Id: I13a6de1ba4c2f004a4c584de906df1926b1799a5
Reviewed-on: https://chromium-review.googlesource.com/561018
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484528}
[modify] https://crrev.com/f6f03d22a4e685b45849c3b0990865c06a4846b1/third_party/WebKit/Source/core/exported/WebViewBase.h
[modify] https://crrev.com/f6f03d22a4e685b45849c3b0990865c06a4846b1/third_party/WebKit/Source/core/frame/WebFrameWidgetBase.h
[modify] https://crrev.com/f6f03d22a4e685b45849c3b0990865c06a4846b1/third_party/WebKit/Source/core/frame/WebLocalFrameBase.h
[modify] https://crrev.com/f6f03d22a4e685b45849c3b0990865c06a4846b1/third_party/WebKit/Source/core/frame/WebViewFrameWidget.cpp
[modify] https://crrev.com/f6f03d22a4e685b45849c3b0990865c06a4846b1/third_party/WebKit/Source/core/frame/WebViewFrameWidget.h
[modify] https://crrev.com/f6f03d22a4e685b45849c3b0990865c06a4846b1/third_party/WebKit/Source/core/loader/EmptyClients.h
[modify] https://crrev.com/f6f03d22a4e685b45849c3b0990865c06a4846b1/third_party/WebKit/Source/core/page/ChromeClient.h
[modify] https://crrev.com/f6f03d22a4e685b45849c3b0990865c06a4846b1/third_party/WebKit/Source/modules/compositorworker/AnimationWorklet.cpp
[modify] https://crrev.com/f6f03d22a4e685b45849c3b0990865c06a4846b1/third_party/WebKit/Source/modules/compositorworker/AnimationWorkletProxyClientImpl.cpp
[modify] https://crrev.com/f6f03d22a4e685b45849c3b0990865c06a4846b1/third_party/WebKit/Source/modules/compositorworker/AnimationWorkletProxyClientImpl.h
[modify] https://crrev.com/f6f03d22a4e685b45849c3b0990865c06a4846b1/third_party/WebKit/Source/modules/compositorworker/CompositorWorker.cpp
[modify] https://crrev.com/f6f03d22a4e685b45849c3b0990865c06a4846b1/third_party/WebKit/Source/modules/compositorworker/CompositorWorkerProxyClientImpl.cpp
[modify] https://crrev.com/f6f03d22a4e685b45849c3b0990865c06a4846b1/third_party/WebKit/Source/modules/compositorworker/CompositorWorkerProxyClientImpl.h
[modify] https://crrev.com/f6f03d22a4e685b45849c3b0990865c06a4846b1/third_party/WebKit/Source/web/ChromeClientImpl.cpp
[modify] https://crrev.com/f6f03d22a4e685b45849c3b0990865c06a4846b1/third_party/WebKit/Source/web/ChromeClientImpl.h
[modify] https://crrev.com/f6f03d22a4e685b45849c3b0990865c06a4846b1/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
[modify] https://crrev.com/f6f03d22a4e685b45849c3b0990865c06a4846b1/third_party/WebKit/Source/web/WebFrameWidgetImpl.h
[modify] https://crrev.com/f6f03d22a4e685b45849c3b0990865c06a4846b1/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
[modify] https://crrev.com/f6f03d22a4e685b45849c3b0990865c06a4846b1/third_party/WebKit/Source/web/WebLocalFrameImpl.h
[modify] https://crrev.com/f6f03d22a4e685b45849c3b0990865c06a4846b1/third_party/WebKit/Source/web/WebViewImpl.cpp
[modify] https://crrev.com/f6f03d22a4e685b45849c3b0990865c06a4846b1/third_party/WebKit/Source/web/WebViewImpl.h
Project Member

Comment 79 by bugdroid1@chromium.org, Jul 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/29ea4e7b80e011404572ca22b5f819e66974368d

commit 29ea4e7b80e011404572ca22b5f819e66974368d
Author: Daniel Cheng <dcheng@chromium.org>
Date: Sun Jul 09 20:02:24 2017

Forbid new dependencies on WebRemoteFrameImpl.

WebRemoteFrameBase is already disallowed until we devise a concrete plan
for splitting out controller functionality. As WebRemoteFrameBase is
simply a proxy class for WebRemoteFrameImpl, WebRemoteFrameImpl should
similarly be disallowed.

Bug: 712963
Change-Id: I1d883e65b958947ee36f7fa50b67dc5a5cf16ecd
Reviewed-on: https://chromium-review.googlesource.com/564072
Reviewed-by: Stuart Langley <slangley@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485162}
[modify] https://crrev.com/29ea4e7b80e011404572ca22b5f819e66974368d/third_party/WebKit/Source/core/DEPS
Project Member

Comment 80 by bugdroid1@chromium.org, Jul 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/35934f34d5af90512e2c16593c6527c4639dad6a

commit 35934f34d5af90512e2c16593c6527c4639dad6a
Author: Nicholas Verne <nverne@chromium.org>
Date: Sun Jul 16 03:34:42 2017

Moves WebDevToolsAgentImpl to core.

WebDevToolsAgentImpl uses many InspectorAgents that are implemented in modules/.
To enable these agents' use from core/ we now register a callback from
ModulesInitializer::Initialize that can append the modules/ InspectorAgents
to an InspectorSession.

Since WebDevToolsAgentImpl needs to use static methods of WebView and
WebViewBase directly, these need to be availble in core/ as well. We created
WebViewBase.cpp and moved the definitions there. Also, to keep Windows happy
WebViewBase is now a NON_EXPORTED_BASE of WebViewImpl, since there is now
code for WebViewBase static methods in different library and Windows otherwise
fails to link
warning C4275: non dll-interface class 'blink::WebViewBase' used as base for
dll-interface class 'blink::WebViewImpl'

Bug: 712963
Change-Id: I9159327618118b2a2f652ed15a76271040b5bc30
Reviewed-on: https://chromium-review.googlesource.com/544726
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Sasha Morrissey <sashab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487003}
[modify] https://crrev.com/35934f34d5af90512e2c16593c6527c4639dad6a/third_party/WebKit/Source/core/exported/BUILD.gn
[rename] https://crrev.com/35934f34d5af90512e2c16593c6527c4639dad6a/third_party/WebKit/Source/core/exported/WebDevToolsAgentImpl.cpp
[rename] https://crrev.com/35934f34d5af90512e2c16593c6527c4639dad6a/third_party/WebKit/Source/core/exported/WebDevToolsAgentImpl.h
[add] https://crrev.com/35934f34d5af90512e2c16593c6527c4639dad6a/third_party/WebKit/Source/core/exported/WebViewBase.cpp
[modify] https://crrev.com/35934f34d5af90512e2c16593c6527c4639dad6a/third_party/WebKit/Source/core/exported/WebViewBase.h
[modify] https://crrev.com/35934f34d5af90512e2c16593c6527c4639dad6a/third_party/WebKit/Source/core/inspector/BUILD.gn
[add] https://crrev.com/35934f34d5af90512e2c16593c6527c4639dad6a/third_party/WebKit/Source/core/inspector/InspectorBaseAgent.cpp
[modify] https://crrev.com/35934f34d5af90512e2c16593c6527c4639dad6a/third_party/WebKit/Source/core/inspector/InspectorBaseAgent.h
[modify] https://crrev.com/35934f34d5af90512e2c16593c6527c4639dad6a/third_party/WebKit/Source/modules/ModulesInitializer.cpp
[modify] https://crrev.com/35934f34d5af90512e2c16593c6527c4639dad6a/third_party/WebKit/Source/web/BUILD.gn
[modify] https://crrev.com/35934f34d5af90512e2c16593c6527c4639dad6a/third_party/WebKit/Source/web/LocalFrameClientImpl.cpp
[modify] https://crrev.com/35934f34d5af90512e2c16593c6527c4639dad6a/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
[modify] https://crrev.com/35934f34d5af90512e2c16593c6527c4639dad6a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
[modify] https://crrev.com/35934f34d5af90512e2c16593c6527c4639dad6a/third_party/WebKit/Source/web/WebViewImpl.cpp
Project Member

Comment 82 by bugdroid1@chromium.org, Jul 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e9402924f0e9a0f16faef1ad0702f53ec1d1680

commit 9e9402924f0e9a0f16faef1ad0702f53ec1d1680
Author: Nicholas Verne <nverne@chromium.org>
Date: Wed Jul 19 08:58:19 2017

Pre-work for moving WebLocalFrameImpl to core/

We remove WebLocalFrameImpl's dependency on LocalFrameClientImpl
in favour of LocalFramClient. The Impl is now obtained from WebFactory. 

LocalFrameClientImpl no longer uses WebLocalFrameImpl where 
WebLocalFrameBase or WebFrame could be used.

Bug: 712963
Change-Id: I68f5e87415ee468498b3aadd19af6ddcbcd10205
Reviewed-on: https://chromium-review.googlesource.com/576599
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487796}
[modify] https://crrev.com/9e9402924f0e9a0f16faef1ad0702f53ec1d1680/third_party/WebKit/Source/core/exported/WebFactory.h
[modify] https://crrev.com/9e9402924f0e9a0f16faef1ad0702f53ec1d1680/third_party/WebKit/Source/core/frame/LocalFrameClient.h
[modify] https://crrev.com/9e9402924f0e9a0f16faef1ad0702f53ec1d1680/third_party/WebKit/Source/web/LocalFrameClientImpl.cpp
[modify] https://crrev.com/9e9402924f0e9a0f16faef1ad0702f53ec1d1680/third_party/WebKit/Source/web/LocalFrameClientImpl.h
[modify] https://crrev.com/9e9402924f0e9a0f16faef1ad0702f53ec1d1680/third_party/WebKit/Source/web/WebFactoryImpl.cpp
[modify] https://crrev.com/9e9402924f0e9a0f16faef1ad0702f53ec1d1680/third_party/WebKit/Source/web/WebFactoryImpl.h
[modify] https://crrev.com/9e9402924f0e9a0f16faef1ad0702f53ec1d1680/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
[modify] https://crrev.com/9e9402924f0e9a0f16faef1ad0702f53ec1d1680/third_party/WebKit/Source/web/WebLocalFrameImpl.h
Project Member

Comment 83 by bugdroid1@chromium.org, Jul 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d7bea544eaee0e7aee36684491746cd444a39e86

commit d7bea544eaee0e7aee36684491746cd444a39e86
Author: Nicholas Verne <nverne@chromium.org>
Date: Fri Jul 21 11:30:33 2017

Moves WebLocalFrameImpl and ChromeClientImpl to core.

static methods previouly in WebViewImpl.cpp are now available in
WebViewBase.cpp. These classes will eventually merge and the schism
will be repaired. 

Usages of base::SingleThreadTaskRunner in WebLocalFrameImpl are replaced
by the alias in platform/WebTaskRunner to satisfy our PRESUBMIT.

Bug: 712963
Change-Id: I76ba9b1d7f15180b8d2dfeaed8cdc93ff9ac091f
Reviewed-on: https://chromium-review.googlesource.com/577429
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488632}
[modify] https://crrev.com/d7bea544eaee0e7aee36684491746cd444a39e86/third_party/WebKit/Source/core/exported/WebViewBase.cpp
[modify] https://crrev.com/d7bea544eaee0e7aee36684491746cd444a39e86/third_party/WebKit/Source/core/exported/WebViewBase.h
[modify] https://crrev.com/d7bea544eaee0e7aee36684491746cd444a39e86/third_party/WebKit/Source/core/frame/BUILD.gn
[rename] https://crrev.com/d7bea544eaee0e7aee36684491746cd444a39e86/third_party/WebKit/Source/core/frame/WebLocalFrameImpl.cpp
[rename] https://crrev.com/d7bea544eaee0e7aee36684491746cd444a39e86/third_party/WebKit/Source/core/frame/WebLocalFrameImpl.h
[modify] https://crrev.com/d7bea544eaee0e7aee36684491746cd444a39e86/third_party/WebKit/Source/core/page/BUILD.gn
[rename] https://crrev.com/d7bea544eaee0e7aee36684491746cd444a39e86/third_party/WebKit/Source/core/page/ChromeClientImpl.cpp
[rename] https://crrev.com/d7bea544eaee0e7aee36684491746cd444a39e86/third_party/WebKit/Source/core/page/ChromeClientImpl.h
[modify] https://crrev.com/d7bea544eaee0e7aee36684491746cd444a39e86/third_party/WebKit/Source/web/BUILD.gn
[modify] https://crrev.com/d7bea544eaee0e7aee36684491746cd444a39e86/third_party/WebKit/Source/web/WebFactoryImpl.cpp
[modify] https://crrev.com/d7bea544eaee0e7aee36684491746cd444a39e86/third_party/WebKit/Source/web/WebViewImpl.cpp
[modify] https://crrev.com/d7bea544eaee0e7aee36684491746cd444a39e86/third_party/WebKit/Source/web/WebViewImpl.h
[modify] https://crrev.com/d7bea544eaee0e7aee36684491746cd444a39e86/third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp
[modify] https://crrev.com/d7bea544eaee0e7aee36684491746cd444a39e86/third_party/WebKit/Source/web/tests/LayoutGeometryMapTest.cpp
[modify] https://crrev.com/d7bea544eaee0e7aee36684491746cd444a39e86/third_party/WebKit/Source/web/tests/SmoothScrollTest.cpp
Project Member

Comment 84 by bugdroid1@chromium.org, Jul 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b2bf443681aa874c0e520dbfaf7989465b3f00c

commit 7b2bf443681aa874c0e520dbfaf7989465b3f00c
Author: Stuart Langley <slangley@chromium.org>
Date: Mon Jul 24 06:32:32 2017

Move LocalFrameClientImpl.* from web/ -> core/exported/.

Moves methods needed for initializing modules classes to ModulesInitializer
using pure virtual methods defined in CoreInitializer.

Removes the call to initialize LocalFrameClientImpl from WebFactory.

Bug: 712963
Change-Id: Iba22d5160dabc788befb0b635e3501d9b8d94478
Reviewed-on: https://chromium-review.googlesource.com/582060
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488925}
[modify] https://crrev.com/7b2bf443681aa874c0e520dbfaf7989465b3f00c/third_party/WebKit/Source/core/CoreInitializer.h
[modify] https://crrev.com/7b2bf443681aa874c0e520dbfaf7989465b3f00c/third_party/WebKit/Source/core/exported/BUILD.gn
[rename] https://crrev.com/7b2bf443681aa874c0e520dbfaf7989465b3f00c/third_party/WebKit/Source/core/exported/LocalFrameClientImpl.cpp
[rename] https://crrev.com/7b2bf443681aa874c0e520dbfaf7989465b3f00c/third_party/WebKit/Source/core/exported/LocalFrameClientImpl.h
[modify] https://crrev.com/7b2bf443681aa874c0e520dbfaf7989465b3f00c/third_party/WebKit/Source/core/exported/WebFactory.h
[modify] https://crrev.com/7b2bf443681aa874c0e520dbfaf7989465b3f00c/third_party/WebKit/Source/core/frame/WebLocalFrameImpl.cpp
[modify] https://crrev.com/7b2bf443681aa874c0e520dbfaf7989465b3f00c/third_party/WebKit/Source/modules/ModulesInitializer.cpp
[modify] https://crrev.com/7b2bf443681aa874c0e520dbfaf7989465b3f00c/third_party/WebKit/Source/modules/ModulesInitializer.h
[modify] https://crrev.com/7b2bf443681aa874c0e520dbfaf7989465b3f00c/third_party/WebKit/Source/web/BUILD.gn
[modify] https://crrev.com/7b2bf443681aa874c0e520dbfaf7989465b3f00c/third_party/WebKit/Source/web/WebFactoryImpl.cpp
[modify] https://crrev.com/7b2bf443681aa874c0e520dbfaf7989465b3f00c/third_party/WebKit/Source/web/WebFactoryImpl.h
[modify] https://crrev.com/7b2bf443681aa874c0e520dbfaf7989465b3f00c/third_party/WebKit/Source/web/tests/LocalFrameClientImplTest.cpp
Project Member

Comment 85 by bugdroid1@chromium.org, Jul 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e8bee36f0d78e63f56f1a9aacd5333053ed852b4

commit e8bee36f0d78e63f56f1a9aacd5333053ed852b4
Author: Nicholas Verne <nverne@chromium.org>
Date: Mon Jul 24 09:52:00 2017

Moves ChromeClientImplTest to core/page

Bug: 712963
Change-Id: Ia3e33717ae979cf2ec78bd15e2e3e837048925e0
Reviewed-on: https://chromium-review.googlesource.com/582033
Reviewed-by: Stuart Langley <slangley@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488938}
[modify] https://crrev.com/e8bee36f0d78e63f56f1a9aacd5333053ed852b4/third_party/WebKit/Source/core/BUILD.gn
[rename] https://crrev.com/e8bee36f0d78e63f56f1a9aacd5333053ed852b4/third_party/WebKit/Source/core/page/ChromeClientImplTest.cpp
[modify] https://crrev.com/e8bee36f0d78e63f56f1a9aacd5333053ed852b4/third_party/WebKit/Source/web/BUILD.gn
Project Member

Comment 86 by bugdroid1@chromium.org, Jul 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7bf9dd80d63b254b4876642641cb087b81f84329

commit 7bf9dd80d63b254b4876642641cb087b81f84329
Author: Stuart Langley <slangley@chromium.org>
Date: Tue Jul 25 23:19:06 2017

Allow gfx::ICCProfile to be used in core/.

Note that this is used in WebViewImpl, that is currently located in web/ but
we want to move it to core/exported.

Also, there are plans to use gfx:: in blink directly, crbug.com/738465, so
in all likelyhood we'll eventually remove the restriction for gfx entirely.

Bug: 712963
Change-Id: I1f2c1e4a7f12b6322ba2bf31e0ea1d15925158d0
Reviewed-on: https://chromium-review.googlesource.com/583748
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489478}
[modify] https://crrev.com/7bf9dd80d63b254b4876642641cb087b81f84329/third_party/WebKit/PRESUBMIT.py
Project Member

Comment 88 by bugdroid1@chromium.org, Jul 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3526d3a7f45d3c25fdffac894ab5d0c501b087c2

commit 3526d3a7f45d3c25fdffac894ab5d0c501b087c2
Author: Nicholas Verne <nverne@chromium.org>
Date: Wed Jul 26 13:31:28 2017

Moves LocalFrameClientImplTest to core/exported.

Bug: 712963
Change-Id: Ib90a0a5731d9c6185a161e311fd00759a7b89c22
Reviewed-on: https://chromium-review.googlesource.com/584636
Reviewed-by: Stuart Langley <slangley@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489625}
[modify] https://crrev.com/3526d3a7f45d3c25fdffac894ab5d0c501b087c2/third_party/WebKit/Source/core/BUILD.gn
[rename] https://crrev.com/3526d3a7f45d3c25fdffac894ab5d0c501b087c2/third_party/WebKit/Source/core/exported/LocalFrameClientImplTest.cpp
[modify] https://crrev.com/3526d3a7f45d3c25fdffac894ab5d0c501b087c2/third_party/WebKit/Source/web/BUILD.gn
Project Member

Comment 89 by bugdroid1@chromium.org, Jul 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a0248d52d9cb1cdac76a8b0006b55250b28169c

commit 5a0248d52d9cb1cdac76a8b0006b55250b28169c
Author: Stuart Langley <slangley@chromium.org>
Date: Fri Jul 28 01:00:56 2017

Move WebViewImpl.* from web/ -> core/exported/.

Includes the following changes:
- Move methods that were installing supplements in the ctor() to (Core|Modules)Initializer.
- Remove MediaKeysClient and move methods to MediaKeysController. 
- Remove StorageClient and move methods to StorageNamespaceController. It does have a reference
to WebViewBase*. As the lifetime of StrorageNamespaceController is bound to the Page, and
as the Page is bound to WebViewImpl then I believe that this is safe.

Bug: 712963
Change-Id: I5904536f19b8ea376de2aa49267f5dce71925c5a
Reviewed-on: https://chromium-review.googlesource.com/584148
Commit-Queue: Stuart Langley <slangley@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490170}
[modify] https://crrev.com/5a0248d52d9cb1cdac76a8b0006b55250b28169c/third_party/WebKit/Source/core/CoreInitializer.h
[modify] https://crrev.com/5a0248d52d9cb1cdac76a8b0006b55250b28169c/third_party/WebKit/Source/core/exported/BUILD.gn
[rename] https://crrev.com/5a0248d52d9cb1cdac76a8b0006b55250b28169c/third_party/WebKit/Source/core/exported/WebViewImpl.cpp
[rename] https://crrev.com/5a0248d52d9cb1cdac76a8b0006b55250b28169c/third_party/WebKit/Source/core/exported/WebViewImpl.h
[modify] https://crrev.com/5a0248d52d9cb1cdac76a8b0006b55250b28169c/third_party/WebKit/Source/core/page/Page.h
[modify] https://crrev.com/5a0248d52d9cb1cdac76a8b0006b55250b28169c/third_party/WebKit/Source/modules/ModulesInitializer.cpp
[modify] https://crrev.com/5a0248d52d9cb1cdac76a8b0006b55250b28169c/third_party/WebKit/Source/modules/ModulesInitializer.h
[modify] https://crrev.com/5a0248d52d9cb1cdac76a8b0006b55250b28169c/third_party/WebKit/Source/modules/encryptedmedia/BUILD.gn
[delete] https://crrev.com/5d4692d3f4efdc6d0a9a9b7b12655b84cd8553f2/third_party/WebKit/Source/modules/encryptedmedia/MediaKeysClient.cpp
[delete] https://crrev.com/5d4692d3f4efdc6d0a9a9b7b12655b84cd8553f2/third_party/WebKit/Source/modules/encryptedmedia/MediaKeysClient.h
[modify] https://crrev.com/5a0248d52d9cb1cdac76a8b0006b55250b28169c/third_party/WebKit/Source/modules/encryptedmedia/MediaKeysController.cpp
[modify] https://crrev.com/5a0248d52d9cb1cdac76a8b0006b55250b28169c/third_party/WebKit/Source/modules/encryptedmedia/MediaKeysController.h
[modify] https://crrev.com/5a0248d52d9cb1cdac76a8b0006b55250b28169c/third_party/WebKit/Source/modules/storage/BUILD.gn
[modify] https://crrev.com/5a0248d52d9cb1cdac76a8b0006b55250b28169c/third_party/WebKit/Source/modules/storage/StorageArea.cpp
[delete] https://crrev.com/5d4692d3f4efdc6d0a9a9b7b12655b84cd8553f2/third_party/WebKit/Source/modules/storage/StorageClient.cpp
[delete] https://crrev.com/5d4692d3f4efdc6d0a9a9b7b12655b84cd8553f2/third_party/WebKit/Source/modules/storage/StorageClient.h
[modify] https://crrev.com/5a0248d52d9cb1cdac76a8b0006b55250b28169c/third_party/WebKit/Source/modules/storage/StorageNamespaceController.cpp
[modify] https://crrev.com/5a0248d52d9cb1cdac76a8b0006b55250b28169c/third_party/WebKit/Source/modules/storage/StorageNamespaceController.h
[modify] https://crrev.com/5a0248d52d9cb1cdac76a8b0006b55250b28169c/third_party/WebKit/Source/web/BUILD.gn
[modify] https://crrev.com/5a0248d52d9cb1cdac76a8b0006b55250b28169c/third_party/WebKit/Source/web/WebFactoryImpl.cpp
[modify] https://crrev.com/5a0248d52d9cb1cdac76a8b0006b55250b28169c/third_party/WebKit/Source/web/tests/LayoutGeometryMapTest.cpp
[modify] https://crrev.com/5a0248d52d9cb1cdac76a8b0006b55250b28169c/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
Project Member

Comment 90 by bugdroid1@chromium.org, Jul 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e706c39fccfb952c9d06191baff73d573141ca8

commit 2e706c39fccfb952c9d06191baff73d573141ca8
Author: Nicholas Verne <nverne@chromium.org>
Date: Fri Jul 28 05:15:32 2017

Move tests out of web/ to core/ and modules/

Bug: 712963
Change-Id: I0567555e2250ee43ff425ef164617e3a3c2b90bb
Reviewed-on: https://chromium-review.googlesource.com/588529
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490278}
[modify] https://crrev.com/2e706c39fccfb952c9d06191baff73d573141ca8/third_party/WebKit/Source/core/BUILD.gn
[rename] https://crrev.com/2e706c39fccfb952c9d06191baff73d573141ca8/third_party/WebKit/Source/core/html/imports/HTMLImportSheetsTest.cpp
[rename] https://crrev.com/2e706c39fccfb952c9d06191baff73d573141ca8/third_party/WebKit/Source/core/page/scrolling/ScrollMetricsTest.cpp
[rename] https://crrev.com/2e706c39fccfb952c9d06191baff73d573141ca8/third_party/WebKit/Source/core/page/scrolling/SmoothScrollTest.cpp
[modify] https://crrev.com/2e706c39fccfb952c9d06191baff73d573141ca8/third_party/WebKit/Source/modules/BUILD.gn
[rename] https://crrev.com/2e706c39fccfb952c9d06191baff73d573141ca8/third_party/WebKit/Source/modules/accessibility/AccessibilityObjectModelTest.cpp
[modify] https://crrev.com/2e706c39fccfb952c9d06191baff73d573141ca8/third_party/WebKit/Source/web/BUILD.gn
Project Member

Comment 91 by bugdroid1@chromium.org, Aug 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f3f9f8f8da2237c604f4b4b0e86be96b4ab992f0

commit f3f9f8f8da2237c604f4b4b0e86be96b4ab992f0
Author: Nicholas Verne <nverne@chromium.org>
Date: Tue Aug 01 06:29:57 2017

Removes WebFactory

WebFactory was a temporary class enabling the staged removal of files from
web/. It is no longer required.

Bug: 712963
Change-Id: If274612b3f722a598232bc27438bc0a6aff75908
Reviewed-on: https://chromium-review.googlesource.com/595023
Reviewed-by: Stuart Langley <slangley@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490885}
[modify] https://crrev.com/f3f9f8f8da2237c604f4b4b0e86be96b4ab992f0/third_party/WebKit/Source/controller/BlinkInitializer.cpp
[modify] https://crrev.com/f3f9f8f8da2237c604f4b4b0e86be96b4ab992f0/third_party/WebKit/Source/core/exported/BUILD.gn
[delete] https://crrev.com/e66b41544e7a861be5bfe976fcf4225e3e81844a/third_party/WebKit/Source/core/exported/WebFactory.cpp
[delete] https://crrev.com/e66b41544e7a861be5bfe976fcf4225e3e81844a/third_party/WebKit/Source/core/exported/WebFactory.h
[modify] https://crrev.com/f3f9f8f8da2237c604f4b4b0e86be96b4ab992f0/third_party/WebKit/Source/core/exported/WebRemoteFrameImpl.cpp
[modify] https://crrev.com/f3f9f8f8da2237c604f4b4b0e86be96b4ab992f0/third_party/WebKit/Source/core/exported/WebSharedWorkerImpl.cpp
[modify] https://crrev.com/f3f9f8f8da2237c604f4b4b0e86be96b4ab992f0/third_party/WebKit/Source/core/exported/WebViewImpl.cpp
[modify] https://crrev.com/f3f9f8f8da2237c604f4b4b0e86be96b4ab992f0/third_party/WebKit/Source/modules/exported/WebEmbeddedWorkerImpl.cpp
[modify] https://crrev.com/f3f9f8f8da2237c604f4b4b0e86be96b4ab992f0/third_party/WebKit/Source/web/BUILD.gn
[delete] https://crrev.com/e66b41544e7a861be5bfe976fcf4225e3e81844a/third_party/WebKit/Source/web/WebFactoryImpl.cpp
[delete] https://crrev.com/e66b41544e7a861be5bfe976fcf4225e3e81844a/third_party/WebKit/Source/web/WebFactoryImpl.h
Project Member

Comment 92 by bugdroid1@chromium.org, Aug 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/092512af64fdad80caaed32edd5f383d4261a790

commit 092512af64fdad80caaed32edd5f383d4261a790
Author: Nicholas Verne <nverne@chromium.org>
Date: Tue Aug 01 07:22:16 2017

Move web/SpinLockTest to //base.

The test now uses base threading types, but the logic for exercising the
SpinLock remains.

Bug: 712963
Change-Id: Ic720786a6925679a772f01b2d189657fc59513f2
Reviewed-on: https://chromium-review.googlesource.com/593528
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490898}
[modify] https://crrev.com/092512af64fdad80caaed32edd5f383d4261a790/base/BUILD.gn
[add] https://crrev.com/092512af64fdad80caaed32edd5f383d4261a790/base/allocator/partition_allocator/spin_lock_unittest.cc
[modify] https://crrev.com/092512af64fdad80caaed32edd5f383d4261a790/third_party/WebKit/Source/web/BUILD.gn
[delete] https://crrev.com/523332f31f9114c5ed009ab2c49384b5f8826c7e/third_party/WebKit/Source/web/tests/SpinLockTest.cpp
Project Member

Comment 94 by bugdroid1@chromium.org, Aug 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76ff5b5a09f51dea7752697124d08c658798a7c2

commit 76ff5b5a09f51dea7752697124d08c658798a7c2
Author: Stuart Langley <slangley@chromium.org>
Date: Wed Aug 02 01:59:02 2017

No new dependencies on WebLocalFrameImpl.h please.

Bug: 712963
Change-Id: I079d33a74817c384e69ff1009e15af72c4bb9c4f
Reviewed-on: https://chromium-review.googlesource.com/596619
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491210}
[modify] https://crrev.com/76ff5b5a09f51dea7752697124d08c658798a7c2/third_party/WebKit/Source/core/DEPS
Project Member

Comment 95 by bugdroid1@chromium.org, Aug 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/539dd052149ea5993da8f2fab801b059bd3073f9

commit 539dd052149ea5993da8f2fab801b059bd3073f9
Author: Nicholas Verne <nverne@chromium.org>
Date: Wed Aug 02 08:38:23 2017

Rehome STATIC_ASSERT_ENUMS

This CL continues to remove asserts from AssertMatchingEnums.cpp and
place them in files nearer their internal definitions.

Bug: 712963
Change-Id: I8cda3922744b053ecbbcb5b6c94a685f419defa4
Reviewed-on: https://chromium-review.googlesource.com/597382
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491313}
[modify] https://crrev.com/539dd052149ea5993da8f2fab801b059bd3073f9/third_party/WebKit/Source/core/dom/IconURL.cpp
[modify] https://crrev.com/539dd052149ea5993da8f2fab801b059bd3073f9/third_party/WebKit/Source/core/editing/EditingBehavior.cpp
[modify] https://crrev.com/539dd052149ea5993da8f2fab801b059bd3073f9/third_party/WebKit/Source/core/events/EventTarget.cpp
[modify] https://crrev.com/539dd052149ea5993da8f2fab801b059bd3073f9/third_party/WebKit/Source/core/fileapi/FileError.cpp
[modify] https://crrev.com/539dd052149ea5993da8f2fab801b059bd3073f9/third_party/WebKit/Source/core/frame/csp/CSPSource.cpp
[modify] https://crrev.com/539dd052149ea5993da8f2fab801b059bd3073f9/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
[modify] https://crrev.com/539dd052149ea5993da8f2fab801b059bd3073f9/third_party/WebKit/Source/core/loader/NavigationPolicy.cpp
[modify] https://crrev.com/539dd052149ea5993da8f2fab801b059bd3073f9/third_party/WebKit/Source/core/page/PageVisibilityState.cpp
[modify] https://crrev.com/539dd052149ea5993da8f2fab801b059bd3073f9/third_party/WebKit/Source/modules/filesystem/DOMFileSystemBase.cpp
[modify] https://crrev.com/539dd052149ea5993da8f2fab801b059bd3073f9/third_party/WebKit/Source/modules/quota/DeprecatedStorageQuota.cpp
[modify] https://crrev.com/539dd052149ea5993da8f2fab801b059bd3073f9/third_party/WebKit/Source/modules/quota/StorageManager.cpp
[modify] https://crrev.com/539dd052149ea5993da8f2fab801b059bd3073f9/third_party/WebKit/Source/modules/speech/SpeechRecognitionError.cpp
[modify] https://crrev.com/539dd052149ea5993da8f2fab801b059bd3073f9/third_party/WebKit/Source/platform/FileMetadata.cpp
[modify] https://crrev.com/539dd052149ea5993da8f2fab801b059bd3073f9/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp
[modify] https://crrev.com/539dd052149ea5993da8f2fab801b059bd3073f9/third_party/WebKit/Source/platform/loader/fetch/ResourceResponse.cpp
[modify] https://crrev.com/539dd052149ea5993da8f2fab801b059bd3073f9/third_party/WebKit/Source/platform/mediastream/MediaStreamSource.cpp
[modify] https://crrev.com/539dd052149ea5993da8f2fab801b059bd3073f9/third_party/WebKit/Source/platform/network/ContentSecurityPolicyParsers.cpp
[modify] https://crrev.com/539dd052149ea5993da8f2fab801b059bd3073f9/third_party/WebKit/Source/platform/scroll/Scrollbar.cpp
[modify] https://crrev.com/539dd052149ea5993da8f2fab801b059bd3073f9/third_party/WebKit/Source/platform/weborigin/SecurityPolicy.cpp
[modify] https://crrev.com/539dd052149ea5993da8f2fab801b059bd3073f9/third_party/WebKit/Source/web/AssertMatchingEnums.cpp
[modify] https://crrev.com/539dd052149ea5993da8f2fab801b059bd3073f9/third_party/WebKit/public/platform/WebScrollbar.h
[modify] https://crrev.com/539dd052149ea5993da8f2fab801b059bd3073f9/third_party/WebKit/public/web/WebFrameOwnerProperties.h
Project Member

Comment 96 by bugdroid1@chromium.org, Aug 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a51164f020721249c875b85ed85070f43128cb74

commit a51164f020721249c875b85ed85070f43128cb74
Author: Nicholas Verne <nverne@chromium.org>
Date: Wed Aug 02 13:44:16 2017

Move VirtualTimeTest to core/exported.

Bug: 712963
Change-Id: I9d88fb2153c9de3ff01c5542923a7d4e832ac382
Reviewed-on: https://chromium-review.googlesource.com/597610
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491360}
[modify] https://crrev.com/a51164f020721249c875b85ed85070f43128cb74/third_party/WebKit/Source/core/BUILD.gn
[rename] https://crrev.com/a51164f020721249c875b85ed85070f43128cb74/third_party/WebKit/Source/core/scheduler/VirtualTimeTest.cpp
[modify] https://crrev.com/a51164f020721249c875b85ed85070f43128cb74/third_party/WebKit/Source/web/BUILD.gn
Project Member

Comment 97 by bugdroid1@chromium.org, Aug 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/60af7d994d34c1dfa5c13a4f91793e3fb37fa262

commit 60af7d994d34c1dfa5c13a4f91793e3fb37fa262
Author: Nicholas Verne <nverne@chromium.org>
Date: Thu Aug 03 08:15:33 2017

Break out WebKit.cpp wrappers.

Delete the empty and unused files in web/.

Bug: 712963
Change-Id: If0b2f20834e2474ae8ebf23259079045a85601ec
Reviewed-on: https://chromium-review.googlesource.com/599139
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491674}
[modify] https://crrev.com/60af7d994d34c1dfa5c13a4f91793e3fb37fa262/third_party/WebKit/Source/core/layout/LayoutTheme.cpp
[modify] https://crrev.com/60af7d994d34c1dfa5c13a4f91793e3fb37fa262/third_party/WebKit/Source/core/page/Page.cpp
[modify] https://crrev.com/60af7d994d34c1dfa5c13a4f91793e3fb37fa262/third_party/WebKit/Source/core/workers/WorkerBackingThread.cpp
[modify] https://crrev.com/60af7d994d34c1dfa5c13a4f91793e3fb37fa262/third_party/WebKit/Source/platform/DEPS
[modify] https://crrev.com/60af7d994d34c1dfa5c13a4f91793e3fb37fa262/third_party/WebKit/Source/platform/LayoutTestSupport.cpp
[modify] https://crrev.com/60af7d994d34c1dfa5c13a4f91793e3fb37fa262/third_party/WebKit/Source/platform/MemoryCoordinator.cpp
[modify] https://crrev.com/60af7d994d34c1dfa5c13a4f91793e3fb37fa262/third_party/WebKit/Source/platform/bindings/RuntimeCallStats.cpp
[modify] https://crrev.com/60af7d994d34c1dfa5c13a4f91793e3fb37fa262/third_party/WebKit/Source/platform/bindings/V8PerIsolateData.cpp
[modify] https://crrev.com/60af7d994d34c1dfa5c13a4f91793e3fb37fa262/third_party/WebKit/Source/web/BUILD.gn
[delete] https://crrev.com/27004cb5e9005aa1bd43b0e5d8dce18bfed15193/third_party/WebKit/Source/web/WebExport.h
[delete] https://crrev.com/27004cb5e9005aa1bd43b0e5d8dce18bfed15193/third_party/WebKit/Source/web/WebKit.cpp
Project Member

Comment 98 by bugdroid1@chromium.org, Aug 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/afc8fa887c0a13cc1fdf6dba0e6730b4cd9c0267

commit afc8fa887c0a13cc1fdf6dba0e6730b4cd9c0267
Author: Nicholas Verne <nverne@chromium.org>
Date: Fri Aug 04 06:32:15 2017

Rehome remaining STATIC_ASSERT_ENUMs

Delete the last web/ cpp file.

Bug: 712963
Change-Id: I2a8f5d514285121fa5b3512718baddc9ccaf2e24
Reviewed-on: https://chromium-review.googlesource.com/601609
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491953}
[modify] https://crrev.com/afc8fa887c0a13cc1fdf6dba0e6730b4cd9c0267/third_party/WebKit/Source/bindings/core/DEPS
[modify] https://crrev.com/afc8fa887c0a13cc1fdf6dba0e6730b4cd9c0267/third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp
[modify] https://crrev.com/afc8fa887c0a13cc1fdf6dba0e6730b4cd9c0267/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp
[modify] https://crrev.com/afc8fa887c0a13cc1fdf6dba0e6730b4cd9c0267/third_party/WebKit/Source/bindings/core/v8/serialization/SerializedScriptValue.cpp
[modify] https://crrev.com/afc8fa887c0a13cc1fdf6dba0e6730b4cd9c0267/third_party/WebKit/Source/core/dom/SandboxFlags.cpp
[modify] https://crrev.com/afc8fa887c0a13cc1fdf6dba0e6730b4cd9c0267/third_party/WebKit/Source/core/editing/SelectionController.cpp
[modify] https://crrev.com/afc8fa887c0a13cc1fdf6dba0e6730b4cd9c0267/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
[modify] https://crrev.com/afc8fa887c0a13cc1fdf6dba0e6730b4cd9c0267/third_party/WebKit/Source/core/exported/WebSettingsImpl.cpp
[modify] https://crrev.com/afc8fa887c0a13cc1fdf6dba0e6730b4cd9c0267/third_party/WebKit/Source/core/frame/Frame.cpp
[modify] https://crrev.com/afc8fa887c0a13cc1fdf6dba0e6730b4cd9c0267/third_party/WebKit/Source/core/html/media/AutoplayPolicy.cpp
[modify] https://crrev.com/afc8fa887c0a13cc1fdf6dba0e6730b4cd9c0267/third_party/WebKit/Source/core/inspector/ConsoleMessage.cpp
[modify] https://crrev.com/afc8fa887c0a13cc1fdf6dba0e6730b4cd9c0267/third_party/WebKit/Source/core/loader/DocumentLoader.cpp
[modify] https://crrev.com/afc8fa887c0a13cc1fdf6dba0e6730b4cd9c0267/third_party/WebKit/Source/core/loader/FrameLoader.cpp
[modify] https://crrev.com/afc8fa887c0a13cc1fdf6dba0e6730b4cd9c0267/third_party/WebKit/Source/core/loader/ProgressTracker.cpp
[modify] https://crrev.com/afc8fa887c0a13cc1fdf6dba0e6730b4cd9c0267/third_party/WebKit/Source/core/style/ComputedStyle.cpp
[modify] https://crrev.com/afc8fa887c0a13cc1fdf6dba0e6730b4cd9c0267/third_party/WebKit/Source/modules/indexeddb/IDBDatabase.cpp
[modify] https://crrev.com/afc8fa887c0a13cc1fdf6dba0e6730b4cd9c0267/third_party/WebKit/Source/modules/indexeddb/IDBKey.cpp
[modify] https://crrev.com/afc8fa887c0a13cc1fdf6dba0e6730b4cd9c0267/third_party/WebKit/Source/modules/indexeddb/IDBKeyPath.cpp
[modify] https://crrev.com/afc8fa887c0a13cc1fdf6dba0e6730b4cd9c0267/third_party/WebKit/Source/modules/indexeddb/IDBMetadata.cpp
[modify] https://crrev.com/afc8fa887c0a13cc1fdf6dba0e6730b4cd9c0267/third_party/WebKit/Source/modules/navigatorcontentutils/NavigatorContentUtilsClient.cpp
[modify] https://crrev.com/afc8fa887c0a13cc1fdf6dba0e6730b4cd9c0267/third_party/WebKit/Source/platform/graphics/BitmapImage.cpp
[modify] https://crrev.com/afc8fa887c0a13cc1fdf6dba0e6730b4cd9c0267/third_party/WebKit/Source/platform/graphics/DEPS
[delete] https://crrev.com/c586e12685a82150fef6a94927339f76e0907d21/third_party/WebKit/Source/web/AssertMatchingEnums.cpp
[modify] https://crrev.com/afc8fa887c0a13cc1fdf6dba0e6730b4cd9c0267/third_party/WebKit/Source/web/BUILD.gn
[add] https://crrev.com/afc8fa887c0a13cc1fdf6dba0e6730b4cd9c0267/third_party/WebKit/Source/web/Empty.cpp
Project Member

Comment 99 by bugdroid1@chromium.org, Aug 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eeb168acde0805dc48f5dcc3959b63d92ae087dc

commit eeb168acde0805dc48f5dcc3959b63d92ae087dc
Author: Bruce Dawson <brucedawson@chromium.org>
Date: Sat Aug 05 00:59:14 2017

Revert "Rehome remaining STATIC_ASSERT_ENUMs"

This reverts commit afc8fa887c0a13cc1fdf6dba0e6730b4cd9c0267.

Reason for revert: Component builds will break if they don't
have an old blink_web.dll.lib lying around

Original change's description:
> Rehome remaining STATIC_ASSERT_ENUMs
> 
> Delete the last web/ cpp file.
> 
> Bug: 712963
> Change-Id: I2a8f5d514285121fa5b3512718baddc9ccaf2e24
> Reviewed-on: https://chromium-review.googlesource.com/601609
> Commit-Queue: Nicholas Verne <nverne@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#491953}

TBR=haraken@chromium.org,nverne@chromium.org

Change-Id: I3c634f7cf5e791735b0511154ab79203576c7a64
No-Presubmit: true
Bug: 712963,752674
Reviewed-on: https://chromium-review.googlesource.com/602947
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492203}
[modify] https://crrev.com/eeb168acde0805dc48f5dcc3959b63d92ae087dc/third_party/WebKit/Source/bindings/core/DEPS
[modify] https://crrev.com/eeb168acde0805dc48f5dcc3959b63d92ae087dc/third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp
[modify] https://crrev.com/eeb168acde0805dc48f5dcc3959b63d92ae087dc/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp
[modify] https://crrev.com/eeb168acde0805dc48f5dcc3959b63d92ae087dc/third_party/WebKit/Source/bindings/core/v8/serialization/SerializedScriptValue.cpp
[modify] https://crrev.com/eeb168acde0805dc48f5dcc3959b63d92ae087dc/third_party/WebKit/Source/core/dom/SandboxFlags.cpp
[modify] https://crrev.com/eeb168acde0805dc48f5dcc3959b63d92ae087dc/third_party/WebKit/Source/core/editing/SelectionController.cpp
[modify] https://crrev.com/eeb168acde0805dc48f5dcc3959b63d92ae087dc/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
[modify] https://crrev.com/eeb168acde0805dc48f5dcc3959b63d92ae087dc/third_party/WebKit/Source/core/exported/WebSettingsImpl.cpp
[modify] https://crrev.com/eeb168acde0805dc48f5dcc3959b63d92ae087dc/third_party/WebKit/Source/core/frame/Frame.cpp
[modify] https://crrev.com/eeb168acde0805dc48f5dcc3959b63d92ae087dc/third_party/WebKit/Source/core/html/media/AutoplayPolicy.cpp
[modify] https://crrev.com/eeb168acde0805dc48f5dcc3959b63d92ae087dc/third_party/WebKit/Source/core/inspector/ConsoleMessage.cpp
[modify] https://crrev.com/eeb168acde0805dc48f5dcc3959b63d92ae087dc/third_party/WebKit/Source/core/loader/DocumentLoader.cpp
[modify] https://crrev.com/eeb168acde0805dc48f5dcc3959b63d92ae087dc/third_party/WebKit/Source/core/loader/FrameLoader.cpp
[modify] https://crrev.com/eeb168acde0805dc48f5dcc3959b63d92ae087dc/third_party/WebKit/Source/core/loader/ProgressTracker.cpp
[modify] https://crrev.com/eeb168acde0805dc48f5dcc3959b63d92ae087dc/third_party/WebKit/Source/core/style/ComputedStyle.cpp
[modify] https://crrev.com/eeb168acde0805dc48f5dcc3959b63d92ae087dc/third_party/WebKit/Source/modules/indexeddb/IDBDatabase.cpp
[modify] https://crrev.com/eeb168acde0805dc48f5dcc3959b63d92ae087dc/third_party/WebKit/Source/modules/indexeddb/IDBKey.cpp
[modify] https://crrev.com/eeb168acde0805dc48f5dcc3959b63d92ae087dc/third_party/WebKit/Source/modules/indexeddb/IDBKeyPath.cpp
[modify] https://crrev.com/eeb168acde0805dc48f5dcc3959b63d92ae087dc/third_party/WebKit/Source/modules/indexeddb/IDBMetadata.cpp
[modify] https://crrev.com/eeb168acde0805dc48f5dcc3959b63d92ae087dc/third_party/WebKit/Source/modules/navigatorcontentutils/NavigatorContentUtilsClient.cpp
[modify] https://crrev.com/eeb168acde0805dc48f5dcc3959b63d92ae087dc/third_party/WebKit/Source/platform/graphics/BitmapImage.cpp
[modify] https://crrev.com/eeb168acde0805dc48f5dcc3959b63d92ae087dc/third_party/WebKit/Source/platform/graphics/DEPS
[add] https://crrev.com/eeb168acde0805dc48f5dcc3959b63d92ae087dc/third_party/WebKit/Source/web/AssertMatchingEnums.cpp
[modify] https://crrev.com/eeb168acde0805dc48f5dcc3959b63d92ae087dc/third_party/WebKit/Source/web/BUILD.gn
[delete] https://crrev.com/e09ae9ae37364468dce317c84b9e7ca3f44cae50/third_party/WebKit/Source/web/Empty.cpp
Project Member

Comment 100 by bugdroid1@chromium.org, Aug 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ef90c60c92c7ce9283906160e2dbeaf384cca40

commit 8ef90c60c92c7ce9283906160e2dbeaf384cca40
Author: nverne <nverne@chromium.org>
Date: Mon Aug 07 06:06:48 2017

Removes web/ lib and dependencies from Blink.


Rehome remaining STATIC_ASSERT_ENUMs. This leaves blink_web empty. Since
Windows doesn't allow empty libraries, we need to remove dependencies on
blink's web/ lib.

Bug: 712963
Change-Id: Ib8090a3cf20082a9648249fac36fc8037707502e
Reviewed-on: https://chromium-review.googlesource.com/602093
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492269}
[modify] https://crrev.com/8ef90c60c92c7ce9283906160e2dbeaf384cca40/third_party/WebKit/Source/bindings/core/DEPS
[modify] https://crrev.com/8ef90c60c92c7ce9283906160e2dbeaf384cca40/third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp
[modify] https://crrev.com/8ef90c60c92c7ce9283906160e2dbeaf384cca40/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp
[modify] https://crrev.com/8ef90c60c92c7ce9283906160e2dbeaf384cca40/third_party/WebKit/Source/bindings/core/v8/serialization/SerializedScriptValue.cpp
[modify] https://crrev.com/8ef90c60c92c7ce9283906160e2dbeaf384cca40/third_party/WebKit/Source/controller/BUILD.gn
[modify] https://crrev.com/8ef90c60c92c7ce9283906160e2dbeaf384cca40/third_party/WebKit/Source/core/dom/SandboxFlags.cpp
[modify] https://crrev.com/8ef90c60c92c7ce9283906160e2dbeaf384cca40/third_party/WebKit/Source/core/editing/SelectionController.cpp
[modify] https://crrev.com/8ef90c60c92c7ce9283906160e2dbeaf384cca40/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
[modify] https://crrev.com/8ef90c60c92c7ce9283906160e2dbeaf384cca40/third_party/WebKit/Source/core/exported/WebSettingsImpl.cpp
[modify] https://crrev.com/8ef90c60c92c7ce9283906160e2dbeaf384cca40/third_party/WebKit/Source/core/frame/Frame.cpp
[modify] https://crrev.com/8ef90c60c92c7ce9283906160e2dbeaf384cca40/third_party/WebKit/Source/core/html/media/AutoplayPolicy.cpp
[modify] https://crrev.com/8ef90c60c92c7ce9283906160e2dbeaf384cca40/third_party/WebKit/Source/core/inspector/ConsoleMessage.cpp
[modify] https://crrev.com/8ef90c60c92c7ce9283906160e2dbeaf384cca40/third_party/WebKit/Source/core/loader/DocumentLoader.cpp
[modify] https://crrev.com/8ef90c60c92c7ce9283906160e2dbeaf384cca40/third_party/WebKit/Source/core/loader/FrameLoader.cpp
[modify] https://crrev.com/8ef90c60c92c7ce9283906160e2dbeaf384cca40/third_party/WebKit/Source/core/loader/ProgressTracker.cpp
[modify] https://crrev.com/8ef90c60c92c7ce9283906160e2dbeaf384cca40/third_party/WebKit/Source/core/style/ComputedStyle.cpp
[modify] https://crrev.com/8ef90c60c92c7ce9283906160e2dbeaf384cca40/third_party/WebKit/Source/modules/indexeddb/IDBDatabase.cpp
[modify] https://crrev.com/8ef90c60c92c7ce9283906160e2dbeaf384cca40/third_party/WebKit/Source/modules/indexeddb/IDBKey.cpp
[modify] https://crrev.com/8ef90c60c92c7ce9283906160e2dbeaf384cca40/third_party/WebKit/Source/modules/indexeddb/IDBKeyPath.cpp
[modify] https://crrev.com/8ef90c60c92c7ce9283906160e2dbeaf384cca40/third_party/WebKit/Source/modules/indexeddb/IDBMetadata.cpp
[modify] https://crrev.com/8ef90c60c92c7ce9283906160e2dbeaf384cca40/third_party/WebKit/Source/modules/navigatorcontentutils/NavigatorContentUtilsClient.cpp
[modify] https://crrev.com/8ef90c60c92c7ce9283906160e2dbeaf384cca40/third_party/WebKit/Source/platform/graphics/BitmapImage.cpp
[modify] https://crrev.com/8ef90c60c92c7ce9283906160e2dbeaf384cca40/third_party/WebKit/Source/platform/graphics/DEPS
[delete] https://crrev.com/350a1053dc2a1ce6574f425cc917ba4066e52bad/third_party/WebKit/Source/web/AssertMatchingEnums.cpp
[modify] https://crrev.com/8ef90c60c92c7ce9283906160e2dbeaf384cca40/third_party/WebKit/Source/web/BUILD.gn
[modify] https://crrev.com/8ef90c60c92c7ce9283906160e2dbeaf384cca40/third_party/WebKit/public/BUILD.gn
Project Member

Comment 101 by bugdroid1@chromium.org, Aug 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6c400f69b826b7b30f9d5527ae3862fce47124b

commit e6c400f69b826b7b30f9d5527ae3862fce47124b
Author: Nicholas Verne <nverne@chromium.org>
Date: Wed Aug 09 09:47:49 2017

Moved webkit_unit_tests target to controller/

As part of Onion Soup 2.0, we are removing the web/ directory. The
remaining tests in the webkit_unit_tests target are all blink bindings
tests. This target continues to exist, but the build rule now lives in
controller/. 

Bug: 712963
Change-Id: I6af8552e3c81b98cd68eb787e99b8ce0bce3c9ab
Reviewed-on: https://chromium-review.googlesource.com/599129
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492926}
[modify] https://crrev.com/e6c400f69b826b7b30f9d5527ae3862fce47124b/BUILD.gn
[modify] https://crrev.com/e6c400f69b826b7b30f9d5527ae3862fce47124b/testing/buildbot/gn_isolate_map.pyl
[modify] https://crrev.com/e6c400f69b826b7b30f9d5527ae3862fce47124b/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/e6c400f69b826b7b30f9d5527ae3862fce47124b/third_party/WebKit/PRESUBMIT.py
[modify] https://crrev.com/e6c400f69b826b7b30f9d5527ae3862fce47124b/third_party/WebKit/Source/controller/BUILD.gn
[rename] https://crrev.com/e6c400f69b826b7b30f9d5527ae3862fce47124b/third_party/WebKit/Source/controller/tests/DEPS
[rename] https://crrev.com/e6c400f69b826b7b30f9d5527ae3862fce47124b/third_party/WebKit/Source/controller/tests/OWNERS
[rename] https://crrev.com/e6c400f69b826b7b30f9d5527ae3862fce47124b/third_party/WebKit/Source/controller/tests/RunAllTests.cpp
[modify] https://crrev.com/e6c400f69b826b7b30f9d5527ae3862fce47124b/third_party/WebKit/Source/web/BUILD.gn
[modify] https://crrev.com/e6c400f69b826b7b30f9d5527ae3862fce47124b/third_party/WebKit/public/BUILD.gn
Project Member

Comment 102 by bugdroid1@chromium.org, Aug 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/91a9ccccadfede02a51b53ec166d5ebb688859b7

commit 91a9ccccadfede02a51b53ec166d5ebb688859b7
Author: Nicholas Verne <nverne@chromium.org>
Date: Wed Aug 09 21:21:06 2017

Remove web/ finally!!!

Bug: 712963
Change-Id: I319460822c2e8d8a8816ad033e51576821db500d
Reviewed-on: https://chromium-review.googlesource.com/606812
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493141}
[delete] https://crrev.com/4c9a909b879eac5a626499004fa025cca8113922/third_party/WebKit/Source/web/BUILD.gn
[delete] https://crrev.com/4c9a909b879eac5a626499004fa025cca8113922/third_party/WebKit/Source/web/DEPS
[delete] https://crrev.com/4c9a909b879eac5a626499004fa025cca8113922/third_party/WebKit/Source/web/OWNERS

Comment 103 by slangley@chromium.org, Aug 10 2017

Status: Fixed (was: Started)
\o/
Showing comments 4 - 103 of 103 Older ›
►

Sign in to add a comment