New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 712947 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit 28 days ago
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

DL 165 adapter doesn't work on samus

Project Member Reported by marc...@chromium.org, Apr 19 2017

Issue description

Owner: marc...@chromium.org
Status: Assigned (was: Untriaged)
Labels: -Pri-3 Pri-2
(I am pretty sure it used to work before)
Cc: jenchiehhuang@chromium.org katierh@chromium.org
UDL problem, so CCing people who might be interested.
Cc: bhthompson@chromium.org srivatsanr@google.com
marcheu - what are next steps here? is this DL taking a look at this or a googler?

can you elaborate on "doesn't work" to see if we see any similar UDL issues on the DL125?
This is UDL, so this is on google. I hope to find time at some point, I CC'd more people in case they are interested in this bug.

Sorry, I can't elaborate further because I haven't investigated anything yet.
Cc: mzhuo@chromium.org
marcheu - do you have this dongle we can borrow?

mzhuo - any chance you have time to look at this?
Yes I have the dongle, you can borrow it.
Cc: marc...@chromium.org
Owner: tutankhamen@chromium.org
Status: Started (was: Assigned)
Components: OS>Kernel>Graphics OS>Kernel>Display
Status: Fixed (was: Started)
Project Member

Comment 13 by bugdroid1@chromium.org, Oct 25 2017

Labels: merge-merged-chromeos-3.14
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/ce8434bc1e3ee967f4e078269d934d6e322af618

commit ce8434bc1e3ee967f4e078269d934d6e322af618
Author: Robert Tarasov <tutankhamen77@gmail.com>
Date: Wed Oct 25 05:47:54 2017

CHROMIUM: drm/udl: Fixed problem with UDL adpater reconnection

Fixed problem with DisplayLink and DisplayLink certified adapers in
kernel v3.14 when adapter doesn't want to work if it was initialized
with disconnected DVI cable. Now udl driver checks and updates its
connection state every 10 seconds.

BUG= chromium:712947 , chromium:737842 
TEST=Boot Samus with connected DL165 adapter, but with disconnected
DVI cable. Connect DVI cable after system will start. DL165 adapter
should work.

Change-Id: Ia6b3fa50363ed10b4e9687b0550eb777ca66f5a6
Signed-off-by: Robert Tarasov <tutankhamen@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/647483
Reviewed-by: Stéphane Marchesin <marcheu@chromium.org>

[add] https://crrev.com/ce8434bc1e3ee967f4e078269d934d6e322af618/drivers/gpu/drm/udl/udl_connector.h
[modify] https://crrev.com/ce8434bc1e3ee967f4e078269d934d6e322af618/drivers/gpu/drm/udl/udl_connector.c
[modify] https://crrev.com/ce8434bc1e3ee967f4e078269d934d6e322af618/drivers/gpu/drm/udl/udl_drv.c
[modify] https://crrev.com/ce8434bc1e3ee967f4e078269d934d6e322af618/drivers/gpu/drm/udl/udl_main.c

Project Member

Comment 14 by bugdroid1@chromium.org, Oct 25 2017

Labels: merge-merged-chromeos-3.18
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/7eed521f64f92ab9841897dac54c2ef2687ed232

commit 7eed521f64f92ab9841897dac54c2ef2687ed232
Author: Robert Tarasov <tutankhamen77@gmail.com>
Date: Wed Oct 25 05:47:52 2017

CHROMIUM: drm/udl: Fixed problem with UDL adpater reconnection

Fixed problem with DisplayLink and DisplayLink certified adapers in
kernel v3.18 when adapter doesn't want to work if it was initialized
with disconnected DVI cable. Now udl driver checks and updates its
connection state every 10 seconds. Now UDL driver retreives all edid
data blocks instead of only base one. Previous approch could lead to
improper initialization of video mode with certain monitors.

BUG= chromium:712947 , chromium:737842 , chromium:765354 
TEST=Boot Samus with connected DL165 adapter, but with disconnected
DVI cable. Connect DVI cable after system will start. DL165 adapter
should work.

Change-Id: I15c617eae58d695a4a324c5e4ff59f2ed8dd89ee
Signed-off-by: Robert Tarasov <tutankhamen@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/699914
Reviewed-by: Joe Kniss <djmk@google.com>
Reviewed-by: Stéphane Marchesin <marcheu@chromium.org>

[add] https://crrev.com/7eed521f64f92ab9841897dac54c2ef2687ed232/drivers/gpu/drm/udl/udl_connector.h
[modify] https://crrev.com/7eed521f64f92ab9841897dac54c2ef2687ed232/drivers/gpu/drm/udl/udl_connector.c
[modify] https://crrev.com/7eed521f64f92ab9841897dac54c2ef2687ed232/drivers/gpu/drm/udl/udl_drv.c
[modify] https://crrev.com/7eed521f64f92ab9841897dac54c2ef2687ed232/drivers/gpu/drm/udl/udl_main.c

Project Member

Comment 15 by bugdroid1@chromium.org, Oct 25 2017

Labels: merge-merged-chromeos-3.8
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/04a60d4fe235cb01e5ee280fe7cea049cef08325

commit 04a60d4fe235cb01e5ee280fe7cea049cef08325
Author: Robert Tarasov <tutankhamen77@gmail.com>
Date: Wed Oct 25 05:47:56 2017

CHROMIUM: drm/udl: Fixed problem with UDL adpater reconnection

Fixed problem with DisplayLink and DisplayLink certified adapers in
kernel v3.8 when adapter doesn't want to work if it was initialized
with disconnected DVI cable. Now udl driver checks and updates its
connection state every 10 seconds. Now UDL driver retreives all edid
data blocks instead of only base one. Previous approch could lead to
improper initialization of video mode with certain monitors.

BUG= chromium:712947 , chromium:737842 , chromium:765354 
TEST=Boot Samus with connected DL165 adapter, but with disconnected
DVI cable. Connect DVI cable after system will start. DL165 adapter
should work.

Change-Id: I7eb6a4b43b97a8df2b37fd2c9739945b36ab3387
Signed-off-by: Robert Tarasov <tutankhamen@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/706105
Reviewed-by: Joe Kniss <djmk@google.com>
Reviewed-by: Stéphane Marchesin <marcheu@chromium.org>

[add] https://crrev.com/04a60d4fe235cb01e5ee280fe7cea049cef08325/drivers/gpu/drm/udl/udl_connector.h
[modify] https://crrev.com/04a60d4fe235cb01e5ee280fe7cea049cef08325/drivers/gpu/drm/udl/udl_connector.c
[modify] https://crrev.com/04a60d4fe235cb01e5ee280fe7cea049cef08325/drivers/gpu/drm/udl/udl_drv.c
[modify] https://crrev.com/04a60d4fe235cb01e5ee280fe7cea049cef08325/drivers/gpu/drm/udl/udl_main.c

Project Member

Comment 16 by bugdroid1@chromium.org, Oct 25 2017

Labels: merge-merged-chromeos-4.4
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/63e4f2991f6c295a26f2701d3bc5ef55afcc6496

commit 63e4f2991f6c295a26f2701d3bc5ef55afcc6496
Author: Robert Tarasov <tutankhamen77@gmail.com>
Date: Wed Oct 25 22:44:16 2017

CHROMIUM: drm/udl: Fixed problem with UDL adpater reconnection

Fixed problem with DisplayLink and DisplayLink certified adapers in
kernel v4.4 when adapter doesn't want to work if it was initialized
with disconnected DVI cable. Now udl driver checks and updates its
connection state every 10 seconds. Now UDL driver retreives all edid
data blocks instead of only base one. Previous approch could lead to
improper initialization of video mode with certain monitors.

BUG= chromium:712947 , chromium:737842 , chromium:765354 
TEST=Boot Samus with connected DL165 adapter, but with disconnected
DVI cable. Connect DVI cable after system will start. DL165 adapter
should work.

Change-Id: Ic12ba8b2e41d6a2a0f8984c1d13c0f5ce9cac783
Signed-off-by: Robert Tarasov <tutankhamen@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/717778
Reviewed-by: Stéphane Marchesin <marcheu@chromium.org>

[add] https://crrev.com/63e4f2991f6c295a26f2701d3bc5ef55afcc6496/drivers/gpu/drm/udl/udl_connector.h
[modify] https://crrev.com/63e4f2991f6c295a26f2701d3bc5ef55afcc6496/drivers/gpu/drm/udl/udl_connector.c
[modify] https://crrev.com/63e4f2991f6c295a26f2701d3bc5ef55afcc6496/drivers/gpu/drm/udl/udl_drv.c
[modify] https://crrev.com/63e4f2991f6c295a26f2701d3bc5ef55afcc6496/drivers/gpu/drm/udl/udl_main.c

Project Member

Comment 17 by bugdroid1@chromium.org, Feb 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/108dea203db3c9b9ca59152c2ad5ae98b275b1d9

commit 108dea203db3c9b9ca59152c2ad5ae98b275b1d9
Author: Jeffy Chen <jeffy.chen@rock-chips.com>
Date: Tue Feb 27 06:07:18 2018

FIXUP: CHROMIUM: drm/udl: Fixed problem with UDL adpater reconnection

Sync with the upstream version:
afdfc4c6f55f drm/udl: Fixed problem with UDL adpater reconnection

This fix this compile error:
drivers/gpu/drm/udl/udl_connector.c:17:27: fatal error: udl_connector.h: No such file or directory
compilation terminated.

BUG= chromium:712947 , chromium:737842 
TEST=Build and boot

Change-Id: If5df001e79c0f72932471689303705e63a6ca6d9
Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
Reviewed-on: https://chromium-review.googlesource.com/936503
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Stéphane Marchesin <marcheu@chromium.org>

[modify] https://crrev.com/108dea203db3c9b9ca59152c2ad5ae98b275b1d9/drivers/gpu/drm/udl/udl_connector.c

Sign in to add a comment