New issue
Advanced search Search tips

Issue 712945 link

Starred by 1 user
Status: Fixed
Owner:
lazyboy@chromium.org
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Use OnceCallback in bound methods of ref counted ContentVerifier

Project Member Reported by lazyboy@chromium.org, Apr 19 2017 
It's better if we can use OnceCallback and destroy them after Run()ning. Removing reference count of ContentVerifier immediately

There isn't a bug I'm aware of because of this though, just trying to be safe.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e289daa9258b8646c54ae1dfcbda3f8843ba4012

commit e289daa9258b8646c54ae1dfcbda3f8843ba4012
Author: lazyboy <lazyboy@chromium.org>
Date: Wed Apr 19 20:29:54 2017

Bind ContentVerifer::VerifyFailed as OnceCallback.

The consumer ContentVerifyJob, calls this only once and ContentVerifier
is ref counted, so this is a good thing to do.

BUG= 712945 
Test=No visible changes expected.

Review-Url: https://codereview.chromium.org/2824333003
Cr-Commit-Position: refs/heads/master@{#465731}

[modify] https://crrev.com/e289daa9258b8646c54ae1dfcbda3f8843ba4012/extensions/browser/content_verifier.cc
[modify] https://crrev.com/e289daa9258b8646c54ae1dfcbda3f8843ba4012/extensions/browser/content_verifier.h
[modify] https://crrev.com/e289daa9258b8646c54ae1dfcbda3f8843ba4012/extensions/browser/content_verify_job.cc
[modify] https://crrev.com/e289daa9258b8646c54ae1dfcbda3f8843ba4012/extensions/browser/content_verify_job.h

Comment 2 by lazyboy@chromium.org, Apr 20 2017

Status: Fixed (was: Started)
►

Sign in to add a comment