Stop including full "du -h" output in feedback reports |
||||
Issue description(Forking from issue 672188 .) We include the output of running "/usr/bin/du -h / | grep -v -e \\/home\\/.*\\/Downloads\\/" in feedback reports now. This was apparently added to debug a GVC issue, but it's super-noisy and makes feedback reports even harder to read than before. Please prioritize changing this command to just log the files that you care about (maybe only on the stateful partition?). There's all kinds of useless information from /dev, /sys, the readonly partition, etc. right now.
,
Apr 27 2017
I completely agree with derat now! I've been recently looking at some feedback reports and I noticed how annoying it is to have >34K text lines of endless useless information. This must be removed entirely or limited to a small subset of paths.
,
Apr 27 2017
I spoke with Rahul, and we agreed to only limit this to /mnt/stateful_partition and /home while still excluding the Downloads directories. This on my caroline reduces the number of line from 40762 to 5602.
,
Apr 27 2017
derat@ Do you have any other concerns? The CL was just sent for review.
,
Apr 27 2017
It might be nice if we additionally only included files and directories larger than a certain size (we're including this due to concerns about disk usage, right?). Getting it down to 5K lines is definitely a step in the right direction, though -- thanks! :-)
,
Apr 27 2017
I am not sure if restricting by file size would be a good idea. We could have situations where we have lots of directories that individually don't take up that much space, but together add up to the capacity of the device. 5k lines is still a lot but I believe it should be something we can live with - since it is providing us valuable data about the state of the device.
,
Apr 27 2017
that's what the --max-depth flag is for
,
Apr 28 2017
Interesting! du -h --max-depth=4 /home/ /mnt/stateful_partition/ | grep -v -e Downloads produces only 599 lines on caroline! The output is very concise and readable. I like that!
,
May 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aaa7094990b832b7fc7c8aa9b650dd4285cc313c commit aaa7094990b832b7fc7c8aa9b650dd4285cc313c Author: afakhry <afakhry@chromium.org> Date: Wed May 03 04:40:32 2017 Reduce noise from using du to log disk usage in feedback reports We will limit this to /mnt/stateful_partition/ and /home/ as the rest of directories are just useless noise. BUG= 712942 Review-Url: https://codereview.chromium.org/2844223005 Cr-Commit-Position: refs/heads/master@{#468894} [modify] https://crrev.com/aaa7094990b832b7fc7c8aa9b650dd4285cc313c/chrome/browser/chromeos/system_logs/command_line_log_source.cc
,
May 3 2017
,
May 8 2017
Verified in Chrome OS 9532.0.0, 60.0.3092.0. |
||||
►
Sign in to add a comment |
||||
Comment 1 by r...@chromium.org
, Apr 19 2017Owner: afakhry@chromium.org