"PrerenderingOfflinerTest.ForegroundTransitionIgnoredOnHighEndDevice" is flaky |
|||||||
Issue description"PrerenderingOfflinerTest.ForegroundTransitionIgnoredOnHighEndDevice" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 7 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyTgsSBUZsYWtlIkNQcmVyZW5kZXJpbmdPZmZsaW5lclRlc3QuRm9yZWdyb3VuZFRyYW5zaXRpb25JZ25vcmVkT25IaWdoRW5kRGV2aWNlDA. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Apr 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9f304870185ffc3bc6e3113cb3bb5a7c2619eacd commit 9f304870185ffc3bc6e3113cb3bb5a7c2619eacd Author: aboxhall <aboxhall@chromium.org> Date: Wed Apr 19 05:43:57 2017 Disable PrerenderingOfflinerTest.ForegroundTransitionIgnoredOnHighEndDevice BUG= 712941 TBR=dougarnett Review-Url: https://codereview.chromium.org/2831493002 Cr-Commit-Position: refs/heads/master@{#465501} [modify] https://crrev.com/9f304870185ffc3bc6e3113cb3bb5a7c2619eacd/chrome/browser/android/offline_pages/prerendering_offliner_unittest.cc
,
Apr 19 2017
,
Apr 20 2017
Setting component to offline pages.
,
Apr 21 2017
Many of the offliner tests seem to be flaky: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=unit_tests&tests=PrerenderingOfflinerTest Disabling many of them in order to fix builds.
,
Apr 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/08d35b49a641b91ca016420e57821ec2c15ff3db commit 08d35b49a641b91ca016420e57821ec2c15ff3db Author: mattcary <mattcary@chromium.org> Date: Fri Apr 21 15:33:28 2017 Disable flaky tests in PrerenderingOfflinerTest. TBR=petewil,jianli BUG= 712941 Review-Url: https://codereview.chromium.org/2827363003 Cr-Commit-Position: refs/heads/master@{#466345} [modify] https://crrev.com/08d35b49a641b91ca016420e57821ec2c15ff3db/chrome/browser/android/offline_pages/prerendering_offliner_unittest.cc
,
Apr 21 2017
Pete, what is the outlook for deprecating/removing the PrerenderingOffliner?
,
Apr 21 2017
It is still a few months away before we make the switch over to the BackgroundLoaderOffliner, so I'll see if I can take a look at these flakes.
,
Apr 25 2017
,
Apr 25 2017
I looked at a few cases for PrerenderingOfflinerTest.ForegroundTransitionIgnoredOnHighEndDevice. The stack is: ~MockPrerenderingLoader() std::blah::reset(offline_pages::PrerenderingLoader*) std::blah::~unique_ptr() offline_pages::PrerenderingOffliner::~PrerenderingOffliner() std::blah::reset(offline_pages::PrerenderingOffliner*) std::blah::~unique_ptr() offline_pages::PrerenderingOfflinerTest::~PrerenderingOfflinerTest() I started investigating because I initially thought it might have something to do with the commit that disables prerendering for tests: https://codereview.chromium.org/2828143003 It is unrelated because: 1. The last test disable is 3 days ago and the patch above landed only yesterday 2. These unittests use MockPrerenderingLoader which only emulates prerendering, does not call into the actual Prerender 3. The crash looks more like a double-destroy of the WebContents in the test. I could not reproduce this crash on my local device (N4/KTU84Z), 20 of 20 runs PASSED, did the offending commit get reverted?
,
Apr 25 2017
,
Apr 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b16ffdebce9e4724eb3e415c8760abc751d1c035 commit b16ffdebce9e4724eb3e415c8760abc751d1c035 Author: petewil <petewil@chromium.org> Date: Tue Apr 25 20:03:20 2017 Fix uninitialized pointer in unit tests. This may be causing the flakiness we have been seeing with prerendering offliner unit tests. BUG= 712941 Review-Url: https://codereview.chromium.org/2843513005 Cr-Commit-Position: refs/heads/master@{#467081} [modify] https://crrev.com/b16ffdebce9e4724eb3e415c8760abc751d1c035/chrome/browser/android/offline_pages/prerendering_offliner_unittest.cc
,
Apr 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4ab7eea2c4f7ee425a2c38ceab1a84be2fc27daf commit 4ab7eea2c4f7ee425a2c38ceab1a84be2fc27daf Author: petewil <petewil@chromium.org> Date: Thu Apr 27 20:27:30 2017 Re-enable formerly flaky tests for the PrerenderingOffliner. A Sheriff disabled these tests when they were found to be flaky. I've fixed two problems, an uninitialized pointer which might have been causing a crash (previous changelist), and in this changelist a missing call to PumpLoop() causing the test to fail when race conditions happened. BUG= 712941 Review-Url: https://codereview.chromium.org/2837873006 Cr-Commit-Position: refs/heads/master@{#467765} [modify] https://crrev.com/4ab7eea2c4f7ee425a2c38ceab1a84be2fc27daf/chrome/browser/android/offline_pages/prerendering_offliner_unittest.cc
,
Apr 27 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by aboxhall@chromium.org
, Apr 19 2017