New issue
Advanced search Search tips

Issue 712922 link

Starred by 1 user
Status: Verified
Owner:
martis@chromium.org
Closed: Apr 2017
Cc:
droger@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Remove translate MetricsNameIndex

Project Member Reported by martis@chromium.org, Apr 19 2017 
Translate metrics are registered with an unnecessary enum system
(MetricsNameIndex) which is only used in tests. This should be
removed.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/40c92451bdce5b9b9fae80f7bdd87ffc9b74e16e

commit 40c92451bdce5b9b9fae80f7bdd87ffc9b74e16e
Author: martis <martis@chromium.org>
Date: Wed Apr 26 09:06:43 2017

Removed translate MetricsNameIndex.

The enum is unnecessary and is only used in tests. I've introduced an internal
namespace, but I'm happy to change if there's a more idiomatic approach.

BUG= 712922 

Review-Url: https://codereview.chromium.org/2825943002
Cr-Commit-Position: refs/heads/master@{#467276}

[modify] https://crrev.com/40c92451bdce5b9b9fae80f7bdd87ffc9b74e16e/components/translate/core/common/translate_metrics.cc
[modify] https://crrev.com/40c92451bdce5b9b9fae80f7bdd87ffc9b74e16e/components/translate/core/common/translate_metrics.h
[modify] https://crrev.com/40c92451bdce5b9b9fae80f7bdd87ffc9b74e16e/components/translate/core/common/translate_metrics_unittest.cc

Comment 2 by lafo...@chromium.org, Apr 27 2017

Components: -UI>Browser>Translate UI>Browser>Language>Translate

Comment 3 by martis@chromium.org, Apr 28 2017

Status: Verified (was: Available)
►

Sign in to add a comment