New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 712918 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Steps timing function does not match spec outside range [0,1]

Project Member Reported by suzyh@chromium.org, Apr 19 2017

Issue description

With inputs outside the range [0,1], the steps timing function does not match the behaviour described in https://www.w3.org/TR/css-timing-1/#step-timing-functions, as demonstrated by the failing LayoutTests/external/wpt/css-timing-1/step-timing-functions-output.html.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc03a50c0abe027a408aae5c72f08b10d7fbe584

commit dc03a50c0abe027a408aae5c72f08b10d7fbe584
Author: suzyh <suzyh@chromium.org>
Date: Thu Apr 20 00:53:35 2017

Fix step timing outside range [0,1]

With inputs outside the range [0,1], the steps timing function does not
match the behaviour described in
https://www.w3.org/TR/css-timing-1/#step-timing-functions,
as demonstrated by the failing
LayoutTests/external/wpt/css-timing-1/step-timing-functions-output.html.
This patch changes the step timing implementation to match the specced
algorithm.

BUG= 712918 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2830553002
Cr-Commit-Position: refs/heads/master@{#465835}

[modify] https://crrev.com/dc03a50c0abe027a408aae5c72f08b10d7fbe584/cc/animation/keyframed_animation_curve_unittest.cc
[modify] https://crrev.com/dc03a50c0abe027a408aae5c72f08b10d7fbe584/cc/animation/timing_function.cc
[delete] https://crrev.com/616af64093de539709fe6be5085029a42e58fe2d/third_party/WebKit/LayoutTests/external/wpt/css-timing-1/step-timing-functions-output-expected.txt
[modify] https://crrev.com/dc03a50c0abe027a408aae5c72f08b10d7fbe584/third_party/WebKit/Source/platform/animation/TimingFunctionTest.cpp

Comment 2 by suzyh@chromium.org, Apr 20 2017

Status: Fixed (was: Started)

Sign in to add a comment